[INFO] crate ppbert 0.8.4 is already in cache [INFO] extracting crate ppbert 0.8.4 into work/ex/clippy-test-run/sources/stable/reg/ppbert/0.8.4 [INFO] extracting crate ppbert 0.8.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ppbert/0.8.4 [INFO] validating manifest of ppbert-0.8.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ppbert-0.8.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ppbert-0.8.4 [INFO] finished frobbing ppbert-0.8.4 [INFO] frobbed toml for ppbert-0.8.4 written to work/ex/clippy-test-run/sources/stable/reg/ppbert/0.8.4/Cargo.toml [INFO] started frobbing ppbert-0.8.4 [INFO] finished frobbing ppbert-0.8.4 [INFO] frobbed toml for ppbert-0.8.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ppbert/0.8.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ppbert-0.8.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ppbert/0.8.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 178e2dc4ed5b15afd23d7e3f9040226c16e478694bc50f20bc721bacef84e13b [INFO] running `"docker" "start" "-a" "178e2dc4ed5b15afd23d7e3f9040226c16e478694bc50f20bc721bacef84e13b"` [INFO] [stderr] Checking ppbert v0.8.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | Parser { contents: contents, pos: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | Parser { contents: contents, pos: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/consts.rs:20:33 [INFO] [stderr] | [INFO] [stderr] 20 | pub const DISK_LOG_MAGIC: u32 = 0x01020304; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0102_0304` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/consts.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | pub const DISK_LOG_OPENED: u32 = 0x06070809; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0607_0809` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/consts.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | pub const DISK_LOG_CLOSED: u32 = 0x63584d0b; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6358_4d0b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/consts.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | pub const DISK_LOG_TERM_MAGIC: u32 = 0x62574c41; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6257_4c41` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bertterm.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bertterm.rs:378:9 [INFO] [stderr] | [INFO] [stderr] 378 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return Ok(term); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return Some(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return Ok(terms); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(terms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return Some(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Ok(terms); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(terms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return Some(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return self.bert_term(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bert_term()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:318:13 [INFO] [stderr] | [INFO] [stderr] 318 | / return Err(BertError::NotEnoughData { [INFO] [stderr] 319 | | offset: self.pos, [INFO] [stderr] 320 | | needed: 1, [INFO] [stderr] 321 | | available: 0 [INFO] [stderr] 322 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 318 | Err(BertError::NotEnoughData { [INFO] [stderr] 319 | offset: self.pos, [INFO] [stderr] 320 | needed: 1, [INFO] [stderr] 321 | available: 0 [INFO] [stderr] 322 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:324:13 [INFO] [stderr] | [INFO] [stderr] 324 | return Ok(self.contents[self.pos]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.contents[self.pos])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:342:9 [INFO] [stderr] | [INFO] [stderr] 342 | return Ok(slice); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(slice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:348:9 [INFO] [stderr] | [INFO] [stderr] 348 | return Ok(b); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:353:9 [INFO] [stderr] | [INFO] [stderr] 353 | return Ok(b as char); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(b as char)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | return Ok(n); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:365:9 [INFO] [stderr] | [INFO] [stderr] 365 | return Ok(n); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | return Ok(n); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:377:9 [INFO] [stderr] | [INFO] [stderr] 377 | return Ok(n); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:399:9 [INFO] [stderr] | [INFO] [stderr] 399 | return Ok(val); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/consts.rs:20:33 [INFO] [stderr] | [INFO] [stderr] 20 | pub const DISK_LOG_MAGIC: u32 = 0x01020304; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0102_0304` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/consts.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | pub const DISK_LOG_OPENED: u32 = 0x06070809; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0607_0809` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/consts.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | pub const DISK_LOG_CLOSED: u32 = 0x63584d0b; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6358_4d0b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/consts.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | pub const DISK_LOG_TERM_MAGIC: u32 = 0x62574c41; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6257_4c41` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bertterm.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bertterm.rs:378:9 [INFO] [stderr] | [INFO] [stderr] 378 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return Ok(term); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return Some(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return Ok(terms); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(terms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return Some(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Ok(terms); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(terms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return Some(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return self.bert_term(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bert_term()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:318:13 [INFO] [stderr] | [INFO] [stderr] 318 | / return Err(BertError::NotEnoughData { [INFO] [stderr] 319 | | offset: self.pos, [INFO] [stderr] 320 | | needed: 1, [INFO] [stderr] 321 | | available: 0 [INFO] [stderr] 322 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 318 | Err(BertError::NotEnoughData { [INFO] [stderr] 319 | offset: self.pos, [INFO] [stderr] 320 | needed: 1, [INFO] [stderr] 321 | available: 0 [INFO] [stderr] 322 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:324:13 [INFO] [stderr] | [INFO] [stderr] 324 | return Ok(self.contents[self.pos]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.contents[self.pos])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:342:9 [INFO] [stderr] | [INFO] [stderr] 342 | return Ok(slice); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(slice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:348:9 [INFO] [stderr] | [INFO] [stderr] 348 | return Ok(b); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:353:9 [INFO] [stderr] | [INFO] [stderr] 353 | return Ok(b as char); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(b as char)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | return Ok(n); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:365:9 [INFO] [stderr] | [INFO] [stderr] 365 | return Ok(n); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | return Ok(n); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:377:9 [INFO] [stderr] | [INFO] [stderr] 377 | return Ok(n); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:399:9 [INFO] [stderr] | [INFO] [stderr] 399 | return Ok(val); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let () =` [INFO] [stderr] --> src/parser.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let () = self.magic_number()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/parser.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | let _ = self.magic_number()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:189:26 [INFO] [stderr] | [INFO] [stderr] 189 | Ok(BertTerm::Int(b as i32)) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:210:18 [INFO] [stderr] | [INFO] [stderr] 210 | .map(|f| BertTerm::Float(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BertTerm::Float` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:236:22 [INFO] [stderr] | [INFO] [stderr] 236 | .map(|s| BertTerm::Atom(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BertTerm::Atom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:245:18 [INFO] [stderr] | [INFO] [stderr] 245 | .map(|s| BertTerm::Atom(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BertTerm::Atom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/parser.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | sum = sum + &t; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sum += &t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/parser.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | pos = pos * (256).to_bigint().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pos *= (256).to_bigint().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/parser.rs:389:13 [INFO] [stderr] | [INFO] [stderr] 389 | val = val | ((b as u64 & 0x7f) << (7*i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val |= ((b as u64 & 0x7f) << (7*i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:389:27 [INFO] [stderr] | [INFO] [stderr] 389 | val = val | ((b as u64 & 0x7f) << (7*i)); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let () =` [INFO] [stderr] --> src/parser.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let () = self.magic_number()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/parser.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | let _ = self.magic_number()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:189:26 [INFO] [stderr] | [INFO] [stderr] 189 | Ok(BertTerm::Int(b as i32)) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:210:18 [INFO] [stderr] | [INFO] [stderr] 210 | .map(|f| BertTerm::Float(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BertTerm::Float` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:236:22 [INFO] [stderr] | [INFO] [stderr] 236 | .map(|s| BertTerm::Atom(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BertTerm::Atom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:245:18 [INFO] [stderr] | [INFO] [stderr] 245 | .map(|s| BertTerm::Atom(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BertTerm::Atom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(&mut stdout, "")` [INFO] [stderr] --> src/main.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | writeln!(&mut stdout, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut stdout)` [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/parser.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | sum = sum + &t; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sum += &t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/parser.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | pos = pos * (256).to_bigint().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pos *= (256).to_bigint().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/parser.rs:389:13 [INFO] [stderr] | [INFO] [stderr] 389 | val = val | ((b as u64 & 0x7f) << (7*i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val |= ((b as u64 & 0x7f) << (7*i))` [INFO] [stderr] warning: using `writeln!(&mut stdout, "")` [INFO] [stderr] --> src/main.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | writeln!(&mut stdout, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut stdout)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(&mut stdout, "")` [INFO] [stderr] --> src/main.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | writeln!(&mut stdout, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut stdout)` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(&mut stdout, "")` [INFO] [stderr] --> src/main.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | writeln!(&mut stdout, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut stdout)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(&mut stdout, "")` [INFO] [stderr] --> src/main.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | writeln!(&mut stdout, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut stdout)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(&mut stdout, "")` [INFO] [stderr] --> src/main.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | writeln!(&mut stdout, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(&mut stdout)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:389:27 [INFO] [stderr] | [INFO] [stderr] 389 | val = val | ((b as u64 & 0x7f) << (7*i)); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/parser_integration.rs:83:19 [INFO] [stderr] | [INFO] [stderr] 83 | let pi: f64 = 3.141592; [INFO] [stderr] | ^^^^^^^^ help: consider: `3.141_592` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/parser_integration.rs:97:40 [INFO] [stderr] | [INFO] [stderr] 97 | Ok(BertTerm::Float(x)) => x == 3.141592, [INFO] [stderr] | ^^^^^^^^ help: consider: `3.141_592` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> tests/parser_integration.rs:35:37 [INFO] [stderr] | [INFO] [stderr] 35 | Ok(BertTerm::Int(j)) => i as i32 == j, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> tests/parser_integration.rs:45:42 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(BertTerm::Int(j)) => j == i as i32, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> tests/parser_integration.rs:50:42 [INFO] [stderr] | [INFO] [stderr] 50 | Ok(BertTerm::Int(j)) => j == (i as i32) << 8, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> tests/parser_integration.rs:55:42 [INFO] [stderr] | [INFO] [stderr] 55 | Ok(BertTerm::Int(j)) => j == (i as i32) << 16, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> tests/parser_integration.rs:60:42 [INFO] [stderr] | [INFO] [stderr] 60 | Ok(BertTerm::Int(j)) => j == (i as i32) << 24, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/parser_integration.rs:69:35 [INFO] [stderr] | [INFO] [stderr] 69 | Ok(BertTerm::Float(f)) => f == 98.5, [INFO] [stderr] | ^^^^^^^^^ help: consider comparing them within some error: `(f - 98.5).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/parser_integration.rs:69:35 [INFO] [stderr] | [INFO] [stderr] 69 | Ok(BertTerm::Float(f)) => f == 98.5, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/parser_integration.rs:74:35 [INFO] [stderr] | [INFO] [stderr] 74 | Ok(BertTerm::Float(f)) => f == -23.5, [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(f - -23.5).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/parser_integration.rs:74:35 [INFO] [stderr] | [INFO] [stderr] 74 | Ok(BertTerm::Float(f)) => f == -23.5, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/parser_integration.rs:83:19 [INFO] [stderr] | [INFO] [stderr] 83 | let pi: f64 = 3.141592; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(float_as_u64 >> 56) as u8` [INFO] [stderr] --> tests/parser_integration.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | (float_as_u64 >> 56) as u8 & 0xff_u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(float_as_u64 >> 48) as u8` [INFO] [stderr] --> tests/parser_integration.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | (float_as_u64 >> 48) as u8 & 0xff_u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(float_as_u64 >> 40) as u8` [INFO] [stderr] --> tests/parser_integration.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | (float_as_u64 >> 40) as u8 & 0xff_u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(float_as_u64 >> 32) as u8` [INFO] [stderr] --> tests/parser_integration.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | (float_as_u64 >> 32) as u8 & 0xff_u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(float_as_u64 >> 24) as u8` [INFO] [stderr] --> tests/parser_integration.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | (float_as_u64 >> 24) as u8 & 0xff_u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(float_as_u64 >> 16) as u8` [INFO] [stderr] --> tests/parser_integration.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | (float_as_u64 >> 16) as u8 & 0xff_u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(float_as_u64 >> 8) as u8` [INFO] [stderr] --> tests/parser_integration.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | (float_as_u64 >> 8) as u8 & 0xff_u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(float_as_u64 >> 0) as u8` [INFO] [stderr] --> tests/parser_integration.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | (float_as_u64 >> 0) as u8 & 0xff_u8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `float_as_u64` [INFO] [stderr] --> tests/parser_integration.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | (float_as_u64 >> 0) as u8 & 0xff_u8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/parser_integration.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | Ok(BertTerm::Float(x)) => x == 3.141592, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(x - 3.141592).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/parser_integration.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | Ok(BertTerm::Float(x)) => x == 3.141592, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/parser_integration.rs:97:40 [INFO] [stderr] | [INFO] [stderr] 97 | Ok(BertTerm::Float(x)) => x == 3.141592, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ppbert`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/convert.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | return bytes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/convert.rs:151:32 [INFO] [stderr] | [INFO] [stderr] 151 | assert_eq!(usize_to_leb128(624485), vec![0xE5, 0x8E, 0x26]); [INFO] [stderr] | ^^^^^^ help: consider: `624_485` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "178e2dc4ed5b15afd23d7e3f9040226c16e478694bc50f20bc721bacef84e13b"` [INFO] running `"docker" "rm" "-f" "178e2dc4ed5b15afd23d7e3f9040226c16e478694bc50f20bc721bacef84e13b"` [INFO] [stdout] 178e2dc4ed5b15afd23d7e3f9040226c16e478694bc50f20bc721bacef84e13b