[INFO] crate poston 0.3.1 is already in cache [INFO] extracting crate poston 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/poston/0.3.1 [INFO] extracting crate poston 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/poston/0.3.1 [INFO] validating manifest of poston-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of poston-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing poston-0.3.1 [INFO] finished frobbing poston-0.3.1 [INFO] frobbed toml for poston-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/poston/0.3.1/Cargo.toml [INFO] started frobbing poston-0.3.1 [INFO] finished frobbing poston-0.3.1 [INFO] frobbed toml for poston-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/poston/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting poston-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/poston/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 27e3beb832640951a2723b9faf19c60021dd194673b9448fdf5d56dbf1a30521 [INFO] running `"docker" "start" "-a" "27e3beb832640951a2723b9faf19c60021dd194673b9448fdf5d56dbf1a30521"` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Compiling proc-macro2 v0.4.26 [INFO] [stderr] Compiling memchr v2.1.3 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Compiling regex v1.1.0 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking safemem v0.3.0 [INFO] [stderr] Checking termcolor v1.0.4 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking regex-syntax v0.6.5 [INFO] [stderr] Checking humantime v1.2.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking rand_os v0.1.1 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking rmp v0.8.7 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking backoff v0.1.2 [INFO] [stderr] Checking rmp-serde v0.13.7 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking uuid v0.7.2 [INFO] [stderr] Checking pretty_env_logger v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Checking poston v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/connect.rs:287:24 [INFO] [stderr] | [INFO] [stderr] 287 | if let Ok(_) = addr.to_socket_addrs() { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 288 | | let count = CONN_COUNT.fetch_add(1, Ordering::SeqCst); [INFO] [stderr] 289 | | if count % 20 == 0 { [INFO] [stderr] 290 | | Ok(TestStream(AtomicUsize::new(1))) [INFO] [stderr] ... | [INFO] [stderr] 295 | | Err(io::Error::from(io::ErrorKind::ConnectionRefused)) [INFO] [stderr] 296 | | } [INFO] [stderr] | |_________________- help: try this: `if addr.to_socket_addrs().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/worker.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | addr.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 131 | &(*addr).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 131 | &str::clone(addr), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `poston`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "27e3beb832640951a2723b9faf19c60021dd194673b9448fdf5d56dbf1a30521"` [INFO] running `"docker" "rm" "-f" "27e3beb832640951a2723b9faf19c60021dd194673b9448fdf5d56dbf1a30521"` [INFO] [stdout] 27e3beb832640951a2723b9faf19c60021dd194673b9448fdf5d56dbf1a30521