[INFO] crate postgres_array 0.9.0 is already in cache
[INFO] extracting crate postgres_array 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/postgres_array/0.9.0
[INFO] extracting crate postgres_array 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/postgres_array/0.9.0
[INFO] validating manifest of postgres_array-0.9.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of postgres_array-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing postgres_array-0.9.0
[INFO] finished frobbing postgres_array-0.9.0
[INFO] frobbed toml for postgres_array-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/postgres_array/0.9.0/Cargo.toml
[INFO] started frobbing postgres_array-0.9.0
[INFO] finished frobbing postgres_array-0.9.0
[INFO] frobbed toml for postgres_array-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/postgres_array/0.9.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting postgres_array-0.9.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/postgres_array/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] dcc7a6cb5af4e3ea425a3a07330370bbd56671ae6816e12fd4beafca19d20674
[INFO] running `"docker" "start" "-a" "dcc7a6cb5af4e3ea425a3a07330370bbd56671ae6816e12fd4beafca19d20674"`
[INFO] [stderr]     Checking stringprep v0.1.2
[INFO] [stderr]     Checking postgres-protocol v0.3.2
[INFO] [stderr]     Checking postgres-shared v0.4.2
[INFO] [stderr]     Checking postgres v0.15.2
[INFO] [stderr]     Checking postgres_array v0.9.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/array.rs:74:13
[INFO] [stderr]    |
[INFO] [stderr] 74 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/array.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/array.rs:100:17
[INFO] [stderr]     |
[INFO] [stderr] 100 |                 lower_bound: lower_bound,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lower_bound`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/array.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     mut data: &mut I,
[INFO] [stderr]    |     ----^^^^
[INFO] [stderr]    |     |
[INFO] [stderr]    |     help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/array.rs:150:5
[INFO] [stderr]     |
[INFO] [stderr] 150 | /     pub fn iter<'a>(&'a self) -> Iter<'a, T> {
[INFO] [stderr] 151 | |         Iter { inner: self.data.iter() }
[INFO] [stderr] 152 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/array.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 | /     pub fn iter_mut<'a>(&'a mut self) -> IterMut<'a, T> {
[INFO] [stderr] 157 | |         IterMut { inner: self.data.iter_mut() }
[INFO] [stderr] 158 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/impls.rs:44:9
[INFO] [stderr]    |
[INFO] [stderr] 44 | /         match ty.kind() {
[INFO] [stderr] 45 | |             &Kind::Array(ref ty) => <T as FromSql>::accepts(ty),
[INFO] [stderr] 46 | |             _ => false,
[INFO] [stderr] 47 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 44 |         match *ty.kind() {
[INFO] [stderr] 45 |             Kind::Array(ref ty) => <T as FromSql>::accepts(ty),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/impls.rs:56:28
[INFO] [stderr]    |
[INFO] [stderr] 56 |           let element_type = match ty.kind() {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 57 | |             &Kind::Array(ref ty) => ty,
[INFO] [stderr] 58 | |             _ => unreachable!(),
[INFO] [stderr] 59 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 56 |         let element_type = match *ty.kind() {
[INFO] [stderr] 57 |             Kind::Array(ref ty) => ty,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/impls.rs:86:9
[INFO] [stderr]    |
[INFO] [stderr] 86 | /         match ty.kind() {
[INFO] [stderr] 87 | |             &Kind::Array(ref ty) => <T as ToSql>::accepts(ty),
[INFO] [stderr] 88 | |             _ => false,
[INFO] [stderr] 89 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 86 |         match *ty.kind() {
[INFO] [stderr] 87 |             Kind::Array(ref ty) => <T as ToSql>::accepts(ty),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:28:14
[INFO] [stderr]    |
[INFO] [stderr] 28 |     fn shift(&self, idx: i32) -> i32 {
[INFO] [stderr]    |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/array.rs:74:13
[INFO] [stderr]    |
[INFO] [stderr] 74 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/array.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/array.rs:100:17
[INFO] [stderr]     |
[INFO] [stderr] 100 |                 lower_bound: lower_bound,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lower_bound`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/array.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     mut data: &mut I,
[INFO] [stderr]    |     ----^^^^
[INFO] [stderr]    |     |
[INFO] [stderr]    |     help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/array.rs:150:5
[INFO] [stderr]     |
[INFO] [stderr] 150 | /     pub fn iter<'a>(&'a self) -> Iter<'a, T> {
[INFO] [stderr] 151 | |         Iter { inner: self.data.iter() }
[INFO] [stderr] 152 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/array.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 | /     pub fn iter_mut<'a>(&'a mut self) -> IterMut<'a, T> {
[INFO] [stderr] 157 | |         IterMut { inner: self.data.iter_mut() }
[INFO] [stderr] 158 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/impls.rs:44:9
[INFO] [stderr]    |
[INFO] [stderr] 44 | /         match ty.kind() {
[INFO] [stderr] 45 | |             &Kind::Array(ref ty) => <T as FromSql>::accepts(ty),
[INFO] [stderr] 46 | |             _ => false,
[INFO] [stderr] 47 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 44 |         match *ty.kind() {
[INFO] [stderr] 45 |             Kind::Array(ref ty) => <T as FromSql>::accepts(ty),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/impls.rs:56:28
[INFO] [stderr]    |
[INFO] [stderr] 56 |           let element_type = match ty.kind() {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 57 | |             &Kind::Array(ref ty) => ty,
[INFO] [stderr] 58 | |             _ => unreachable!(),
[INFO] [stderr] 59 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 56 |         let element_type = match *ty.kind() {
[INFO] [stderr] 57 |             Kind::Array(ref ty) => ty,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/impls.rs:86:9
[INFO] [stderr]    |
[INFO] [stderr] 86 | /         match ty.kind() {
[INFO] [stderr] 87 | |             &Kind::Array(ref ty) => <T as ToSql>::accepts(ty),
[INFO] [stderr] 88 | |             _ => false,
[INFO] [stderr] 89 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 86 |         match *ty.kind() {
[INFO] [stderr] 87 |             Kind::Array(ref ty) => <T as ToSql>::accepts(ty),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:28:14
[INFO] [stderr]    |
[INFO] [stderr] 28 |     fn shift(&self, idx: i32) -> i32 {
[INFO] [stderr]    |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 16.05s
[INFO] running `"docker" "inspect" "dcc7a6cb5af4e3ea425a3a07330370bbd56671ae6816e12fd4beafca19d20674"`
[INFO] running `"docker" "rm" "-f" "dcc7a6cb5af4e3ea425a3a07330370bbd56671ae6816e12fd4beafca19d20674"`
[INFO] [stdout] dcc7a6cb5af4e3ea425a3a07330370bbd56671ae6816e12fd4beafca19d20674