[INFO] crate postgres-service 0.15.0 is already in cache [INFO] extracting crate postgres-service 0.15.0 into work/ex/clippy-test-run/sources/stable/reg/postgres-service/0.15.0 [INFO] extracting crate postgres-service 0.15.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/postgres-service/0.15.0 [INFO] validating manifest of postgres-service-0.15.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of postgres-service-0.15.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing postgres-service-0.15.0 [INFO] finished frobbing postgres-service-0.15.0 [INFO] frobbed toml for postgres-service-0.15.0 written to work/ex/clippy-test-run/sources/stable/reg/postgres-service/0.15.0/Cargo.toml [INFO] started frobbing postgres-service-0.15.0 [INFO] finished frobbing postgres-service-0.15.0 [INFO] frobbed toml for postgres-service-0.15.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/postgres-service/0.15.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting postgres-service-0.15.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/postgres-service/0.15.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6661f0d1b1b89619d145949f56b3a685a89a348271bb3237f2db94e3fc525337 [INFO] running `"docker" "start" "-a" "6661f0d1b1b89619d145949f56b3a685a89a348271bb3237f2db94e3fc525337"` [INFO] [stderr] Checking stringprep v0.1.2 [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Checking postgres-shared v0.4.2 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Checking postgres-service v0.15.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:27:30 [INFO] [stderr] | [INFO] [stderr] 27 | let host = self.maybe_host.unwrap_or( [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 28 | | postgres::params::Host::Unix( [INFO] [stderr] 29 | | std::path::PathBuf::from("/var/run/postgresql") [INFO] [stderr] 30 | | ) [INFO] [stderr] 31 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | let host = self.maybe_host.unwrap_or_else(|| postgres::params::Host::Unix( [INFO] [stderr] 28 | std::path::PathBuf::from("/var/run/postgresql") [INFO] [stderr] 29 | )); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | if v.len()>0 && v.starts_with('/') [INFO] [stderr] | ^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:93:44 [INFO] [stderr] | [INFO] [stderr] 93 | if let Some(section) = ini.section(Some(service_name.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 93 | if let Some(section) = ini.section(Some(&(*service_name).clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 93 | if let Some(section) = ini.section(Some(&str::clone(service_name))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:100:46 [INFO] [stderr] | [INFO] [stderr] 100 | let confdir = std::env::var("PGSYSCONFDIR").unwrap_or("/etc/postgresql-common".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "/etc/postgresql-common".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `postgres-service`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:27:30 [INFO] [stderr] | [INFO] [stderr] 27 | let host = self.maybe_host.unwrap_or( [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 28 | | postgres::params::Host::Unix( [INFO] [stderr] 29 | | std::path::PathBuf::from("/var/run/postgresql") [INFO] [stderr] 30 | | ) [INFO] [stderr] 31 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | let host = self.maybe_host.unwrap_or_else(|| postgres::params::Host::Unix( [INFO] [stderr] 28 | std::path::PathBuf::from("/var/run/postgresql") [INFO] [stderr] 29 | )); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | if v.len()>0 && v.starts_with('/') [INFO] [stderr] | ^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:93:44 [INFO] [stderr] | [INFO] [stderr] 93 | if let Some(section) = ini.section(Some(service_name.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 93 | if let Some(section) = ini.section(Some(&(*service_name).clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 93 | if let Some(section) = ini.section(Some(&str::clone(service_name))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:100:46 [INFO] [stderr] | [INFO] [stderr] 100 | let confdir = std::env::var("PGSYSCONFDIR").unwrap_or("/etc/postgresql-common".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "/etc/postgresql-common".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `postgres-service`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6661f0d1b1b89619d145949f56b3a685a89a348271bb3237f2db94e3fc525337"` [INFO] running `"docker" "rm" "-f" "6661f0d1b1b89619d145949f56b3a685a89a348271bb3237f2db94e3fc525337"` [INFO] [stdout] 6661f0d1b1b89619d145949f56b3a685a89a348271bb3237f2db94e3fc525337