[INFO] crate postgres-derive 0.3.3 is already in cache [INFO] extracting crate postgres-derive 0.3.3 into work/ex/clippy-test-run/sources/stable/reg/postgres-derive/0.3.3 [INFO] extracting crate postgres-derive 0.3.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/postgres-derive/0.3.3 [INFO] validating manifest of postgres-derive-0.3.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of postgres-derive-0.3.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing postgres-derive-0.3.3 [INFO] finished frobbing postgres-derive-0.3.3 [INFO] frobbed toml for postgres-derive-0.3.3 written to work/ex/clippy-test-run/sources/stable/reg/postgres-derive/0.3.3/Cargo.toml [INFO] started frobbing postgres-derive-0.3.3 [INFO] finished frobbing postgres-derive-0.3.3 [INFO] frobbed toml for postgres-derive-0.3.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/postgres-derive/0.3.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting postgres-derive-0.3.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/postgres-derive/0.3.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] de72fd5d64ac42464ad91b68dd8346f73c94e7de76962fe28aafc9283f2123bf [INFO] running `"docker" "start" "-a" "de72fd5d64ac42464ad91b68dd8346f73c94e7de76962fe28aafc9283f2123bf"` [INFO] [stderr] Checking proc-macro2 v0.3.8 [INFO] [stderr] Compiling postgres-derive v0.3.3 (/opt/crater/workdir) [INFO] [stderr] Checking quote v0.5.2 [INFO] [stderr] Checking syn v0.13.11 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/composites.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/composites.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/composites.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | let ident = raw.ident.as_ref().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*raw.ident.as_ref().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/enums.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | ident: raw.ident.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `raw.ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fromsql.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | fn enum_body(ident: &Ident, variants: &[Variant]) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fromsql.rs:81:23 [INFO] [stderr] | [INFO] [stderr] 81 | fn domain_body(ident: &Ident, field: &syn::Field) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fromsql.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | fn composite_body(ident: &Ident, fields: &[Field]) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tosql.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | fn enum_body(ident: &Ident, variants: &[Variant]) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/composites.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | let ident = raw.ident.as_ref().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*raw.ident.as_ref().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/enums.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | ident: raw.ident.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `raw.ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fromsql.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | fn enum_body(ident: &Ident, variants: &[Variant]) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fromsql.rs:81:23 [INFO] [stderr] | [INFO] [stderr] 81 | fn domain_body(ident: &Ident, field: &syn::Field) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fromsql.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | fn composite_body(ident: &Ident, fields: &[Field]) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tosql.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | fn enum_body(ident: &Ident, variants: &[Variant]) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.63s [INFO] running `"docker" "inspect" "de72fd5d64ac42464ad91b68dd8346f73c94e7de76962fe28aafc9283f2123bf"` [INFO] running `"docker" "rm" "-f" "de72fd5d64ac42464ad91b68dd8346f73c94e7de76962fe28aafc9283f2123bf"` [INFO] [stdout] de72fd5d64ac42464ad91b68dd8346f73c94e7de76962fe28aafc9283f2123bf