[INFO] crate postgres-binary-copy 0.5.0 is already in cache [INFO] extracting crate postgres-binary-copy 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/postgres-binary-copy/0.5.0 [INFO] extracting crate postgres-binary-copy 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/postgres-binary-copy/0.5.0 [INFO] validating manifest of postgres-binary-copy-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of postgres-binary-copy-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing postgres-binary-copy-0.5.0 [INFO] finished frobbing postgres-binary-copy-0.5.0 [INFO] frobbed toml for postgres-binary-copy-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/postgres-binary-copy/0.5.0/Cargo.toml [INFO] started frobbing postgres-binary-copy-0.5.0 [INFO] finished frobbing postgres-binary-copy-0.5.0 [INFO] frobbed toml for postgres-binary-copy-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/postgres-binary-copy/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting postgres-binary-copy-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/postgres-binary-copy/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ca5fd0d9db33961d06190a866f13c85fc6749809abb7f4317471dd3aa5f136c6 [INFO] running `"docker" "start" "-a" "ca5fd0d9db33961d06190a866f13c85fc6749809abb7f4317471dd3aa5f136c6"` [INFO] [stderr] Checking streaming-iterator v0.1.4 [INFO] [stderr] Checking postgres-binary-copy v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | types: types, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `types` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | it: it, [INFO] [stderr] | ^^^^^^ help: replace it with: `it` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | value_writer: value_writer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:339:17 [INFO] [stderr] | [INFO] [stderr] 339 | remaining: remaining, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | types: types, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `types` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | it: it, [INFO] [stderr] | ^^^^^^ help: replace it with: `it` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | value_writer: value_writer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:339:17 [INFO] [stderr] | [INFO] [stderr] 339 | remaining: remaining, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | const HEADER_MAGIC: &'static [u8] = b"PGCOPY\n\xff\r\n\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | const HEADER_MAGIC: &'static [u8] = b"PGCOPY\n\xff\r\n\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.57s [INFO] running `"docker" "inspect" "ca5fd0d9db33961d06190a866f13c85fc6749809abb7f4317471dd3aa5f136c6"` [INFO] running `"docker" "rm" "-f" "ca5fd0d9db33961d06190a866f13c85fc6749809abb7f4317471dd3aa5f136c6"` [INFO] [stdout] ca5fd0d9db33961d06190a866f13c85fc6749809abb7f4317471dd3aa5f136c6