[INFO] crate positioned-io 0.2.2 is already in cache [INFO] extracting crate positioned-io 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/positioned-io/0.2.2 [INFO] extracting crate positioned-io 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/positioned-io/0.2.2 [INFO] validating manifest of positioned-io-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of positioned-io-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing positioned-io-0.2.2 [INFO] finished frobbing positioned-io-0.2.2 [INFO] frobbed toml for positioned-io-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/positioned-io/0.2.2/Cargo.toml [INFO] started frobbing positioned-io-0.2.2 [INFO] finished frobbing positioned-io-0.2.2 [INFO] frobbed toml for positioned-io-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/positioned-io/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting positioned-io-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/positioned-io/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d18ffbf230278b7ac048d1975321fae585034c725ded4846d2f5191340a08a63 [INFO] running `"docker" "start" "-a" "d18ffbf230278b7ac048d1975321fae585034c725ded4846d2f5191340a08a63"` [INFO] [stderr] Checking positioned-io v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/byteorder/byteio.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | io: io, [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/byteorder/byteio.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | io: io, [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | Cursor { io: io, pos: pos } [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:58:26 [INFO] [stderr] | [INFO] [stderr] 58 | Cursor { io: io, pos: pos } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | io: io, [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | Cursor { io: io, pos: pos } [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:58:26 [INFO] [stderr] | [INFO] [stderr] 58 | Cursor { io: io, pos: pos } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | io: io, [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slice.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | i: i, [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:109:16 [INFO] [stderr] | [INFO] [stderr] 109 | assert_eq!(0x67616b63, r); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6761_6b63` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/array.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | self.as_ref().read_at(pos, buf) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/array.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | self.as_ref().size() [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/array.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | self.as_ref().read_at(pos, buf) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/array.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | self.as_ref().size() [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/test.rs:101:24 [INFO] [stderr] | [INFO] [stderr] 101 | assert!(s.contains("\n")); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.21s [INFO] running `"docker" "inspect" "d18ffbf230278b7ac048d1975321fae585034c725ded4846d2f5191340a08a63"` [INFO] running `"docker" "rm" "-f" "d18ffbf230278b7ac048d1975321fae585034c725ded4846d2f5191340a08a63"` [INFO] [stdout] d18ffbf230278b7ac048d1975321fae585034c725ded4846d2f5191340a08a63