[INFO] crate porteurbars 0.1.5 is already in cache [INFO] extracting crate porteurbars 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/porteurbars/0.1.5 [INFO] extracting crate porteurbars 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/porteurbars/0.1.5 [INFO] validating manifest of porteurbars-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of porteurbars-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing porteurbars-0.1.5 [INFO] finished frobbing porteurbars-0.1.5 [INFO] frobbed toml for porteurbars-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/porteurbars/0.1.5/Cargo.toml [INFO] started frobbing porteurbars-0.1.5 [INFO] finished frobbing porteurbars-0.1.5 [INFO] frobbed toml for porteurbars-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/porteurbars/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting porteurbars-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/porteurbars/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d2f733d78ea1698f7df96cdce8ac09a7663637e17e8ad91c1dff28a025f1ee0c [INFO] running `"docker" "start" "-a" "d2f733d78ea1698f7df96cdce8ac09a7663637e17e8ad91c1dff28a025f1ee0c"` [INFO] [stderr] Checking case v0.1.0 [INFO] [stderr] Checking handlebars v0.28.3 [INFO] [stderr] Checking porteurbars v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: using `writeln!(t, "")` [INFO] [stderr] --> src/template.rs:296:25 [INFO] [stderr] | [INFO] [stderr] 296 | writeln!(t, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(t, "")` [INFO] [stderr] --> src/template.rs:296:25 [INFO] [stderr] | [INFO] [stderr] 296 | writeln!(t, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/template.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | const TEMPLATE_DIR: &'static str = "template"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/template.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | const DEFAULTS: &'static str = "default.env"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/template.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | const TEMPLATE_DIR: &'static str = "template"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/template.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | const DEFAULTS: &'static str = "default.env"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/defaults.rs:22:36 [INFO] [stderr] | [INFO] [stderr] 22 | .filter(|l| !l.starts_with("#")) [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/defaults.rs:23:30 [INFO] [stderr] | [INFO] [stderr] 23 | .map(|l| l.splitn(2, "=").collect::>()) [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/defaults.rs:26:56 [INFO] [stderr] | [INFO] [stderr] 26 | if let Some(value) = pair[1].splitn(2, "#").next() { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/git.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn from_str(txt: &str) -> Result { [INFO] [stderr] 21 | | lazy_static! { [INFO] [stderr] 22 | | static ref LOCAL: Regex = Regex::new(r#"^file://(\S+)$"#).unwrap(); [INFO] [stderr] 23 | | static ref GH: Regex = Regex::new(r#"^([^\s/]+)/([^\s/]+?)$"#).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 44 | | .ok_or(ErrorKind::InvalidUri(txt.into()).into()) [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/git.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .ok_or(ErrorKind::InvalidUri(txt.into()).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::InvalidUri(txt.into()).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/errors.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / error_chain! { [INFO] [stderr] 9 | | [INFO] [stderr] 10 | | foreign_links { [INFO] [stderr] 11 | | Io(io::Error); [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/template.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | .unwrap_or(path.to_path_buf()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| path.to_path_buf())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/template.rs:91:14 [INFO] [stderr] | [INFO] [stderr] 91 | .unwrap_or(self.path.to_path_buf()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.path.to_path_buf())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/template.rs:197:22 [INFO] [stderr] | [INFO] [stderr] 197 | .ok_or(RenderError::new(format!( [INFO] [stderr] | ______________________^ [INFO] [stderr] 198 | | "Parameter 0 with str type is required for {} helper.", [INFO] [stderr] 199 | | helper_name [INFO] [stderr] 200 | | )))?; [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 197 | .ok_or_else(|| RenderError::new(format!( [INFO] [stderr] 198 | "Parameter 0 with str type is required for {} helper.", [INFO] [stderr] 199 | helper_name [INFO] [stderr] 200 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/template.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | rc.writer.write(f(value).as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/template.rs:220:65 [INFO] [stderr] | [INFO] [stderr] 220 | let a = h.param(0).and_then(|v| v.value().as_str()).ok_or( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 221 | | RenderError::new( [INFO] [stderr] 222 | | "Parameter 0 with str type is required for eq helper.", [INFO] [stderr] 223 | | ), [INFO] [stderr] 224 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 220 | let a = h.param(0).and_then(|v| v.value().as_str()).ok_or_else(|| RenderError::new( [INFO] [stderr] 221 | "Parameter 0 with str type is required for eq helper.", [INFO] [stderr] 222 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/template.rs:225:65 [INFO] [stderr] | [INFO] [stderr] 225 | let b = h.param(1).and_then(|v| v.value().as_str()).ok_or( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 226 | | RenderError::new( [INFO] [stderr] 227 | | "Parameter 1 with str type is required for eq helper.", [INFO] [stderr] 228 | | ), [INFO] [stderr] 229 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 225 | let b = h.param(1).and_then(|v| v.value().as_str()).ok_or_else(|| RenderError::new( [INFO] [stderr] 226 | "Parameter 1 with str type is required for eq helper.", [INFO] [stderr] 227 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/template.rs:260:41 [INFO] [stderr] | [INFO] [stderr] 260 | Ok(trimmed.is_empty() || trimmed != String::from("r")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"r"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/defaults.rs:22:36 [INFO] [stderr] | [INFO] [stderr] 22 | .filter(|l| !l.starts_with("#")) [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/defaults.rs:23:30 [INFO] [stderr] | [INFO] [stderr] 23 | .map(|l| l.splitn(2, "=").collect::>()) [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/defaults.rs:26:56 [INFO] [stderr] | [INFO] [stderr] 26 | if let Some(value) = pair[1].splitn(2, "#").next() { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/template.rs:331:23 [INFO] [stderr] | [INFO] [stderr] 331 | fn interact(defaults: &defaults::Defaults) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/git.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn from_str(txt: &str) -> Result { [INFO] [stderr] 21 | | lazy_static! { [INFO] [stderr] 22 | | static ref LOCAL: Regex = Regex::new(r#"^file://(\S+)$"#).unwrap(); [INFO] [stderr] 23 | | static ref GH: Regex = Regex::new(r#"^([^\s/]+)/([^\s/]+?)$"#).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 44 | | .ok_or(ErrorKind::InvalidUri(txt.into()).into()) [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: Could not compile `porteurbars`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/git.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .ok_or(ErrorKind::InvalidUri(txt.into()).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::InvalidUri(txt.into()).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/errors.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / error_chain! { [INFO] [stderr] 9 | | [INFO] [stderr] 10 | | foreign_links { [INFO] [stderr] 11 | | Io(io::Error); [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/template.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | .unwrap_or(path.to_path_buf()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| path.to_path_buf())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/template.rs:91:14 [INFO] [stderr] | [INFO] [stderr] 91 | .unwrap_or(self.path.to_path_buf()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.path.to_path_buf())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/template.rs:197:22 [INFO] [stderr] | [INFO] [stderr] 197 | .ok_or(RenderError::new(format!( [INFO] [stderr] | ______________________^ [INFO] [stderr] 198 | | "Parameter 0 with str type is required for {} helper.", [INFO] [stderr] 199 | | helper_name [INFO] [stderr] 200 | | )))?; [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 197 | .ok_or_else(|| RenderError::new(format!( [INFO] [stderr] 198 | "Parameter 0 with str type is required for {} helper.", [INFO] [stderr] 199 | helper_name [INFO] [stderr] 200 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/template.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | rc.writer.write(f(value).as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/template.rs:220:65 [INFO] [stderr] | [INFO] [stderr] 220 | let a = h.param(0).and_then(|v| v.value().as_str()).ok_or( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 221 | | RenderError::new( [INFO] [stderr] 222 | | "Parameter 0 with str type is required for eq helper.", [INFO] [stderr] 223 | | ), [INFO] [stderr] 224 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 220 | let a = h.param(0).and_then(|v| v.value().as_str()).ok_or_else(|| RenderError::new( [INFO] [stderr] 221 | "Parameter 0 with str type is required for eq helper.", [INFO] [stderr] 222 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/template.rs:225:65 [INFO] [stderr] | [INFO] [stderr] 225 | let b = h.param(1).and_then(|v| v.value().as_str()).ok_or( [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 226 | | RenderError::new( [INFO] [stderr] 227 | | "Parameter 1 with str type is required for eq helper.", [INFO] [stderr] 228 | | ), [INFO] [stderr] 229 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 225 | let b = h.param(1).and_then(|v| v.value().as_str()).ok_or_else(|| RenderError::new( [INFO] [stderr] 226 | "Parameter 1 with str type is required for eq helper.", [INFO] [stderr] 227 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/template.rs:260:41 [INFO] [stderr] | [INFO] [stderr] 260 | Ok(trimmed.is_empty() || trimmed != String::from("r")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"r"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/template.rs:331:23 [INFO] [stderr] | [INFO] [stderr] 331 | fn interact(defaults: &defaults::Defaults) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `porteurbars`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d2f733d78ea1698f7df96cdce8ac09a7663637e17e8ad91c1dff28a025f1ee0c"` [INFO] running `"docker" "rm" "-f" "d2f733d78ea1698f7df96cdce8ac09a7663637e17e8ad91c1dff28a025f1ee0c"` [INFO] [stdout] d2f733d78ea1698f7df96cdce8ac09a7663637e17e8ad91c1dff28a025f1ee0c