[INFO] crate port_scanner 0.1.5 is already in cache [INFO] extracting crate port_scanner 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/port_scanner/0.1.5 [INFO] extracting crate port_scanner 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/port_scanner/0.1.5 [INFO] validating manifest of port_scanner-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of port_scanner-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing port_scanner-0.1.5 [INFO] finished frobbing port_scanner-0.1.5 [INFO] frobbed toml for port_scanner-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/port_scanner/0.1.5/Cargo.toml [INFO] started frobbing port_scanner-0.1.5 [INFO] finished frobbing port_scanner-0.1.5 [INFO] frobbed toml for port_scanner-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/port_scanner/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting port_scanner-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/port_scanner/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5beaf01f2ffbed530c8897bf93dde038c7113878c94b40695646b3699ba8dcee [INFO] running `"docker" "start" "-a" "5beaf01f2ffbed530c8897bf93dde038c7113878c94b40695646b3699ba8dcee"` [INFO] [stderr] Checking port_scanner v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match TcpStream::connect(("0.0.0.0", port)) { [INFO] [stderr] 13 | | Ok(_) => true, [INFO] [stderr] 14 | | Err(_) => false, [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ help: try this: `TcpStream::connect(("0.0.0.0", port)).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / match TcpStream::connect(addr) { [INFO] [stderr] 27 | | Ok(_) => true, [INFO] [stderr] 28 | | Err(_) => false, [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ help: try this: `TcpStream::connect(addr).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / match TcpListener::bind(("127.0.0.1", port)) { [INFO] [stderr] 118 | | Ok(_) => true, [INFO] [stderr] 119 | | Err(_) => false, [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ help: try this: `TcpListener::bind(("127.0.0.1", port)).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match TcpStream::connect(("0.0.0.0", port)) { [INFO] [stderr] 13 | | Ok(_) => true, [INFO] [stderr] 14 | | Err(_) => false, [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ help: try this: `TcpStream::connect(("0.0.0.0", port)).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / match TcpStream::connect(addr) { [INFO] [stderr] 27 | | Ok(_) => true, [INFO] [stderr] 28 | | Err(_) => false, [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ help: try this: `TcpStream::connect(addr).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / match TcpListener::bind(("127.0.0.1", port)) { [INFO] [stderr] 118 | | Ok(_) => true, [INFO] [stderr] 119 | | Err(_) => false, [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ help: try this: `TcpListener::bind(("127.0.0.1", port)).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> examples/scan_port.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / match is_open { [INFO] [stderr] 8 | | true => println!("Port 8123 is open"), [INFO] [stderr] 9 | | false => println!("Port 8123 is close"), [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if is_open { println!("Port 8123 is open") } else { println!("Port 8123 is close") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.32s [INFO] running `"docker" "inspect" "5beaf01f2ffbed530c8897bf93dde038c7113878c94b40695646b3699ba8dcee"` [INFO] running `"docker" "rm" "-f" "5beaf01f2ffbed530c8897bf93dde038c7113878c94b40695646b3699ba8dcee"` [INFO] [stdout] 5beaf01f2ffbed530c8897bf93dde038c7113878c94b40695646b3699ba8dcee