[INFO] crate popcorn-blas 0.1.0 is already in cache [INFO] extracting crate popcorn-blas 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/popcorn-blas/0.1.0 [INFO] extracting crate popcorn-blas 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/popcorn-blas/0.1.0 [INFO] validating manifest of popcorn-blas-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of popcorn-blas-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing popcorn-blas-0.1.0 [INFO] removed path dependency popcorn from popcorn-blas-0.1.0 [INFO] finished frobbing popcorn-blas-0.1.0 [INFO] frobbed toml for popcorn-blas-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/popcorn-blas/0.1.0/Cargo.toml [INFO] started frobbing popcorn-blas-0.1.0 [INFO] removed path dependency popcorn from popcorn-blas-0.1.0 [INFO] finished frobbing popcorn-blas-0.1.0 [INFO] frobbed toml for popcorn-blas-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/popcorn-blas/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting popcorn-blas-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/popcorn-blas/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c924c2d7b1379c22dcaf020e53b2fdb636c298268660d08c69ba4a6fb46da43b [INFO] running `"docker" "start" "-a" "c924c2d7b1379c22dcaf020e53b2fdb636c298268660d08c69ba4a6fb46da43b"` [INFO] [stderr] warning: unused manifest key: package.keyworkds [INFO] [stderr] Checking blas-sys v0.6.9 [INFO] [stderr] Checking popcorn v0.1.0 [INFO] [stderr] Checking popcorn-blas v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frameworks/native/broadcast/shape.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frameworks/native/broadcast/shape.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | target: target [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frameworks/native/broadcast/iter.rs:24:7 [INFO] [stderr] | [INFO] [stderr] 24 | dim: dim, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frameworks/native/broadcast/iter.rs:26:7 [INFO] [stderr] | [INFO] [stderr] 26 | buf: buf [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frameworks/native/broadcast/iter.rs:69:7 [INFO] [stderr] | [INFO] [stderr] 69 | bufs: bufs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bufs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frameworks/native/broadcast/iter.rs:70:7 [INFO] [stderr] | [INFO] [stderr] 70 | iterators: iterators [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iterators` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frameworks/native/broadcast/iter.rs:132:7 [INFO] [stderr] | [INFO] [stderr] 132 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frameworks/native/broadcast/shape.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frameworks/native/broadcast/shape.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | target: target [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frameworks/native/broadcast/iter.rs:24:7 [INFO] [stderr] | [INFO] [stderr] 24 | dim: dim, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frameworks/native/broadcast/iter.rs:26:7 [INFO] [stderr] | [INFO] [stderr] 26 | buf: buf [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frameworks/native/broadcast/iter.rs:69:7 [INFO] [stderr] | [INFO] [stderr] 69 | bufs: bufs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bufs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frameworks/native/broadcast/iter.rs:70:7 [INFO] [stderr] | [INFO] [stderr] 70 | iterators: iterators [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iterators` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frameworks/native/broadcast/iter.rs:132:7 [INFO] [stderr] | [INFO] [stderr] 132 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/operation.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | mut shape_c: Buffer, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(patterns_in_fns_without_body)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/operation.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | mut c: Buffer) -> [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: unused import: `IntoFuture` [INFO] [stderr] --> src/frameworks/native/mod.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | use futures::{Future, IntoFuture}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/frameworks/native/mod.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | use popcorn::buffer::{self, Buffer, BufferDevice, Error}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: private trait `frameworks::native::Dot` in public interface (error E0445) [INFO] [stderr] --> src/frameworks/native/mod.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / impl DotOperation for Backend { [INFO] [stderr] 23 | | fn bcast_dot(&self, [INFO] [stderr] 24 | | shape_a: Buffer, [INFO] [stderr] 25 | | a: Buffer, [INFO] [stderr] ... | [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/frameworks/native/mod.rs:28:16 [INFO] [stderr] | [INFO] [stderr] 28 | mut shape_c: Buffer, [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/frameworks/native/mod.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | mut c: Buffer) -> [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/operation.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / Box, Buffer, // A [INFO] [stderr] 13 | | Buffer, Buffer, // B [INFO] [stderr] 14 | | Buffer, Buffer), Error=Error>>; // Result [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/frameworks/native/broadcast/iter.rs:133:14 [INFO] [stderr] | [INFO] [stderr] 133 | range: 1..(shape.len() + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `1..=shape.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/frameworks/native/broadcast/iter.rs:144:35 [INFO] [stderr] | [INFO] [stderr] 144 | take(self.shape.len() - i). [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 145 | | fold(1, |acc, size| acc * size) [INFO] [stderr] | |_______________________________________^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/frameworks/native/broadcast/mod.rs:12:52 [INFO] [stderr] | [INFO] [stderr] 12 | b: &'a [T]) -> Result<(Vec, DenseBroadcastIter<'a, T>, DenseBroadcastIter<'a, T>), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/frameworks/native/broadcast/mod.rs:21:54 [INFO] [stderr] | [INFO] [stderr] 21 | let bdims_a = BroadcastDimension::shape_from_iters(shape_a.iter().map(|x| *x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `shape_a.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/frameworks/native/broadcast/mod.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | bshape.iter().map(|x| *x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bshape.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/frameworks/native/broadcast/mod.rs:25:54 [INFO] [stderr] | [INFO] [stderr] 25 | let bdims_b = BroadcastDimension::shape_from_iters(shape_b.iter().map(|x| *x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `shape_b.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/frameworks/native/broadcast/mod.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | bshape.iter().map(|x| *x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bshape.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/frameworks/native/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / Box, Buffer, [INFO] [stderr] 31 | | Buffer, Buffer, [INFO] [stderr] 32 | | Buffer, Buffer), Error=Error>> { [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/operation.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | mut shape_c: Buffer, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(patterns_in_fns_without_body)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: patterns aren't allowed in methods without bodies [INFO] [stderr] --> src/operation.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | mut c: Buffer) -> [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #35203 [INFO] [stderr] [INFO] [stderr] warning: unused import: `IntoFuture` [INFO] [stderr] --> src/frameworks/native/mod.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | use futures::{Future, IntoFuture}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/frameworks/native/mod.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | use popcorn::buffer::{self, Buffer, BufferDevice, Error}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: private trait `frameworks::native::Dot` in public interface (error E0445) [INFO] [stderr] --> src/frameworks/native/mod.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / impl DotOperation for Backend { [INFO] [stderr] 23 | | fn bcast_dot(&self, [INFO] [stderr] 24 | | shape_a: Buffer, [INFO] [stderr] 25 | | a: Buffer, [INFO] [stderr] ... | [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/frameworks/native/mod.rs:28:16 [INFO] [stderr] | [INFO] [stderr] 28 | mut shape_c: Buffer, [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/frameworks/native/mod.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | mut c: Buffer) -> [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/operation.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / Box, Buffer, // A [INFO] [stderr] 13 | | Buffer, Buffer, // B [INFO] [stderr] 14 | | Buffer, Buffer), Error=Error>>; // Result [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/frameworks/native/broadcast/iter.rs:133:14 [INFO] [stderr] | [INFO] [stderr] 133 | range: 1..(shape.len() + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `1..=shape.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/frameworks/native/broadcast/iter.rs:144:35 [INFO] [stderr] | [INFO] [stderr] 144 | take(self.shape.len() - i). [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 145 | | fold(1, |acc, size| acc * size) [INFO] [stderr] | |_______________________________________^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/frameworks/native/broadcast/mod.rs:12:52 [INFO] [stderr] | [INFO] [stderr] 12 | b: &'a [T]) -> Result<(Vec, DenseBroadcastIter<'a, T>, DenseBroadcastIter<'a, T>), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/frameworks/native/broadcast/mod.rs:21:54 [INFO] [stderr] | [INFO] [stderr] 21 | let bdims_a = BroadcastDimension::shape_from_iters(shape_a.iter().map(|x| *x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `shape_a.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/frameworks/native/broadcast/mod.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | bshape.iter().map(|x| *x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bshape.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/frameworks/native/broadcast/mod.rs:25:54 [INFO] [stderr] | [INFO] [stderr] 25 | let bdims_b = BroadcastDimension::shape_from_iters(shape_b.iter().map(|x| *x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `shape_b.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/frameworks/native/broadcast/mod.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | bshape.iter().map(|x| *x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bshape.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/frameworks/native/mod.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / Box, Buffer, [INFO] [stderr] 31 | | Buffer, Buffer, [INFO] [stderr] 32 | | Buffer, Buffer), Error=Error>> { [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.61s [INFO] running `"docker" "inspect" "c924c2d7b1379c22dcaf020e53b2fdb636c298268660d08c69ba4a6fb46da43b"` [INFO] running `"docker" "rm" "-f" "c924c2d7b1379c22dcaf020e53b2fdb636c298268660d08c69ba4a6fb46da43b"` [INFO] [stdout] c924c2d7b1379c22dcaf020e53b2fdb636c298268660d08c69ba4a6fb46da43b