[INFO] crate pony 0.1.10 is already in cache [INFO] extracting crate pony 0.1.10 into work/ex/clippy-test-run/sources/stable/reg/pony/0.1.10 [INFO] extracting crate pony 0.1.10 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pony/0.1.10 [INFO] validating manifest of pony-0.1.10 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pony-0.1.10 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pony-0.1.10 [INFO] finished frobbing pony-0.1.10 [INFO] frobbed toml for pony-0.1.10 written to work/ex/clippy-test-run/sources/stable/reg/pony/0.1.10/Cargo.toml [INFO] started frobbing pony-0.1.10 [INFO] finished frobbing pony-0.1.10 [INFO] frobbed toml for pony-0.1.10 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pony/0.1.10/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pony-0.1.10 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pony/0.1.10:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 31fdc29eb59511d83464385c6dca1f7a3bbb653b6d4b52dc180df227a687bfb7 [INFO] running `"docker" "start" "-a" "31fdc29eb59511d83464385c6dca1f7a3bbb653b6d4b52dc180df227a687bfb7"` [INFO] [stderr] Checking pony v0.1.10 (/opt/crater/workdir) [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pony.rs:118:101 [INFO] [stderr] | [INFO] [stderr] 118 | headers.append_raw("ETag", format!("{}", (d.as_secs() * 1000) + d.subsec_millis() as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(d.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/pony.rs:157:16 [INFO] [stderr] | [INFO] [stderr] 157 | if let Ok(_) = reader.read_to_end(&mut contents) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 158 | | Ok(contents) [INFO] [stderr] 159 | | } else { [INFO] [stderr] 160 | | return Err(String::from("File unreadable")) [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________- help: try this: `if reader.read_to_end(&mut contents).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/pony.rs:166:27 [INFO] [stderr] | [INFO] [stderr] 166 | if path.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pony.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | / match req.method() { [INFO] [stderr] 184 | | &Get => { [INFO] [stderr] 185 | | self.get(req) [INFO] [stderr] 186 | | }, [INFO] [stderr] ... | [INFO] [stderr] 207 | | } [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 183 | match *req.method() { [INFO] [stderr] 184 | Get => { [INFO] [stderr] 185 | self.get(req) [INFO] [stderr] 186 | }, [INFO] [stderr] 187 | Post => { [INFO] [stderr] 188 | match self.posts.get(req.path()) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pony_builder::PonyBuilder` [INFO] [stderr] --> src/pony_builder.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> PonyBuilder { [INFO] [stderr] 30 | | Self { [INFO] [stderr] 31 | | gets: HashMap::new(), [INFO] [stderr] 32 | | posts: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/pony_builder.rs:120:20 [INFO] [stderr] | [INFO] [stderr] 120 | panic!(format!("Not found path is a directory")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Not found path is a directory".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pony_builder.rs:130:57 [INFO] [stderr] | [INFO] [stderr] 130 | self.known_extensions = HashSet::from_iter(list.into_iter().map(|e| e.to_string())); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pony_builder.rs:135:43 [INFO] [stderr] | [INFO] [stderr] 135 | self.known_extensions.extend(exts.into_iter().map(|e| e.to_string())); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pony_builder.rs:140:25 [INFO] [stderr] | [INFO] [stderr] 140 | for ext in exts.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/pony_builder.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | static_enabled: self.static_enabled == true, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.static_enabled` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/pony_builder.rs:162:31 [INFO] [stderr] | [INFO] [stderr] 162 | custom_not_found: self.custom_not_found == true, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.custom_not_found` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/pony_builder.rs:164:23 [INFO] [stderr] | [INFO] [stderr] 164 | use_gzip: self.static_gzip_enabled == true, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.static_gzip_enabled` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pony.rs:118:101 [INFO] [stderr] | [INFO] [stderr] 118 | headers.append_raw("ETag", format!("{}", (d.as_secs() * 1000) + d.subsec_millis() as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(d.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/pony.rs:157:16 [INFO] [stderr] | [INFO] [stderr] 157 | if let Ok(_) = reader.read_to_end(&mut contents) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 158 | | Ok(contents) [INFO] [stderr] 159 | | } else { [INFO] [stderr] 160 | | return Err(String::from("File unreadable")) [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________- help: try this: `if reader.read_to_end(&mut contents).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/pony.rs:166:27 [INFO] [stderr] | [INFO] [stderr] 166 | if path.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pony.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | / match req.method() { [INFO] [stderr] 184 | | &Get => { [INFO] [stderr] 185 | | self.get(req) [INFO] [stderr] 186 | | }, [INFO] [stderr] ... | [INFO] [stderr] 207 | | } [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 183 | match *req.method() { [INFO] [stderr] 184 | Get => { [INFO] [stderr] 185 | self.get(req) [INFO] [stderr] 186 | }, [INFO] [stderr] 187 | Post => { [INFO] [stderr] 188 | match self.posts.get(req.path()) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/pony.rs:276:17 [INFO] [stderr] | [INFO] [stderr] 276 | Err(_) => panic!("Req is not OK"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pony.rs:305:20 [INFO] [stderr] | [INFO] [stderr] 305 | let body = match method { [INFO] [stderr] | ____________________^ [INFO] [stderr] 306 | | &Method::Get => "GET", [INFO] [stderr] 307 | | &Method::Put => "PUT", [INFO] [stderr] 308 | | &Method::Post => "POST", [INFO] [stderr] 309 | | &Method::Delete => "DELETE", [INFO] [stderr] 310 | | _ => "UNKNOWN" [INFO] [stderr] 311 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 305 | let body = match *method { [INFO] [stderr] 306 | Method::Get => "GET", [INFO] [stderr] 307 | Method::Put => "PUT", [INFO] [stderr] 308 | Method::Post => "POST", [INFO] [stderr] 309 | Method::Delete => "DELETE", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `pony_builder::PonyBuilder` [INFO] [stderr] --> src/pony_builder.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> PonyBuilder { [INFO] [stderr] 30 | | Self { [INFO] [stderr] 31 | | gets: HashMap::new(), [INFO] [stderr] 32 | | posts: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/pony_builder.rs:120:20 [INFO] [stderr] | [INFO] [stderr] 120 | panic!(format!("Not found path is a directory")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Not found path is a directory".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pony_builder.rs:130:57 [INFO] [stderr] | [INFO] [stderr] 130 | self.known_extensions = HashSet::from_iter(list.into_iter().map(|e| e.to_string())); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pony_builder.rs:135:43 [INFO] [stderr] | [INFO] [stderr] 135 | self.known_extensions.extend(exts.into_iter().map(|e| e.to_string())); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pony_builder.rs:140:25 [INFO] [stderr] | [INFO] [stderr] 140 | for ext in exts.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/pony_builder.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | static_enabled: self.static_enabled == true, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.static_enabled` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/pony_builder.rs:162:31 [INFO] [stderr] | [INFO] [stderr] 162 | custom_not_found: self.custom_not_found == true, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.custom_not_found` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/pony_builder.rs:164:23 [INFO] [stderr] | [INFO] [stderr] 164 | use_gzip: self.static_gzip_enabled == true, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.static_gzip_enabled` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/pony_builder.rs:212:38 [INFO] [stderr] | [INFO] [stderr] 212 | assert!(pb.not_found_path == path.to_string(), "pb.not_found_path did not match"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.13s [INFO] running `"docker" "inspect" "31fdc29eb59511d83464385c6dca1f7a3bbb653b6d4b52dc180df227a687bfb7"` [INFO] running `"docker" "rm" "-f" "31fdc29eb59511d83464385c6dca1f7a3bbb653b6d4b52dc180df227a687bfb7"` [INFO] [stdout] 31fdc29eb59511d83464385c6dca1f7a3bbb653b6d4b52dc180df227a687bfb7