[INFO] crate polynomial 0.1.0 is already in cache [INFO] extracting crate polynomial 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/polynomial/0.1.0 [INFO] extracting crate polynomial 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/polynomial/0.1.0 [INFO] validating manifest of polynomial-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of polynomial-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing polynomial-0.1.0 [INFO] finished frobbing polynomial-0.1.0 [INFO] frobbed toml for polynomial-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/polynomial/0.1.0/Cargo.toml [INFO] started frobbing polynomial-0.1.0 [INFO] finished frobbing polynomial-0.1.0 [INFO] frobbed toml for polynomial-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/polynomial/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting polynomial-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/polynomial/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 90cb45630d2ff592626dc9d29445bc082948c8bf4264589ad35abf3954cfd3e8 [INFO] running `"docker" "start" "-a" "90cb45630d2ff592626dc9d29445bc082948c8bf4264589ad35abf3954cfd3e8"` [INFO] [stderr] Checking polynomial v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | Polynomial { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | Polynomial { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:100:20 [INFO] [stderr] | [INFO] [stderr] 100 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 101 | | if (*n) == one { [INFO] [stderr] 102 | | format!("{}^{}", x, i) [INFO] [stderr] 103 | | } else if (*n) == -one.clone() { [INFO] [stderr] ... | [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 100 | } else if (*n) == one { [INFO] [stderr] 101 | format!("{}^{}", x, i) [INFO] [stderr] 102 | } else if (*n) == -one.clone() { [INFO] [stderr] 103 | format!("-{}^{}", x, i) [INFO] [stderr] 104 | } else { [INFO] [stderr] 105 | format!("{}*{}^{}", n.to_string(), x, i) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:100:20 [INFO] [stderr] | [INFO] [stderr] 100 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 101 | | if (*n) == one { [INFO] [stderr] 102 | | format!("{}^{}", x, i) [INFO] [stderr] 103 | | } else if (*n) == -one.clone() { [INFO] [stderr] ... | [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 100 | } else if (*n) == one { [INFO] [stderr] 101 | format!("{}^{}", x, i) [INFO] [stderr] 102 | } else if (*n) == -one.clone() { [INFO] [stderr] 103 | format!("-{}^{}", x, i) [INFO] [stderr] 104 | } else { [INFO] [stderr] 105 | format!("{}*{}^{}", n.to_string(), x, i) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:110:16 [INFO] [stderr] | [INFO] [stderr] 110 | if s.len() > 0 && (*n) > Zero::zero() { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:283:27 [INFO] [stderr] | [INFO] [stderr] 283 | if self.is_zero() || other.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:293:45 [INFO] [stderr] | [INFO] [stderr] 293 | let kend = cmp::min(slen, i + 1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `polynomial`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:110:16 [INFO] [stderr] | [INFO] [stderr] 110 | if s.len() > 0 && (*n) > Zero::zero() { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:283:27 [INFO] [stderr] | [INFO] [stderr] 283 | if self.is_zero() || other.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:293:45 [INFO] [stderr] | [INFO] [stderr] 293 | let kend = cmp::min(slen, i + 1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `polynomial`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "90cb45630d2ff592626dc9d29445bc082948c8bf4264589ad35abf3954cfd3e8"` [INFO] running `"docker" "rm" "-f" "90cb45630d2ff592626dc9d29445bc082948c8bf4264589ad35abf3954cfd3e8"` [INFO] [stdout] 90cb45630d2ff592626dc9d29445bc082948c8bf4264589ad35abf3954cfd3e8