[INFO] crate polly 0.1.2 is already in cache [INFO] extracting crate polly 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/polly/0.1.2 [INFO] extracting crate polly 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/polly/0.1.2 [INFO] validating manifest of polly-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of polly-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing polly-0.1.2 [INFO] finished frobbing polly-0.1.2 [INFO] frobbed toml for polly-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/polly/0.1.2/Cargo.toml [INFO] started frobbing polly-0.1.2 [INFO] finished frobbing polly-0.1.2 [INFO] frobbed toml for polly-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/polly/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting polly-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/polly/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ce1de0b17aae43bbf04165240b046083d166986fdf090ca669bd3160d1df48fa [INFO] running `"docker" "start" "-a" "ce1de0b17aae43bbf04165240b046083d166986fdf090ca669bd3160d1df48fa"` [INFO] [stderr] Checking serde v0.6.15 [INFO] [stderr] Checking serde_json v0.6.1 [INFO] [stderr] Checking polly v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/codegen.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | parent: parent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/codegen.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | parent: parent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/codegen.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | parent: parent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/tokens/element.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/codegen.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | parent: parent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/tokens/element.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/template.rs:528:13 [INFO] [stderr] | [INFO] [stderr] 528 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/template.rs:528:13 [INFO] [stderr] | [INFO] [stderr] 528 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/compiler/parser.rs:189:60 [INFO] [stderr] | [INFO] [stderr] 189 | return Ok(CompCall((ComponentCall::from_component(component)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/compiler/parser.rs:189:60 [INFO] [stderr] | [INFO] [stderr] 189 | return Ok(CompCall((ComponentCall::from_component(component)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/compiler/codegen.rs:13:24 [INFO] [stderr] | [INFO] [stderr] 13 | const VOID_ELEMENTS: [&'static str; 13] = ["area", "base", "br", "col", "hr", "img", "input", [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/codegen.rs:238:32 [INFO] [stderr] | [INFO] [stderr] 238 | Some(value) => return Ok(value.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(value.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/codegen.rs:239:22 [INFO] [stderr] | [INFO] [stderr] 239 | _ => return Err(CodegenError::NotAnObjectOrNull(String::from(name.clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(CodegenError::NotAnObjectOrNull(String::from(name.clone())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/template.rs:422:27 [INFO] [stderr] | [INFO] [stderr] 422 | Err(error) => return Err(error), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/template.rs:578:19 [INFO] [stderr] | [INFO] [stderr] 578 | const BASIC: &'static str = "

Hello World!

"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/template.rs:579:22 [INFO] [stderr] | [INFO] [stderr] 579 | const BASIC_DE: &'static str = "

Hallo Welt!

"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/compiler/parser.rs:275:49 [INFO] [stderr] | [INFO] [stderr] 275 | return unexpected_eof!(Symbol(index, Equals)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/compiler/parser.rs:285:45 [INFO] [stderr] | [INFO] [stderr] 285 | None => return unexpected_eof!(Word(index, key)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/compiler/parser.rs:189:60 [INFO] [stderr] | [INFO] [stderr] 189 | return Ok(CompCall((ComponentCall::from_component(component)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/compiler/parser.rs:189:60 [INFO] [stderr] | [INFO] [stderr] 189 | return Ok(CompCall((ComponentCall::from_component(component)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/compiler/codegen.rs:13:24 [INFO] [stderr] | [INFO] [stderr] 13 | const VOID_ELEMENTS: [&'static str; 13] = ["area", "base", "br", "col", "hr", "img", "input", [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/codegen.rs:238:32 [INFO] [stderr] | [INFO] [stderr] 238 | Some(value) => return Ok(value.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(value.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/codegen.rs:239:22 [INFO] [stderr] | [INFO] [stderr] 239 | _ => return Err(CodegenError::NotAnObjectOrNull(String::from(name.clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(CodegenError::NotAnObjectOrNull(String::from(name.clone())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/template.rs:422:27 [INFO] [stderr] | [INFO] [stderr] 422 | Err(error) => return Err(error), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/template.rs:578:19 [INFO] [stderr] | [INFO] [stderr] 578 | const BASIC: &'static str = "

Hello World!

"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/template.rs:579:22 [INFO] [stderr] | [INFO] [stderr] 579 | const BASIC_DE: &'static str = "

Hallo Welt!

"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/compiler/parser.rs:275:49 [INFO] [stderr] | [INFO] [stderr] 275 | return unexpected_eof!(Symbol(index, Equals)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/compiler/parser.rs:285:45 [INFO] [stderr] | [INFO] [stderr] 285 | None => return unexpected_eof!(Word(index, key)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused label `'element` [INFO] [stderr] --> src/compiler/parser.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | / 'element: while let Some(token) = self.take() { [INFO] [stderr] 225 | | match token { [INFO] [stderr] 226 | | Symbol(index, Ampersand) => { [INFO] [stderr] 227 | | let identifier = get_namespaced_identifer!(self, [INFO] [stderr] ... | [INFO] [stderr] 315 | | } [INFO] [stderr] 316 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/compiler/parser.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return Err(UnexpectedEof($token)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 285 | None => return unexpected_eof!(Word(index, key)), [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::diverging_sub_expression)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/compiler/parser.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return Err(UnexpectedEof($token)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 275 | return unexpected_eof!(Symbol(index, Equals)); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compiler/parser.rs:395:24 [INFO] [stderr] | [INFO] [stderr] 395 | let mut text = String::from(word); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `word` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/compiler/codegen.rs:228:34 [INFO] [stderr] | [INFO] [stderr] 228 | fn get_variable(&self, name: &String) -> Result { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 228 | fn get_variable(&self, name: &str) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `name.clone()` to [INFO] [stderr] | [INFO] [stderr] 239 | _ => return Err(CodegenError::NotAnObjectOrNull(String::from(name.to_string()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compiler/codegen.rs:239:65 [INFO] [stderr] | [INFO] [stderr] 239 | _ => return Err(CodegenError::NotAnObjectOrNull(String::from(name.clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `name.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/compiler/codegen.rs:352:17 [INFO] [stderr] | [INFO] [stderr] 352 | for ref value in object.values() { [INFO] [stderr] | ^^^^^^^^^ --------------- help: try: `let value = &object.values();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/template.rs:321:20 [INFO] [stderr] | [INFO] [stderr] 321 | if let Some(_) = self.components.insert(key, value) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 322 | | return Err(TemplateError::PreDefinedComponent); [INFO] [stderr] 323 | | } [INFO] [stderr] | |_____________- help: try this: `if self.components.insert(key, value).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/template.rs:329:16 [INFO] [stderr] | [INFO] [stderr] 329 | if let Some(_) = self.components.insert(key, value) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 330 | | return Err(TemplateError::PreDefinedComponent); [INFO] [stderr] 331 | | } else { [INFO] [stderr] 332 | | return Ok(()); [INFO] [stderr] 333 | | } [INFO] [stderr] | |_________- help: try this: `if self.components.insert(key, value).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/template.rs:404:16 [INFO] [stderr] | [INFO] [stderr] 404 | if let Some(_) = self.functions.insert(name, function) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 405 | | Err(TemplateError::PreDefinedFunction) [INFO] [stderr] 406 | | } else { [INFO] [stderr] 407 | | Ok(()) [INFO] [stderr] 408 | | } [INFO] [stderr] | |_________- help: try this: `if self.functions.insert(name, function).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unused label `'element` [INFO] [stderr] --> src/compiler/parser.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | / 'element: while let Some(token) = self.take() { [INFO] [stderr] 225 | | match token { [INFO] [stderr] 226 | | Symbol(index, Ampersand) => { [INFO] [stderr] 227 | | let identifier = get_namespaced_identifer!(self, [INFO] [stderr] ... | [INFO] [stderr] 315 | | } [INFO] [stderr] 316 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/compiler/parser.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return Err(UnexpectedEof($token)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 285 | None => return unexpected_eof!(Word(index, key)), [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::diverging_sub_expression)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: sub-expression diverges [INFO] [stderr] --> src/compiler/parser.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return Err(UnexpectedEof($token)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 275 | return unexpected_eof!(Symbol(index, Equals)); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compiler/parser.rs:395:24 [INFO] [stderr] | [INFO] [stderr] 395 | let mut text = String::from(word); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `word` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/compiler/codegen.rs:228:34 [INFO] [stderr] | [INFO] [stderr] 228 | fn get_variable(&self, name: &String) -> Result { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 228 | fn get_variable(&self, name: &str) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `name.clone()` to [INFO] [stderr] | [INFO] [stderr] 239 | _ => return Err(CodegenError::NotAnObjectOrNull(String::from(name.to_string()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compiler/codegen.rs:239:65 [INFO] [stderr] | [INFO] [stderr] 239 | _ => return Err(CodegenError::NotAnObjectOrNull(String::from(name.clone()))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `name.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/compiler/codegen.rs:352:17 [INFO] [stderr] | [INFO] [stderr] 352 | for ref value in object.values() { [INFO] [stderr] | ^^^^^^^^^ --------------- help: try: `let value = &object.values();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/template.rs:321:20 [INFO] [stderr] | [INFO] [stderr] 321 | if let Some(_) = self.components.insert(key, value) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 322 | | return Err(TemplateError::PreDefinedComponent); [INFO] [stderr] 323 | | } [INFO] [stderr] | |_____________- help: try this: `if self.components.insert(key, value).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/template.rs:329:16 [INFO] [stderr] | [INFO] [stderr] 329 | if let Some(_) = self.components.insert(key, value) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 330 | | return Err(TemplateError::PreDefinedComponent); [INFO] [stderr] 331 | | } else { [INFO] [stderr] 332 | | return Ok(()); [INFO] [stderr] 333 | | } [INFO] [stderr] | |_________- help: try this: `if self.components.insert(key, value).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/template.rs:404:16 [INFO] [stderr] | [INFO] [stderr] 404 | if let Some(_) = self.functions.insert(name, function) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 405 | | Err(TemplateError::PreDefinedFunction) [INFO] [stderr] 406 | | } else { [INFO] [stderr] 407 | | Ok(()) [INFO] [stderr] 408 | | } [INFO] [stderr] | |_________- help: try this: `if self.functions.insert(name, function).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:21:29 [INFO] [stderr] | [INFO] [stderr] 21 | let path_metadata = metadata(path) [INFO] [stderr] | _____________________________^ [INFO] [stderr] 22 | | .ok() [INFO] [stderr] 23 | | .expect("Couldn't find file, please make sure your path is \ [INFO] [stderr] 24 | | correct."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | let mut file = File::create(path) [INFO] [stderr] | ________________________________^ [INFO] [stderr] 54 | | .ok() [INFO] [stderr] 55 | | .expect("Couldn't create file at destination"); [INFO] [stderr] | |_________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | file.write_all(&html.into_bytes()).ok().expect("Couldn't write to file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:21:29 [INFO] [stderr] | [INFO] [stderr] 21 | let path_metadata = metadata(path) [INFO] [stderr] | _____________________________^ [INFO] [stderr] 22 | | .ok() [INFO] [stderr] 23 | | .expect("Couldn't find file, please make sure your path is \ [INFO] [stderr] 24 | | correct."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | let mut file = File::create(path) [INFO] [stderr] | ________________________________^ [INFO] [stderr] 54 | | .ok() [INFO] [stderr] 55 | | .expect("Couldn't create file at destination"); [INFO] [stderr] | |_________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | file.write_all(&html.into_bytes()).ok().expect("Couldn't write to file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.77s [INFO] running `"docker" "inspect" "ce1de0b17aae43bbf04165240b046083d166986fdf090ca669bd3160d1df48fa"` [INFO] running `"docker" "rm" "-f" "ce1de0b17aae43bbf04165240b046083d166986fdf090ca669bd3160d1df48fa"` [INFO] [stdout] ce1de0b17aae43bbf04165240b046083d166986fdf090ca669bd3160d1df48fa