[INFO] crate polish 0.9.9 is already in cache [INFO] extracting crate polish 0.9.9 into work/ex/clippy-test-run/sources/stable/reg/polish/0.9.9 [INFO] extracting crate polish 0.9.9 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/polish/0.9.9 [INFO] validating manifest of polish-0.9.9 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of polish-0.9.9 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing polish-0.9.9 [INFO] finished frobbing polish-0.9.9 [INFO] frobbed toml for polish-0.9.9 written to work/ex/clippy-test-run/sources/stable/reg/polish/0.9.9/Cargo.toml [INFO] started frobbing polish-0.9.9 [INFO] finished frobbing polish-0.9.9 [INFO] frobbed toml for polish-0.9.9 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/polish/0.9.9/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting polish-0.9.9 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/polish/0.9.9:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 595675436ff88f45c134f4b74cd9a7fc0e9e7b2ae547acb81d7e3830cd179d89 [INFO] running `"docker" "start" "-a" "595675436ff88f45c134f4b74cd9a7fc0e9e7b2ae547acb81d7e3830cd179d89"` [INFO] [stderr] Checking polish v0.9.9 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test_case.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test_case.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | criteria: criteria, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `criteria` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test_case.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | exec: exec, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `exec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test_case.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | duration: duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/test_case.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test_case.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test_case.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | criteria: criteria, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `criteria` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test_case.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | exec: exec, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `exec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test_case.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | duration: duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/test_case.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_case.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | return status == TestCaseStatus::PASSED; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `status == TestCaseStatus::PASSED` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_case.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | duration /= 1000000000 as DurationType; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_case.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | duration /= 1000000000 as DurationType; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_case.rs:161:25 [INFO] [stderr] | [INFO] [stderr] 161 | duration /= 1000000 as DurationType; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_case.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_case.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | return self.run_tests(test_class.tests()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.run_tests(test_class.tests())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_case.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | return status == TestCaseStatus::PASSED; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `status == TestCaseStatus::PASSED` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_case.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | duration /= 1000000000 as DurationType; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_case.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | duration /= 1000000000 as DurationType; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_case.rs:161:25 [INFO] [stderr] | [INFO] [stderr] 161 | duration /= 1000000 as DurationType; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_case.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_case.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | return self.run_tests(test_class.tests()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.run_tests(test_class.tests())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `logger::Logger` [INFO] [stderr] --> src/logger.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Logger { [INFO] [stderr] 19 | | Logger { [INFO] [stderr] 20 | | _pass: 0, [INFO] [stderr] 21 | | _fail: 0, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `drop` on this type; consider implementing the `std::ops::Drop` trait or choosing a less ambiguous name [INFO] [stderr] --> src/logger.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn drop(&mut self) { [INFO] [stderr] 75 | | let formatted_pass = format!("{} {}", self.get_num_pass(), Green.paint("PASS")); [INFO] [stderr] 76 | | let formatted_fail = format!("{} {}", self.get_num_fail(), Red.paint("FAIL")); [INFO] [stderr] 77 | | let formatted_warn = format!("{} {}", self.get_num_warn(), Yellow.paint("WARN")); [INFO] [stderr] ... | [INFO] [stderr] 83 | | formatted_info); [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `test_case::TestRunner` [INFO] [stderr] --> src/test_case.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / pub fn new() -> TestRunner { [INFO] [stderr] 89 | | TestRunner { [INFO] [stderr] 90 | | attributes: 0, [INFO] [stderr] 91 | | time_unit: TEST_RUNNER_TIME_UNITS.nanoseconds, [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_case.rs:152:42 [INFO] [stderr] | [INFO] [stderr] 152 | let mut duration: DurationType = (ending_time - starting_time) as DurationType; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(ending_time - starting_time)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_case.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | duration /= 1000000000 as DurationType; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1000000000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_case.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | duration /= 60 as DurationType; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(60)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_case.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | duration /= 1000000000 as DurationType; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1000000000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_case.rs:161:25 [INFO] [stderr] | [INFO] [stderr] 161 | duration /= 1000000 as DurationType; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1000000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_case.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | duration /= 1000 as DurationType; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/test_case.rs:177:12 [INFO] [stderr] | [INFO] [stderr] 177 | if self.module_path.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.module_path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `logger::Logger` [INFO] [stderr] --> src/logger.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Logger { [INFO] [stderr] 19 | | Logger { [INFO] [stderr] 20 | | _pass: 0, [INFO] [stderr] 21 | | _fail: 0, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `drop` on this type; consider implementing the `std::ops::Drop` trait or choosing a less ambiguous name [INFO] [stderr] --> src/logger.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn drop(&mut self) { [INFO] [stderr] 75 | | let formatted_pass = format!("{} {}", self.get_num_pass(), Green.paint("PASS")); [INFO] [stderr] 76 | | let formatted_fail = format!("{} {}", self.get_num_fail(), Red.paint("FAIL")); [INFO] [stderr] 77 | | let formatted_warn = format!("{} {}", self.get_num_warn(), Yellow.paint("WARN")); [INFO] [stderr] ... | [INFO] [stderr] 83 | | formatted_info); [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_case.rs:201:82 [INFO] [stderr] | [INFO] [stderr] 201 | let (mut total_count, mut total_duration): (i32, DurationType) = (0, 0 as DurationType); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/test_case.rs:225:20 [INFO] [stderr] | [INFO] [stderr] 225 | if self.module_path.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.module_path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `test_case::TestRunner` [INFO] [stderr] --> src/test_case.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / pub fn new() -> TestRunner { [INFO] [stderr] 89 | | TestRunner { [INFO] [stderr] 90 | | attributes: 0, [INFO] [stderr] 91 | | time_unit: TEST_RUNNER_TIME_UNITS.nanoseconds, [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_case.rs:152:42 [INFO] [stderr] | [INFO] [stderr] 152 | let mut duration: DurationType = (ending_time - starting_time) as DurationType; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(ending_time - starting_time)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_case.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | duration /= 1000000000 as DurationType; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1000000000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_case.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | duration /= 60 as DurationType; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(60)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_case.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | duration /= 1000000000 as DurationType; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1000000000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_case.rs:161:25 [INFO] [stderr] | [INFO] [stderr] 161 | duration /= 1000000 as DurationType; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1000000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_case.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | duration /= 1000 as DurationType; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/test_case.rs:177:12 [INFO] [stderr] | [INFO] [stderr] 177 | if self.module_path.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.module_path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/test_case.rs:201:82 [INFO] [stderr] | [INFO] [stderr] 201 | let (mut total_count, mut total_duration): (i32, DurationType) = (0, 0 as DurationType); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/test_case.rs:225:20 [INFO] [stderr] | [INFO] [stderr] 225 | if self.module_path.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.module_path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/logs.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | logger.warn(format!("about to fail")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"about to fail".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.80s [INFO] running `"docker" "inspect" "595675436ff88f45c134f4b74cd9a7fc0e9e7b2ae547acb81d7e3830cd179d89"` [INFO] running `"docker" "rm" "-f" "595675436ff88f45c134f4b74cd9a7fc0e9e7b2ae547acb81d7e3830cd179d89"` [INFO] [stdout] 595675436ff88f45c134f4b74cd9a7fc0e9e7b2ae547acb81d7e3830cd179d89