[INFO] crate pokerlookup 0.1.2 is already in cache [INFO] extracting crate pokerlookup 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/pokerlookup/0.1.2 [INFO] extracting crate pokerlookup 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pokerlookup/0.1.2 [INFO] validating manifest of pokerlookup-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pokerlookup-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pokerlookup-0.1.2 [INFO] finished frobbing pokerlookup-0.1.2 [INFO] frobbed toml for pokerlookup-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/pokerlookup/0.1.2/Cargo.toml [INFO] started frobbing pokerlookup-0.1.2 [INFO] finished frobbing pokerlookup-0.1.2 [INFO] frobbed toml for pokerlookup-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pokerlookup/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pokerlookup-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pokerlookup/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f2ebedf2d5a65d16210406504fe43fc9e8f849b5e48ab92ba7cf1b7926262582 [INFO] running `"docker" "start" "-a" "f2ebedf2d5a65d16210406504fe43fc9e8f849b5e48ab92ba7cf1b7926262582"` [INFO] [stderr] Checking cards v1.1.2 [INFO] [stderr] Checking holdem v0.1.2 [INFO] [stderr] Checking pokereval v0.1.2 [INFO] [stderr] Checking pokerlookup v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:134:22 [INFO] [stderr] | [INFO] [stderr] 134 | LookupTable{ hr: hr } [INFO] [stderr] | ^^^^^^ help: replace it with: `hr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:157:22 [INFO] [stderr] | [INFO] [stderr] 157 | LookupTable{ hr: hr } [INFO] [stderr] | ^^^^^^ help: replace it with: `hr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:134:22 [INFO] [stderr] | [INFO] [stderr] 134 | LookupTable{ hr: hr } [INFO] [stderr] | ^^^^^^ help: replace it with: `hr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:157:22 [INFO] [stderr] | [INFO] [stderr] 157 | LookupTable{ hr: hr } [INFO] [stderr] | ^^^^^^ help: replace it with: `hr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/functions.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / if *numcards != 0 { [INFO] [stderr] 78 | | if workcards[0] == workcards[*numcards as usize] { // can't have the same card twice [INFO] [stderr] 79 | | getout = 1; // if so need to get out after counting numcards [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 77 | if *numcards != 0 && workcards[0] == workcards[*numcards as usize] { // can't have the same card twice [INFO] [stderr] 78 | getout = 1; // if so need to get out after counting numcards [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | const EXPECTED_HR_LENGTH : usize = 32487834; [INFO] [stderr] | ^^^^^^^^ help: consider: `32_487_834` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/functions.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / if *numcards != 0 { [INFO] [stderr] 78 | | if workcards[0] == workcards[*numcards as usize] { // can't have the same card twice [INFO] [stderr] 79 | | getout = 1; // if so need to get out after counting numcards [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 77 | if *numcards != 0 && workcards[0] == workcards[*numcards as usize] { // can't have the same card twice [INFO] [stderr] 78 | getout = 1; // if so need to get out after counting numcards [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | const EXPECTED_HR_LENGTH : usize = 32487834; [INFO] [stderr] | ^^^^^^^^ help: consider: `32_487_834` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/functions.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn make_id(id_in: i64, card: i32, numcards: &mut i32) -> Option { [INFO] [stderr] 55 | | let mut newcard = card; [INFO] [stderr] 56 | | [INFO] [stderr] 57 | | let mut suitcount : [i32;4+1] = [0;5]; [INFO] [stderr] ... | [INFO] [stderr] 147 | | ((workcards[6] as i64) << 48)) [INFO] [stderr] 148 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `rank` is only used to index `rankcount`. [INFO] [stderr] --> src/functions.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | for rank in 1..14 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 90 | for in rankcount.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | workcards[cardnum as usize] = workcards[cardnum as usize] & 0xf0; // if not enough - 0 out the suit - now this suit would be a 0 vs 1-4 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[cardnum as usize] &= 0xf0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 121 | SWAP!(0, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 121 | SWAP!(0, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 121 | SWAP!(0, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 122 | SWAP!(1, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 122 | SWAP!(1, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 122 | SWAP!(1, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 123 | SWAP!(2, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 123 | SWAP!(2, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 123 | SWAP!(2, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 124 | SWAP!(0, 2); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 124 | SWAP!(0, 2); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 124 | SWAP!(0, 2); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 125 | SWAP!(1, 3); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 125 | SWAP!(1, 3); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 125 | SWAP!(1, 3); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 126 | SWAP!(4, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 126 | SWAP!(4, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 126 | SWAP!(4, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 127 | SWAP!(2, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 127 | SWAP!(2, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 127 | SWAP!(2, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 128 | SWAP!(3, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 128 | SWAP!(3, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 128 | SWAP!(3, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 129 | SWAP!(0, 1); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 129 | SWAP!(0, 1); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 129 | SWAP!(0, 1); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 130 | SWAP!(2, 3); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 130 | SWAP!(2, 3); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 130 | SWAP!(2, 3); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 131 | SWAP!(4, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 131 | SWAP!(4, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 131 | SWAP!(4, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 132 | SWAP!(1, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 132 | SWAP!(1, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 132 | SWAP!(1, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 133 | SWAP!(3, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 133 | SWAP!(3, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 133 | SWAP!(3, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 134 | SWAP!(1, 2); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 134 | SWAP!(1, 2); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 134 | SWAP!(1, 2); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 135 | SWAP!(3, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 135 | SWAP!(3, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 135 | SWAP!(3, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 136 | SWAP!(5, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 136 | SWAP!(5, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 136 | SWAP!(5, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:141:10 [INFO] [stderr] | [INFO] [stderr] 141 | Some(workcards[0] as i64 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(workcards[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:142:10 [INFO] [stderr] | [INFO] [stderr] 142 | ((workcards[1] as i64) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(workcards[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:143:10 [INFO] [stderr] | [INFO] [stderr] 143 | ((workcards[2] as i64) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(workcards[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:144:10 [INFO] [stderr] | [INFO] [stderr] 144 | ((workcards[3] as i64) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(workcards[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:145:10 [INFO] [stderr] | [INFO] [stderr] 145 | ((workcards[4] as i64) << 32) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(workcards[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:146:10 [INFO] [stderr] | [INFO] [stderr] 146 | ((workcards[5] as i64) << 40) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(workcards[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:147:10 [INFO] [stderr] | [INFO] [stderr] 147 | ((workcards[6] as i64) << 48)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(workcards[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | eval_5cards_kev_array(&hand) as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(eval_5cards_kev_array(&hand))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | eval_6cards_kev_array(&hand) as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(eval_6cards_kev_array(&hand))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | eval_7cards_kev_array(&hand) as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(eval_7cards_kev_array(&hand))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:36:29 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn translate_card(card: &Card) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the variable `position` is used as a loop counter. Consider using `for (position, item) in sub_hands.iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | for (_, val) in sub_hands.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut i32`) [INFO] [stderr] --> src/lib.rs:152:23 [INFO] [stderr] | [INFO] [stderr] 152 | let ptr = buffer.as_mut_ptr() as *mut i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pokerlookup`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/functions.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn make_id(id_in: i64, card: i32, numcards: &mut i32) -> Option { [INFO] [stderr] 55 | | let mut newcard = card; [INFO] [stderr] 56 | | [INFO] [stderr] 57 | | let mut suitcount : [i32;4+1] = [0;5]; [INFO] [stderr] ... | [INFO] [stderr] 147 | | ((workcards[6] as i64) << 48)) [INFO] [stderr] 148 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `rank` is only used to index `rankcount`. [INFO] [stderr] --> src/functions.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | for rank in 1..14 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 90 | for in rankcount.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | workcards[cardnum as usize] = workcards[cardnum as usize] & 0xf0; // if not enough - 0 out the suit - now this suit would be a 0 vs 1-4 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[cardnum as usize] &= 0xf0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 121 | SWAP!(0, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 121 | SWAP!(0, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 121 | SWAP!(0, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 122 | SWAP!(1, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 122 | SWAP!(1, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 122 | SWAP!(1, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 123 | SWAP!(2, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 123 | SWAP!(2, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 123 | SWAP!(2, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 124 | SWAP!(0, 2); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 124 | SWAP!(0, 2); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 124 | SWAP!(0, 2); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 125 | SWAP!(1, 3); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 125 | SWAP!(1, 3); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 125 | SWAP!(1, 3); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 126 | SWAP!(4, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 126 | SWAP!(4, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 126 | SWAP!(4, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 127 | SWAP!(2, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 127 | SWAP!(2, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 127 | SWAP!(2, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 128 | SWAP!(3, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 128 | SWAP!(3, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 128 | SWAP!(3, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 129 | SWAP!(0, 1); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 129 | SWAP!(0, 1); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 129 | SWAP!(0, 1); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 130 | SWAP!(2, 3); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 130 | SWAP!(2, 3); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 130 | SWAP!(2, 3); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 131 | SWAP!(4, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 131 | SWAP!(4, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 131 | SWAP!(4, 5); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 132 | SWAP!(1, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 132 | SWAP!(1, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 132 | SWAP!(1, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 133 | SWAP!(3, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 133 | SWAP!(3, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 133 | SWAP!(3, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 134 | SWAP!(1, 2); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 134 | SWAP!(1, 2); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 134 | SWAP!(1, 2); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 135 | SWAP!(3, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 135 | SWAP!(3, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 135 | SWAP!(3, 4); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 136 | SWAP!(5, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | workcards[$j] = workcards[$j] ^ workcards[$i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$j] ^= workcards[$i]` [INFO] [stderr] ... [INFO] [stderr] 136 | SWAP!(5, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/functions.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | workcards[$i] = workcards[$i] ^ workcards[$j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `workcards[$i] ^= workcards[$j]` [INFO] [stderr] ... [INFO] [stderr] 136 | SWAP!(5, 6); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:141:10 [INFO] [stderr] | [INFO] [stderr] 141 | Some(workcards[0] as i64 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(workcards[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:142:10 [INFO] [stderr] | [INFO] [stderr] 142 | ((workcards[1] as i64) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(workcards[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:143:10 [INFO] [stderr] | [INFO] [stderr] 143 | ((workcards[2] as i64) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(workcards[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:144:10 [INFO] [stderr] | [INFO] [stderr] 144 | ((workcards[3] as i64) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(workcards[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:145:10 [INFO] [stderr] | [INFO] [stderr] 145 | ((workcards[4] as i64) << 32) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(workcards[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:146:10 [INFO] [stderr] | [INFO] [stderr] 146 | ((workcards[5] as i64) << 40) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(workcards[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:147:10 [INFO] [stderr] | [INFO] [stderr] 147 | ((workcards[6] as i64) << 48)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(workcards[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | eval_5cards_kev_array(&hand) as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(eval_5cards_kev_array(&hand))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | eval_6cards_kev_array(&hand) as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(eval_6cards_kev_array(&hand))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/functions.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | eval_7cards_kev_array(&hand) as i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(eval_7cards_kev_array(&hand))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:36:29 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn translate_card(card: &Card) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the variable `position` is used as a loop counter. Consider using `for (position, item) in sub_hands.iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | for (_, val) in sub_hands.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut i32`) [INFO] [stderr] --> src/lib.rs:152:23 [INFO] [stderr] | [INFO] [stderr] 152 | let ptr = buffer.as_mut_ptr() as *mut i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pokerlookup`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f2ebedf2d5a65d16210406504fe43fc9e8f849b5e48ab92ba7cf1b7926262582"` [INFO] running `"docker" "rm" "-f" "f2ebedf2d5a65d16210406504fe43fc9e8f849b5e48ab92ba7cf1b7926262582"` [INFO] [stdout] f2ebedf2d5a65d16210406504fe43fc9e8f849b5e48ab92ba7cf1b7926262582