[INFO] crate pokerhandrange 0.1.1 is already in cache [INFO] extracting crate pokerhandrange 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/pokerhandrange/0.1.1 [INFO] extracting crate pokerhandrange 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pokerhandrange/0.1.1 [INFO] validating manifest of pokerhandrange-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pokerhandrange-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pokerhandrange-0.1.1 [INFO] finished frobbing pokerhandrange-0.1.1 [INFO] frobbed toml for pokerhandrange-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/pokerhandrange/0.1.1/Cargo.toml [INFO] started frobbing pokerhandrange-0.1.1 [INFO] finished frobbing pokerhandrange-0.1.1 [INFO] frobbed toml for pokerhandrange-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pokerhandrange/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pokerhandrange-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pokerhandrange/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2b9854c7bb2f01a46b99a23c2b727f251c36af0ec501cd1039d19419511df7ed [INFO] running `"docker" "start" "-a" "2b9854c7bb2f01a46b99a23c2b727f251c36af0ec501cd1039d19419511df7ed"` [INFO] [stderr] Checking cards v1.1.2 [INFO] [stderr] Checking holdem v0.1.2 [INFO] [stderr] Checking pokereval v0.1.2 [INFO] [stderr] Checking pokerhandrange v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | components: components, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `components` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | combination_lookup: combination_lookup, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `combination_lookup` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | combination_count: combination_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `combination_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | components: components, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `components` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | combination_lookup: combination_lookup, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `combination_lookup` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | combination_count: combination_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `combination_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return Some(returning); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(returning)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:115:22 [INFO] [stderr] | [INFO] [stderr] 115 | let result = if hand.0.value == hand.1.value { [INFO] [stderr] | ______________________^ [INFO] [stderr] 116 | | ita.any(|&x| match x { [INFO] [stderr] 117 | | RangeComponent::Pair(val) => val == value_greater, [INFO] [stderr] 118 | | _ => false [INFO] [stderr] ... | [INFO] [stderr] 130 | | }) [INFO] [stderr] 131 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | cards [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | let cards = match range_component { [INFO] [stderr] | _____________________^ [INFO] [stderr] 154 | | RangeComponent::Pair(val) => { [INFO] [stderr] 155 | | let (suit_one, suit_two) = gen_random_suits(&mut rng); [INFO] [stderr] 156 | | [INFO] [stderr] ... | [INFO] [stderr] 172 | | }, [INFO] [stderr] 173 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return Some(returning); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(returning)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:115:22 [INFO] [stderr] | [INFO] [stderr] 115 | let result = if hand.0.value == hand.1.value { [INFO] [stderr] | ______________________^ [INFO] [stderr] 116 | | ita.any(|&x| match x { [INFO] [stderr] 117 | | RangeComponent::Pair(val) => val == value_greater, [INFO] [stderr] 118 | | _ => false [INFO] [stderr] ... | [INFO] [stderr] 130 | | }) [INFO] [stderr] 131 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | cards [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | let cards = match range_component { [INFO] [stderr] | _____________________^ [INFO] [stderr] 154 | | RangeComponent::Pair(val) => { [INFO] [stderr] 155 | | let (suit_one, suit_two) = gen_random_suits(&mut rng); [INFO] [stderr] 156 | | [INFO] [stderr] ... | [INFO] [stderr] 172 | | }, [INFO] [stderr] 173 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils.rs:67:28 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn next_card_value(cv: &Value) -> Option { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parse.rs:117:17 [INFO] [stderr] | [INFO] [stderr] 117 | format!("This does not make any sense (like JJs)"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"This does not make any sense (like JJs)".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | let raw_components = ranges.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:64:12 [INFO] [stderr] | [INFO] [stderr] 64 | if components.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `components.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:87:58 [INFO] [stderr] | [INFO] [stderr] 87 | combination_lookup.push( (combination_count, component.clone() ) ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*component` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils.rs:67:28 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn next_card_value(cv: &Value) -> Option { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parse.rs:117:17 [INFO] [stderr] | [INFO] [stderr] 117 | format!("This does not make any sense (like JJs)"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"This does not make any sense (like JJs)".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | let raw_components = ranges.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:64:12 [INFO] [stderr] | [INFO] [stderr] 64 | if components.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `components.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:87:58 [INFO] [stderr] | [INFO] [stderr] 87 | combination_lookup.push( (combination_count, component.clone() ) ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*component` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> example/main.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | let total : f64 = (scores.0+scores.1+scores.2) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scores.0+scores.1+scores.2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> example/main.rs:108:29 [INFO] [stderr] | [INFO] [stderr] 108 | let percent_one : f64 = (scores.0 as f64)/total; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scores.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> example/main.rs:109:29 [INFO] [stderr] | [INFO] [stderr] 109 | let percent_two : f64 = (scores.1 as f64)/total; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scores.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> example/main.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | let total : f64 = (scores.0+scores.1+scores.2) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scores.0+scores.1+scores.2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> example/main.rs:108:29 [INFO] [stderr] | [INFO] [stderr] 108 | let percent_one : f64 = (scores.0 as f64)/total; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scores.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> example/main.rs:109:29 [INFO] [stderr] | [INFO] [stderr] 109 | let percent_two : f64 = (scores.1 as f64)/total; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(scores.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.15s [INFO] running `"docker" "inspect" "2b9854c7bb2f01a46b99a23c2b727f251c36af0ec501cd1039d19419511df7ed"` [INFO] running `"docker" "rm" "-f" "2b9854c7bb2f01a46b99a23c2b727f251c36af0ec501cd1039d19419511df7ed"` [INFO] [stdout] 2b9854c7bb2f01a46b99a23c2b727f251c36af0ec501cd1039d19419511df7ed