[INFO] crate podstats 0.1.2 is already in cache [INFO] extracting crate podstats 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/podstats/0.1.2 [INFO] extracting crate podstats 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/podstats/0.1.2 [INFO] validating manifest of podstats-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of podstats-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing podstats-0.1.2 [INFO] finished frobbing podstats-0.1.2 [INFO] frobbed toml for podstats-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/podstats/0.1.2/Cargo.toml [INFO] started frobbing podstats-0.1.2 [INFO] finished frobbing podstats-0.1.2 [INFO] frobbed toml for podstats-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/podstats/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting podstats-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/podstats/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a3e757bf2632f1a555b0eaa8382da7e9325798e3ad18796fa3c5bf141a1f2ac9 [INFO] running `"docker" "start" "-a" "a3e757bf2632f1a555b0eaa8382da7e9325798e3ad18796fa3c5bf141a1f2ac9"` [INFO] [stderr] Checking rmp-serde v0.13.7 [INFO] [stderr] Checking podstats v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return file_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | Ok(config) => return Some(config), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(config)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:119:19 [INFO] [stderr] | [INFO] [stderr] 119 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs` [INFO] [stderr] --> src/subscription.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::fs; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(t) => return t, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | Err(_) => return Vec::new(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | Ok(t) => return t, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | Err(_) => return Vec::new(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(op_sub) => return Some(op_sub), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(op_sub)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:79:19 [INFO] [stderr] | [INFO] [stderr] 79 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:89:23 [INFO] [stderr] | [INFO] [stderr] 89 | Ok(op_sub) => return Some(op_sub), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(op_sub)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | return vec_deserialize(&buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vec_deserialize(&buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | Some(x) => return x.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | None => return "fakedir".to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"fakedir".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes` [INFO] [stderr] --> src/config.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | let bytes = match res { [INFO] [stderr] | ^^^^^ help: consider using `_bytes` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / match file.read_to_end(&mut buffer) { [INFO] [stderr] 110 | | Err(why) => panic!("couldn't read {}: {}", display, why), [INFO] [stderr] 111 | | [INFO] [stderr] 112 | | Ok(_) => (), [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_end(&mut buffer) { panic!("couldn't read {}: {}", display, why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / match op_config { [INFO] [stderr] 127 | | Err(why) => panic!("couldn't encode config: {}", why), [INFO] [stderr] 128 | | Ok(_) => (), [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = op_config { panic!("couldn't encode config: {}", why) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / match path_res { [INFO] [stderr] 137 | | Err(why) => panic!("Couldn't find path for config: {}", why), [INFO] [stderr] 138 | | Ok(_) => (), [INFO] [stderr] 139 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = path_res { panic!("Couldn't find path for config: {}", why) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/config.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | file.write_all(b""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/config.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | file.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/subscription.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn vec_serialize(subs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Subscription]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/subscription.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn deserialize(sub_vec: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/subscription.rs:83:33 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn vec_deserialize(sub_vec: &Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/subscription.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / match file.read_to_end(&mut buffer) { [INFO] [stderr] 108 | | Err(why) => panic!("couldn't read {}: {}", display, why.description()), [INFO] [stderr] 109 | | [INFO] [stderr] 110 | | Ok(_) => (), [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_end(&mut buffer) { panic!("couldn't read {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return file_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | Ok(config) => return Some(config), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(config)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:119:19 [INFO] [stderr] | [INFO] [stderr] 119 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | return config; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(t) => return t, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | Err(_) => return Vec::new(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | Ok(t) => return t, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | Err(_) => return Vec::new(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(op_sub) => return Some(op_sub), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(op_sub)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:79:19 [INFO] [stderr] | [INFO] [stderr] 79 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:89:23 [INFO] [stderr] | [INFO] [stderr] 89 | Ok(op_sub) => return Some(op_sub), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(op_sub)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | return vec_deserialize(&buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vec_deserialize(&buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | Some(x) => return x.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | None => return "fakedir".to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"fakedir".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes` [INFO] [stderr] --> src/config.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | let bytes = match res { [INFO] [stderr] | ^^^^^ help: consider using `_bytes` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / match file.read_to_end(&mut buffer) { [INFO] [stderr] 110 | | Err(why) => panic!("couldn't read {}: {}", display, why), [INFO] [stderr] 111 | | [INFO] [stderr] 112 | | Ok(_) => (), [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_end(&mut buffer) { panic!("couldn't read {}: {}", display, why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / match op_config { [INFO] [stderr] 127 | | Err(why) => panic!("couldn't encode config: {}", why), [INFO] [stderr] 128 | | Ok(_) => (), [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = op_config { panic!("couldn't encode config: {}", why) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / match path_res { [INFO] [stderr] 137 | | Err(why) => panic!("Couldn't find path for config: {}", why), [INFO] [stderr] 138 | | Ok(_) => (), [INFO] [stderr] 139 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = path_res { panic!("Couldn't find path for config: {}", why) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/config.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | file.write_all(b""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/config.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | file.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/config.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | fs::remove_file(test_cache_loc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/subscription.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn vec_serialize(subs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Subscription]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/subscription.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn deserialize(sub_vec: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/subscription.rs:83:33 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn vec_deserialize(sub_vec: &Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/subscription.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / match file.read_to_end(&mut buffer) { [INFO] [stderr] 108 | | Err(why) => panic!("couldn't read {}: {}", display, why.description()), [INFO] [stderr] 109 | | [INFO] [stderr] 110 | | Ok(_) => (), [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_end(&mut buffer) { panic!("couldn't read {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/subscription.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | / match file.write_all(s.as_slice()) { [INFO] [stderr] 199 | | Err(why) => panic!("couldn't write to {}: {}", display, why.description()), [INFO] [stderr] 200 | | Ok(_) => (), [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.write_all(s.as_slice()) { panic!("couldn't write to {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/subscription.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | fs::remove_file(test_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/main.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return file_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | Ok(config) => return Some(config), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(config)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:119:19 [INFO] [stderr] | [INFO] [stderr] 119 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | return config; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(t) => return t, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | Err(_) => return Vec::new(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | Ok(t) => return t, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | Err(_) => return Vec::new(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(op_sub) => return Some(op_sub), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(op_sub)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:79:19 [INFO] [stderr] | [INFO] [stderr] 79 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:89:23 [INFO] [stderr] | [INFO] [stderr] 89 | Ok(op_sub) => return Some(op_sub), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(op_sub)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | return vec_deserialize(&buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vec_deserialize(&buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | Some(x) => return x.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | None => return "fakedir".to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"fakedir".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/main.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return file_str; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | Ok(config) => return Some(config), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(config)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:119:19 [INFO] [stderr] | [INFO] [stderr] 119 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs` [INFO] [stderr] --> src/subscription.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::fs; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(t) => return t, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | Err(_) => return Vec::new(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | Ok(t) => return t, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | Err(_) => return Vec::new(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(op_sub) => return Some(op_sub), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(op_sub)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:79:19 [INFO] [stderr] | [INFO] [stderr] 79 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:89:23 [INFO] [stderr] | [INFO] [stderr] 89 | Ok(op_sub) => return Some(op_sub), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(op_sub)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | return vec_deserialize(&buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vec_deserialize(&buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | Some(x) => return x.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subscription.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | None => return "fakedir".to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"fakedir".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes` [INFO] [stderr] --> src/config.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | let bytes = match res { [INFO] [stderr] | ^^^^^ help: consider using `_bytes` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bytes` [INFO] [stderr] --> src/config.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | let bytes = match res { [INFO] [stderr] | ^^^^^ help: consider using `_bytes` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_config` [INFO] [stderr] --> src/config.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn read_config() -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `write_config` [INFO] [stderr] --> src/config.rs:123:1 [INFO] [stderr] | [INFO] [stderr] 123 | pub fn write_config(config: Config) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_config` [INFO] [stderr] --> src/config.rs:89:1 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn read_config() -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `write_config` [INFO] [stderr] --> src/config.rs:123:1 [INFO] [stderr] | [INFO] [stderr] 123 | pub fn write_config(config: Config) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/subscription.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn new(url: &str, name: &str, directory: Option<&str>) -> Subscription { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `vec_serialize` [INFO] [stderr] --> src/subscription.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn vec_serialize(subs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `serialize` [INFO] [stderr] --> src/subscription.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn serialize(sub: &Subscription) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `deserialize` [INFO] [stderr] --> src/subscription.rs:72:1 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn deserialize(sub_vec: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `process_directory` [INFO] [stderr] --> src/subscription.rs:116:1 [INFO] [stderr] | [INFO] [stderr] 116 | fn process_directory(directory: Option<&str>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / match file.read_to_end(&mut buffer) { [INFO] [stderr] 110 | | Err(why) => panic!("couldn't read {}: {}", display, why), [INFO] [stderr] 111 | | [INFO] [stderr] 112 | | Ok(_) => (), [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_end(&mut buffer) { panic!("couldn't read {}: {}", display, why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / match op_config { [INFO] [stderr] 127 | | Err(why) => panic!("couldn't encode config: {}", why), [INFO] [stderr] 128 | | Ok(_) => (), [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = op_config { panic!("couldn't encode config: {}", why) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / match path_res { [INFO] [stderr] 137 | | Err(why) => panic!("Couldn't find path for config: {}", why), [INFO] [stderr] 138 | | Ok(_) => (), [INFO] [stderr] 139 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = path_res { panic!("Couldn't find path for config: {}", why) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/config.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | file.write_all(b""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/config.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | file.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/config.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | fs::remove_file(test_cache_loc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / match file.read_to_end(&mut buffer) { [INFO] [stderr] 110 | | Err(why) => panic!("couldn't read {}: {}", display, why), [INFO] [stderr] 111 | | [INFO] [stderr] 112 | | Ok(_) => (), [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_end(&mut buffer) { panic!("couldn't read {}: {}", display, why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / match op_config { [INFO] [stderr] 127 | | Err(why) => panic!("couldn't encode config: {}", why), [INFO] [stderr] 128 | | Ok(_) => (), [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = op_config { panic!("couldn't encode config: {}", why) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / match path_res { [INFO] [stderr] 137 | | Err(why) => panic!("Couldn't find path for config: {}", why), [INFO] [stderr] 138 | | Ok(_) => (), [INFO] [stderr] 139 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = path_res { panic!("Couldn't find path for config: {}", why) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/config.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | file.write_all(b""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/config.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | file.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/subscription.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn vec_serialize(subs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Subscription]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/subscription.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn deserialize(sub_vec: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/subscription.rs:83:33 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn vec_deserialize(sub_vec: &Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/subscription.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn vec_serialize(subs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Subscription]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/subscription.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn deserialize(sub_vec: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/subscription.rs:83:33 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn vec_deserialize(sub_vec: &Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/subscription.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / match file.read_to_end(&mut buffer) { [INFO] [stderr] 108 | | Err(why) => panic!("couldn't read {}: {}", display, why.description()), [INFO] [stderr] 109 | | [INFO] [stderr] 110 | | Ok(_) => (), [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_end(&mut buffer) { panic!("couldn't read {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/subscription.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / match file.read_to_end(&mut buffer) { [INFO] [stderr] 108 | | Err(why) => panic!("couldn't read {}: {}", display, why.description()), [INFO] [stderr] 109 | | [INFO] [stderr] 110 | | Ok(_) => (), [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_end(&mut buffer) { panic!("couldn't read {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:15:48 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn select_from_menu(&self, menu_items: &Vec<&str>) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/util.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | write!(stdout, "{}", v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/subscription.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | / match file.write_all(s.as_slice()) { [INFO] [stderr] 199 | | Err(why) => panic!("couldn't write to {}: {}", display, why.description()), [INFO] [stderr] 200 | | Ok(_) => (), [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.write_all(s.as_slice()) { panic!("couldn't write to {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/subscription.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | fs::remove_file(test_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/util.rs:15:48 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn select_from_menu(&self, menu_items: &Vec<&str>) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/util.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | write!(stdout, "{}", v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.96s [INFO] running `"docker" "inspect" "a3e757bf2632f1a555b0eaa8382da7e9325798e3ad18796fa3c5bf141a1f2ac9"` [INFO] running `"docker" "rm" "-f" "a3e757bf2632f1a555b0eaa8382da7e9325798e3ad18796fa3c5bf141a1f2ac9"` [INFO] [stdout] a3e757bf2632f1a555b0eaa8382da7e9325798e3ad18796fa3c5bf141a1f2ac9