[INFO] crate pocket_prover-derive 0.1.0 is already in cache [INFO] extracting crate pocket_prover-derive 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/pocket_prover-derive/0.1.0 [INFO] extracting crate pocket_prover-derive 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pocket_prover-derive/0.1.0 [INFO] validating manifest of pocket_prover-derive-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pocket_prover-derive-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pocket_prover-derive-0.1.0 [INFO] finished frobbing pocket_prover-derive-0.1.0 [INFO] frobbed toml for pocket_prover-derive-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/pocket_prover-derive/0.1.0/Cargo.toml [INFO] started frobbing pocket_prover-derive-0.1.0 [INFO] finished frobbing pocket_prover-derive-0.1.0 [INFO] frobbed toml for pocket_prover-derive-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pocket_prover-derive/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pocket_prover-derive-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pocket_prover-derive/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ae677be50f6986da850c5faa0b9a50ef45dc62ad432695197cd0f9bb8e47a493 [INFO] running `"docker" "start" "-a" "ae677be50f6986da850c5faa0b9a50ef45dc62ad432695197cd0f9bb8e47a493"` [INFO] [stderr] Checking pocket_prover v0.5.1 [INFO] [stderr] Compiling pocket_prover-derive v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:69:36 [INFO] [stderr] | [INFO] [stderr] 69 | let fields: Vec<(_, Ty)> = if let &VariantData::Struct(ref fields) = body { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 70 | | fields.iter() [INFO] [stderr] 71 | | .map(|field| ( [INFO] [stderr] 72 | | field.ident.as_ref().unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 76 | | panic!("Expected struct fields"); [INFO] [stderr] 77 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | let fields: Vec<(_, Ty)> = if let VariantData::Struct(ref fields) = *body { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:85:28 [INFO] [stderr] | [INFO] [stderr] 85 | let ty_ident = if let &Ty::Path(_, ref parameters) = ty { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 86 | | parameters.segments[0].ident.clone() [INFO] [stderr] 87 | | } else { [INFO] [stderr] 88 | | panic!("Could not find type identifier.") [INFO] [stderr] 89 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | let ty_ident = if let Ty::Path(_, ref parameters) = *ty { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:90:16 [INFO] [stderr] | [INFO] [stderr] 90 | if ty_ident != &Ident::new("u64") { [INFO] [stderr] | ^^^^^^^^^^^^------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `Ident::new("u64")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:115:28 [INFO] [stderr] | [INFO] [stderr] 115 | let ty_ident = if let &Ty::Path(_, ref parameters) = ty { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 116 | | parameters.segments[0].ident.clone() [INFO] [stderr] 117 | | } else { [INFO] [stderr] 118 | | panic!("Could not find type identifier.") [INFO] [stderr] 119 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 115 | let ty_ident = if let Ty::Path(_, ref parameters) = *ty { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | if ty_ident == &Ident::new("u64") { [INFO] [stderr] | ^^^^^^^^^^^^------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `Ident::new("u64")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:69:36 [INFO] [stderr] | [INFO] [stderr] 69 | let fields: Vec<(_, Ty)> = if let &VariantData::Struct(ref fields) = body { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 70 | | fields.iter() [INFO] [stderr] 71 | | .map(|field| ( [INFO] [stderr] 72 | | field.ident.as_ref().unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 76 | | panic!("Expected struct fields"); [INFO] [stderr] 77 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | let fields: Vec<(_, Ty)> = if let VariantData::Struct(ref fields) = *body { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:85:28 [INFO] [stderr] | [INFO] [stderr] 85 | let ty_ident = if let &Ty::Path(_, ref parameters) = ty { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 86 | | parameters.segments[0].ident.clone() [INFO] [stderr] 87 | | } else { [INFO] [stderr] 88 | | panic!("Could not find type identifier.") [INFO] [stderr] 89 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | let ty_ident = if let Ty::Path(_, ref parameters) = *ty { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:90:16 [INFO] [stderr] | [INFO] [stderr] 90 | if ty_ident != &Ident::new("u64") { [INFO] [stderr] | ^^^^^^^^^^^^------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `Ident::new("u64")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:115:28 [INFO] [stderr] | [INFO] [stderr] 115 | let ty_ident = if let &Ty::Path(_, ref parameters) = ty { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 116 | | parameters.segments[0].ident.clone() [INFO] [stderr] 117 | | } else { [INFO] [stderr] 118 | | panic!("Could not find type identifier.") [INFO] [stderr] 119 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 115 | let ty_ident = if let Ty::Path(_, ref parameters) = *ty { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | if ty_ident == &Ident::new("u64") { [INFO] [stderr] | ^^^^^^^^^^^^------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `Ident::new("u64")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/lib.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let foo: Foo = Construct::construct(vs); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> tests/lib.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | let bar: Bar = Construct::construct(vs); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> tests/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | let bar: Bar = Construct::construct(vs); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> tests/lib.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | let bar: Bar> = Construct::construct(vs); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.57s [INFO] running `"docker" "inspect" "ae677be50f6986da850c5faa0b9a50ef45dc62ad432695197cd0f9bb8e47a493"` [INFO] running `"docker" "rm" "-f" "ae677be50f6986da850c5faa0b9a50ef45dc62ad432695197cd0f9bb8e47a493"` [INFO] [stdout] ae677be50f6986da850c5faa0b9a50ef45dc62ad432695197cd0f9bb8e47a493