[INFO] crate pocket-resources 0.3.2 is already in cache [INFO] extracting crate pocket-resources 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/pocket-resources/0.3.2 [INFO] extracting crate pocket-resources 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pocket-resources/0.3.2 [INFO] validating manifest of pocket-resources-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pocket-resources-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pocket-resources-0.3.2 [INFO] finished frobbing pocket-resources-0.3.2 [INFO] frobbed toml for pocket-resources-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/pocket-resources/0.3.2/Cargo.toml [INFO] started frobbing pocket-resources-0.3.2 [INFO] finished frobbing pocket-resources-0.3.2 [INFO] frobbed toml for pocket-resources-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pocket-resources/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pocket-resources-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pocket-resources/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2cc35fb7939fd79f6657bd194821f08c61fc2b494a8adbc5a8647482d57b9e58 [INFO] running `"docker" "start" "-a" "2cc35fb7939fd79f6657bd194821f08c61fc2b494a8adbc5a8647482d57b9e58"` [INFO] [stderr] Checking pocket-resources v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / if entry.resource_str_name != entry.resource_str_name_no_ext { [INFO] [stderr] 96 | | if entries.iter().filter(|e| e.resource_str_name_no_ext == entry.resource_str_name_no_ext || e.resource_str_name == entry.resource_str_name_no_ext).count() == 1 { [INFO] [stderr] 97 | | try!(writeln!(file, r##" [INFO] [stderr] 98 | | if name == r#"{}"# {{ return Some(ResourceId::{}); }} [INFO] [stderr] 99 | | "##, entry.resource_str_name_no_ext, entry.enum_name)); [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | if entry.resource_str_name != entry.resource_str_name_no_ext && entries.iter().filter(|e| e.resource_str_name_no_ext == entry.resource_str_name_no_ext || e.resource_str_name == entry.resource_str_name_no_ext).count() == 1 { [INFO] [stderr] 96 | try!(writeln!(file, r##" [INFO] [stderr] 97 | if name == r#"{}"# {{ return Some(ResourceId::{}); }} [INFO] [stderr] 98 | "##, entry.resource_str_name_no_ext, entry.enum_name)); [INFO] [stderr] 99 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / if entry.struct_name != entry.struct_name_no_ext { [INFO] [stderr] 132 | | if entries.iter().filter(|e| e.struct_name_no_ext == entry.struct_name_no_ext || e.struct_name == entry.struct_name_no_ext).count() == 1 { [INFO] [stderr] 133 | | try!(write!(output, "#[allow(missing_docs)] pub const {}: ", entry.struct_name_no_ext)); [INFO] [stderr] 134 | | for _ in 0 .. base.len() { try!(write!(output, r"super::")); } [INFO] [stderr] ... | [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 131 | if entry.struct_name != entry.struct_name_no_ext && entries.iter().filter(|e| e.struct_name_no_ext == entry.struct_name_no_ext || e.struct_name == entry.struct_name_no_ext).count() == 1 { [INFO] [stderr] 132 | try!(write!(output, "#[allow(missing_docs)] pub const {}: ", entry.struct_name_no_ext)); [INFO] [stderr] 133 | for _ in 0 .. base.len() { try!(write!(output, r"super::")); } [INFO] [stderr] 134 | try!(write!(output, "ResourceId = ")); [INFO] [stderr] 135 | for _ in 0 .. base.len() { try!(write!(output, r"super::")); } [INFO] [stderr] 136 | try!(writeln!(output, r"ResourceId::{};", entry.enum_name)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/lib.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/lib.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / if entry.resource_str_name != entry.resource_str_name_no_ext { [INFO] [stderr] 96 | | if entries.iter().filter(|e| e.resource_str_name_no_ext == entry.resource_str_name_no_ext || e.resource_str_name == entry.resource_str_name_no_ext).count() == 1 { [INFO] [stderr] 97 | | try!(writeln!(file, r##" [INFO] [stderr] 98 | | if name == r#"{}"# {{ return Some(ResourceId::{}); }} [INFO] [stderr] 99 | | "##, entry.resource_str_name_no_ext, entry.enum_name)); [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | if entry.resource_str_name != entry.resource_str_name_no_ext && entries.iter().filter(|e| e.resource_str_name_no_ext == entry.resource_str_name_no_ext || e.resource_str_name == entry.resource_str_name_no_ext).count() == 1 { [INFO] [stderr] 96 | try!(writeln!(file, r##" [INFO] [stderr] 97 | if name == r#"{}"# {{ return Some(ResourceId::{}); }} [INFO] [stderr] 98 | "##, entry.resource_str_name_no_ext, entry.enum_name)); [INFO] [stderr] 99 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / if entry.struct_name != entry.struct_name_no_ext { [INFO] [stderr] 132 | | if entries.iter().filter(|e| e.struct_name_no_ext == entry.struct_name_no_ext || e.struct_name == entry.struct_name_no_ext).count() == 1 { [INFO] [stderr] 133 | | try!(write!(output, "#[allow(missing_docs)] pub const {}: ", entry.struct_name_no_ext)); [INFO] [stderr] 134 | | for _ in 0 .. base.len() { try!(write!(output, r"super::")); } [INFO] [stderr] ... | [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 131 | if entry.struct_name != entry.struct_name_no_ext && entries.iter().filter(|e| e.struct_name_no_ext == entry.struct_name_no_ext || e.struct_name == entry.struct_name_no_ext).count() == 1 { [INFO] [stderr] 132 | try!(write!(output, "#[allow(missing_docs)] pub const {}: ", entry.struct_name_no_ext)); [INFO] [stderr] 133 | for _ in 0 .. base.len() { try!(write!(output, r"super::")); } [INFO] [stderr] 134 | try!(write!(output, "ResourceId = ")); [INFO] [stderr] 135 | for _ in 0 .. base.len() { try!(write!(output, r"super::")); } [INFO] [stderr] 136 | try!(writeln!(output, r"ResourceId::{};", entry.enum_name)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/lib.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/lib.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.80s [INFO] running `"docker" "inspect" "2cc35fb7939fd79f6657bd194821f08c61fc2b494a8adbc5a8647482d57b9e58"` [INFO] running `"docker" "rm" "-f" "2cc35fb7939fd79f6657bd194821f08c61fc2b494a8adbc5a8647482d57b9e58"` [INFO] [stdout] 2cc35fb7939fd79f6657bd194821f08c61fc2b494a8adbc5a8647482d57b9e58