[INFO] crate pnetlink 0.0.3 is already in cache [INFO] extracting crate pnetlink 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/pnetlink/0.0.3 [INFO] extracting crate pnetlink 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnetlink/0.0.3 [INFO] validating manifest of pnetlink-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pnetlink-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pnetlink-0.0.3 [INFO] finished frobbing pnetlink-0.0.3 [INFO] frobbed toml for pnetlink-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/pnetlink/0.0.3/Cargo.toml [INFO] started frobbing pnetlink-0.0.3 [INFO] finished frobbing pnetlink-0.0.3 [INFO] frobbed toml for pnetlink-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnetlink/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pnetlink-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pnetlink/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 209ffb04d0a39066f020cde352128225310e8505585e07a27cb5d6916cbc8bef [INFO] running `"docker" "start" "-a" "209ffb04d0a39066f020cde352128225310e8505585e07a27cb5d6916cbc8bef"` [INFO] [stderr] Compiling pnetlink v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/netlink.rs:53:27 [INFO] [stderr] | [INFO] [stderr] 53 | NetlinkIterable { buf: buf } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/netlink.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/netlink.rs:237:29 [INFO] [stderr] | [INFO] [stderr] 237 | NetlinkConnection { sock: sock } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/netlink.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/route/addr.rs:406:32 [INFO] [stderr] | [INFO] [stderr] 406 | IfAddrRequestBuilder { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/route/link.rs:493:31 [INFO] [stderr] | [INFO] [stderr] 493 | IfInfoPacketBuilder { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/route/neighbour.rs:424:43 [INFO] [stderr] | [INFO] [stderr] 424 | NeighbourDiscoveryPacketBuilder { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/route/mod.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokio.rs:23:28 [INFO] [stderr] | [INFO] [stderr] 23 | Ok(NetlinkSocket { io: io }) [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokio.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/netlink.rs:53:27 [INFO] [stderr] | [INFO] [stderr] 53 | NetlinkIterable { buf: buf } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/netlink.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/netlink.rs:237:29 [INFO] [stderr] | [INFO] [stderr] 237 | NetlinkConnection { sock: sock } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/netlink.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/route/addr.rs:406:32 [INFO] [stderr] | [INFO] [stderr] 406 | IfAddrRequestBuilder { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/route/link.rs:493:31 [INFO] [stderr] | [INFO] [stderr] 493 | IfInfoPacketBuilder { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/route/neighbour.rs:424:43 [INFO] [stderr] | [INFO] [stderr] 424 | NeighbourDiscoveryPacketBuilder { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/route/mod.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokio.rs:23:28 [INFO] [stderr] | [INFO] [stderr] 23 | Ok(NetlinkSocket { io: io }) [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokio.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc` [INFO] [stderr] --> src/packet/netlink.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use libc; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BufRead`, `BufReader` [INFO] [stderr] --> src/packet/netlink.rs:5:20 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::{Read,BufRead,BufReader,Write}; [INFO] [stderr] | ^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::marker::PhantomData` [INFO] [stderr] --> src/packet/netlink.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::marker::PhantomData; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `FromPacket` [INFO] [stderr] --> src/packet/netlink.rs:7:38 [INFO] [stderr] | [INFO] [stderr] 7 | use pnet::packet::{Packet,PacketSize,FromPacket}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:95:22 [INFO] [stderr] | [INFO] [stderr] 95 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:109:18 [INFO] [stderr] | [INFO] [stderr] 109 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:191:18 [INFO] [stderr] | [INFO] [stderr] 191 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:205:18 [INFO] [stderr] | [INFO] [stderr] 205 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:219:22 [INFO] [stderr] | [INFO] [stderr] 219 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:233:18 [INFO] [stderr] | [INFO] [stderr] 233 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:247:18 [INFO] [stderr] | [INFO] [stderr] 247 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:263:40 [INFO] [stderr] | [INFO] [stderr] 263 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:264:40 [INFO] [stderr] | [INFO] [stderr] 264 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:305:40 [INFO] [stderr] | [INFO] [stderr] 305 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:306:40 [INFO] [stderr] | [INFO] [stderr] 306 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:318:40 [INFO] [stderr] | [INFO] [stderr] 318 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:319:40 [INFO] [stderr] | [INFO] [stderr] 319 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:558:18 [INFO] [stderr] | [INFO] [stderr] 558 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:626:18 [INFO] [stderr] | [INFO] [stderr] 626 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:642:40 [INFO] [stderr] | [INFO] [stderr] 642 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:643:40 [INFO] [stderr] | [INFO] [stderr] 643 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `RtAttrMtuPacket` [INFO] [stderr] --> src/packet/route/addr.rs:2:144 [INFO] [stderr] | [INFO] [stderr] 2 | use packet::route::{IfAddrCacheInfoPacket,MutableIfInfoPacket,IfAddrPacket,MutableIfAddrPacket,RtAttrIterator,RtAttrPacket,MutableRtAttrPacket,RtAttrMtuPacket}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `MutableNetlinkPacket`, `NetlinkErrorPacket` [INFO] [stderr] --> src/packet/route/addr.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | use packet::netlink::{MutableNetlinkPacket,NetlinkPacket,NetlinkErrorPacket}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `NetlinkProtocol`, `NetlinkSocket` [INFO] [stderr] --> src/packet/route/addr.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | use socket::{NetlinkSocket,NetlinkProtocol}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::PacketSize` [INFO] [stderr] --> src/packet/route/addr.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use pnet::packet::PacketSize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::util::MacAddr` [INFO] [stderr] --> src/packet/route/addr.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use pnet::util::MacAddr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc` [INFO] [stderr] --> src/packet/route/addr.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use libc; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `LittleEndian` [INFO] [stderr] --> src/packet/route/addr.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | use byteorder::{LittleEndian, BigEndian, ReadBytesExt}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packet/route/addr.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | return Some(Addr { packet: pkt }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Addr { packet: pkt })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packet/route/link.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | return Some(Link { packet: pkt }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Link { packet: pkt })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc` [INFO] [stderr] --> src/packet/route/neighbour.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use libc; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `MutableRtAttrPacket`, `RtAttrMtuPacket` [INFO] [stderr] --> src/packet/route/neighbour.rs:11:35 [INFO] [stderr] | [INFO] [stderr] 11 | RtAttrPacket, MutableRtAttrPacket, RtAttrMtuPacket}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `MutableNetlinkPacket`, `NetlinkErrorPacket` [INFO] [stderr] --> src/packet/route/neighbour.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | use packet::netlink::{MutableNetlinkPacket, NetlinkPacket, NetlinkErrorPacket}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `NetlinkProtocol`, `NetlinkSocket` [INFO] [stderr] --> src/packet/route/neighbour.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | use ::socket::{NetlinkSocket, NetlinkProtocol}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::MutablePacket` [INFO] [stderr] --> src/packet/route/neighbour.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use pnet::packet::MutablePacket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::PacketSize` [INFO] [stderr] --> src/packet/route/neighbour.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use pnet::packet::PacketSize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packet/route/neighbour.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | return Some(Neighbour { packet: pkt }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Neighbour { packet: pkt })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ffi::CStr` [INFO] [stderr] --> src/packet/route/neighbour.rs:390:13 [INFO] [stderr] | [INFO] [stderr] 390 | use std::ffi::CStr; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/packet/route/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub mod route; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `NetlinkReader` [INFO] [stderr] --> src/packet/route/route.rs:6:43 [INFO] [stderr] | [INFO] [stderr] 6 | use packet::netlink::{NetlinkBufIterator, NetlinkReader, NetlinkRequestBuilder}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ffi::CStr` [INFO] [stderr] --> src/packet/route/route.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | use std::ffi::CStr; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packet/route/route.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | return Some(Route { packet: pkt }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Route { packet: pkt })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `MutableRtAttrPacket`, `MutableRtMsgPacket`, `RtAttrPacket` [INFO] [stderr] --> src/packet/route/rule.rs:2:35 [INFO] [stderr] | [INFO] [stderr] 2 | use packet::route::{FibRulePacket,MutableRtMsgPacket,MutableIfInfoPacket,RtAttrIterator,RtAttrPacket,MutableRtAttrPacket}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `packet::route::link::Link` [INFO] [stderr] --> src/packet/route/rule.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use packet::route::link::Link; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `MutableNetlinkPacket`, `NetlinkErrorPacket` [INFO] [stderr] --> src/packet/route/rule.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | use packet::netlink::{MutableNetlinkPacket,NetlinkPacket,NetlinkErrorPacket}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `NetlinkReader` [INFO] [stderr] --> src/packet/route/rule.rs:6:42 [INFO] [stderr] | [INFO] [stderr] 6 | use packet::netlink::{NetlinkBufIterator,NetlinkReader,NetlinkRequestBuilder}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `NetlinkProtocol`, `NetlinkSocket` [INFO] [stderr] --> src/packet/route/rule.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | use socket::{NetlinkSocket,NetlinkProtocol}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::MutablePacket` [INFO] [stderr] --> src/packet/route/rule.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use pnet::packet::MutablePacket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::PacketSize` [INFO] [stderr] --> src/packet/route/rule.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use pnet::packet::PacketSize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::util::MacAddr` [INFO] [stderr] --> src/packet/route/rule.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use pnet::util::MacAddr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc` [INFO] [stderr] --> src/packet/route/rule.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use libc; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::net::Ipv4Addr` [INFO] [stderr] --> src/packet/route/rule.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use std::net::Ipv4Addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/packet/route/rule.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | use std::io::{Read,Cursor,self}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `BigEndian` [INFO] [stderr] --> src/packet/route/rule.rs:17:31 [INFO] [stderr] | [INFO] [stderr] 17 | use byteorder::{LittleEndian, BigEndian, ReadBytesExt}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ffi::CStr` [INFO] [stderr] --> src/packet/route/rule.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | use std::ffi::CStr; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packet/route/rule.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | return Some(Rule { packet: pkt }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rule { packet: pkt })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:112:22 [INFO] [stderr] | [INFO] [stderr] 112 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:126:18 [INFO] [stderr] | [INFO] [stderr] 126 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:142:22 [INFO] [stderr] | [INFO] [stderr] 142 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:158:18 [INFO] [stderr] | [INFO] [stderr] 158 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:247:22 [INFO] [stderr] | [INFO] [stderr] 247 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:261:18 [INFO] [stderr] | [INFO] [stderr] 261 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:277:22 [INFO] [stderr] | [INFO] [stderr] 277 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:293:18 [INFO] [stderr] | [INFO] [stderr] 293 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:345:40 [INFO] [stderr] | [INFO] [stderr] 345 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:346:40 [INFO] [stderr] | [INFO] [stderr] 346 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:362:44 [INFO] [stderr] | [INFO] [stderr] 362 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:363:44 [INFO] [stderr] | [INFO] [stderr] 363 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:378:40 [INFO] [stderr] | [INFO] [stderr] 378 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:379:40 [INFO] [stderr] | [INFO] [stderr] 379 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:685:18 [INFO] [stderr] | [INFO] [stderr] 685 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:799:18 [INFO] [stderr] | [INFO] [stderr] 799 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:867:40 [INFO] [stderr] | [INFO] [stderr] 867 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:868:40 [INFO] [stderr] | [INFO] [stderr] 868 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1092:18 [INFO] [stderr] | [INFO] [stderr] 1092 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1106:18 [INFO] [stderr] | [INFO] [stderr] 1106 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1120:18 [INFO] [stderr] | [INFO] [stderr] 1120 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1134:18 [INFO] [stderr] | [INFO] [stderr] 1134 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1207:18 [INFO] [stderr] | [INFO] [stderr] 1207 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1221:18 [INFO] [stderr] | [INFO] [stderr] 1221 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1235:18 [INFO] [stderr] | [INFO] [stderr] 1235 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1249:18 [INFO] [stderr] | [INFO] [stderr] 1249 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1265:40 [INFO] [stderr] | [INFO] [stderr] 1265 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1266:40 [INFO] [stderr] | [INFO] [stderr] 1266 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1278:40 [INFO] [stderr] | [INFO] [stderr] 1278 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1279:40 [INFO] [stderr] | [INFO] [stderr] 1279 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1291:40 [INFO] [stderr] | [INFO] [stderr] 1291 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1292:40 [INFO] [stderr] | [INFO] [stderr] 1292 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1304:40 [INFO] [stderr] | [INFO] [stderr] 1304 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1305:40 [INFO] [stderr] | [INFO] [stderr] 1305 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1555:18 [INFO] [stderr] | [INFO] [stderr] 1555 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1567:18 [INFO] [stderr] | [INFO] [stderr] 1567 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1583:22 [INFO] [stderr] | [INFO] [stderr] 1583 | let b0 = ((_self.packet[co + 0] as u16le)) as u16le; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1700:18 [INFO] [stderr] | [INFO] [stderr] 1700 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1712:18 [INFO] [stderr] | [INFO] [stderr] 1712 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1728:22 [INFO] [stderr] | [INFO] [stderr] 1728 | let b0 = ((_self.packet[co + 0] as u16le)) as u16le; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1796:40 [INFO] [stderr] | [INFO] [stderr] 1796 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1797:40 [INFO] [stderr] | [INFO] [stderr] 1797 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2158:18 [INFO] [stderr] | [INFO] [stderr] 2158 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2306:18 [INFO] [stderr] | [INFO] [stderr] 2306 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2402:40 [INFO] [stderr] | [INFO] [stderr] 2402 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2403:40 [INFO] [stderr] | [INFO] [stderr] 2403 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2652:18 [INFO] [stderr] | [INFO] [stderr] 2652 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2666:18 [INFO] [stderr] | [INFO] [stderr] 2666 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2680:18 [INFO] [stderr] | [INFO] [stderr] 2680 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2694:18 [INFO] [stderr] | [INFO] [stderr] 2694 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2708:18 [INFO] [stderr] | [INFO] [stderr] 2708 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2722:18 [INFO] [stderr] | [INFO] [stderr] 2722 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2736:18 [INFO] [stderr] | [INFO] [stderr] 2736 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2750:18 [INFO] [stderr] | [INFO] [stderr] 2750 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2827:18 [INFO] [stderr] | [INFO] [stderr] 2827 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2841:18 [INFO] [stderr] | [INFO] [stderr] 2841 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2855:18 [INFO] [stderr] | [INFO] [stderr] 2855 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2869:18 [INFO] [stderr] | [INFO] [stderr] 2869 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2883:18 [INFO] [stderr] | [INFO] [stderr] 2883 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2897:18 [INFO] [stderr] | [INFO] [stderr] 2897 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2911:18 [INFO] [stderr] | [INFO] [stderr] 2911 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2925:18 [INFO] [stderr] | [INFO] [stderr] 2925 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2941:40 [INFO] [stderr] | [INFO] [stderr] 2941 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2942:40 [INFO] [stderr] | [INFO] [stderr] 2942 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2954:40 [INFO] [stderr] | [INFO] [stderr] 2954 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2955:40 [INFO] [stderr] | [INFO] [stderr] 2955 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2967:40 [INFO] [stderr] | [INFO] [stderr] 2967 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2968:40 [INFO] [stderr] | [INFO] [stderr] 2968 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2980:40 [INFO] [stderr] | [INFO] [stderr] 2980 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2981:40 [INFO] [stderr] | [INFO] [stderr] 2981 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2993:40 [INFO] [stderr] | [INFO] [stderr] 2993 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2994:40 [INFO] [stderr] | [INFO] [stderr] 2994 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3006:40 [INFO] [stderr] | [INFO] [stderr] 3006 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3007:40 [INFO] [stderr] | [INFO] [stderr] 3007 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3019:40 [INFO] [stderr] | [INFO] [stderr] 3019 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3020:40 [INFO] [stderr] | [INFO] [stderr] 3020 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3032:40 [INFO] [stderr] | [INFO] [stderr] 3032 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3033:40 [INFO] [stderr] | [INFO] [stderr] 3033 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3349:18 [INFO] [stderr] | [INFO] [stderr] 3349 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3493:18 [INFO] [stderr] | [INFO] [stderr] 3493 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3581:40 [INFO] [stderr] | [INFO] [stderr] 3581 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3582:40 [INFO] [stderr] | [INFO] [stderr] 3582 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3819:18 [INFO] [stderr] | [INFO] [stderr] 3819 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3831:18 [INFO] [stderr] | [INFO] [stderr] 3831 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3894:18 [INFO] [stderr] | [INFO] [stderr] 3894 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3906:18 [INFO] [stderr] | [INFO] [stderr] 3906 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4159:18 [INFO] [stderr] | [INFO] [stderr] 4159 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4171:18 [INFO] [stderr] | [INFO] [stderr] 4171 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4183:18 [INFO] [stderr] | [INFO] [stderr] 4183 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4251:18 [INFO] [stderr] | [INFO] [stderr] 4251 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4263:18 [INFO] [stderr] | [INFO] [stderr] 4263 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4275:18 [INFO] [stderr] | [INFO] [stderr] 4275 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4313:40 [INFO] [stderr] | [INFO] [stderr] 4313 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4314:40 [INFO] [stderr] | [INFO] [stderr] 4314 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused imports: `MutableNetlinkPacket`, `NetlinkPacket` [INFO] [stderr] --> src/packet/audit/mod.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | use packet::netlink::{MutableNetlinkPacket,NetlinkPacket}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `NetlinkBufIterator` [INFO] [stderr] --> src/packet/audit/mod.rs:3:23 [INFO] [stderr] | [INFO] [stderr] 3 | use packet::netlink::{NetlinkBufIterator,NetlinkReader,NetlinkRequestBuilder}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `NetlinkProtocol`, `NetlinkSocket` [INFO] [stderr] --> src/packet/audit/mod.rs:4:16 [INFO] [stderr] | [INFO] [stderr] 4 | use ::socket::{NetlinkSocket,NetlinkProtocol}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::MutablePacket` [INFO] [stderr] --> src/packet/audit/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use pnet::packet::MutablePacket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc` [INFO] [stderr] --> src/packet/audit/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use libc; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::PrimitiveValues` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use pnet::packet::PrimitiveValues; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:64:18 [INFO] [stderr] | [INFO] [stderr] 64 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:78:18 [INFO] [stderr] | [INFO] [stderr] 78 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:120:18 [INFO] [stderr] | [INFO] [stderr] 120 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:148:18 [INFO] [stderr] | [INFO] [stderr] 148 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:162:18 [INFO] [stderr] | [INFO] [stderr] 162 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:176:18 [INFO] [stderr] | [INFO] [stderr] 176 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:190:18 [INFO] [stderr] | [INFO] [stderr] 190 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:267:18 [INFO] [stderr] | [INFO] [stderr] 267 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:281:18 [INFO] [stderr] | [INFO] [stderr] 281 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:295:18 [INFO] [stderr] | [INFO] [stderr] 295 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:309:18 [INFO] [stderr] | [INFO] [stderr] 309 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:323:18 [INFO] [stderr] | [INFO] [stderr] 323 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:337:18 [INFO] [stderr] | [INFO] [stderr] 337 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:351:18 [INFO] [stderr] | [INFO] [stderr] 351 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:365:18 [INFO] [stderr] | [INFO] [stderr] 365 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:379:18 [INFO] [stderr] | [INFO] [stderr] 379 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:393:18 [INFO] [stderr] | [INFO] [stderr] 393 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:409:40 [INFO] [stderr] | [INFO] [stderr] 409 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:410:40 [INFO] [stderr] | [INFO] [stderr] 410 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:422:40 [INFO] [stderr] | [INFO] [stderr] 422 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:423:40 [INFO] [stderr] | [INFO] [stderr] 423 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:435:40 [INFO] [stderr] | [INFO] [stderr] 435 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:436:40 [INFO] [stderr] | [INFO] [stderr] 436 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:448:40 [INFO] [stderr] | [INFO] [stderr] 448 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:449:40 [INFO] [stderr] | [INFO] [stderr] 449 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:461:40 [INFO] [stderr] | [INFO] [stderr] 461 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:462:40 [INFO] [stderr] | [INFO] [stderr] 462 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:474:40 [INFO] [stderr] | [INFO] [stderr] 474 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:475:40 [INFO] [stderr] | [INFO] [stderr] 475 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:487:40 [INFO] [stderr] | [INFO] [stderr] 487 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:488:40 [INFO] [stderr] | [INFO] [stderr] 488 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:500:40 [INFO] [stderr] | [INFO] [stderr] 500 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:501:40 [INFO] [stderr] | [INFO] [stderr] 501 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:513:40 [INFO] [stderr] | [INFO] [stderr] 513 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:514:40 [INFO] [stderr] | [INFO] [stderr] 514 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:526:40 [INFO] [stderr] | [INFO] [stderr] 526 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:527:40 [INFO] [stderr] | [INFO] [stderr] 527 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Future` [INFO] [stderr] --> src/tokio.rs:2:15 [INFO] [stderr] | [INFO] [stderr] 2 | use futures::{Future, Poll, Async}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/tokio.rs:7:76 [INFO] [stderr] | [INFO] [stderr] 7 | use ::packet::netlink::{NetlinkPacket,MutableNetlinkPacket,NetlinkMsgFlags,self}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `IfInfoPacket`, `MutableIfInfoPacket` [INFO] [stderr] --> src/tokio.rs:8:23 [INFO] [stderr] | [INFO] [stderr] 8 | use ::packet::route::{IfInfoPacket,MutableIfInfoPacket}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `FromPacket` [INFO] [stderr] --> src/tokio.rs:9:38 [INFO] [stderr] | [INFO] [stderr] 9 | use pnet::packet::{Packet,PacketSize,FromPacket}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokio.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return Ok(write_at); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(write_at)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokio.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | return Ok(owned_pkt); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(owned_pkt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc` [INFO] [stderr] --> src/packet/netlink.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use libc; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BufRead`, `BufReader` [INFO] [stderr] --> src/packet/netlink.rs:5:20 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::{Read,BufRead,BufReader,Write}; [INFO] [stderr] | ^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::marker::PhantomData` [INFO] [stderr] --> src/packet/netlink.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::marker::PhantomData; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `FromPacket` [INFO] [stderr] --> src/packet/netlink.rs:7:38 [INFO] [stderr] | [INFO] [stderr] 7 | use pnet::packet::{Packet,PacketSize,FromPacket}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:95:22 [INFO] [stderr] | [INFO] [stderr] 95 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:109:18 [INFO] [stderr] | [INFO] [stderr] 109 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:191:18 [INFO] [stderr] | [INFO] [stderr] 191 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:205:18 [INFO] [stderr] | [INFO] [stderr] 205 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:219:22 [INFO] [stderr] | [INFO] [stderr] 219 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:233:18 [INFO] [stderr] | [INFO] [stderr] 233 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:247:18 [INFO] [stderr] | [INFO] [stderr] 247 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:263:40 [INFO] [stderr] | [INFO] [stderr] 263 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:264:40 [INFO] [stderr] | [INFO] [stderr] 264 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:305:40 [INFO] [stderr] | [INFO] [stderr] 305 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:306:40 [INFO] [stderr] | [INFO] [stderr] 306 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:318:40 [INFO] [stderr] | [INFO] [stderr] 318 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:319:40 [INFO] [stderr] | [INFO] [stderr] 319 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:558:18 [INFO] [stderr] | [INFO] [stderr] 558 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:626:18 [INFO] [stderr] | [INFO] [stderr] 626 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:642:40 [INFO] [stderr] | [INFO] [stderr] 642 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:643:40 [INFO] [stderr] | [INFO] [stderr] 643 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude` [INFO] [stderr] --> src/packet/netlink.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | use std::io::prelude; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::BufRead` [INFO] [stderr] --> src/packet/netlink.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | use std::io::BufRead; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude` [INFO] [stderr] --> src/packet/netlink.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | use std::io::prelude; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::BufRead` [INFO] [stderr] --> src/packet/netlink.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | use std::io::BufRead; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Read` [INFO] [stderr] --> src/packet/netlink.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | use std::io::Read; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/packet/netlink.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude` [INFO] [stderr] --> src/packet/netlink.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | use std::io::prelude; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::BufReader` [INFO] [stderr] --> src/packet/netlink.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | use std::io::BufReader; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::BufRead` [INFO] [stderr] --> src/packet/netlink.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | use std::io::BufRead; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Read` [INFO] [stderr] --> src/packet/netlink.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | use std::io::Read; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `RtAttrMtuPacket` [INFO] [stderr] --> src/packet/route/addr.rs:2:144 [INFO] [stderr] | [INFO] [stderr] 2 | use packet::route::{IfAddrCacheInfoPacket,MutableIfInfoPacket,IfAddrPacket,MutableIfAddrPacket,RtAttrIterator,RtAttrPacket,MutableRtAttrPacket,RtAttrMtuPacket}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `MutableNetlinkPacket`, `NetlinkErrorPacket` [INFO] [stderr] --> src/packet/route/addr.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | use packet::netlink::{MutableNetlinkPacket,NetlinkPacket,NetlinkErrorPacket}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `NetlinkProtocol`, `NetlinkSocket` [INFO] [stderr] --> src/packet/route/addr.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | use socket::{NetlinkSocket,NetlinkProtocol}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::PacketSize` [INFO] [stderr] --> src/packet/route/addr.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use pnet::packet::PacketSize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::util::MacAddr` [INFO] [stderr] --> src/packet/route/addr.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use pnet::util::MacAddr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc` [INFO] [stderr] --> src/packet/route/addr.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use libc; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `LittleEndian` [INFO] [stderr] --> src/packet/route/addr.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | use byteorder::{LittleEndian, BigEndian, ReadBytesExt}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packet/route/addr.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | return Some(Addr { packet: pkt }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Addr { packet: pkt })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packet/route/link.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | return Some(Link { packet: pkt }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Link { packet: pkt })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc` [INFO] [stderr] --> src/packet/route/neighbour.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use libc; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `MutableRtAttrPacket`, `RtAttrMtuPacket` [INFO] [stderr] --> src/packet/route/neighbour.rs:11:35 [INFO] [stderr] | [INFO] [stderr] 11 | RtAttrPacket, MutableRtAttrPacket, RtAttrMtuPacket}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `MutableNetlinkPacket`, `NetlinkErrorPacket` [INFO] [stderr] --> src/packet/route/neighbour.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | use packet::netlink::{MutableNetlinkPacket, NetlinkPacket, NetlinkErrorPacket}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `NetlinkProtocol`, `NetlinkSocket` [INFO] [stderr] --> src/packet/route/neighbour.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | use ::socket::{NetlinkSocket, NetlinkProtocol}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::MutablePacket` [INFO] [stderr] --> src/packet/route/neighbour.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use pnet::packet::MutablePacket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::PacketSize` [INFO] [stderr] --> src/packet/route/neighbour.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use pnet::packet::PacketSize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packet/route/neighbour.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | return Some(Neighbour { packet: pkt }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Neighbour { packet: pkt })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ffi::CStr` [INFO] [stderr] --> src/packet/route/neighbour.rs:390:13 [INFO] [stderr] | [INFO] [stderr] 390 | use std::ffi::CStr; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Link` [INFO] [stderr] --> src/packet/route/neighbour.rs:487:37 [INFO] [stderr] | [INFO] [stderr] 487 | use ::packet::route::link::{Link, Links}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/packet/route/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub mod route; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `NetlinkReader` [INFO] [stderr] --> src/packet/route/route.rs:6:43 [INFO] [stderr] | [INFO] [stderr] 6 | use packet::netlink::{NetlinkBufIterator, NetlinkReader, NetlinkRequestBuilder}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ffi::CStr` [INFO] [stderr] --> src/packet/route/route.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | use std::ffi::CStr; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packet/route/route.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | return Some(Route { packet: pkt }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Route { packet: pkt })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `MutableRtAttrPacket`, `MutableRtMsgPacket`, `RtAttrPacket` [INFO] [stderr] --> src/packet/route/rule.rs:2:35 [INFO] [stderr] | [INFO] [stderr] 2 | use packet::route::{FibRulePacket,MutableRtMsgPacket,MutableIfInfoPacket,RtAttrIterator,RtAttrPacket,MutableRtAttrPacket}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `packet::route::link::Link` [INFO] [stderr] --> src/packet/route/rule.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use packet::route::link::Link; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `MutableNetlinkPacket`, `NetlinkErrorPacket` [INFO] [stderr] --> src/packet/route/rule.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | use packet::netlink::{MutableNetlinkPacket,NetlinkPacket,NetlinkErrorPacket}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `NetlinkReader` [INFO] [stderr] --> src/packet/route/rule.rs:6:42 [INFO] [stderr] | [INFO] [stderr] 6 | use packet::netlink::{NetlinkBufIterator,NetlinkReader,NetlinkRequestBuilder}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `NetlinkProtocol`, `NetlinkSocket` [INFO] [stderr] --> src/packet/route/rule.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | use socket::{NetlinkSocket,NetlinkProtocol}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::MutablePacket` [INFO] [stderr] --> src/packet/route/rule.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use pnet::packet::MutablePacket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::PacketSize` [INFO] [stderr] --> src/packet/route/rule.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use pnet::packet::PacketSize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::util::MacAddr` [INFO] [stderr] --> src/packet/route/rule.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use pnet::util::MacAddr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc` [INFO] [stderr] --> src/packet/route/rule.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use libc; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::net::Ipv4Addr` [INFO] [stderr] --> src/packet/route/rule.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use std::net::Ipv4Addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/packet/route/rule.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | use std::io::{Read,Cursor,self}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `BigEndian` [INFO] [stderr] --> src/packet/route/rule.rs:17:31 [INFO] [stderr] | [INFO] [stderr] 17 | use byteorder::{LittleEndian, BigEndian, ReadBytesExt}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ffi::CStr` [INFO] [stderr] --> src/packet/route/rule.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | use std::ffi::CStr; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packet/route/rule.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | return Some(Rule { packet: pkt }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rule { packet: pkt })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:112:22 [INFO] [stderr] | [INFO] [stderr] 112 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:126:18 [INFO] [stderr] | [INFO] [stderr] 126 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:142:22 [INFO] [stderr] | [INFO] [stderr] 142 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:158:18 [INFO] [stderr] | [INFO] [stderr] 158 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:247:22 [INFO] [stderr] | [INFO] [stderr] 247 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:261:18 [INFO] [stderr] | [INFO] [stderr] 261 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:277:22 [INFO] [stderr] | [INFO] [stderr] 277 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:293:18 [INFO] [stderr] | [INFO] [stderr] 293 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:345:40 [INFO] [stderr] | [INFO] [stderr] 345 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:346:40 [INFO] [stderr] | [INFO] [stderr] 346 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:362:44 [INFO] [stderr] | [INFO] [stderr] 362 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:363:44 [INFO] [stderr] | [INFO] [stderr] 363 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:378:40 [INFO] [stderr] | [INFO] [stderr] 378 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:379:40 [INFO] [stderr] | [INFO] [stderr] 379 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:685:18 [INFO] [stderr] | [INFO] [stderr] 685 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:799:18 [INFO] [stderr] | [INFO] [stderr] 799 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:867:40 [INFO] [stderr] | [INFO] [stderr] 867 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:868:40 [INFO] [stderr] | [INFO] [stderr] 868 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1092:18 [INFO] [stderr] | [INFO] [stderr] 1092 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1106:18 [INFO] [stderr] | [INFO] [stderr] 1106 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1120:18 [INFO] [stderr] | [INFO] [stderr] 1120 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1134:18 [INFO] [stderr] | [INFO] [stderr] 1134 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1207:18 [INFO] [stderr] | [INFO] [stderr] 1207 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1221:18 [INFO] [stderr] | [INFO] [stderr] 1221 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1235:18 [INFO] [stderr] | [INFO] [stderr] 1235 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1249:18 [INFO] [stderr] | [INFO] [stderr] 1249 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1265:40 [INFO] [stderr] | [INFO] [stderr] 1265 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1266:40 [INFO] [stderr] | [INFO] [stderr] 1266 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1278:40 [INFO] [stderr] | [INFO] [stderr] 1278 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1279:40 [INFO] [stderr] | [INFO] [stderr] 1279 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1291:40 [INFO] [stderr] | [INFO] [stderr] 1291 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1292:40 [INFO] [stderr] | [INFO] [stderr] 1292 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1304:40 [INFO] [stderr] | [INFO] [stderr] 1304 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1305:40 [INFO] [stderr] | [INFO] [stderr] 1305 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1555:18 [INFO] [stderr] | [INFO] [stderr] 1555 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1567:18 [INFO] [stderr] | [INFO] [stderr] 1567 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1583:22 [INFO] [stderr] | [INFO] [stderr] 1583 | let b0 = ((_self.packet[co + 0] as u16le)) as u16le; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1700:18 [INFO] [stderr] | [INFO] [stderr] 1700 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1712:18 [INFO] [stderr] | [INFO] [stderr] 1712 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1728:22 [INFO] [stderr] | [INFO] [stderr] 1728 | let b0 = ((_self.packet[co + 0] as u16le)) as u16le; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1796:40 [INFO] [stderr] | [INFO] [stderr] 1796 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1797:40 [INFO] [stderr] | [INFO] [stderr] 1797 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2158:18 [INFO] [stderr] | [INFO] [stderr] 2158 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2306:18 [INFO] [stderr] | [INFO] [stderr] 2306 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2402:40 [INFO] [stderr] | [INFO] [stderr] 2402 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2403:40 [INFO] [stderr] | [INFO] [stderr] 2403 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2652:18 [INFO] [stderr] | [INFO] [stderr] 2652 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2666:18 [INFO] [stderr] | [INFO] [stderr] 2666 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2680:18 [INFO] [stderr] | [INFO] [stderr] 2680 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2694:18 [INFO] [stderr] | [INFO] [stderr] 2694 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2708:18 [INFO] [stderr] | [INFO] [stderr] 2708 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2722:18 [INFO] [stderr] | [INFO] [stderr] 2722 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2736:18 [INFO] [stderr] | [INFO] [stderr] 2736 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2750:18 [INFO] [stderr] | [INFO] [stderr] 2750 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2827:18 [INFO] [stderr] | [INFO] [stderr] 2827 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2841:18 [INFO] [stderr] | [INFO] [stderr] 2841 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2855:18 [INFO] [stderr] | [INFO] [stderr] 2855 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2869:18 [INFO] [stderr] | [INFO] [stderr] 2869 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2883:18 [INFO] [stderr] | [INFO] [stderr] 2883 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2897:18 [INFO] [stderr] | [INFO] [stderr] 2897 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2911:18 [INFO] [stderr] | [INFO] [stderr] 2911 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2925:18 [INFO] [stderr] | [INFO] [stderr] 2925 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2941:40 [INFO] [stderr] | [INFO] [stderr] 2941 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2942:40 [INFO] [stderr] | [INFO] [stderr] 2942 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2954:40 [INFO] [stderr] | [INFO] [stderr] 2954 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2955:40 [INFO] [stderr] | [INFO] [stderr] 2955 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2967:40 [INFO] [stderr] | [INFO] [stderr] 2967 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2968:40 [INFO] [stderr] | [INFO] [stderr] 2968 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2980:40 [INFO] [stderr] | [INFO] [stderr] 2980 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2981:40 [INFO] [stderr] | [INFO] [stderr] 2981 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2993:40 [INFO] [stderr] | [INFO] [stderr] 2993 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2994:40 [INFO] [stderr] | [INFO] [stderr] 2994 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3006:40 [INFO] [stderr] | [INFO] [stderr] 3006 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3007:40 [INFO] [stderr] | [INFO] [stderr] 3007 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3019:40 [INFO] [stderr] | [INFO] [stderr] 3019 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3020:40 [INFO] [stderr] | [INFO] [stderr] 3020 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3032:40 [INFO] [stderr] | [INFO] [stderr] 3032 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3033:40 [INFO] [stderr] | [INFO] [stderr] 3033 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3349:18 [INFO] [stderr] | [INFO] [stderr] 3349 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3493:18 [INFO] [stderr] | [INFO] [stderr] 3493 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3581:40 [INFO] [stderr] | [INFO] [stderr] 3581 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3582:40 [INFO] [stderr] | [INFO] [stderr] 3582 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3819:18 [INFO] [stderr] | [INFO] [stderr] 3819 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3831:18 [INFO] [stderr] | [INFO] [stderr] 3831 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3894:18 [INFO] [stderr] | [INFO] [stderr] 3894 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3906:18 [INFO] [stderr] | [INFO] [stderr] 3906 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4159:18 [INFO] [stderr] | [INFO] [stderr] 4159 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4171:18 [INFO] [stderr] | [INFO] [stderr] 4171 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4183:18 [INFO] [stderr] | [INFO] [stderr] 4183 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4251:18 [INFO] [stderr] | [INFO] [stderr] 4251 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4263:18 [INFO] [stderr] | [INFO] [stderr] 4263 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4275:18 [INFO] [stderr] | [INFO] [stderr] 4275 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4313:40 [INFO] [stderr] | [INFO] [stderr] 4313 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4314:40 [INFO] [stderr] | [INFO] [stderr] 4314 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused imports: `MutableNetlinkPacket`, `NetlinkPacket` [INFO] [stderr] --> src/packet/audit/mod.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | use packet::netlink::{MutableNetlinkPacket,NetlinkPacket}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `NetlinkBufIterator` [INFO] [stderr] --> src/packet/audit/mod.rs:3:23 [INFO] [stderr] | [INFO] [stderr] 3 | use packet::netlink::{NetlinkBufIterator,NetlinkReader,NetlinkRequestBuilder}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `NetlinkProtocol`, `NetlinkSocket` [INFO] [stderr] --> src/packet/audit/mod.rs:4:16 [INFO] [stderr] | [INFO] [stderr] 4 | use ::socket::{NetlinkSocket,NetlinkProtocol}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::MutablePacket` [INFO] [stderr] --> src/packet/audit/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use pnet::packet::MutablePacket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc` [INFO] [stderr] --> src/packet/audit/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use libc; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::PrimitiveValues` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use pnet::packet::PrimitiveValues; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:64:18 [INFO] [stderr] | [INFO] [stderr] 64 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:78:18 [INFO] [stderr] | [INFO] [stderr] 78 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:120:18 [INFO] [stderr] | [INFO] [stderr] 120 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:148:18 [INFO] [stderr] | [INFO] [stderr] 148 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:162:18 [INFO] [stderr] | [INFO] [stderr] 162 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:176:18 [INFO] [stderr] | [INFO] [stderr] 176 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:190:18 [INFO] [stderr] | [INFO] [stderr] 190 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:267:18 [INFO] [stderr] | [INFO] [stderr] 267 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:281:18 [INFO] [stderr] | [INFO] [stderr] 281 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:295:18 [INFO] [stderr] | [INFO] [stderr] 295 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:309:18 [INFO] [stderr] | [INFO] [stderr] 309 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:323:18 [INFO] [stderr] | [INFO] [stderr] 323 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:337:18 [INFO] [stderr] | [INFO] [stderr] 337 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:351:18 [INFO] [stderr] | [INFO] [stderr] 351 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:365:18 [INFO] [stderr] | [INFO] [stderr] 365 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:379:18 [INFO] [stderr] | [INFO] [stderr] 379 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:393:18 [INFO] [stderr] | [INFO] [stderr] 393 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:409:40 [INFO] [stderr] | [INFO] [stderr] 409 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:410:40 [INFO] [stderr] | [INFO] [stderr] 410 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:422:40 [INFO] [stderr] | [INFO] [stderr] 422 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:423:40 [INFO] [stderr] | [INFO] [stderr] 423 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:435:40 [INFO] [stderr] | [INFO] [stderr] 435 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:436:40 [INFO] [stderr] | [INFO] [stderr] 436 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:448:40 [INFO] [stderr] | [INFO] [stderr] 448 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:449:40 [INFO] [stderr] | [INFO] [stderr] 449 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:461:40 [INFO] [stderr] | [INFO] [stderr] 461 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:462:40 [INFO] [stderr] | [INFO] [stderr] 462 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:474:40 [INFO] [stderr] | [INFO] [stderr] 474 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:475:40 [INFO] [stderr] | [INFO] [stderr] 475 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:487:40 [INFO] [stderr] | [INFO] [stderr] 487 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:488:40 [INFO] [stderr] | [INFO] [stderr] 488 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:500:40 [INFO] [stderr] | [INFO] [stderr] 500 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:501:40 [INFO] [stderr] | [INFO] [stderr] 501 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:513:40 [INFO] [stderr] | [INFO] [stderr] 513 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:514:40 [INFO] [stderr] | [INFO] [stderr] 514 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:526:40 [INFO] [stderr] | [INFO] [stderr] 526 | _self.packet[co + 2] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:527:40 [INFO] [stderr] | [INFO] [stderr] 527 | _self.packet[co + 3] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/tokio.rs:7:76 [INFO] [stderr] | [INFO] [stderr] 7 | use ::packet::netlink::{NetlinkPacket,MutableNetlinkPacket,NetlinkMsgFlags,self}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `IfInfoPacket` [INFO] [stderr] --> src/tokio.rs:8:23 [INFO] [stderr] | [INFO] [stderr] 8 | use ::packet::route::{IfInfoPacket,MutableIfInfoPacket}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `FromPacket` [INFO] [stderr] --> src/tokio.rs:9:38 [INFO] [stderr] | [INFO] [stderr] 9 | use pnet::packet::{Packet,PacketSize,FromPacket}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokio.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return Ok(write_at); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(write_at)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokio.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | return Ok(owned_pkt); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(owned_pkt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/tokio.rs:170:18 [INFO] [stderr] | [INFO] [stderr] 170 | let framed = tokio_io::AsyncRead::framed(sock, NetlinkCodec {}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/tokio.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | buf.truncate(write_at); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BytesMut::drain_to': use split_to instead [INFO] [stderr] --> src/tokio.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | buf.drain_to(len as usize); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/tokio.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | buf.truncate(write_at); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BytesMut::drain_to': use split_to instead [INFO] [stderr] --> src/tokio.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | buf.drain_to(len as usize); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Event::kind': use Event::readiness() [INFO] [stderr] --> src/tokio.rs:228:30 [INFO] [stderr] | [INFO] [stderr] 228 | if event.kind() == Ready::writable() { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Event::kind': use Event::readiness() [INFO] [stderr] --> src/tokio.rs:236:30 [INFO] [stderr] | [INFO] [stderr] 236 | if event.kind() & Ready::readable() == Ready::readable() { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/packet/netlink.rs:5:38 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::{Read,BufRead,BufReader,Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::PacketSize` [INFO] [stderr] --> src/packet/audit/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use pnet::packet::PacketSize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/socket.rs:174:48 [INFO] [stderr] | [INFO] [stderr] 174 | pub fn getsockopt(&mut self, option: SockOpt, val: bool) -> Result { [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/packet/route/addr.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | let mut buf = vec![0; MutableIfAddrPacket::minimum_packet_size()]; [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/packet/route/link.rs:244:17 [INFO] [stderr] | [INFO] [stderr] 244 | let buf = vec![0; MutableIfInfoPacket::minimum_packet_size()]; [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/packet/route/addr.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | let mut buf = vec![0; MutableIfAddrPacket::minimum_packet_size()]; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/packet/route/addr.rs:394:13 [INFO] [stderr] | [INFO] [stderr] 394 | let mut reply = conn.send(req); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/packet/route/neighbour.rs:171:29 [INFO] [stderr] | [INFO] [stderr] 171 | self.with_rta_iter(|mut iter| { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/packet/route/neighbour.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | let mut data = vec![0; len]; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/packet/route/route.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | let mut reply = conn.send(req); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/packet/netlink.rs:5:38 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::{Read,BufRead,BufReader,Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::PacketSize` [INFO] [stderr] --> src/packet/audit/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use pnet::packet::PacketSize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Future` [INFO] [stderr] --> src/tokio.rs:2:15 [INFO] [stderr] | [INFO] [stderr] 2 | use futures::{Future, Poll, Async}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/packet/route/rule.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let mut reply = conn.send(req); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/tokio.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | let s = l.run(f); [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/socket.rs:174:48 [INFO] [stderr] | [INFO] [stderr] 174 | pub fn getsockopt(&mut self, option: SockOpt, val: bool) -> Result { [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/packet/route/addr.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | let mut buf = vec![0; MutableIfAddrPacket::minimum_packet_size()]; [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/packet/route/link.rs:244:17 [INFO] [stderr] | [INFO] [stderr] 244 | let buf = vec![0; MutableIfInfoPacket::minimum_packet_size()]; [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/packet/route/addr.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | let mut buf = vec![0; MutableIfAddrPacket::minimum_packet_size()]; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/packet/route/addr.rs:394:13 [INFO] [stderr] | [INFO] [stderr] 394 | let mut reply = conn.send(req); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/packet/route/neighbour.rs:171:29 [INFO] [stderr] | [INFO] [stderr] 171 | self.with_rta_iter(|mut iter| { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/packet/route/neighbour.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | let mut data = vec![0; len]; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/packet/route/route.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | let mut reply = conn.send(req); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/packet/route/rule.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let mut reply = conn.send(req); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dump_addr` [INFO] [stderr] --> src/packet/route/addr.rs:332:5 [INFO] [stderr] | [INFO] [stderr] 332 | fn dump_addr(msg: NetlinkPacket) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_links_iter` [INFO] [stderr] --> src/packet/route/link.rs:438:5 [INFO] [stderr] | [INFO] [stderr] 438 | fn get_links_iter(r: NetlinkBufIterator) -> LinksIterator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_neighbours_iter` [INFO] [stderr] --> src/packet/route/neighbour.rs:385:5 [INFO] [stderr] | [INFO] [stderr] 385 | fn get_neighbours_iter(r: NetlinkBufIterator) -> NeighboursIterator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dump_neighbour` [INFO] [stderr] --> src/packet/route/neighbour.rs:389:5 [INFO] [stderr] | [INFO] [stderr] 389 | fn dump_neighbour(msg: NetlinkPacket) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_family` [INFO] [stderr] --> src/packet/route/neighbour.rs:427:5 [INFO] [stderr] | [INFO] [stderr] 427 | pub fn set_family(mut self, family: u8) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_state` [INFO] [stderr] --> src/packet/route/neighbour.rs:443:5 [INFO] [stderr] | [INFO] [stderr] 443 | pub fn set_state(mut self, state: NeighbourState) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_flags` [INFO] [stderr] --> src/packet/route/neighbour.rs:451:5 [INFO] [stderr] | [INFO] [stderr] 451 | pub fn set_flags(mut self, flags: NeighbourFlags) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_type` [INFO] [stderr] --> src/packet/route/neighbour.rs:459:5 [INFO] [stderr] | [INFO] [stderr] 459 | pub fn set_type(mut self, type_: u8) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `RtmType` [INFO] [stderr] --> src/packet/route/route.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | enum RtmType { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dump_route` [INFO] [stderr] --> src/packet/route/route.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | fn dump_route(msg: NetlinkPacket) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dump_rule` [INFO] [stderr] --> src/packet/route/rule.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | fn dump_rule(msg: NetlinkPacket) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `Inet_diag` should have a camel case name such as `InetDiag` [INFO] [stderr] --> src/socket.rs:31:2 [INFO] [stderr] | [INFO] [stderr] 31 | Inet_diag = 4, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `IP6_fw` should have a camel case name such as `Ip6Fw` [INFO] [stderr] --> src/socket.rs:40:2 [INFO] [stderr] | [INFO] [stderr] 40 | IP6_fw = 13, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/socket.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | bind(sock.fd, transmute(&mut sockaddr), size_of::() as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut sockaddr as *mut libc::sockaddr_nl as *const libc::sockaddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/socket.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | mem::transmute(&val), mem::size_of::() as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&val as *const i32 as *const libc::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/socket.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | mem::transmute(&mut ffi_val), mem::transmute(&mut opt_len)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ffi_val as *mut i32 as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/socket.rs:151:39 [INFO] [stderr] | [INFO] [stderr] 151 | mem::transmute(&mut ffi_val), mem::transmute(&mut opt_len)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut opt_len as *mut i32 as *mut u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 24 | | if packet.len() >= NetlinkPacket::minimum_packet_size() { [INFO] [stderr] 25 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 26 | | Some(NetlinkPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 27 | | } else { None } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn to_immutable<'p>(&'p self) -> NetlinkPacket<'p> { [INFO] [stderr] 41 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 42 | | NetlinkPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:67:33 [INFO] [stderr] | [INFO] [stderr] 67 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:69:19 [INFO] [stderr] | [INFO] [stderr] 69 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:70:19 [INFO] [stderr] | [INFO] [stderr] 70 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:81:33 [INFO] [stderr] | [INFO] [stderr] 81 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:82:19 [INFO] [stderr] | [INFO] [stderr] 82 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:95:22 [INFO] [stderr] | [INFO] [stderr] 95 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:95:37 [INFO] [stderr] | [INFO] [stderr] 95 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:96:23 [INFO] [stderr] | [INFO] [stderr] 96 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:109:18 [INFO] [stderr] | [INFO] [stderr] 109 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:109:33 [INFO] [stderr] | [INFO] [stderr] 109 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:110:19 [INFO] [stderr] | [INFO] [stderr] 110 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:111:19 [INFO] [stderr] | [INFO] [stderr] 111 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:112:19 [INFO] [stderr] | [INFO] [stderr] 112 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:123:33 [INFO] [stderr] | [INFO] [stderr] 123 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:124:19 [INFO] [stderr] | [INFO] [stderr] 124 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:125:19 [INFO] [stderr] | [INFO] [stderr] 125 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:126:19 [INFO] [stderr] | [INFO] [stderr] 126 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 135 | | if packet.len() >= MutableNetlinkPacket::minimum_packet_size() { [INFO] [stderr] 136 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 137 | | Some(MutableNetlinkPacket{packet: [INFO] [stderr] 138 | | MutPacketData::Borrowed(packet),}) [INFO] [stderr] 139 | | } else { None } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / pub fn to_immutable<'p>(&'p self) -> NetlinkPacket<'p> { [INFO] [stderr] 153 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 154 | | NetlinkPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 155 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:191:18 [INFO] [stderr] | [INFO] [stderr] 191 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:191:33 [INFO] [stderr] | [INFO] [stderr] 191 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:192:19 [INFO] [stderr] | [INFO] [stderr] 192 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:193:19 [INFO] [stderr] | [INFO] [stderr] 193 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:194:19 [INFO] [stderr] | [INFO] [stderr] 194 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:205:18 [INFO] [stderr] | [INFO] [stderr] 205 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:205:33 [INFO] [stderr] | [INFO] [stderr] 205 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:206:19 [INFO] [stderr] | [INFO] [stderr] 206 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:219:22 [INFO] [stderr] | [INFO] [stderr] 219 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:219:37 [INFO] [stderr] | [INFO] [stderr] 219 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:220:23 [INFO] [stderr] | [INFO] [stderr] 220 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:233:18 [INFO] [stderr] | [INFO] [stderr] 233 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:233:33 [INFO] [stderr] | [INFO] [stderr] 233 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:234:19 [INFO] [stderr] | [INFO] [stderr] 234 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:235:19 [INFO] [stderr] | [INFO] [stderr] 235 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:236:19 [INFO] [stderr] | [INFO] [stderr] 236 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:247:18 [INFO] [stderr] | [INFO] [stderr] 247 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:247:33 [INFO] [stderr] | [INFO] [stderr] 247 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:248:19 [INFO] [stderr] | [INFO] [stderr] 248 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:249:19 [INFO] [stderr] | [INFO] [stderr] 249 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:250:19 [INFO] [stderr] | [INFO] [stderr] 250 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:261:22 [INFO] [stderr] | [INFO] [stderr] 261 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:274:22 [INFO] [stderr] | [INFO] [stderr] 274 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:289:26 [INFO] [stderr] | [INFO] [stderr] 289 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:303:22 [INFO] [stderr] | [INFO] [stderr] 303 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:316:22 [INFO] [stderr] | [INFO] [stderr] 316 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:356:5 [INFO] [stderr] | [INFO] [stderr] 356 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:359:5 [INFO] [stderr] | [INFO] [stderr] 359 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 360 | | let _self = self; [INFO] [stderr] 361 | | let start = 16; [INFO] [stderr] 362 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 366 | | &mut _self.packet[start..end] [INFO] [stderr] 367 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:371:5 [INFO] [stderr] | [INFO] [stderr] 371 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:374:5 [INFO] [stderr] | [INFO] [stderr] 374 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 375 | | let _self = self; [INFO] [stderr] 376 | | let start = 16; [INFO] [stderr] 377 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 381 | | &_self.packet[start..end] [INFO] [stderr] 382 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:386:5 [INFO] [stderr] | [INFO] [stderr] 386 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:389:5 [INFO] [stderr] | [INFO] [stderr] 389 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 390 | | let _self = self; [INFO] [stderr] 391 | | let start = 16; [INFO] [stderr] 392 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 396 | | &_self.packet[start..end] [INFO] [stderr] 397 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:411:12 [INFO] [stderr] | [INFO] [stderr] 411 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:513:5 [INFO] [stderr] | [INFO] [stderr] 513 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 514 | | if packet.len() >= NetlinkErrorPacket::minimum_packet_size() { [INFO] [stderr] 515 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 516 | | Some(NetlinkErrorPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 517 | | } else { None } [INFO] [stderr] 518 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:530:5 [INFO] [stderr] | [INFO] [stderr] 530 | / pub fn to_immutable<'p>(&'p self) -> NetlinkErrorPacket<'p> { [INFO] [stderr] 531 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 532 | | NetlinkErrorPacket{packet: [INFO] [stderr] 533 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 534 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:558:18 [INFO] [stderr] | [INFO] [stderr] 558 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:558:33 [INFO] [stderr] | [INFO] [stderr] 558 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:559:19 [INFO] [stderr] | [INFO] [stderr] 559 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:560:19 [INFO] [stderr] | [INFO] [stderr] 560 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:561:19 [INFO] [stderr] | [INFO] [stderr] 561 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:569:5 [INFO] [stderr] | [INFO] [stderr] 569 | / pub fn new<'p>(packet: &'p mut [u8]) [INFO] [stderr] 570 | | -> Option> { [INFO] [stderr] 571 | | if packet.len() >= MutableNetlinkErrorPacket::minimum_packet_size() { [INFO] [stderr] 572 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] ... | [INFO] [stderr] 575 | | } else { None } [INFO] [stderr] 576 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:590:5 [INFO] [stderr] | [INFO] [stderr] 590 | / pub fn to_immutable<'p>(&'p self) -> NetlinkErrorPacket<'p> { [INFO] [stderr] 591 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 592 | | NetlinkErrorPacket{packet: [INFO] [stderr] 593 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 594 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:626:18 [INFO] [stderr] | [INFO] [stderr] 626 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:626:33 [INFO] [stderr] | [INFO] [stderr] 626 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:627:19 [INFO] [stderr] | [INFO] [stderr] 627 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:628:19 [INFO] [stderr] | [INFO] [stderr] 628 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:629:19 [INFO] [stderr] | [INFO] [stderr] 629 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:640:22 [INFO] [stderr] | [INFO] [stderr] 640 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:673:5 [INFO] [stderr] | [INFO] [stderr] 673 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:676:5 [INFO] [stderr] | [INFO] [stderr] 676 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 677 | | let _self = self; [INFO] [stderr] 678 | | let start = 4; [INFO] [stderr] 679 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 680 | | &mut _self.packet[start..] [INFO] [stderr] 681 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:686:5 [INFO] [stderr] | [INFO] [stderr] 686 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:689:5 [INFO] [stderr] | [INFO] [stderr] 689 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 690 | | let _self = self; [INFO] [stderr] 691 | | let start = 4; [INFO] [stderr] 692 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 693 | | &_self.packet[start..] [INFO] [stderr] 694 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:698:5 [INFO] [stderr] | [INFO] [stderr] 698 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:701:5 [INFO] [stderr] | [INFO] [stderr] 701 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 702 | | let _self = self; [INFO] [stderr] 703 | | let start = 4; [INFO] [stderr] 704 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 705 | | &_self.packet[start..] [INFO] [stderr] 706 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:720:12 [INFO] [stderr] | [INFO] [stderr] 720 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/packet/netlink.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | / loop { [INFO] [stderr] 181 | | if let Some(pkt) = NetlinkPacket::new(&self.buf[self.read_at..]) { [INFO] [stderr] 182 | | let len = ::util::align(pkt.get_length() as usize); [INFO] [stderr] 183 | | if len == 0 { [INFO] [stderr] ... | [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `packet::netlink::NetlinkConnection` [INFO] [stderr] --> src/packet/netlink.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | / pub fn new() -> Self { [INFO] [stderr] 243 | | NetlinkConnection { [INFO] [stderr] 244 | | sock: NetlinkSocket::bind(NetlinkProtocol::Route, 0 as u32).unwrap(), [INFO] [stderr] 245 | | } [INFO] [stderr] 246 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 241 | impl Default for packet::netlink::NetlinkConnection { [INFO] [stderr] 242 | fn default() -> Self { [INFO] [stderr] 243 | Self::new() [INFO] [stderr] 244 | } [INFO] [stderr] 245 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/packet/route/addr.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match self { [INFO] [stderr] 115 | | &IpAddr::V4(ip) => { [INFO] [stderr] 116 | | let mut v = Vec::new(); [INFO] [stderr] 117 | | v.extend_from_slice(&ip.octets()[..]); [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 114 | match *self { [INFO] [stderr] 115 | IpAddr::V4(ip) => { [INFO] [stderr] 116 | let mut v = Vec::new(); [INFO] [stderr] 117 | v.extend_from_slice(&ip.octets()[..]); [INFO] [stderr] 118 | v [INFO] [stderr] 119 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/addr.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/addr.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/packet/route/addr.rs:198:31 [INFO] [stderr] | [INFO] [stderr] 198 | RtAttrPacket::new(&mut rta_buf).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/packet/route/addr.rs:207:31 [INFO] [stderr] | [INFO] [stderr] 207 | RtAttrPacket::new(&mut rta_buf1).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/addr.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | self.write(req.packet()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/packet/route/addr.rs:312:64 [INFO] [stderr] | [INFO] [stderr] 312 | rti.find(|rta| rta.get_rta_type() == rta_type).map(|rta| cb(rta)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `cb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/packet/route/addr.rs:323:17 [INFO] [stderr] | [INFO] [stderr] 323 | &mut ip6addr[..].copy_from_slice(bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ip6addr[..].copy_from_slice(bytes);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/packet/route/addr.rs:358:33 [INFO] [stderr] | [INFO] [stderr] 358 | &mut ip6addr[..].copy_from_slice(rta.payload()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ip6addr[..].copy_from_slice(rta.payload());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/link.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/link.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/link.rs:265:9 [INFO] [stderr] | [INFO] [stderr] 265 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/link.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/link.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/link.rs:316:8 [INFO] [stderr] | [INFO] [stderr] 316 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/link.rs:335:8 [INFO] [stderr] | [INFO] [stderr] 335 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/packet/route/link.rs:432:64 [INFO] [stderr] | [INFO] [stderr] 432 | rti.find(|rta| rta.get_rta_type() == rta_type).map(|rta| cb(rta)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `cb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `packet::route::link::IfInfoPacketBuilder` [INFO] [stderr] --> src/packet/route/link.rs:490:5 [INFO] [stderr] | [INFO] [stderr] 490 | / pub fn new() -> Self { [INFO] [stderr] 491 | | let len = MutableIfInfoPacket::minimum_packet_size(); [INFO] [stderr] 492 | | let data = vec![0; len]; [INFO] [stderr] 493 | | IfInfoPacketBuilder { data: data } [INFO] [stderr] 494 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 485 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variant `LINK_NETNSID` should have a camel case name such as `LinkNetnsid` [INFO] [stderr] --> src/packet/route/neighbour.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | LINK_NETNSID = 10, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/neighbour.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | / write!(f, [INFO] [stderr] 165 | | "{:?}: {:?}, {:?}, {:?}, {:?}", [INFO] [stderr] 166 | | family, [INFO] [stderr] 167 | | self.get_ifindex(), [INFO] [stderr] 168 | | self.get_state(), [INFO] [stderr] 169 | | self.get_flags(), [INFO] [stderr] 170 | | self.get_type()); [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/neighbour.rs:182:25 [INFO] [stderr] | [INFO] [stderr] 182 | write!(f, " lladdr: {:?}", mac_addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/neighbour.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | write!(f, " vlan id: {:?}", rta.payload()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/neighbour.rs:192:33 [INFO] [stderr] | [INFO] [stderr] 192 | write!(f, " {:?}", addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/neighbour.rs:195:33 [INFO] [stderr] | [INFO] [stderr] 195 | write!(f, "unknown address length {:?}", l); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/neighbour.rs:200:25 [INFO] [stderr] | [INFO] [stderr] 200 | write!(f, " unknown attribute {:?}", rta); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/neighbour.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/packet/route/neighbour.rs:380:71 [INFO] [stderr] | [INFO] [stderr] 380 | rti.find(|rta| rta.get_rta_type() == rta_type as u16).map(|rta| cb(rta)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `cb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_links_iter` [INFO] [stderr] --> src/packet/route/link.rs:438:5 [INFO] [stderr] | [INFO] [stderr] 438 | fn get_links_iter(r: NetlinkBufIterator) -> LinksIterator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_neighbours_iter` [INFO] [stderr] --> src/packet/route/neighbour.rs:385:5 [INFO] [stderr] | [INFO] [stderr] 385 | fn get_neighbours_iter(r: NetlinkBufIterator) -> NeighboursIterator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_family` [INFO] [stderr] --> src/packet/route/neighbour.rs:427:5 [INFO] [stderr] | [INFO] [stderr] 427 | pub fn set_family(mut self, family: u8) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_state` [INFO] [stderr] --> src/packet/route/neighbour.rs:443:5 [INFO] [stderr] | [INFO] [stderr] 443 | pub fn set_state(mut self, state: NeighbourState) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_flags` [INFO] [stderr] --> src/packet/route/neighbour.rs:451:5 [INFO] [stderr] | [INFO] [stderr] 451 | pub fn set_flags(mut self, flags: NeighbourFlags) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_type` [INFO] [stderr] --> src/packet/route/neighbour.rs:459:5 [INFO] [stderr] | [INFO] [stderr] 459 | pub fn set_type(mut self, type_: u8) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `RtmType` [INFO] [stderr] --> src/packet/route/route.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | enum RtmType { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/packet/route/route.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | const NOTIFY = 0x100; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(overflowing_literals)] on by default [INFO] [stderr] = note: the literal `0x100` (decimal `256`) does not fit into an `u8` and will become `0u8` [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/packet/route/route.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | const CLONED = 0x200; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the literal `0x200` (decimal `512`) does not fit into an `u8` and will become `0u8` [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/packet/route/route.rs:50:26 [INFO] [stderr] | [INFO] [stderr] 50 | const EQUALIZE = 0x400; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the literal `0x400` (decimal `1024`) does not fit into an `u8` and will become `0u8` [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/packet/route/route.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | const PREFIX = 0x800; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the literal `0x800` (decimal `2048`) does not fit into an `u8` and will become `0u8` [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] warning: variant `Inet_diag` should have a camel case name such as `InetDiag` [INFO] [stderr] --> src/socket.rs:31:2 [INFO] [stderr] | [INFO] [stderr] 31 | Inet_diag = 4, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `IP6_fw` should have a camel case name such as `Ip6Fw` [INFO] [stderr] --> src/socket.rs:40:2 [INFO] [stderr] | [INFO] [stderr] 40 | IP6_fw = 13, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/socket.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | bind(sock.fd, transmute(&mut sockaddr), size_of::() as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut sockaddr as *mut libc::sockaddr_nl as *const libc::sockaddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/socket.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | mem::transmute(&val), mem::size_of::() as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&val as *const i32 as *const libc::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/socket.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | mem::transmute(&mut ffi_val), mem::transmute(&mut opt_len)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut ffi_val as *mut i32 as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/socket.rs:151:39 [INFO] [stderr] | [INFO] [stderr] 151 | mem::transmute(&mut ffi_val), mem::transmute(&mut opt_len)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut opt_len as *mut i32 as *mut u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 24 | | if packet.len() >= NetlinkPacket::minimum_packet_size() { [INFO] [stderr] 25 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 26 | | Some(NetlinkPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 27 | | } else { None } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn to_immutable<'p>(&'p self) -> NetlinkPacket<'p> { [INFO] [stderr] 41 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 42 | | NetlinkPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/packet/route/route.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | / match self { [INFO] [stderr] 195 | | &IpAddr::V4(ip) => { [INFO] [stderr] 196 | | payload.copy_from_slice(&ip.octets()); [INFO] [stderr] 197 | | } [INFO] [stderr] ... | [INFO] [stderr] 200 | | } [INFO] [stderr] 201 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 194 | match *self { [INFO] [stderr] 195 | IpAddr::V4(ip) => { [INFO] [stderr] 196 | payload.copy_from_slice(&ip.octets()); [INFO] [stderr] 197 | } [INFO] [stderr] 198 | IpAddr::V6(ip) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/packet/route/route.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | / match self { [INFO] [stderr] 206 | | &IpAddr::V4(_) => 4, [INFO] [stderr] 207 | | &IpAddr::V6(_) => 16, [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 205 | match *self { [INFO] [stderr] 206 | IpAddr::V4(_) => 4, [INFO] [stderr] 207 | IpAddr::V6(_) => 16, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:67:33 [INFO] [stderr] | [INFO] [stderr] 67 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:69:19 [INFO] [stderr] | [INFO] [stderr] 69 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:70:19 [INFO] [stderr] | [INFO] [stderr] 70 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:81:33 [INFO] [stderr] | [INFO] [stderr] 81 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:82:19 [INFO] [stderr] | [INFO] [stderr] 82 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/packet/route/route.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | self.as_ref().map(|d| d.payload_add(payload)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(d) = self.as_ref() { d.payload_add(payload) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:95:22 [INFO] [stderr] | [INFO] [stderr] 95 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:95:37 [INFO] [stderr] | [INFO] [stderr] 95 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:96:23 [INFO] [stderr] | [INFO] [stderr] 96 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:109:18 [INFO] [stderr] | [INFO] [stderr] 109 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:109:33 [INFO] [stderr] | [INFO] [stderr] 109 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:110:19 [INFO] [stderr] | [INFO] [stderr] 110 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:111:19 [INFO] [stderr] | [INFO] [stderr] 111 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:112:19 [INFO] [stderr] | [INFO] [stderr] 112 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:123:33 [INFO] [stderr] | [INFO] [stderr] 123 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:124:19 [INFO] [stderr] | [INFO] [stderr] 124 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:125:19 [INFO] [stderr] | [INFO] [stderr] 125 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:126:19 [INFO] [stderr] | [INFO] [stderr] 126 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 135 | | if packet.len() >= MutableNetlinkPacket::minimum_packet_size() { [INFO] [stderr] 136 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 137 | | Some(MutableNetlinkPacket{packet: [INFO] [stderr] 138 | | MutPacketData::Borrowed(packet),}) [INFO] [stderr] 139 | | } else { None } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / pub fn to_immutable<'p>(&'p self) -> NetlinkPacket<'p> { [INFO] [stderr] 153 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 154 | | NetlinkPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 155 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:191:18 [INFO] [stderr] | [INFO] [stderr] 191 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:191:33 [INFO] [stderr] | [INFO] [stderr] 191 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:192:19 [INFO] [stderr] | [INFO] [stderr] 192 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:193:19 [INFO] [stderr] | [INFO] [stderr] 193 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:194:19 [INFO] [stderr] | [INFO] [stderr] 194 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:205:18 [INFO] [stderr] | [INFO] [stderr] 205 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:205:33 [INFO] [stderr] | [INFO] [stderr] 205 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:206:19 [INFO] [stderr] | [INFO] [stderr] 206 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:219:22 [INFO] [stderr] | [INFO] [stderr] 219 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:219:37 [INFO] [stderr] | [INFO] [stderr] 219 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:220:23 [INFO] [stderr] | [INFO] [stderr] 220 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:233:18 [INFO] [stderr] | [INFO] [stderr] 233 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:233:33 [INFO] [stderr] | [INFO] [stderr] 233 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:234:19 [INFO] [stderr] | [INFO] [stderr] 234 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:235:19 [INFO] [stderr] | [INFO] [stderr] 235 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:236:19 [INFO] [stderr] | [INFO] [stderr] 236 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:247:18 [INFO] [stderr] | [INFO] [stderr] 247 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:247:33 [INFO] [stderr] | [INFO] [stderr] 247 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:248:19 [INFO] [stderr] | [INFO] [stderr] 248 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:249:19 [INFO] [stderr] | [INFO] [stderr] 249 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:250:19 [INFO] [stderr] | [INFO] [stderr] 250 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:261:22 [INFO] [stderr] | [INFO] [stderr] 261 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:274:22 [INFO] [stderr] | [INFO] [stderr] 274 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:289:26 [INFO] [stderr] | [INFO] [stderr] 289 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:303:22 [INFO] [stderr] | [INFO] [stderr] 303 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] | [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 49 | | if packet.len() >= IfInfoPacket::minimum_packet_size() { [INFO] [stderr] 50 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 51 | | Some(IfInfoPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 52 | | } else { None } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:316:22 [INFO] [stderr] | [INFO] [stderr] 316 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn to_immutable<'p>(&'p self) -> IfInfoPacket<'p> { [INFO] [stderr] 66 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 67 | | IfInfoPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: method `get__pad` should have a snake case name such as `get_pad` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / pub fn get__pad(&self) -> u8 { [INFO] [stderr] 98 | | let _self = self; [INFO] [stderr] 99 | | let co = 1; [INFO] [stderr] 100 | | (_self.packet[co] as u8) [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:356:5 [INFO] [stderr] | [INFO] [stderr] 356 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:359:5 [INFO] [stderr] | [INFO] [stderr] 359 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 360 | | let _self = self; [INFO] [stderr] 361 | | let start = 16; [INFO] [stderr] 362 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 366 | | &mut _self.packet[start..end] [INFO] [stderr] 367 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:112:22 [INFO] [stderr] | [INFO] [stderr] 112 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:112:37 [INFO] [stderr] | [INFO] [stderr] 112 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:113:23 [INFO] [stderr] | [INFO] [stderr] 113 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:126:18 [INFO] [stderr] | [INFO] [stderr] 126 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:126:33 [INFO] [stderr] | [INFO] [stderr] 126 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:371:5 [INFO] [stderr] | [INFO] [stderr] 371 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:127:19 [INFO] [stderr] | [INFO] [stderr] 127 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:374:5 [INFO] [stderr] | [INFO] [stderr] 374 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 375 | | let _self = self; [INFO] [stderr] 376 | | let start = 16; [INFO] [stderr] 377 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 381 | | &_self.packet[start..end] [INFO] [stderr] 382 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:128:19 [INFO] [stderr] | [INFO] [stderr] 128 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:129:19 [INFO] [stderr] | [INFO] [stderr] 129 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:386:5 [INFO] [stderr] | [INFO] [stderr] 386 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:389:5 [INFO] [stderr] | [INFO] [stderr] 389 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 390 | | let _self = self; [INFO] [stderr] 391 | | let start = 16; [INFO] [stderr] 392 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 396 | | &_self.packet[start..end] [INFO] [stderr] 397 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:142:22 [INFO] [stderr] | [INFO] [stderr] 142 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:142:37 [INFO] [stderr] | [INFO] [stderr] 142 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:143:23 [INFO] [stderr] | [INFO] [stderr] 143 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:144:23 [INFO] [stderr] | [INFO] [stderr] 144 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:145:23 [INFO] [stderr] | [INFO] [stderr] 145 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:411:12 [INFO] [stderr] | [INFO] [stderr] 411 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:158:18 [INFO] [stderr] | [INFO] [stderr] 158 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:158:33 [INFO] [stderr] | [INFO] [stderr] 158 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:159:19 [INFO] [stderr] | [INFO] [stderr] 159 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:160:19 [INFO] [stderr] | [INFO] [stderr] 160 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:161:19 [INFO] [stderr] | [INFO] [stderr] 161 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 170 | | if packet.len() >= MutableIfInfoPacket::minimum_packet_size() { [INFO] [stderr] 171 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 172 | | Some(MutableIfInfoPacket{packet: [INFO] [stderr] 173 | | MutPacketData::Borrowed(packet),}) [INFO] [stderr] 174 | | } else { None } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | / pub fn to_immutable<'p>(&'p self) -> IfInfoPacket<'p> { [INFO] [stderr] 188 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 189 | | IfInfoPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 190 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: method `get__pad` should have a snake case name such as `get_pad` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | / pub fn get__pad(&self) -> u8 { [INFO] [stderr] 233 | | let _self = self; [INFO] [stderr] 234 | | let co = 1; [INFO] [stderr] 235 | | (_self.packet[co] as u8) [INFO] [stderr] 236 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:247:22 [INFO] [stderr] | [INFO] [stderr] 247 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:247:37 [INFO] [stderr] | [INFO] [stderr] 247 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:248:23 [INFO] [stderr] | [INFO] [stderr] 248 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:261:18 [INFO] [stderr] | [INFO] [stderr] 261 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:261:33 [INFO] [stderr] | [INFO] [stderr] 261 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:262:19 [INFO] [stderr] | [INFO] [stderr] 262 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:263:19 [INFO] [stderr] | [INFO] [stderr] 263 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:264:19 [INFO] [stderr] | [INFO] [stderr] 264 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:277:22 [INFO] [stderr] | [INFO] [stderr] 277 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:277:37 [INFO] [stderr] | [INFO] [stderr] 277 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:278:23 [INFO] [stderr] | [INFO] [stderr] 278 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:279:23 [INFO] [stderr] | [INFO] [stderr] 279 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:280:23 [INFO] [stderr] | [INFO] [stderr] 280 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:293:18 [INFO] [stderr] | [INFO] [stderr] 293 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:293:33 [INFO] [stderr] | [INFO] [stderr] 293 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:294:19 [INFO] [stderr] | [INFO] [stderr] 294 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:295:19 [INFO] [stderr] | [INFO] [stderr] 295 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:296:19 [INFO] [stderr] | [INFO] [stderr] 296 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:306:22 [INFO] [stderr] | [INFO] [stderr] 306 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: method `set__pad` should have a snake case name such as `set_pad` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:312:5 [INFO] [stderr] | [INFO] [stderr] 312 | / pub fn set__pad(&mut self, val: u8) { [INFO] [stderr] 313 | | let _self = self; [INFO] [stderr] 314 | | let co = 1; [INFO] [stderr] 315 | | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:315:22 [INFO] [stderr] | [INFO] [stderr] 315 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:329:26 [INFO] [stderr] | [INFO] [stderr] 329 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:513:5 [INFO] [stderr] | [INFO] [stderr] 513 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 514 | | if packet.len() >= NetlinkErrorPacket::minimum_packet_size() { [INFO] [stderr] 515 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 516 | | Some(NetlinkErrorPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 517 | | } else { None } [INFO] [stderr] 518 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:343:22 [INFO] [stderr] | [INFO] [stderr] 343 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:530:5 [INFO] [stderr] | [INFO] [stderr] 530 | / pub fn to_immutable<'p>(&'p self) -> NetlinkErrorPacket<'p> { [INFO] [stderr] 531 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 532 | | NetlinkErrorPacket{packet: [INFO] [stderr] 533 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 534 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:360:26 [INFO] [stderr] | [INFO] [stderr] 360 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:376:22 [INFO] [stderr] | [INFO] [stderr] 376 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:558:18 [INFO] [stderr] | [INFO] [stderr] 558 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:558:33 [INFO] [stderr] | [INFO] [stderr] 558 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:559:19 [INFO] [stderr] | [INFO] [stderr] 559 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:560:19 [INFO] [stderr] | [INFO] [stderr] 560 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:561:19 [INFO] [stderr] | [INFO] [stderr] 561 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:569:5 [INFO] [stderr] | [INFO] [stderr] 569 | / pub fn new<'p>(packet: &'p mut [u8]) [INFO] [stderr] 570 | | -> Option> { [INFO] [stderr] 571 | | if packet.len() >= MutableNetlinkErrorPacket::minimum_packet_size() { [INFO] [stderr] 572 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] ... | [INFO] [stderr] 575 | | } else { None } [INFO] [stderr] 576 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:408:5 [INFO] [stderr] | [INFO] [stderr] 408 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:411:5 [INFO] [stderr] | [INFO] [stderr] 411 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 412 | | let _self = self; [INFO] [stderr] 413 | | let start = 16; [INFO] [stderr] 414 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 415 | | &mut _self.packet[start..] [INFO] [stderr] 416 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:420:5 [INFO] [stderr] | [INFO] [stderr] 420 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:590:5 [INFO] [stderr] | [INFO] [stderr] 590 | / pub fn to_immutable<'p>(&'p self) -> NetlinkErrorPacket<'p> { [INFO] [stderr] 591 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 592 | | NetlinkErrorPacket{packet: [INFO] [stderr] 593 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 594 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:423:5 [INFO] [stderr] | [INFO] [stderr] 423 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 424 | | let _self = self; [INFO] [stderr] 425 | | let start = 16; [INFO] [stderr] 426 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 427 | | &_self.packet[start..] [INFO] [stderr] 428 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:432:5 [INFO] [stderr] | [INFO] [stderr] 432 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:435:5 [INFO] [stderr] | [INFO] [stderr] 435 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 436 | | let _self = self; [INFO] [stderr] 437 | | let start = 16; [INFO] [stderr] 438 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 439 | | &_self.packet[start..] [INFO] [stderr] 440 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:626:18 [INFO] [stderr] | [INFO] [stderr] 626 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:626:33 [INFO] [stderr] | [INFO] [stderr] 626 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:454:12 [INFO] [stderr] | [INFO] [stderr] 454 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:627:19 [INFO] [stderr] | [INFO] [stderr] 627 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:628:19 [INFO] [stderr] | [INFO] [stderr] 628 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:629:19 [INFO] [stderr] | [INFO] [stderr] 629 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:640:22 [INFO] [stderr] | [INFO] [stderr] 640 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:673:5 [INFO] [stderr] | [INFO] [stderr] 673 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:676:5 [INFO] [stderr] | [INFO] [stderr] 676 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 677 | | let _self = self; [INFO] [stderr] 678 | | let start = 4; [INFO] [stderr] 679 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 680 | | &mut _self.packet[start..] [INFO] [stderr] 681 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:686:5 [INFO] [stderr] | [INFO] [stderr] 686 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:689:5 [INFO] [stderr] | [INFO] [stderr] 689 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 690 | | let _self = self; [INFO] [stderr] 691 | | let start = 4; [INFO] [stderr] 692 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 693 | | &_self.packet[start..] [INFO] [stderr] 694 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:698:5 [INFO] [stderr] | [INFO] [stderr] 698 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:701:5 [INFO] [stderr] | [INFO] [stderr] 701 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 702 | | let _self = self; [INFO] [stderr] 703 | | let start = 4; [INFO] [stderr] 704 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 705 | | &_self.packet[start..] [INFO] [stderr] 706 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/netlink.rs:720:12 [INFO] [stderr] | [INFO] [stderr] 720 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:595:5 [INFO] [stderr] | [INFO] [stderr] 595 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 596 | | if packet.len() >= IfAddrPacket::minimum_packet_size() { [INFO] [stderr] 597 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 598 | | Some(IfAddrPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 599 | | } else { None } [INFO] [stderr] 600 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:612:5 [INFO] [stderr] | [INFO] [stderr] 612 | / pub fn to_immutable<'p>(&'p self) -> IfAddrPacket<'p> { [INFO] [stderr] 613 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 614 | | IfAddrPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 615 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:685:18 [INFO] [stderr] | [INFO] [stderr] 685 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:685:33 [INFO] [stderr] | [INFO] [stderr] 685 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:686:19 [INFO] [stderr] | [INFO] [stderr] 686 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:687:19 [INFO] [stderr] | [INFO] [stderr] 687 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:688:19 [INFO] [stderr] | [INFO] [stderr] 688 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:696:5 [INFO] [stderr] | [INFO] [stderr] 696 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 697 | | if packet.len() >= MutableIfAddrPacket::minimum_packet_size() { [INFO] [stderr] 698 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 699 | | Some(MutableIfAddrPacket{packet: [INFO] [stderr] 700 | | MutPacketData::Borrowed(packet),}) [INFO] [stderr] 701 | | } else { None } [INFO] [stderr] 702 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:714:5 [INFO] [stderr] | [INFO] [stderr] 714 | / pub fn to_immutable<'p>(&'p self) -> IfAddrPacket<'p> { [INFO] [stderr] 715 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 716 | | IfAddrPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 717 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:799:18 [INFO] [stderr] | [INFO] [stderr] 799 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:799:33 [INFO] [stderr] | [INFO] [stderr] 799 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:800:19 [INFO] [stderr] | [INFO] [stderr] 800 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:801:19 [INFO] [stderr] | [INFO] [stderr] 801 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:802:19 [INFO] [stderr] | [INFO] [stderr] 802 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:812:22 [INFO] [stderr] | [INFO] [stderr] 812 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:821:22 [INFO] [stderr] | [INFO] [stderr] 821 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:835:26 [INFO] [stderr] | [INFO] [stderr] 835 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:852:26 [INFO] [stderr] | [INFO] [stderr] 852 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:865:22 [INFO] [stderr] | [INFO] [stderr] 865 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:897:5 [INFO] [stderr] | [INFO] [stderr] 897 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:900:5 [INFO] [stderr] | [INFO] [stderr] 900 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 901 | | let _self = self; [INFO] [stderr] 902 | | let start = 8; [INFO] [stderr] 903 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 904 | | &mut _self.packet[start..] [INFO] [stderr] 905 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:909:5 [INFO] [stderr] | [INFO] [stderr] 909 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:912:5 [INFO] [stderr] | [INFO] [stderr] 912 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 913 | | let _self = self; [INFO] [stderr] 914 | | let start = 8; [INFO] [stderr] 915 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 916 | | &_self.packet[start..] [INFO] [stderr] 917 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:921:5 [INFO] [stderr] | [INFO] [stderr] 921 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:924:5 [INFO] [stderr] | [INFO] [stderr] 924 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 925 | | let _self = self; [INFO] [stderr] 926 | | let start = 8; [INFO] [stderr] 927 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 928 | | &_self.packet[start..] [INFO] [stderr] 929 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:943:12 [INFO] [stderr] | [INFO] [stderr] 943 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1047:5 [INFO] [stderr] | [INFO] [stderr] 1047 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 1048 | | if packet.len() >= IfAddrCacheInfoPacket::minimum_packet_size() { [INFO] [stderr] 1049 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1050 | | Some(IfAddrCacheInfoPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 1051 | | } else { None } [INFO] [stderr] 1052 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1064:5 [INFO] [stderr] | [INFO] [stderr] 1064 | / pub fn to_immutable<'p>(&'p self) -> IfAddrCacheInfoPacket<'p> { [INFO] [stderr] 1065 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1066 | | IfAddrCacheInfoPacket{packet: [INFO] [stderr] 1067 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 1068 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1092:18 [INFO] [stderr] | [INFO] [stderr] 1092 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1092:33 [INFO] [stderr] | [INFO] [stderr] 1092 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1093:19 [INFO] [stderr] | [INFO] [stderr] 1093 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1094:19 [INFO] [stderr] | [INFO] [stderr] 1094 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1095:19 [INFO] [stderr] | [INFO] [stderr] 1095 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1106:18 [INFO] [stderr] | [INFO] [stderr] 1106 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1106:33 [INFO] [stderr] | [INFO] [stderr] 1106 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1107:19 [INFO] [stderr] | [INFO] [stderr] 1107 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1108:19 [INFO] [stderr] | [INFO] [stderr] 1108 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1109:19 [INFO] [stderr] | [INFO] [stderr] 1109 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1120:18 [INFO] [stderr] | [INFO] [stderr] 1120 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1120:33 [INFO] [stderr] | [INFO] [stderr] 1120 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1121:19 [INFO] [stderr] | [INFO] [stderr] 1121 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1122:19 [INFO] [stderr] | [INFO] [stderr] 1122 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1123:19 [INFO] [stderr] | [INFO] [stderr] 1123 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1134:18 [INFO] [stderr] | [INFO] [stderr] 1134 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1134:33 [INFO] [stderr] | [INFO] [stderr] 1134 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1135:19 [INFO] [stderr] | [INFO] [stderr] 1135 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1136:19 [INFO] [stderr] | [INFO] [stderr] 1136 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1137:19 [INFO] [stderr] | [INFO] [stderr] 1137 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1145:5 [INFO] [stderr] | [INFO] [stderr] 1145 | / pub fn new<'p>(packet: &'p mut [u8]) [INFO] [stderr] 1146 | | -> Option> { [INFO] [stderr] 1147 | | if packet.len() >= MutableIfAddrCacheInfoPacket::minimum_packet_size() [INFO] [stderr] 1148 | | { [INFO] [stderr] ... | [INFO] [stderr] 1152 | | } else { None } [INFO] [stderr] 1153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1168:5 [INFO] [stderr] | [INFO] [stderr] 1168 | / pub fn to_immutable<'p>(&'p self) -> IfAddrCacheInfoPacket<'p> { [INFO] [stderr] 1169 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1170 | | IfAddrCacheInfoPacket{packet: [INFO] [stderr] 1171 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 1172 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1207:18 [INFO] [stderr] | [INFO] [stderr] 1207 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1207:33 [INFO] [stderr] | [INFO] [stderr] 1207 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1208:19 [INFO] [stderr] | [INFO] [stderr] 1208 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1209:19 [INFO] [stderr] | [INFO] [stderr] 1209 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1210:19 [INFO] [stderr] | [INFO] [stderr] 1210 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1221:18 [INFO] [stderr] | [INFO] [stderr] 1221 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1221:33 [INFO] [stderr] | [INFO] [stderr] 1221 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1222:19 [INFO] [stderr] | [INFO] [stderr] 1222 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1223:19 [INFO] [stderr] | [INFO] [stderr] 1223 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1224:19 [INFO] [stderr] | [INFO] [stderr] 1224 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1235:18 [INFO] [stderr] | [INFO] [stderr] 1235 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1235:33 [INFO] [stderr] | [INFO] [stderr] 1235 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1236:19 [INFO] [stderr] | [INFO] [stderr] 1236 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1237:19 [INFO] [stderr] | [INFO] [stderr] 1237 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1238:19 [INFO] [stderr] | [INFO] [stderr] 1238 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1249:18 [INFO] [stderr] | [INFO] [stderr] 1249 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1249:33 [INFO] [stderr] | [INFO] [stderr] 1249 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1250:19 [INFO] [stderr] | [INFO] [stderr] 1250 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1251:19 [INFO] [stderr] | [INFO] [stderr] 1251 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1252:19 [INFO] [stderr] | [INFO] [stderr] 1252 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1263:22 [INFO] [stderr] | [INFO] [stderr] 1263 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1276:22 [INFO] [stderr] | [INFO] [stderr] 1276 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1289:22 [INFO] [stderr] | [INFO] [stderr] 1289 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1302:22 [INFO] [stderr] | [INFO] [stderr] 1302 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `16` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1327:56 [INFO] [stderr] | [INFO] [stderr] 1327 | fn packet_size(&self) -> usize { let _self = self; 16 + 0 } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `16` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1332:56 [INFO] [stderr] | [INFO] [stderr] 1332 | fn packet_size(&self) -> usize { let _self = self; 16 + 0 } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1337:5 [INFO] [stderr] | [INFO] [stderr] 1337 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1340:5 [INFO] [stderr] | [INFO] [stderr] 1340 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 1341 | | let _self = self; [INFO] [stderr] 1342 | | let start = 16; [INFO] [stderr] 1343 | | let end = ::std::cmp::min(16 + 0, _self.packet.len()); [INFO] [stderr] 1344 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 1345 | | &mut _self.packet[start..end] [INFO] [stderr] 1346 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `16` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1343:35 [INFO] [stderr] | [INFO] [stderr] 1343 | let end = ::std::cmp::min(16 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1351:5 [INFO] [stderr] | [INFO] [stderr] 1351 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1354:5 [INFO] [stderr] | [INFO] [stderr] 1354 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1355 | | let _self = self; [INFO] [stderr] 1356 | | let start = 16; [INFO] [stderr] 1357 | | let end = ::std::cmp::min(16 + 0, _self.packet.len()); [INFO] [stderr] 1358 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 1359 | | &_self.packet[start..end] [INFO] [stderr] 1360 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `16` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1357:35 [INFO] [stderr] | [INFO] [stderr] 1357 | let end = ::std::cmp::min(16 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1365:5 [INFO] [stderr] | [INFO] [stderr] 1365 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1368:5 [INFO] [stderr] | [INFO] [stderr] 1368 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1369 | | let _self = self; [INFO] [stderr] 1370 | | let start = 16; [INFO] [stderr] 1371 | | let end = ::std::cmp::min(16 + 0, _self.packet.len()); [INFO] [stderr] 1372 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 1373 | | &_self.packet[start..end] [INFO] [stderr] 1374 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `16` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1371:35 [INFO] [stderr] | [INFO] [stderr] 1371 | let end = ::std::cmp::min(16 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1388:12 [INFO] [stderr] | [INFO] [stderr] 1388 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1490:5 [INFO] [stderr] | [INFO] [stderr] 1490 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 1491 | | if packet.len() >= NeighbourDiscoveryPacket::minimum_packet_size() { [INFO] [stderr] 1492 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1493 | | Some(NeighbourDiscoveryPacket{packet: [INFO] [stderr] 1494 | | PacketData::Borrowed(packet),}) [INFO] [stderr] 1495 | | } else { None } [INFO] [stderr] 1496 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1509:5 [INFO] [stderr] | [INFO] [stderr] 1509 | / pub fn to_immutable<'p>(&'p self) -> NeighbourDiscoveryPacket<'p> { [INFO] [stderr] 1510 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1511 | | NeighbourDiscoveryPacket{packet: [INFO] [stderr] 1512 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 1513 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1555:18 [INFO] [stderr] | [INFO] [stderr] 1555 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1555:33 [INFO] [stderr] | [INFO] [stderr] 1555 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1556:19 [INFO] [stderr] | [INFO] [stderr] 1556 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1567:18 [INFO] [stderr] | [INFO] [stderr] 1567 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1567:33 [INFO] [stderr] | [INFO] [stderr] 1567 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1568:19 [INFO] [stderr] | [INFO] [stderr] 1568 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1569:19 [INFO] [stderr] | [INFO] [stderr] 1569 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1570:19 [INFO] [stderr] | [INFO] [stderr] 1570 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1583:22 [INFO] [stderr] | [INFO] [stderr] 1583 | let b0 = ((_self.packet[co + 0] as u16le)) as u16le; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1583:37 [INFO] [stderr] | [INFO] [stderr] 1583 | let b0 = ((_self.packet[co + 0] as u16le)) as u16le; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1584:23 [INFO] [stderr] | [INFO] [stderr] 1584 | let b1 = ((_self.packet[co + 1] as u16le) << 8) as u16le; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1617:5 [INFO] [stderr] | [INFO] [stderr] 1617 | / pub fn new<'p>(packet: &'p mut [u8]) [INFO] [stderr] 1618 | | -> Option> { [INFO] [stderr] 1619 | | if packet.len() >= [INFO] [stderr] 1620 | | MutableNeighbourDiscoveryPacket::minimum_packet_size() { [INFO] [stderr] ... | [INFO] [stderr] 1624 | | } else { None } [INFO] [stderr] 1625 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1640:5 [INFO] [stderr] | [INFO] [stderr] 1640 | / pub fn to_immutable<'p>(&'p self) -> NeighbourDiscoveryPacket<'p> { [INFO] [stderr] 1641 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1642 | | NeighbourDiscoveryPacket{packet: [INFO] [stderr] 1643 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 1644 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/packet/netlink.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | / loop { [INFO] [stderr] 181 | | if let Some(pkt) = NetlinkPacket::new(&self.buf[self.read_at..]) { [INFO] [stderr] 182 | | let len = ::util::align(pkt.get_length() as usize); [INFO] [stderr] 183 | | if len == 0 { [INFO] [stderr] ... | [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `packet::netlink::NetlinkConnection` [INFO] [stderr] --> src/packet/netlink.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | / pub fn new() -> Self { [INFO] [stderr] 243 | | NetlinkConnection { [INFO] [stderr] 244 | | sock: NetlinkSocket::bind(NetlinkProtocol::Route, 0 as u32).unwrap(), [INFO] [stderr] 245 | | } [INFO] [stderr] 246 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 241 | impl Default for packet::netlink::NetlinkConnection { [INFO] [stderr] 242 | fn default() -> Self { [INFO] [stderr] 243 | Self::new() [INFO] [stderr] 244 | } [INFO] [stderr] 245 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1700:18 [INFO] [stderr] | [INFO] [stderr] 1700 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1700:33 [INFO] [stderr] | [INFO] [stderr] 1700 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1701:19 [INFO] [stderr] | [INFO] [stderr] 1701 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1712:18 [INFO] [stderr] | [INFO] [stderr] 1712 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1712:33 [INFO] [stderr] | [INFO] [stderr] 1712 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1713:19 [INFO] [stderr] | [INFO] [stderr] 1713 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1714:19 [INFO] [stderr] | [INFO] [stderr] 1714 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1715:19 [INFO] [stderr] | [INFO] [stderr] 1715 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1728:22 [INFO] [stderr] | [INFO] [stderr] 1728 | let b0 = ((_self.packet[co + 0] as u16le)) as u16le; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1728:37 [INFO] [stderr] | [INFO] [stderr] 1728 | let b0 = ((_self.packet[co + 0] as u16le)) as u16le; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1729:23 [INFO] [stderr] | [INFO] [stderr] 1729 | let b1 = ((_self.packet[co + 1] as u16le) << 8) as u16le; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1764:22 [INFO] [stderr] | [INFO] [stderr] 1764 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1773:22 [INFO] [stderr] | [INFO] [stderr] 1773 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1783:22 [INFO] [stderr] | [INFO] [stderr] 1783 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1794:22 [INFO] [stderr] | [INFO] [stderr] 1794 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1811:26 [INFO] [stderr] | [INFO] [stderr] 1811 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1829:26 [INFO] [stderr] | [INFO] [stderr] 1829 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1841:22 [INFO] [stderr] | [INFO] [stderr] 1841 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1871:5 [INFO] [stderr] | [INFO] [stderr] 1871 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1874:5 [INFO] [stderr] | [INFO] [stderr] 1874 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 1875 | | let _self = self; [INFO] [stderr] 1876 | | let start = 12; [INFO] [stderr] 1877 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 1878 | | &mut _self.packet[start..] [INFO] [stderr] 1879 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1884:5 [INFO] [stderr] | [INFO] [stderr] 1884 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1887:5 [INFO] [stderr] | [INFO] [stderr] 1887 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1888 | | let _self = self; [INFO] [stderr] 1889 | | let start = 12; [INFO] [stderr] 1890 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 1891 | | &_self.packet[start..] [INFO] [stderr] 1892 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1897:5 [INFO] [stderr] | [INFO] [stderr] 1897 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1900:5 [INFO] [stderr] | [INFO] [stderr] 1900 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1901 | | let _self = self; [INFO] [stderr] 1902 | | let start = 12; [INFO] [stderr] 1903 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 1904 | | &_self.packet[start..] [INFO] [stderr] 1905 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:1919:12 [INFO] [stderr] | [INFO] [stderr] 1919 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2046:5 [INFO] [stderr] | [INFO] [stderr] 2046 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 2047 | | if packet.len() >= RtMsgPacket::minimum_packet_size() { [INFO] [stderr] 2048 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 2049 | | Some(RtMsgPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 2050 | | } else { None } [INFO] [stderr] 2051 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2063:5 [INFO] [stderr] | [INFO] [stderr] 2063 | / pub fn to_immutable<'p>(&'p self) -> RtMsgPacket<'p> { [INFO] [stderr] 2064 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 2065 | | RtMsgPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 2066 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2158:18 [INFO] [stderr] | [INFO] [stderr] 2158 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2158:33 [INFO] [stderr] | [INFO] [stderr] 2158 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2159:19 [INFO] [stderr] | [INFO] [stderr] 2159 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2160:19 [INFO] [stderr] | [INFO] [stderr] 2160 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2161:19 [INFO] [stderr] | [INFO] [stderr] 2161 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method `get__padding` should have a snake case name such as `get_padding` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2168:5 [INFO] [stderr] | [INFO] [stderr] 2168 | / pub fn get__padding(&self) -> u8 { [INFO] [stderr] 2169 | | let _self = self; [INFO] [stderr] 2170 | | let co = 11; [INFO] [stderr] 2171 | | (_self.packet[co] as u8) [INFO] [stderr] 2172 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2178:5 [INFO] [stderr] | [INFO] [stderr] 2178 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 2179 | | if packet.len() >= MutableRtMsgPacket::minimum_packet_size() { [INFO] [stderr] 2180 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 2181 | | Some(MutableRtMsgPacket{packet: MutPacketData::Borrowed(packet),}) [INFO] [stderr] 2182 | | } else { None } [INFO] [stderr] 2183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2195:5 [INFO] [stderr] | [INFO] [stderr] 2195 | / pub fn to_immutable<'p>(&'p self) -> RtMsgPacket<'p> { [INFO] [stderr] 2196 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 2197 | | RtMsgPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 2198 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2306:18 [INFO] [stderr] | [INFO] [stderr] 2306 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2306:33 [INFO] [stderr] | [INFO] [stderr] 2306 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2307:19 [INFO] [stderr] | [INFO] [stderr] 2307 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2308:19 [INFO] [stderr] | [INFO] [stderr] 2308 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2309:19 [INFO] [stderr] | [INFO] [stderr] 2309 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method `get__padding` should have a snake case name such as `get_padding` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2316:5 [INFO] [stderr] | [INFO] [stderr] 2316 | / pub fn get__padding(&self) -> u8 { [INFO] [stderr] 2317 | | let _self = self; [INFO] [stderr] 2318 | | let co = 11; [INFO] [stderr] 2319 | | (_self.packet[co] as u8) [INFO] [stderr] 2320 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2328:22 [INFO] [stderr] | [INFO] [stderr] 2328 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2337:22 [INFO] [stderr] | [INFO] [stderr] 2337 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2346:22 [INFO] [stderr] | [INFO] [stderr] 2346 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2355:22 [INFO] [stderr] | [INFO] [stderr] 2355 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2364:22 [INFO] [stderr] | [INFO] [stderr] 2364 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2373:22 [INFO] [stderr] | [INFO] [stderr] 2373 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2387:26 [INFO] [stderr] | [INFO] [stderr] 2387 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2400:22 [INFO] [stderr] | [INFO] [stderr] 2400 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: method `set__padding` should have a snake case name such as `set_padding` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2409:5 [INFO] [stderr] | [INFO] [stderr] 2409 | / pub fn set__padding(&mut self, val: u8) { [INFO] [stderr] 2410 | | let _self = self; [INFO] [stderr] 2411 | | let co = 11; [INFO] [stderr] 2412 | | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] 2413 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2412:22 [INFO] [stderr] | [INFO] [stderr] 2412 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2441:5 [INFO] [stderr] | [INFO] [stderr] 2441 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2444:5 [INFO] [stderr] | [INFO] [stderr] 2444 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 2445 | | let _self = self; [INFO] [stderr] 2446 | | let start = 12; [INFO] [stderr] 2447 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 2448 | | &mut _self.packet[start..] [INFO] [stderr] 2449 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2453:5 [INFO] [stderr] | [INFO] [stderr] 2453 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2456:5 [INFO] [stderr] | [INFO] [stderr] 2456 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 2457 | | let _self = self; [INFO] [stderr] 2458 | | let start = 12; [INFO] [stderr] 2459 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 2460 | | &_self.packet[start..] [INFO] [stderr] 2461 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2465:5 [INFO] [stderr] | [INFO] [stderr] 2465 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2468:5 [INFO] [stderr] | [INFO] [stderr] 2468 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 2469 | | let _self = self; [INFO] [stderr] 2470 | | let start = 12; [INFO] [stderr] 2471 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 2472 | | &_self.packet[start..] [INFO] [stderr] 2473 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2487:12 [INFO] [stderr] | [INFO] [stderr] 2487 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2607:5 [INFO] [stderr] | [INFO] [stderr] 2607 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 2608 | | if packet.len() >= RouteCacheInfoPacket::minimum_packet_size() { [INFO] [stderr] 2609 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 2610 | | Some(RouteCacheInfoPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 2611 | | } else { None } [INFO] [stderr] 2612 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2624:5 [INFO] [stderr] | [INFO] [stderr] 2624 | / pub fn to_immutable<'p>(&'p self) -> RouteCacheInfoPacket<'p> { [INFO] [stderr] 2625 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 2626 | | RouteCacheInfoPacket{packet: [INFO] [stderr] 2627 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 2628 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2652:18 [INFO] [stderr] | [INFO] [stderr] 2652 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2652:33 [INFO] [stderr] | [INFO] [stderr] 2652 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2653:19 [INFO] [stderr] | [INFO] [stderr] 2653 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2654:19 [INFO] [stderr] | [INFO] [stderr] 2654 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2655:19 [INFO] [stderr] | [INFO] [stderr] 2655 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/packet/route/addr.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match self { [INFO] [stderr] 115 | | &IpAddr::V4(ip) => { [INFO] [stderr] 116 | | let mut v = Vec::new(); [INFO] [stderr] 117 | | v.extend_from_slice(&ip.octets()[..]); [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 114 | match *self { [INFO] [stderr] 115 | IpAddr::V4(ip) => { [INFO] [stderr] 116 | let mut v = Vec::new(); [INFO] [stderr] 117 | v.extend_from_slice(&ip.octets()[..]); [INFO] [stderr] 118 | v [INFO] [stderr] 119 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/addr.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2666:18 [INFO] [stderr] | [INFO] [stderr] 2666 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2666:33 [INFO] [stderr] | [INFO] [stderr] 2666 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2667:19 [INFO] [stderr] | [INFO] [stderr] 2667 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2668:19 [INFO] [stderr] | [INFO] [stderr] 2668 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2669:19 [INFO] [stderr] | [INFO] [stderr] 2669 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2680:18 [INFO] [stderr] | [INFO] [stderr] 2680 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2680:33 [INFO] [stderr] | [INFO] [stderr] 2680 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2681:19 [INFO] [stderr] | [INFO] [stderr] 2681 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2682:19 [INFO] [stderr] | [INFO] [stderr] 2682 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2683:19 [INFO] [stderr] | [INFO] [stderr] 2683 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2694:18 [INFO] [stderr] | [INFO] [stderr] 2694 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2694:33 [INFO] [stderr] | [INFO] [stderr] 2694 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2695:19 [INFO] [stderr] | [INFO] [stderr] 2695 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2696:19 [INFO] [stderr] | [INFO] [stderr] 2696 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2697:19 [INFO] [stderr] | [INFO] [stderr] 2697 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2708:18 [INFO] [stderr] | [INFO] [stderr] 2708 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2708:33 [INFO] [stderr] | [INFO] [stderr] 2708 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2709:19 [INFO] [stderr] | [INFO] [stderr] 2709 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2710:19 [INFO] [stderr] | [INFO] [stderr] 2710 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2711:19 [INFO] [stderr] | [INFO] [stderr] 2711 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2722:18 [INFO] [stderr] | [INFO] [stderr] 2722 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2722:33 [INFO] [stderr] | [INFO] [stderr] 2722 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2723:19 [INFO] [stderr] | [INFO] [stderr] 2723 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2724:19 [INFO] [stderr] | [INFO] [stderr] 2724 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2725:19 [INFO] [stderr] | [INFO] [stderr] 2725 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2736:18 [INFO] [stderr] | [INFO] [stderr] 2736 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2736:33 [INFO] [stderr] | [INFO] [stderr] 2736 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2737:19 [INFO] [stderr] | [INFO] [stderr] 2737 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2738:19 [INFO] [stderr] | [INFO] [stderr] 2738 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2739:19 [INFO] [stderr] | [INFO] [stderr] 2739 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2750:18 [INFO] [stderr] | [INFO] [stderr] 2750 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2750:33 [INFO] [stderr] | [INFO] [stderr] 2750 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2751:19 [INFO] [stderr] | [INFO] [stderr] 2751 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2752:19 [INFO] [stderr] | [INFO] [stderr] 2752 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2753:19 [INFO] [stderr] | [INFO] [stderr] 2753 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2761:5 [INFO] [stderr] | [INFO] [stderr] 2761 | / pub fn new<'p>(packet: &'p mut [u8]) [INFO] [stderr] 2762 | | -> Option> { [INFO] [stderr] 2763 | | if packet.len() >= MutableRouteCacheInfoPacket::minimum_packet_size() [INFO] [stderr] 2764 | | { [INFO] [stderr] ... | [INFO] [stderr] 2768 | | } else { None } [INFO] [stderr] 2769 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2784:5 [INFO] [stderr] | [INFO] [stderr] 2784 | / pub fn to_immutable<'p>(&'p self) -> RouteCacheInfoPacket<'p> { [INFO] [stderr] 2785 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 2786 | | RouteCacheInfoPacket{packet: [INFO] [stderr] 2787 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 2788 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2827:18 [INFO] [stderr] | [INFO] [stderr] 2827 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2827:33 [INFO] [stderr] | [INFO] [stderr] 2827 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2828:19 [INFO] [stderr] | [INFO] [stderr] 2828 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2829:19 [INFO] [stderr] | [INFO] [stderr] 2829 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2830:19 [INFO] [stderr] | [INFO] [stderr] 2830 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2841:18 [INFO] [stderr] | [INFO] [stderr] 2841 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2841:33 [INFO] [stderr] | [INFO] [stderr] 2841 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2842:19 [INFO] [stderr] | [INFO] [stderr] 2842 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2843:19 [INFO] [stderr] | [INFO] [stderr] 2843 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2844:19 [INFO] [stderr] | [INFO] [stderr] 2844 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2855:18 [INFO] [stderr] | [INFO] [stderr] 2855 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2855:33 [INFO] [stderr] | [INFO] [stderr] 2855 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2856:19 [INFO] [stderr] | [INFO] [stderr] 2856 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2857:19 [INFO] [stderr] | [INFO] [stderr] 2857 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2858:19 [INFO] [stderr] | [INFO] [stderr] 2858 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2869:18 [INFO] [stderr] | [INFO] [stderr] 2869 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2869:33 [INFO] [stderr] | [INFO] [stderr] 2869 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2870:19 [INFO] [stderr] | [INFO] [stderr] 2870 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2871:19 [INFO] [stderr] | [INFO] [stderr] 2871 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2872:19 [INFO] [stderr] | [INFO] [stderr] 2872 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/addr.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2883:18 [INFO] [stderr] | [INFO] [stderr] 2883 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2883:33 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 2883 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2884:19 [INFO] [stderr] | [INFO] [stderr] 2884 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2885:19 [INFO] [stderr] | [INFO] [stderr] 2885 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2886:19 [INFO] [stderr] | [INFO] [stderr] 2886 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2897:18 [INFO] [stderr] | [INFO] [stderr] 2897 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2897:33 [INFO] [stderr] | [INFO] [stderr] 2897 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2898:19 [INFO] [stderr] | [INFO] [stderr] 2898 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2899:19 [INFO] [stderr] | [INFO] [stderr] 2899 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2900:19 [INFO] [stderr] | [INFO] [stderr] 2900 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2911:18 [INFO] [stderr] | [INFO] [stderr] 2911 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2911:33 [INFO] [stderr] | [INFO] [stderr] 2911 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2912:19 [INFO] [stderr] | [INFO] [stderr] 2912 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2913:19 [INFO] [stderr] | [INFO] [stderr] 2913 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2914:19 [INFO] [stderr] | [INFO] [stderr] 2914 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2925:18 [INFO] [stderr] | [INFO] [stderr] 2925 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2925:33 [INFO] [stderr] | [INFO] [stderr] 2925 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2926:19 [INFO] [stderr] | [INFO] [stderr] 2926 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2927:19 [INFO] [stderr] | [INFO] [stderr] 2927 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/packet/route/addr.rs:198:31 [INFO] [stderr] | [INFO] [stderr] 198 | RtAttrPacket::new(&mut rta_buf).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/packet/route/addr.rs:207:31 [INFO] [stderr] | [INFO] [stderr] 207 | RtAttrPacket::new(&mut rta_buf1).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/addr.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | self.write(req.packet()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2928:19 [INFO] [stderr] | [INFO] [stderr] 2928 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2939:22 [INFO] [stderr] | [INFO] [stderr] 2939 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2952:22 [INFO] [stderr] | [INFO] [stderr] 2952 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2965:22 [INFO] [stderr] | [INFO] [stderr] 2965 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2978:22 [INFO] [stderr] | [INFO] [stderr] 2978 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:2991:22 [INFO] [stderr] | [INFO] [stderr] 2991 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/packet/route/addr.rs:312:64 [INFO] [stderr] | [INFO] [stderr] 312 | rti.find(|rta| rta.get_rta_type() == rta_type).map(|rta| cb(rta)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `cb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/packet/route/addr.rs:323:17 [INFO] [stderr] | [INFO] [stderr] 323 | &mut ip6addr[..].copy_from_slice(bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ip6addr[..].copy_from_slice(bytes);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3004:22 [INFO] [stderr] | [INFO] [stderr] 3004 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3017:22 [INFO] [stderr] | [INFO] [stderr] 3017 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3030:22 [INFO] [stderr] | [INFO] [stderr] 3030 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `32` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3055:56 [INFO] [stderr] | [INFO] [stderr] 3055 | fn packet_size(&self) -> usize { let _self = self; 32 + 0 } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `32` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3060:56 [INFO] [stderr] | [INFO] [stderr] 3060 | fn packet_size(&self) -> usize { let _self = self; 32 + 0 } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3065:5 [INFO] [stderr] | [INFO] [stderr] 3065 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3068:5 [INFO] [stderr] | [INFO] [stderr] 3068 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 3069 | | let _self = self; [INFO] [stderr] 3070 | | let start = 32; [INFO] [stderr] 3071 | | let end = ::std::cmp::min(32 + 0, _self.packet.len()); [INFO] [stderr] 3072 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 3073 | | &mut _self.packet[start..end] [INFO] [stderr] 3074 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/packet/route/addr.rs:358:33 [INFO] [stderr] | [INFO] [stderr] 358 | &mut ip6addr[..].copy_from_slice(rta.payload()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ip6addr[..].copy_from_slice(rta.payload());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `32` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3071:35 [INFO] [stderr] | [INFO] [stderr] 3071 | let end = ::std::cmp::min(32 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3079:5 [INFO] [stderr] | [INFO] [stderr] 3079 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3082:5 [INFO] [stderr] | [INFO] [stderr] 3082 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 3083 | | let _self = self; [INFO] [stderr] 3084 | | let start = 32; [INFO] [stderr] 3085 | | let end = ::std::cmp::min(32 + 0, _self.packet.len()); [INFO] [stderr] 3086 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 3087 | | &_self.packet[start..end] [INFO] [stderr] 3088 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `32` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3085:35 [INFO] [stderr] | [INFO] [stderr] 3085 | let end = ::std::cmp::min(32 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3092:5 [INFO] [stderr] | [INFO] [stderr] 3092 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3095:5 [INFO] [stderr] | [INFO] [stderr] 3095 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 3096 | | let _self = self; [INFO] [stderr] 3097 | | let start = 32; [INFO] [stderr] 3098 | | let end = ::std::cmp::min(32 + 0, _self.packet.len()); [INFO] [stderr] 3099 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 3100 | | &_self.packet[start..end] [INFO] [stderr] 3101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `32` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3098:35 [INFO] [stderr] | [INFO] [stderr] 3098 | let end = ::std::cmp::min(32 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3115:12 [INFO] [stderr] | [INFO] [stderr] 3115 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3233:5 [INFO] [stderr] | [INFO] [stderr] 3233 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 3234 | | if packet.len() >= FibRulePacket::minimum_packet_size() { [INFO] [stderr] 3235 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 3236 | | Some(FibRulePacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 3237 | | } else { None } [INFO] [stderr] 3238 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3250:5 [INFO] [stderr] | [INFO] [stderr] 3250 | / pub fn to_immutable<'p>(&'p self) -> FibRulePacket<'p> { [INFO] [stderr] 3251 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 3252 | | FibRulePacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 3253 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3349:18 [INFO] [stderr] | [INFO] [stderr] 3349 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3349:33 [INFO] [stderr] | [INFO] [stderr] 3349 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3350:19 [INFO] [stderr] | [INFO] [stderr] 3350 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3351:19 [INFO] [stderr] | [INFO] [stderr] 3351 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3352:19 [INFO] [stderr] | [INFO] [stderr] 3352 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3360:5 [INFO] [stderr] | [INFO] [stderr] 3360 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 3361 | | if packet.len() >= MutableFibRulePacket::minimum_packet_size() { [INFO] [stderr] 3362 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 3363 | | Some(MutableFibRulePacket{packet: [INFO] [stderr] 3364 | | MutPacketData::Borrowed(packet),}) [INFO] [stderr] 3365 | | } else { None } [INFO] [stderr] 3366 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3378:5 [INFO] [stderr] | [INFO] [stderr] 3378 | / pub fn to_immutable<'p>(&'p self) -> FibRulePacket<'p> { [INFO] [stderr] 3379 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 3380 | | FibRulePacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 3381 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3493:18 [INFO] [stderr] | [INFO] [stderr] 3493 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3493:33 [INFO] [stderr] | [INFO] [stderr] 3493 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3494:19 [INFO] [stderr] | [INFO] [stderr] 3494 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3495:19 [INFO] [stderr] | [INFO] [stderr] 3495 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3496:19 [INFO] [stderr] | [INFO] [stderr] 3496 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3506:22 [INFO] [stderr] | [INFO] [stderr] 3506 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3515:22 [INFO] [stderr] | [INFO] [stderr] 3515 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3524:22 [INFO] [stderr] | [INFO] [stderr] 3524 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3533:22 [INFO] [stderr] | [INFO] [stderr] 3533 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3542:22 [INFO] [stderr] | [INFO] [stderr] 3542 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3551:22 [INFO] [stderr] | [INFO] [stderr] 3551 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3560:22 [INFO] [stderr] | [INFO] [stderr] 3560 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3569:22 [INFO] [stderr] | [INFO] [stderr] 3569 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3579:22 [INFO] [stderr] | [INFO] [stderr] 3579 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3611:5 [INFO] [stderr] | [INFO] [stderr] 3611 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3614:5 [INFO] [stderr] | [INFO] [stderr] 3614 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 3615 | | let _self = self; [INFO] [stderr] 3616 | | let start = 12; [INFO] [stderr] 3617 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 3618 | | &mut _self.packet[start..] [INFO] [stderr] 3619 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3623:5 [INFO] [stderr] | [INFO] [stderr] 3623 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3626:5 [INFO] [stderr] | [INFO] [stderr] 3626 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 3627 | | let _self = self; [INFO] [stderr] 3628 | | let start = 12; [INFO] [stderr] 3629 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 3630 | | &_self.packet[start..] [INFO] [stderr] 3631 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3635:5 [INFO] [stderr] | [INFO] [stderr] 3635 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3638:5 [INFO] [stderr] | [INFO] [stderr] 3638 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 3639 | | let _self = self; [INFO] [stderr] 3640 | | let start = 12; [INFO] [stderr] 3641 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 3642 | | &_self.packet[start..] [INFO] [stderr] 3643 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3657:12 [INFO] [stderr] | [INFO] [stderr] 3657 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/link.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/link.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/link.rs:265:9 [INFO] [stderr] | [INFO] [stderr] 265 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/link.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/link.rs:297:9 [INFO] [stderr] | [INFO] [stderr] 297 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/link.rs:316:8 [INFO] [stderr] | [INFO] [stderr] 316 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/link.rs:335:8 [INFO] [stderr] | [INFO] [stderr] 335 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3775:5 [INFO] [stderr] | [INFO] [stderr] 3775 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 3776 | | if packet.len() >= RtAttrPacket::minimum_packet_size() { [INFO] [stderr] 3777 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 3778 | | Some(RtAttrPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 3779 | | } else { None } [INFO] [stderr] 3780 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3792:5 [INFO] [stderr] | [INFO] [stderr] 3792 | / pub fn to_immutable<'p>(&'p self) -> RtAttrPacket<'p> { [INFO] [stderr] 3793 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 3794 | | RtAttrPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 3795 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3819:18 [INFO] [stderr] | [INFO] [stderr] 3819 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3819:33 [INFO] [stderr] | [INFO] [stderr] 3819 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3820:19 [INFO] [stderr] | [INFO] [stderr] 3820 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3831:18 [INFO] [stderr] | [INFO] [stderr] 3831 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3831:33 [INFO] [stderr] | [INFO] [stderr] 3831 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3832:19 [INFO] [stderr] | [INFO] [stderr] 3832 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3840:5 [INFO] [stderr] | [INFO] [stderr] 3840 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 3841 | | if packet.len() >= MutableRtAttrPacket::minimum_packet_size() { [INFO] [stderr] 3842 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 3843 | | Some(MutableRtAttrPacket{packet: [INFO] [stderr] 3844 | | MutPacketData::Borrowed(packet),}) [INFO] [stderr] 3845 | | } else { None } [INFO] [stderr] 3846 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3858:5 [INFO] [stderr] | [INFO] [stderr] 3858 | / pub fn to_immutable<'p>(&'p self) -> RtAttrPacket<'p> { [INFO] [stderr] 3859 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 3860 | | RtAttrPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 3861 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3894:18 [INFO] [stderr] | [INFO] [stderr] 3894 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3894:33 [INFO] [stderr] | [INFO] [stderr] 3894 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3895:19 [INFO] [stderr] | [INFO] [stderr] 3895 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3906:18 [INFO] [stderr] | [INFO] [stderr] 3906 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3906:33 [INFO] [stderr] | [INFO] [stderr] 3906 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3907:19 [INFO] [stderr] | [INFO] [stderr] 3907 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3918:22 [INFO] [stderr] | [INFO] [stderr] 3918 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3929:22 [INFO] [stderr] | [INFO] [stderr] 3929 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/packet/route/link.rs:432:64 [INFO] [stderr] | [INFO] [stderr] 432 | rti.find(|rta| rta.get_rta_type() == rta_type).map(|rta| cb(rta)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `cb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3967:5 [INFO] [stderr] | [INFO] [stderr] 3967 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3970:5 [INFO] [stderr] | [INFO] [stderr] 3970 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 3971 | | let _self = self; [INFO] [stderr] 3972 | | let start = 4; [INFO] [stderr] 3973 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 3977 | | &mut _self.packet[start..end] [INFO] [stderr] 3978 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `packet::route::link::IfInfoPacketBuilder` [INFO] [stderr] --> src/packet/route/link.rs:490:5 [INFO] [stderr] | [INFO] [stderr] 490 | / pub fn new() -> Self { [INFO] [stderr] 491 | | let len = MutableIfInfoPacket::minimum_packet_size(); [INFO] [stderr] 492 | | let data = vec![0; len]; [INFO] [stderr] 493 | | IfInfoPacketBuilder { data: data } [INFO] [stderr] 494 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 485 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3982:5 [INFO] [stderr] | [INFO] [stderr] 3982 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3985:5 [INFO] [stderr] | [INFO] [stderr] 3985 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 3986 | | let _self = self; [INFO] [stderr] 3987 | | let start = 4; [INFO] [stderr] 3988 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 3992 | | &_self.packet[start..end] [INFO] [stderr] 3993 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/packet/route/link.rs:582:9 [INFO] [stderr] | [INFO] [stderr] 582 | conn.iter_links().unwrap().find(|link| link.get_name() == Some("test1488".to_owned())).is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|link| link.get_name() == Some("test1488".to_owned())).is_some()` with `any(|link| link.get_name() == Some("test1488".to_owned()))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/link.rs:583:9 [INFO] [stderr] | [INFO] [stderr] 583 | conn.delete_link(link); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:3997:5 [INFO] [stderr] | [INFO] [stderr] 3997 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/link.rs:611:9 [INFO] [stderr] | [INFO] [stderr] 611 | conn.delete_link(link); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4000:5 [INFO] [stderr] | [INFO] [stderr] 4000 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 4001 | | let _self = self; [INFO] [stderr] 4002 | | let start = 4; [INFO] [stderr] 4003 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 4007 | | &_self.packet[start..end] [INFO] [stderr] 4008 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: variant `LINK_NETNSID` should have a camel case name such as `LinkNetnsid` [INFO] [stderr] --> src/packet/route/neighbour.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | LINK_NETNSID = 10, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4022:12 [INFO] [stderr] | [INFO] [stderr] 4022 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4115:5 [INFO] [stderr] | [INFO] [stderr] 4115 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 4116 | | if packet.len() >= RtAttrMtuPacket::minimum_packet_size() { [INFO] [stderr] 4117 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 4118 | | Some(RtAttrMtuPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 4119 | | } else { None } [INFO] [stderr] 4120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4132:5 [INFO] [stderr] | [INFO] [stderr] 4132 | / pub fn to_immutable<'p>(&'p self) -> RtAttrMtuPacket<'p> { [INFO] [stderr] 4133 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 4134 | | RtAttrMtuPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 4135 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4159:18 [INFO] [stderr] | [INFO] [stderr] 4159 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4159:33 [INFO] [stderr] | [INFO] [stderr] 4159 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4160:19 [INFO] [stderr] | [INFO] [stderr] 4160 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4171:18 [INFO] [stderr] | [INFO] [stderr] 4171 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4171:33 [INFO] [stderr] | [INFO] [stderr] 4171 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4172:19 [INFO] [stderr] | [INFO] [stderr] 4172 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4183:18 [INFO] [stderr] | [INFO] [stderr] 4183 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4183:33 [INFO] [stderr] | [INFO] [stderr] 4183 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4184:19 [INFO] [stderr] | [INFO] [stderr] 4184 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4185:19 [INFO] [stderr] | [INFO] [stderr] 4185 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4186:19 [INFO] [stderr] | [INFO] [stderr] 4186 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4194:5 [INFO] [stderr] | [INFO] [stderr] 4194 | / pub fn new<'p>(packet: &'p mut [u8]) [INFO] [stderr] 4195 | | -> Option> { [INFO] [stderr] 4196 | | if packet.len() >= MutableRtAttrMtuPacket::minimum_packet_size() { [INFO] [stderr] 4197 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] ... | [INFO] [stderr] 4200 | | } else { None } [INFO] [stderr] 4201 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4214:5 [INFO] [stderr] | [INFO] [stderr] 4214 | / pub fn to_immutable<'p>(&'p self) -> RtAttrMtuPacket<'p> { [INFO] [stderr] 4215 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 4216 | | RtAttrMtuPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 4217 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4251:18 [INFO] [stderr] | [INFO] [stderr] 4251 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4251:33 [INFO] [stderr] | [INFO] [stderr] 4251 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4252:19 [INFO] [stderr] | [INFO] [stderr] 4252 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4263:18 [INFO] [stderr] | [INFO] [stderr] 4263 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4263:33 [INFO] [stderr] | [INFO] [stderr] 4263 | let b0 = ((_self.packet[co + 0] as u16he)) as u16he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4264:19 [INFO] [stderr] | [INFO] [stderr] 4264 | let b1 = ((_self.packet[co + 1] as u16he) << 8) as u16he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4275:18 [INFO] [stderr] | [INFO] [stderr] 4275 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4275:33 [INFO] [stderr] | [INFO] [stderr] 4275 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4276:19 [INFO] [stderr] | [INFO] [stderr] 4276 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4277:19 [INFO] [stderr] | [INFO] [stderr] 4277 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/neighbour.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | / write!(f, [INFO] [stderr] 165 | | "{:?}: {:?}, {:?}, {:?}, {:?}", [INFO] [stderr] 166 | | family, [INFO] [stderr] 167 | | self.get_ifindex(), [INFO] [stderr] 168 | | self.get_state(), [INFO] [stderr] 169 | | self.get_flags(), [INFO] [stderr] 170 | | self.get_type()); [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/neighbour.rs:182:25 [INFO] [stderr] | [INFO] [stderr] 182 | write!(f, " lladdr: {:?}", mac_addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/neighbour.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | write!(f, " vlan id: {:?}", rta.payload()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/neighbour.rs:192:33 [INFO] [stderr] | [INFO] [stderr] 192 | write!(f, " {:?}", addr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/neighbour.rs:195:33 [INFO] [stderr] | [INFO] [stderr] 195 | write!(f, "unknown address length {:?}", l); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/packet/route/neighbour.rs:200:25 [INFO] [stderr] | [INFO] [stderr] 200 | write!(f, " unknown attribute {:?}", rta); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/packet/route/neighbour.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | try!(self.write(req.packet())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/packet/route/neighbour.rs:380:71 [INFO] [stderr] | [INFO] [stderr] 380 | rti.find(|rta| rta.get_rta_type() == rta_type as u16).map(|rta| cb(rta)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `cb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4278:19 [INFO] [stderr] | [INFO] [stderr] 4278 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4289:22 [INFO] [stderr] | [INFO] [stderr] 4289 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4300:22 [INFO] [stderr] | [INFO] [stderr] 4300 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4311:22 [INFO] [stderr] | [INFO] [stderr] 4311 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: method `set__payload` should have a snake case name such as `set_payload` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4320:5 [INFO] [stderr] | [INFO] [stderr] 4320 | / pub fn set__payload(&mut self, vals: &[u8]) { [INFO] [stderr] 4321 | | use std::ptr::copy_nonoverlapping; [INFO] [stderr] 4322 | | let mut _self = self; [INFO] [stderr] 4323 | | let current_offset = 8; [INFO] [stderr] ... | [INFO] [stderr] 4330 | | } [INFO] [stderr] 4331 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4335:56 [INFO] [stderr] | [INFO] [stderr] 4335 | fn packet_size(&self) -> usize { let _self = self; 8 + 0 } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4340:56 [INFO] [stderr] | [INFO] [stderr] 4340 | fn packet_size(&self) -> usize { let _self = self; 8 + 0 } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4345:5 [INFO] [stderr] | [INFO] [stderr] 4345 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4348:5 [INFO] [stderr] | [INFO] [stderr] 4348 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 4349 | | let _self = self; [INFO] [stderr] 4350 | | let start = 8; [INFO] [stderr] 4351 | | let end = ::std::cmp::min(8 + 0, _self.packet.len()); [INFO] [stderr] 4352 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 4353 | | &mut _self.packet[start..end] [INFO] [stderr] 4354 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4351:35 [INFO] [stderr] | [INFO] [stderr] 4351 | let end = ::std::cmp::min(8 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4359:5 [INFO] [stderr] | [INFO] [stderr] 4359 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4362:5 [INFO] [stderr] | [INFO] [stderr] 4362 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 4363 | | let _self = self; [INFO] [stderr] 4364 | | let start = 8; [INFO] [stderr] 4365 | | let end = ::std::cmp::min(8 + 0, _self.packet.len()); [INFO] [stderr] 4366 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 4367 | | &_self.packet[start..end] [INFO] [stderr] 4368 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4365:35 [INFO] [stderr] | [INFO] [stderr] 4365 | let end = ::std::cmp::min(8 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4372:5 [INFO] [stderr] | [INFO] [stderr] 4372 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4375:5 [INFO] [stderr] | [INFO] [stderr] 4375 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 4376 | | let _self = self; [INFO] [stderr] 4377 | | let start = 8; [INFO] [stderr] 4378 | | let end = ::std::cmp::min(8 + 0, _self.packet.len()); [INFO] [stderr] 4379 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 4380 | | &_self.packet[start..end] [INFO] [stderr] 4381 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4378:35 [INFO] [stderr] | [INFO] [stderr] 4378 | let end = ::std::cmp::min(8 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/route/route.rs:4395:12 [INFO] [stderr] | [INFO] [stderr] 4395 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 20 | | if packet.len() >= AuditStatusPacket::minimum_packet_size() { [INFO] [stderr] 21 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 22 | | Some(AuditStatusPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 23 | | } else { None } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn to_immutable<'p>(&'p self) -> AuditStatusPacket<'p> { [INFO] [stderr] 37 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 38 | | AuditStatusPacket{packet: [INFO] [stderr] 39 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:64:18 [INFO] [stderr] | [INFO] [stderr] 64 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:64:33 [INFO] [stderr] | [INFO] [stderr] 64 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:66:19 [INFO] [stderr] | [INFO] [stderr] 66 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:67:19 [INFO] [stderr] | [INFO] [stderr] 67 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:78:18 [INFO] [stderr] | [INFO] [stderr] 78 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:78:33 [INFO] [stderr] | [INFO] [stderr] 78 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:79:19 [INFO] [stderr] | [INFO] [stderr] 79 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:92:33 [INFO] [stderr] | [INFO] [stderr] 92 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:93:19 [INFO] [stderr] | [INFO] [stderr] 93 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:95:19 [INFO] [stderr] | [INFO] [stderr] 95 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:106:33 [INFO] [stderr] | [INFO] [stderr] 106 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:107:19 [INFO] [stderr] | [INFO] [stderr] 107 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:108:19 [INFO] [stderr] | [INFO] [stderr] 108 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:109:19 [INFO] [stderr] | [INFO] [stderr] 109 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:120:18 [INFO] [stderr] | [INFO] [stderr] 120 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:120:33 [INFO] [stderr] | [INFO] [stderr] 120 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:121:19 [INFO] [stderr] | [INFO] [stderr] 121 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/packet/route/route.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | const NOTIFY = 0x100; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(overflowing_literals)] on by default [INFO] [stderr] = note: the literal `0x100` (decimal `256`) does not fit into an `u8` and will become `0u8` [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:122:19 [INFO] [stderr] | [INFO] [stderr] 122 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/packet/route/route.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | const CLONED = 0x200; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the literal `0x200` (decimal `512`) does not fit into an `u8` and will become `0u8` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/packet/route/route.rs:50:26 [INFO] [stderr] | [INFO] [stderr] 50 | const EQUALIZE = 0x400; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the literal `0x400` (decimal `1024`) does not fit into an `u8` and will become `0u8` [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] --> src/packet/route/route.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | const PREFIX = 0x800; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: the literal `0x800` (decimal `2048`) does not fit into an `u8` and will become `0u8` [INFO] [stderr] [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:134:33 [INFO] [stderr] | [INFO] [stderr] 134 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:135:19 [INFO] [stderr] | [INFO] [stderr] 135 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:136:19 [INFO] [stderr] | [INFO] [stderr] 136 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:137:19 [INFO] [stderr] | [INFO] [stderr] 137 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:148:18 [INFO] [stderr] | [INFO] [stderr] 148 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:148:33 [INFO] [stderr] | [INFO] [stderr] 148 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:149:19 [INFO] [stderr] | [INFO] [stderr] 149 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:150:19 [INFO] [stderr] | [INFO] [stderr] 150 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:151:19 [INFO] [stderr] | [INFO] [stderr] 151 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:162:18 [INFO] [stderr] | [INFO] [stderr] 162 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:162:33 [INFO] [stderr] | [INFO] [stderr] 162 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:163:19 [INFO] [stderr] | [INFO] [stderr] 163 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:164:19 [INFO] [stderr] | [INFO] [stderr] 164 | let b2 = ((_self.packet[co + 2] as u32he) << 16) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:165:19 [INFO] [stderr] | [INFO] [stderr] 165 | let b3 = ((_self.packet[co + 3] as u32he) << 24) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:176:18 [INFO] [stderr] | [INFO] [stderr] 176 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:176:33 [INFO] [stderr] | [INFO] [stderr] 176 | let b0 = ((_self.packet[co + 0] as u32he)) as u32he; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:177:19 [INFO] [stderr] | [INFO] [stderr] 177 | let b1 = ((_self.packet[co + 1] as u32he) << 8) as u32he; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnetlink-656d10727b4212d0/out/audit/audit.rs:178:19 [INFO] [stderr] | [WARN] too many lines in the log, truncating it