[INFO] crate pnet_transport 0.21.0 is already in cache [INFO] extracting crate pnet_transport 0.21.0 into work/ex/clippy-test-run/sources/stable/reg/pnet_transport/0.21.0 [INFO] extracting crate pnet_transport 0.21.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnet_transport/0.21.0 [INFO] validating manifest of pnet_transport-0.21.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pnet_transport-0.21.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pnet_transport-0.21.0 [INFO] finished frobbing pnet_transport-0.21.0 [INFO] frobbed toml for pnet_transport-0.21.0 written to work/ex/clippy-test-run/sources/stable/reg/pnet_transport/0.21.0/Cargo.toml [INFO] started frobbing pnet_transport-0.21.0 [INFO] finished frobbing pnet_transport-0.21.0 [INFO] frobbed toml for pnet_transport-0.21.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnet_transport/0.21.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pnet_transport-0.21.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pnet_transport/0.21.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f3184eb619d91d3b0a6008201c6b7889b7ab5ecc3c999e46c2a95fb86d4b2b5a [INFO] running `"docker" "start" "-a" "f3184eb619d91d3b0a6008201c6b7889b7ab5ecc3c999e46c2a95fb86d4b2b5a"` [INFO] [stderr] Compiling syntex_errors v0.42.0 [INFO] [stderr] Checking pnet_sys v0.21.0 [INFO] [stderr] Compiling syntex_syntax v0.42.0 [INFO] [stderr] Compiling syntex v0.42.2 [INFO] [stderr] Compiling pnet_macros v0.21.0 [INFO] [stderr] Compiling pnet_packet v0.21.0 [INFO] [stderr] Checking pnet_transport v0.21.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | channel_type: channel_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | channel_type: channel_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:100:73 [INFO] [stderr] | [INFO] [stderr] 100 | pnet_sys::socket(pnet_sys::AF_INET, pnet_sys::SOCK_RAW, proto as libc::c_int) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(proto)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:103:74 [INFO] [stderr] | [INFO] [stderr] 103 | pnet_sys::socket(pnet_sys::AF_INET6, pnet_sys::SOCK_RAW, proto as libc::c_int) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(proto)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | / pub fn next(&mut self) -> io::Result<($ty, IpAddr)> { [INFO] [stderr] 229 | | let mut caddr: pnet_sys::SockAddrStorage = unsafe { mem::zeroed() }; [INFO] [stderr] 230 | | let res = pnet_sys::recv_from(self.tr.socket.fd, [INFO] [stderr] 231 | | &mut self.tr.buffer[..], [INFO] [stderr] ... | [INFO] [stderr] 286 | | fn fixup_packet(_buffer: &mut [u8]) {} [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 292 | transport_channel_iterator!(Ipv4Packet, Ipv4TransportChannelIterator, ipv4_packet_iter); [INFO] [stderr] | ---------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | / pub fn next(&mut self) -> io::Result<($ty, IpAddr)> { [INFO] [stderr] 229 | | let mut caddr: pnet_sys::SockAddrStorage = unsafe { mem::zeroed() }; [INFO] [stderr] 230 | | let res = pnet_sys::recv_from(self.tr.socket.fd, [INFO] [stderr] 231 | | &mut self.tr.buffer[..], [INFO] [stderr] ... | [INFO] [stderr] 286 | | fn fixup_packet(_buffer: &mut [u8]) {} [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 294 | transport_channel_iterator!(UdpPacket, UdpTransportChannelIterator, udp_packet_iter); [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | / pub fn next(&mut self) -> io::Result<($ty, IpAddr)> { [INFO] [stderr] 229 | | let mut caddr: pnet_sys::SockAddrStorage = unsafe { mem::zeroed() }; [INFO] [stderr] 230 | | let res = pnet_sys::recv_from(self.tr.socket.fd, [INFO] [stderr] 231 | | &mut self.tr.buffer[..], [INFO] [stderr] ... | [INFO] [stderr] 286 | | fn fixup_packet(_buffer: &mut [u8]) {} [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 296 | transport_channel_iterator!(IcmpPacket, IcmpTransportChannelIterator, icmp_packet_iter); [INFO] [stderr] | ---------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | / pub fn next(&mut self) -> io::Result<($ty, IpAddr)> { [INFO] [stderr] 229 | | let mut caddr: pnet_sys::SockAddrStorage = unsafe { mem::zeroed() }; [INFO] [stderr] 230 | | let res = pnet_sys::recv_from(self.tr.socket.fd, [INFO] [stderr] 231 | | &mut self.tr.buffer[..], [INFO] [stderr] ... | [INFO] [stderr] 286 | | fn fixup_packet(_buffer: &mut [u8]) {} [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 298 | transport_channel_iterator!(Icmpv6Packet, Icmpv6TransportChannelIterator, icmpv6_packet_iter); [INFO] [stderr] | ---------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | / pub fn next(&mut self) -> io::Result<($ty, IpAddr)> { [INFO] [stderr] 229 | | let mut caddr: pnet_sys::SockAddrStorage = unsafe { mem::zeroed() }; [INFO] [stderr] 230 | | let res = pnet_sys::recv_from(self.tr.socket.fd, [INFO] [stderr] 231 | | &mut self.tr.buffer[..], [INFO] [stderr] ... | [INFO] [stderr] 286 | | fn fixup_packet(_buffer: &mut [u8]) {} [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 300 | transport_channel_iterator!(TcpPacket, TcpTransportChannelIterator, tcp_packet_iter); [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:100:73 [INFO] [stderr] | [INFO] [stderr] 100 | pnet_sys::socket(pnet_sys::AF_INET, pnet_sys::SOCK_RAW, proto as libc::c_int) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(proto)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:103:74 [INFO] [stderr] | [INFO] [stderr] 103 | pnet_sys::socket(pnet_sys::AF_INET6, pnet_sys::SOCK_RAW, proto as libc::c_int) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(proto)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | / pub fn next(&mut self) -> io::Result<($ty, IpAddr)> { [INFO] [stderr] 229 | | let mut caddr: pnet_sys::SockAddrStorage = unsafe { mem::zeroed() }; [INFO] [stderr] 230 | | let res = pnet_sys::recv_from(self.tr.socket.fd, [INFO] [stderr] 231 | | &mut self.tr.buffer[..], [INFO] [stderr] ... | [INFO] [stderr] 286 | | fn fixup_packet(_buffer: &mut [u8]) {} [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 292 | transport_channel_iterator!(Ipv4Packet, Ipv4TransportChannelIterator, ipv4_packet_iter); [INFO] [stderr] | ---------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | / pub fn next(&mut self) -> io::Result<($ty, IpAddr)> { [INFO] [stderr] 229 | | let mut caddr: pnet_sys::SockAddrStorage = unsafe { mem::zeroed() }; [INFO] [stderr] 230 | | let res = pnet_sys::recv_from(self.tr.socket.fd, [INFO] [stderr] 231 | | &mut self.tr.buffer[..], [INFO] [stderr] ... | [INFO] [stderr] 286 | | fn fixup_packet(_buffer: &mut [u8]) {} [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 294 | transport_channel_iterator!(UdpPacket, UdpTransportChannelIterator, udp_packet_iter); [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | / pub fn next(&mut self) -> io::Result<($ty, IpAddr)> { [INFO] [stderr] 229 | | let mut caddr: pnet_sys::SockAddrStorage = unsafe { mem::zeroed() }; [INFO] [stderr] 230 | | let res = pnet_sys::recv_from(self.tr.socket.fd, [INFO] [stderr] 231 | | &mut self.tr.buffer[..], [INFO] [stderr] ... | [INFO] [stderr] 286 | | fn fixup_packet(_buffer: &mut [u8]) {} [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 296 | transport_channel_iterator!(IcmpPacket, IcmpTransportChannelIterator, icmp_packet_iter); [INFO] [stderr] | ---------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | / pub fn next(&mut self) -> io::Result<($ty, IpAddr)> { [INFO] [stderr] 229 | | let mut caddr: pnet_sys::SockAddrStorage = unsafe { mem::zeroed() }; [INFO] [stderr] 230 | | let res = pnet_sys::recv_from(self.tr.socket.fd, [INFO] [stderr] 231 | | &mut self.tr.buffer[..], [INFO] [stderr] ... | [INFO] [stderr] 286 | | fn fixup_packet(_buffer: &mut [u8]) {} [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 298 | transport_channel_iterator!(Icmpv6Packet, Icmpv6TransportChannelIterator, icmpv6_packet_iter); [INFO] [stderr] | ---------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | / pub fn next(&mut self) -> io::Result<($ty, IpAddr)> { [INFO] [stderr] 229 | | let mut caddr: pnet_sys::SockAddrStorage = unsafe { mem::zeroed() }; [INFO] [stderr] 230 | | let res = pnet_sys::recv_from(self.tr.socket.fd, [INFO] [stderr] 231 | | &mut self.tr.buffer[..], [INFO] [stderr] ... | [INFO] [stderr] 286 | | fn fixup_packet(_buffer: &mut [u8]) {} [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 300 | transport_channel_iterator!(TcpPacket, TcpTransportChannelIterator, tcp_packet_iter); [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 48.05s [INFO] running `"docker" "inspect" "f3184eb619d91d3b0a6008201c6b7889b7ab5ecc3c999e46c2a95fb86d4b2b5a"` [INFO] running `"docker" "rm" "-f" "f3184eb619d91d3b0a6008201c6b7889b7ab5ecc3c999e46c2a95fb86d4b2b5a"` [INFO] [stdout] f3184eb619d91d3b0a6008201c6b7889b7ab5ecc3c999e46c2a95fb86d4b2b5a