[INFO] crate pnet_sys 0.21.0 is already in cache [INFO] extracting crate pnet_sys 0.21.0 into work/ex/clippy-test-run/sources/stable/reg/pnet_sys/0.21.0 [INFO] extracting crate pnet_sys 0.21.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnet_sys/0.21.0 [INFO] validating manifest of pnet_sys-0.21.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pnet_sys-0.21.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pnet_sys-0.21.0 [INFO] finished frobbing pnet_sys-0.21.0 [INFO] frobbed toml for pnet_sys-0.21.0 written to work/ex/clippy-test-run/sources/stable/reg/pnet_sys/0.21.0/Cargo.toml [INFO] started frobbing pnet_sys-0.21.0 [INFO] finished frobbing pnet_sys-0.21.0 [INFO] frobbed toml for pnet_sys-0.21.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnet_sys/0.21.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pnet_sys-0.21.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pnet_sys/0.21.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 074f18d1f95e31c573a74fd8800e462cff8348a45c05fdf3590f358855ca9f8d [INFO] running `"docker" "start" "-a" "074f18d1f95e31c573a74fd8800e462cff8348a45c05fdf3590f358855ca9f8d"` [INFO] [stderr] Checking pnet_sys v0.21.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:171:17 [INFO] [stderr] | [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] 171 | let e = ntohs(arr[4]); [INFO] [stderr] | ^ [INFO] [stderr] --> src/lib.rs:171:17 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] 171 | let e = ntohs(arr[4]); [INFO] [stderr] | ^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | let f = ntohs(arr[5]); [INFO] [stderr] | ^ [INFO] [stderr] --> src/lib.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | let f = ntohs(arr[5]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | let g = ntohs(arr[6]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | let h = ntohs(arr[7]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | let g = ntohs(arr[6]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | let h = ntohs(arr[7]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/unix.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | tv_nsec: dur.subsec_nanos() as libc::c_long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:123:59 [INFO] [stderr] | [INFO] [stderr] 123 | let inaddr = imp::mk_inaddr(u32::from_be(((octets[0] as u32) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:124:63 [INFO] [stderr] | [INFO] [stderr] 124 | ((octets[1] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:125:63 [INFO] [stderr] | [INFO] [stderr] 125 | ((octets[2] as u32) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:126:62 [INFO] [stderr] | [INFO] [stderr] 126 | (octets[3] as u32))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:151:11 [INFO] [stderr] | [INFO] [stderr] 151 | match storage.ss_family as libc::c_int { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(storage.ss_family)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:154:49 [INFO] [stderr] | [INFO] [stderr] 154 | let storage: &SockAddrIn = unsafe { mem::transmute(storage) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(storage as *const libc::sockaddr_storage as *const libc::sockaddr_in)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:165:50 [INFO] [stderr] | [INFO] [stderr] 165 | let storage: &SockAddrIn6 = unsafe { mem::transmute(storage) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(storage as *const libc::sockaddr_storage as *const libc::sockaddr_in6)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/unix.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | tv_nsec: dur.subsec_nanos() as libc::c_long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:123:59 [INFO] [stderr] | [INFO] [stderr] 123 | let inaddr = imp::mk_inaddr(u32::from_be(((octets[0] as u32) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:124:63 [INFO] [stderr] | [INFO] [stderr] 124 | ((octets[1] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:125:63 [INFO] [stderr] | [INFO] [stderr] 125 | ((octets[2] as u32) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:126:62 [INFO] [stderr] | [INFO] [stderr] 126 | (octets[3] as u32))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(octets[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:151:11 [INFO] [stderr] | [INFO] [stderr] 151 | match storage.ss_family as libc::c_int { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(storage.ss_family)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:154:49 [INFO] [stderr] | [INFO] [stderr] 154 | let storage: &SockAddrIn = unsafe { mem::transmute(storage) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(storage as *const libc::sockaddr_storage as *const libc::sockaddr_in)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:165:50 [INFO] [stderr] | [INFO] [stderr] 165 | let storage: &SockAddrIn6 = unsafe { mem::transmute(storage) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(storage as *const libc::sockaddr_storage as *const libc::sockaddr_in6)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.04s [INFO] running `"docker" "inspect" "074f18d1f95e31c573a74fd8800e462cff8348a45c05fdf3590f358855ca9f8d"` [INFO] running `"docker" "rm" "-f" "074f18d1f95e31c573a74fd8800e462cff8348a45c05fdf3590f358855ca9f8d"` [INFO] [stdout] 074f18d1f95e31c573a74fd8800e462cff8348a45c05fdf3590f358855ca9f8d