[INFO] crate pnet_packet 0.21.0 is already in cache [INFO] extracting crate pnet_packet 0.21.0 into work/ex/clippy-test-run/sources/stable/reg/pnet_packet/0.21.0 [INFO] extracting crate pnet_packet 0.21.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnet_packet/0.21.0 [INFO] validating manifest of pnet_packet-0.21.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pnet_packet-0.21.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pnet_packet-0.21.0 [INFO] finished frobbing pnet_packet-0.21.0 [INFO] frobbed toml for pnet_packet-0.21.0 written to work/ex/clippy-test-run/sources/stable/reg/pnet_packet/0.21.0/Cargo.toml [INFO] started frobbing pnet_packet-0.21.0 [INFO] finished frobbing pnet_packet-0.21.0 [INFO] frobbed toml for pnet_packet-0.21.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnet_packet/0.21.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pnet_packet-0.21.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pnet_packet/0.21.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0eccd0690ac2373e0f1523e1b67e3248d7789cce6ced37b1e8ec1f7117994496 [INFO] running `"docker" "start" "-a" "0eccd0690ac2373e0f1523e1b67e3248d7789cce6ced37b1e8ec1f7117994496"` [INFO] [stderr] Compiling syntex_errors v0.42.0 [INFO] [stderr] Compiling syntex_syntax v0.42.0 [INFO] [stderr] Compiling syntex v0.42.2 [INFO] [stderr] Compiling pnet_macros v0.21.0 [INFO] [stderr] Compiling pnet_packet v0.21.0 (/opt/crater/workdir) [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:219:22 [INFO] [stderr] | [INFO] [stderr] 219 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:388:22 [INFO] [stderr] | [INFO] [stderr] 388 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:163:18 [INFO] [stderr] | [INFO] [stderr] 163 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:536:18 [INFO] [stderr] | [INFO] [stderr] 536 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:822:46 [INFO] [stderr] | [INFO] [stderr] 822 | ((_self.packet[co + 0] & 248) | (((val & 7)) as u8)) as u8; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:842:46 [INFO] [stderr] | [INFO] [stderr] 842 | ((_self.packet[co + 0] & 248) | (((val & 7)) as u8)) as u8; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1352:18 [INFO] [stderr] | [INFO] [stderr] 1352 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1411:18 [INFO] [stderr] | [INFO] [stderr] 1411 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1635:18 [INFO] [stderr] | [INFO] [stderr] 1635 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1696:18 [INFO] [stderr] | [INFO] [stderr] 1696 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1707:40 [INFO] [stderr] | [INFO] [stderr] 1707 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1708:40 [INFO] [stderr] | [INFO] [stderr] 1708 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:280:18 [INFO] [stderr] | [INFO] [stderr] 280 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:292:18 [INFO] [stderr] | [INFO] [stderr] 292 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:313:18 [INFO] [stderr] | [INFO] [stderr] 313 | let b1 = ((_self.packet[co + 1] as u13be)) as u13be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:348:18 [INFO] [stderr] | [INFO] [stderr] 348 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:572:18 [INFO] [stderr] | [INFO] [stderr] 572 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:584:18 [INFO] [stderr] | [INFO] [stderr] 584 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:605:18 [INFO] [stderr] | [INFO] [stderr] 605 | let b1 = ((_self.packet[co + 1] as u13be)) as u13be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:640:18 [INFO] [stderr] | [INFO] [stderr] 640 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:775:46 [INFO] [stderr] | [INFO] [stderr] 775 | ((_self.packet[co + 0] & 240) | (((val & 15)) as u8)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:795:46 [INFO] [stderr] | [INFO] [stderr] 795 | ((_self.packet[co + 0] & 252) | (((val & 3)) as u8)) as u8; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1555:50 [INFO] [stderr] | [INFO] [stderr] 1555 | ((_self.packet[co + 0] & 224) | (((val & 31)) as u8)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | let b2 = ((_self.packet[co + 2] as u20be)) as u20be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:160:22 [INFO] [stderr] | [INFO] [stderr] 160 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:169:22 [INFO] [stderr] | [INFO] [stderr] 169 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:178:22 [INFO] [stderr] | [INFO] [stderr] 178 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:187:22 [INFO] [stderr] | [INFO] [stderr] 187 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:196:22 [INFO] [stderr] | [INFO] [stderr] 196 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:205:22 [INFO] [stderr] | [INFO] [stderr] 205 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:214:22 [INFO] [stderr] | [INFO] [stderr] 214 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:223:22 [INFO] [stderr] | [INFO] [stderr] 223 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:241:22 [INFO] [stderr] | [INFO] [stderr] 241 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:250:22 [INFO] [stderr] | [INFO] [stderr] 250 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:259:22 [INFO] [stderr] | [INFO] [stderr] 259 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:268:22 [INFO] [stderr] | [INFO] [stderr] 268 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:277:22 [INFO] [stderr] | [INFO] [stderr] 277 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:286:22 [INFO] [stderr] | [INFO] [stderr] 286 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:295:22 [INFO] [stderr] | [INFO] [stderr] 295 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:304:22 [INFO] [stderr] | [INFO] [stderr] 304 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:395:18 [INFO] [stderr] | [INFO] [stderr] 395 | let b2 = ((_self.packet[co + 2] as u20be)) as u20be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:407:18 [INFO] [stderr] | [INFO] [stderr] 407 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:444:22 [INFO] [stderr] | [INFO] [stderr] 444 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:453:22 [INFO] [stderr] | [INFO] [stderr] 453 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:462:22 [INFO] [stderr] | [INFO] [stderr] 462 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:471:22 [INFO] [stderr] | [INFO] [stderr] 471 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:480:22 [INFO] [stderr] | [INFO] [stderr] 480 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:489:22 [INFO] [stderr] | [INFO] [stderr] 489 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:498:22 [INFO] [stderr] | [INFO] [stderr] 498 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:507:22 [INFO] [stderr] | [INFO] [stderr] 507 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:525:22 [INFO] [stderr] | [INFO] [stderr] 525 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:534:22 [INFO] [stderr] | [INFO] [stderr] 534 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:543:22 [INFO] [stderr] | [INFO] [stderr] 543 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:552:22 [INFO] [stderr] | [INFO] [stderr] 552 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:561:22 [INFO] [stderr] | [INFO] [stderr] 561 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:570:22 [INFO] [stderr] | [INFO] [stderr] 570 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:579:22 [INFO] [stderr] | [INFO] [stderr] 579 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:588:22 [INFO] [stderr] | [INFO] [stderr] 588 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:626:54 [INFO] [stderr] | [INFO] [stderr] 626 | ((_self.packet[co + 0] & 240) | (((val & 983040) >> 16) as u8)) as [INFO] [stderr] | ^^^^^^ help: consider: `983_040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:116:18 [INFO] [stderr] | [INFO] [stderr] 116 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:128:18 [INFO] [stderr] | [INFO] [stderr] 128 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:140:18 [INFO] [stderr] | [INFO] [stderr] 140 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:202:18 [INFO] [stderr] | [INFO] [stderr] 202 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:214:18 [INFO] [stderr] | [INFO] [stderr] 214 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:226:18 [INFO] [stderr] | [INFO] [stderr] 226 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:238:18 [INFO] [stderr] | [INFO] [stderr] 238 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | pub const NS: u9be = 0b100000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | pub const CWR: u9be = 0b010000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | pub const ECE: u9be = 0b001000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:38:27 [INFO] [stderr] | [INFO] [stderr] 38 | pub const URG: u9be = 0b000100000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | pub const ACK: u9be = 0b000010000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | pub const PSH: u9be = 0b000001000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | pub const RST: u9be = 0b000000100; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:48:27 [INFO] [stderr] | [INFO] [stderr] 48 | pub const SYN: u9be = 0b000000010; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:50:27 [INFO] [stderr] | [INFO] [stderr] 50 | pub const FIN: u9be = 0b000000001; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:188:18 [INFO] [stderr] | [INFO] [stderr] 188 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:200:18 [INFO] [stderr] | [INFO] [stderr] 200 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:214:18 [INFO] [stderr] | [INFO] [stderr] 214 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:228:18 [INFO] [stderr] | [INFO] [stderr] 228 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:258:18 [INFO] [stderr] | [INFO] [stderr] 258 | let b1 = ((_self.packet[co + 1] as u9be)) as u9be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:270:18 [INFO] [stderr] | [INFO] [stderr] 270 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:282:18 [INFO] [stderr] | [INFO] [stderr] 282 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:294:18 [INFO] [stderr] | [INFO] [stderr] 294 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:407:18 [INFO] [stderr] | [INFO] [stderr] 407 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:419:18 [INFO] [stderr] | [INFO] [stderr] 419 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:433:18 [INFO] [stderr] | [INFO] [stderr] 433 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:447:18 [INFO] [stderr] | [INFO] [stderr] 447 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:477:18 [INFO] [stderr] | [INFO] [stderr] 477 | let b1 = ((_self.packet[co + 1] as u9be)) as u9be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:489:18 [INFO] [stderr] | [INFO] [stderr] 489 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:501:18 [INFO] [stderr] | [INFO] [stderr] 501 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:513:18 [INFO] [stderr] | [INFO] [stderr] 513 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:588:40 [INFO] [stderr] | [INFO] [stderr] 588 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:589:40 [INFO] [stderr] | [INFO] [stderr] 589 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:601:40 [INFO] [stderr] | [INFO] [stderr] 601 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:602:40 [INFO] [stderr] | [INFO] [stderr] 602 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:151:22 [INFO] [stderr] | [INFO] [stderr] 151 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:185:22 [INFO] [stderr] | [INFO] [stderr] 185 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:428:22 [INFO] [stderr] | [INFO] [stderr] 428 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:444:22 [INFO] [stderr] | [INFO] [stderr] 444 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:478:22 [INFO] [stderr] | [INFO] [stderr] 478 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:173:18 [INFO] [stderr] | [INFO] [stderr] 173 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:262:18 [INFO] [stderr] | [INFO] [stderr] 262 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:679:22 [INFO] [stderr] | [INFO] [stderr] 679 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:691:22 [INFO] [stderr] | [INFO] [stderr] 691 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:703:22 [INFO] [stderr] | [INFO] [stderr] 703 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:801:22 [INFO] [stderr] | [INFO] [stderr] 801 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:813:22 [INFO] [stderr] | [INFO] [stderr] 813 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:825:22 [INFO] [stderr] | [INFO] [stderr] 825 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1205:22 [INFO] [stderr] | [INFO] [stderr] 1205 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1217:22 [INFO] [stderr] | [INFO] [stderr] 1217 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1229:22 [INFO] [stderr] | [INFO] [stderr] 1229 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1329:22 [INFO] [stderr] | [INFO] [stderr] 1329 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1341:22 [INFO] [stderr] | [INFO] [stderr] 1341 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1353:22 [INFO] [stderr] | [INFO] [stderr] 1353 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1745:22 [INFO] [stderr] | [INFO] [stderr] 1745 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1759:22 [INFO] [stderr] | [INFO] [stderr] 1759 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1862:22 [INFO] [stderr] | [INFO] [stderr] 1862 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1876:22 [INFO] [stderr] | [INFO] [stderr] 1876 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1934:44 [INFO] [stderr] | [INFO] [stderr] 1934 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1935:44 [INFO] [stderr] | [INFO] [stderr] 1935 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2221:22 [INFO] [stderr] | [INFO] [stderr] 2221 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2235:22 [INFO] [stderr] | [INFO] [stderr] 2235 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2334:22 [INFO] [stderr] | [INFO] [stderr] 2334 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2348:22 [INFO] [stderr] | [INFO] [stderr] 2348 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2404:44 [INFO] [stderr] | [INFO] [stderr] 2404 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2405:44 [INFO] [stderr] | [INFO] [stderr] 2405 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:210:18 [INFO] [stderr] | [INFO] [stderr] 210 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:302:18 [INFO] [stderr] | [INFO] [stderr] 302 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1143:22 [INFO] [stderr] | [INFO] [stderr] 1143 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1157:22 [INFO] [stderr] | [INFO] [stderr] 1157 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1302:22 [INFO] [stderr] | [INFO] [stderr] 1302 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1316:22 [INFO] [stderr] | [INFO] [stderr] 1316 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1417:44 [INFO] [stderr] | [INFO] [stderr] 1417 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1418:44 [INFO] [stderr] | [INFO] [stderr] 1418 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1762:22 [INFO] [stderr] | [INFO] [stderr] 1762 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1792:22 [INFO] [stderr] | [INFO] [stderr] 1792 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1806:22 [INFO] [stderr] | [INFO] [stderr] 1806 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1820:22 [INFO] [stderr] | [INFO] [stderr] 1820 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1969:22 [INFO] [stderr] | [INFO] [stderr] 1969 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1999:22 [INFO] [stderr] | [INFO] [stderr] 1999 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2013:22 [INFO] [stderr] | [INFO] [stderr] 2013 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2027:22 [INFO] [stderr] | [INFO] [stderr] 2027 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2157:44 [INFO] [stderr] | [INFO] [stderr] 2157 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2158:44 [INFO] [stderr] | [INFO] [stderr] 2158 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2170:44 [INFO] [stderr] | [INFO] [stderr] 2170 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2171:44 [INFO] [stderr] | [INFO] [stderr] 2171 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2528:22 [INFO] [stderr] | [INFO] [stderr] 2528 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2542:22 [INFO] [stderr] | [INFO] [stderr] 2542 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2556:26 [INFO] [stderr] | [INFO] [stderr] 2556 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2565:26 [INFO] [stderr] | [INFO] [stderr] 2565 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2574:26 [INFO] [stderr] | [INFO] [stderr] 2574 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2583:26 [INFO] [stderr] | [INFO] [stderr] 2583 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2592:26 [INFO] [stderr] | [INFO] [stderr] 2592 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2601:26 [INFO] [stderr] | [INFO] [stderr] 2601 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2610:26 [INFO] [stderr] | [INFO] [stderr] 2610 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2619:26 [INFO] [stderr] | [INFO] [stderr] 2619 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2769:22 [INFO] [stderr] | [INFO] [stderr] 2769 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2783:22 [INFO] [stderr] | [INFO] [stderr] 2783 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2797:26 [INFO] [stderr] | [INFO] [stderr] 2797 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2806:26 [INFO] [stderr] | [INFO] [stderr] 2806 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2815:26 [INFO] [stderr] | [INFO] [stderr] 2815 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2824:26 [INFO] [stderr] | [INFO] [stderr] 2824 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2833:26 [INFO] [stderr] | [INFO] [stderr] 2833 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2842:26 [INFO] [stderr] | [INFO] [stderr] 2842 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2851:26 [INFO] [stderr] | [INFO] [stderr] 2851 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2860:26 [INFO] [stderr] | [INFO] [stderr] 2860 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2965:44 [INFO] [stderr] | [INFO] [stderr] 2965 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2966:44 [INFO] [stderr] | [INFO] [stderr] 2966 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3406:22 [INFO] [stderr] | [INFO] [stderr] 3406 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3428:22 [INFO] [stderr] | [INFO] [stderr] 3428 | let b2 = ((_self.packet[co + 2] as u24be)) as u24be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3442:26 [INFO] [stderr] | [INFO] [stderr] 3442 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3451:26 [INFO] [stderr] | [INFO] [stderr] 3451 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3460:26 [INFO] [stderr] | [INFO] [stderr] 3460 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3469:26 [INFO] [stderr] | [INFO] [stderr] 3469 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3478:26 [INFO] [stderr] | [INFO] [stderr] 3478 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3487:26 [INFO] [stderr] | [INFO] [stderr] 3487 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3496:26 [INFO] [stderr] | [INFO] [stderr] 3496 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3505:26 [INFO] [stderr] | [INFO] [stderr] 3505 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3656:22 [INFO] [stderr] | [INFO] [stderr] 3656 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3678:22 [INFO] [stderr] | [INFO] [stderr] 3678 | let b2 = ((_self.packet[co + 2] as u24be)) as u24be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3692:26 [INFO] [stderr] | [INFO] [stderr] 3692 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3701:26 [INFO] [stderr] | [INFO] [stderr] 3701 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3710:26 [INFO] [stderr] | [INFO] [stderr] 3710 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3719:26 [INFO] [stderr] | [INFO] [stderr] 3719 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3728:26 [INFO] [stderr] | [INFO] [stderr] 3728 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3737:26 [INFO] [stderr] | [INFO] [stderr] 3737 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3746:26 [INFO] [stderr] | [INFO] [stderr] 3746 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3755:26 [INFO] [stderr] | [INFO] [stderr] 3755 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3869:44 [INFO] [stderr] | [INFO] [stderr] 3869 | _self.packet[co + 0] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4299:22 [INFO] [stderr] | [INFO] [stderr] 4299 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4313:22 [INFO] [stderr] | [INFO] [stderr] 4313 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4327:26 [INFO] [stderr] | [INFO] [stderr] 4327 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4336:26 [INFO] [stderr] | [INFO] [stderr] 4336 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4345:26 [INFO] [stderr] | [INFO] [stderr] 4345 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4354:26 [INFO] [stderr] | [INFO] [stderr] 4354 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4363:26 [INFO] [stderr] | [INFO] [stderr] 4363 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4372:26 [INFO] [stderr] | [INFO] [stderr] 4372 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4381:26 [INFO] [stderr] | [INFO] [stderr] 4381 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4390:26 [INFO] [stderr] | [INFO] [stderr] 4390 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4408:26 [INFO] [stderr] | [INFO] [stderr] 4408 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4417:26 [INFO] [stderr] | [INFO] [stderr] 4417 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4426:26 [INFO] [stderr] | [INFO] [stderr] 4426 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4435:26 [INFO] [stderr] | [INFO] [stderr] 4435 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4444:26 [INFO] [stderr] | [INFO] [stderr] 4444 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4453:26 [INFO] [stderr] | [INFO] [stderr] 4453 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4462:26 [INFO] [stderr] | [INFO] [stderr] 4462 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4471:26 [INFO] [stderr] | [INFO] [stderr] 4471 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4620:22 [INFO] [stderr] | [INFO] [stderr] 4620 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4634:22 [INFO] [stderr] | [INFO] [stderr] 4634 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4648:26 [INFO] [stderr] | [INFO] [stderr] 4648 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4657:26 [INFO] [stderr] | [INFO] [stderr] 4657 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4666:26 [INFO] [stderr] | [INFO] [stderr] 4666 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4675:26 [INFO] [stderr] | [INFO] [stderr] 4675 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4684:26 [INFO] [stderr] | [INFO] [stderr] 4684 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4693:26 [INFO] [stderr] | [INFO] [stderr] 4693 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4702:26 [INFO] [stderr] | [INFO] [stderr] 4702 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4711:26 [INFO] [stderr] | [INFO] [stderr] 4711 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4729:26 [INFO] [stderr] | [INFO] [stderr] 4729 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4738:26 [INFO] [stderr] | [INFO] [stderr] 4738 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4747:26 [INFO] [stderr] | [INFO] [stderr] 4747 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4756:26 [INFO] [stderr] | [INFO] [stderr] 4756 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4765:26 [INFO] [stderr] | [INFO] [stderr] 4765 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4774:26 [INFO] [stderr] | [INFO] [stderr] 4774 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4783:26 [INFO] [stderr] | [INFO] [stderr] 4783 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4792:26 [INFO] [stderr] | [INFO] [stderr] 4792 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4897:44 [INFO] [stderr] | [INFO] [stderr] 4897 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4898:44 [INFO] [stderr] | [INFO] [stderr] 4898 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/vlan.rs:144:18 [INFO] [stderr] | [INFO] [stderr] 144 | let b1 = ((_self.packet[co + 1] as u12be)) as u12be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/vlan.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/vlan.rs:245:18 [INFO] [stderr] | [INFO] [stderr] 245 | let b1 = ((_self.packet[co + 1] as u12be)) as u12be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/vlan.rs:259:22 [INFO] [stderr] | [INFO] [stderr] 259 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:219:22 [INFO] [stderr] | [INFO] [stderr] 219 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:388:22 [INFO] [stderr] | [INFO] [stderr] 388 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:163:18 [INFO] [stderr] | [INFO] [stderr] 163 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:536:18 [INFO] [stderr] | [INFO] [stderr] 536 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:822:46 [INFO] [stderr] | [INFO] [stderr] 822 | ((_self.packet[co + 0] & 248) | (((val & 7)) as u8)) as u8; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:842:46 [INFO] [stderr] | [INFO] [stderr] 842 | ((_self.packet[co + 0] & 248) | (((val & 7)) as u8)) as u8; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1352:18 [INFO] [stderr] | [INFO] [stderr] 1352 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1411:18 [INFO] [stderr] | [INFO] [stderr] 1411 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1635:18 [INFO] [stderr] | [INFO] [stderr] 1635 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1696:18 [INFO] [stderr] | [INFO] [stderr] 1696 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1707:40 [INFO] [stderr] | [INFO] [stderr] 1707 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1708:40 [INFO] [stderr] | [INFO] [stderr] 1708 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:280:18 [INFO] [stderr] | [INFO] [stderr] 280 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:292:18 [INFO] [stderr] | [INFO] [stderr] 292 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:313:18 [INFO] [stderr] | [INFO] [stderr] 313 | let b1 = ((_self.packet[co + 1] as u13be)) as u13be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:348:18 [INFO] [stderr] | [INFO] [stderr] 348 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:572:18 [INFO] [stderr] | [INFO] [stderr] 572 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:584:18 [INFO] [stderr] | [INFO] [stderr] 584 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:605:18 [INFO] [stderr] | [INFO] [stderr] 605 | let b1 = ((_self.packet[co + 1] as u13be)) as u13be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:640:18 [INFO] [stderr] | [INFO] [stderr] 640 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:775:46 [INFO] [stderr] | [INFO] [stderr] 775 | ((_self.packet[co + 0] & 240) | (((val & 15)) as u8)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:795:46 [INFO] [stderr] | [INFO] [stderr] 795 | ((_self.packet[co + 0] & 252) | (((val & 3)) as u8)) as u8; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1555:50 [INFO] [stderr] | [INFO] [stderr] 1555 | ((_self.packet[co + 0] & 224) | (((val & 31)) as u8)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | let b2 = ((_self.packet[co + 2] as u20be)) as u20be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:160:22 [INFO] [stderr] | [INFO] [stderr] 160 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:169:22 [INFO] [stderr] | [INFO] [stderr] 169 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:178:22 [INFO] [stderr] | [INFO] [stderr] 178 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:187:22 [INFO] [stderr] | [INFO] [stderr] 187 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:196:22 [INFO] [stderr] | [INFO] [stderr] 196 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:205:22 [INFO] [stderr] | [INFO] [stderr] 205 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:214:22 [INFO] [stderr] | [INFO] [stderr] 214 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:223:22 [INFO] [stderr] | [INFO] [stderr] 223 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:241:22 [INFO] [stderr] | [INFO] [stderr] 241 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:250:22 [INFO] [stderr] | [INFO] [stderr] 250 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:259:22 [INFO] [stderr] | [INFO] [stderr] 259 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:268:22 [INFO] [stderr] | [INFO] [stderr] 268 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:277:22 [INFO] [stderr] | [INFO] [stderr] 277 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:286:22 [INFO] [stderr] | [INFO] [stderr] 286 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:295:22 [INFO] [stderr] | [INFO] [stderr] 295 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:304:22 [INFO] [stderr] | [INFO] [stderr] 304 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:395:18 [INFO] [stderr] | [INFO] [stderr] 395 | let b2 = ((_self.packet[co + 2] as u20be)) as u20be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:407:18 [INFO] [stderr] | [INFO] [stderr] 407 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:444:22 [INFO] [stderr] | [INFO] [stderr] 444 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:453:22 [INFO] [stderr] | [INFO] [stderr] 453 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:462:22 [INFO] [stderr] | [INFO] [stderr] 462 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:471:22 [INFO] [stderr] | [INFO] [stderr] 471 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:480:22 [INFO] [stderr] | [INFO] [stderr] 480 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:489:22 [INFO] [stderr] | [INFO] [stderr] 489 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:498:22 [INFO] [stderr] | [INFO] [stderr] 498 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:507:22 [INFO] [stderr] | [INFO] [stderr] 507 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:525:22 [INFO] [stderr] | [INFO] [stderr] 525 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:534:22 [INFO] [stderr] | [INFO] [stderr] 534 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:543:22 [INFO] [stderr] | [INFO] [stderr] 543 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:552:22 [INFO] [stderr] | [INFO] [stderr] 552 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:561:22 [INFO] [stderr] | [INFO] [stderr] 561 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:570:22 [INFO] [stderr] | [INFO] [stderr] 570 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:579:22 [INFO] [stderr] | [INFO] [stderr] 579 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:588:22 [INFO] [stderr] | [INFO] [stderr] 588 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:626:54 [INFO] [stderr] | [INFO] [stderr] 626 | ((_self.packet[co + 0] & 240) | (((val & 983040) >> 16) as u8)) as [INFO] [stderr] | ^^^^^^ help: consider: `983_040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:116:18 [INFO] [stderr] | [INFO] [stderr] 116 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:128:18 [INFO] [stderr] | [INFO] [stderr] 128 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:140:18 [INFO] [stderr] | [INFO] [stderr] 140 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:202:18 [INFO] [stderr] | [INFO] [stderr] 202 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:214:18 [INFO] [stderr] | [INFO] [stderr] 214 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:226:18 [INFO] [stderr] | [INFO] [stderr] 226 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:238:18 [INFO] [stderr] | [INFO] [stderr] 238 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | pub const NS: u9be = 0b100000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | pub const CWR: u9be = 0b010000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | pub const ECE: u9be = 0b001000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:38:27 [INFO] [stderr] | [INFO] [stderr] 38 | pub const URG: u9be = 0b000100000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | pub const ACK: u9be = 0b000010000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | pub const PSH: u9be = 0b000001000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | pub const RST: u9be = 0b000000100; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:48:27 [INFO] [stderr] | [INFO] [stderr] 48 | pub const SYN: u9be = 0b000000010; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:50:27 [INFO] [stderr] | [INFO] [stderr] 50 | pub const FIN: u9be = 0b000000001; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:188:18 [INFO] [stderr] | [INFO] [stderr] 188 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:200:18 [INFO] [stderr] | [INFO] [stderr] 200 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:214:18 [INFO] [stderr] | [INFO] [stderr] 214 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:228:18 [INFO] [stderr] | [INFO] [stderr] 228 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:258:18 [INFO] [stderr] | [INFO] [stderr] 258 | let b1 = ((_self.packet[co + 1] as u9be)) as u9be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:270:18 [INFO] [stderr] | [INFO] [stderr] 270 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:282:18 [INFO] [stderr] | [INFO] [stderr] 282 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:294:18 [INFO] [stderr] | [INFO] [stderr] 294 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:407:18 [INFO] [stderr] | [INFO] [stderr] 407 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:419:18 [INFO] [stderr] | [INFO] [stderr] 419 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:433:18 [INFO] [stderr] | [INFO] [stderr] 433 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:447:18 [INFO] [stderr] | [INFO] [stderr] 447 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:477:18 [INFO] [stderr] | [INFO] [stderr] 477 | let b1 = ((_self.packet[co + 1] as u9be)) as u9be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:489:18 [INFO] [stderr] | [INFO] [stderr] 489 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:501:18 [INFO] [stderr] | [INFO] [stderr] 501 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:513:18 [INFO] [stderr] | [INFO] [stderr] 513 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:588:40 [INFO] [stderr] | [INFO] [stderr] 588 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:589:40 [INFO] [stderr] | [INFO] [stderr] 589 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:601:40 [INFO] [stderr] | [INFO] [stderr] 601 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:602:40 [INFO] [stderr] | [INFO] [stderr] 602 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1480:33 [INFO] [stderr] | [INFO] [stderr] 1480 | tcp_header.set_sequence(2419577528); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_419_577_528` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1481:53 [INFO] [stderr] | [INFO] [stderr] 1481 | assert_eq!(tcp_header . get_sequence ( ) , 0x9037d2b8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x9037_d2b8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1482:40 [INFO] [stderr] | [INFO] [stderr] 1482 | tcp_header.set_acknowledgement(2487988854); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_487_988_854` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1483:60 [INFO] [stderr] | [INFO] [stderr] 1483 | assert_eq!(tcp_header . get_acknowledgement ( ) , 0x944bb276); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x944b_b276` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1491:39 [INFO] [stderr] | [INFO] [stderr] 1491 | let ts = TcpOption::timestamp(743951781, 44056978); [INFO] [stderr] | ^^^^^^^^^ help: consider: `743_951_781` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1491:50 [INFO] [stderr] | [INFO] [stderr] 1491 | let ts = TcpOption::timestamp(743951781, 44056978); [INFO] [stderr] | ^^^^^^^^ help: consider: `44_056_978` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:151:22 [INFO] [stderr] | [INFO] [stderr] 151 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:185:22 [INFO] [stderr] | [INFO] [stderr] 185 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:428:22 [INFO] [stderr] | [INFO] [stderr] 428 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:444:22 [INFO] [stderr] | [INFO] [stderr] 444 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:478:22 [INFO] [stderr] | [INFO] [stderr] 478 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:173:18 [INFO] [stderr] | [INFO] [stderr] 173 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:262:18 [INFO] [stderr] | [INFO] [stderr] 262 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:679:22 [INFO] [stderr] | [INFO] [stderr] 679 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:691:22 [INFO] [stderr] | [INFO] [stderr] 691 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:703:22 [INFO] [stderr] | [INFO] [stderr] 703 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:801:22 [INFO] [stderr] | [INFO] [stderr] 801 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:813:22 [INFO] [stderr] | [INFO] [stderr] 813 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:825:22 [INFO] [stderr] | [INFO] [stderr] 825 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1205:22 [INFO] [stderr] | [INFO] [stderr] 1205 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1217:22 [INFO] [stderr] | [INFO] [stderr] 1217 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1229:22 [INFO] [stderr] | [INFO] [stderr] 1229 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1329:22 [INFO] [stderr] | [INFO] [stderr] 1329 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1341:22 [INFO] [stderr] | [INFO] [stderr] 1341 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1353:22 [INFO] [stderr] | [INFO] [stderr] 1353 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1745:22 [INFO] [stderr] | [INFO] [stderr] 1745 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1759:22 [INFO] [stderr] | [INFO] [stderr] 1759 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1862:22 [INFO] [stderr] | [INFO] [stderr] 1862 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1876:22 [INFO] [stderr] | [INFO] [stderr] 1876 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1934:44 [INFO] [stderr] | [INFO] [stderr] 1934 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1935:44 [INFO] [stderr] | [INFO] [stderr] 1935 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2221:22 [INFO] [stderr] | [INFO] [stderr] 2221 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2235:22 [INFO] [stderr] | [INFO] [stderr] 2235 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2334:22 [INFO] [stderr] | [INFO] [stderr] 2334 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2348:22 [INFO] [stderr] | [INFO] [stderr] 2348 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2404:44 [INFO] [stderr] | [INFO] [stderr] 2404 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2405:44 [INFO] [stderr] | [INFO] [stderr] 2405 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:210:18 [INFO] [stderr] | [INFO] [stderr] 210 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:302:18 [INFO] [stderr] | [INFO] [stderr] 302 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1143:22 [INFO] [stderr] | [INFO] [stderr] 1143 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1157:22 [INFO] [stderr] | [INFO] [stderr] 1157 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1302:22 [INFO] [stderr] | [INFO] [stderr] 1302 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1316:22 [INFO] [stderr] | [INFO] [stderr] 1316 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1417:44 [INFO] [stderr] | [INFO] [stderr] 1417 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1418:44 [INFO] [stderr] | [INFO] [stderr] 1418 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1762:22 [INFO] [stderr] | [INFO] [stderr] 1762 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1792:22 [INFO] [stderr] | [INFO] [stderr] 1792 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1806:22 [INFO] [stderr] | [INFO] [stderr] 1806 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1820:22 [INFO] [stderr] | [INFO] [stderr] 1820 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1969:22 [INFO] [stderr] | [INFO] [stderr] 1969 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:1999:22 [INFO] [stderr] | [INFO] [stderr] 1999 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2013:22 [INFO] [stderr] | [INFO] [stderr] 2013 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2027:22 [INFO] [stderr] | [INFO] [stderr] 2027 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2157:44 [INFO] [stderr] | [INFO] [stderr] 2157 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2158:44 [INFO] [stderr] | [INFO] [stderr] 2158 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2170:44 [INFO] [stderr] | [INFO] [stderr] 2170 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2171:44 [INFO] [stderr] | [INFO] [stderr] 2171 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2528:22 [INFO] [stderr] | [INFO] [stderr] 2528 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2542:22 [INFO] [stderr] | [INFO] [stderr] 2542 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2556:26 [INFO] [stderr] | [INFO] [stderr] 2556 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2565:26 [INFO] [stderr] | [INFO] [stderr] 2565 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2574:26 [INFO] [stderr] | [INFO] [stderr] 2574 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2583:26 [INFO] [stderr] | [INFO] [stderr] 2583 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2592:26 [INFO] [stderr] | [INFO] [stderr] 2592 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2601:26 [INFO] [stderr] | [INFO] [stderr] 2601 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2610:26 [INFO] [stderr] | [INFO] [stderr] 2610 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2619:26 [INFO] [stderr] | [INFO] [stderr] 2619 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2769:22 [INFO] [stderr] | [INFO] [stderr] 2769 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2783:22 [INFO] [stderr] | [INFO] [stderr] 2783 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2797:26 [INFO] [stderr] | [INFO] [stderr] 2797 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2806:26 [INFO] [stderr] | [INFO] [stderr] 2806 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2815:26 [INFO] [stderr] | [INFO] [stderr] 2815 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2824:26 [INFO] [stderr] | [INFO] [stderr] 2824 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2833:26 [INFO] [stderr] | [INFO] [stderr] 2833 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2842:26 [INFO] [stderr] | [INFO] [stderr] 2842 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2851:26 [INFO] [stderr] | [INFO] [stderr] 2851 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2860:26 [INFO] [stderr] | [INFO] [stderr] 2860 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2965:44 [INFO] [stderr] | [INFO] [stderr] 2965 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:2966:44 [INFO] [stderr] | [INFO] [stderr] 2966 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3406:22 [INFO] [stderr] | [INFO] [stderr] 3406 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3428:22 [INFO] [stderr] | [INFO] [stderr] 3428 | let b2 = ((_self.packet[co + 2] as u24be)) as u24be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3442:26 [INFO] [stderr] | [INFO] [stderr] 3442 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3451:26 [INFO] [stderr] | [INFO] [stderr] 3451 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3460:26 [INFO] [stderr] | [INFO] [stderr] 3460 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3469:26 [INFO] [stderr] | [INFO] [stderr] 3469 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3478:26 [INFO] [stderr] | [INFO] [stderr] 3478 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3487:26 [INFO] [stderr] | [INFO] [stderr] 3487 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3496:26 [INFO] [stderr] | [INFO] [stderr] 3496 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3505:26 [INFO] [stderr] | [INFO] [stderr] 3505 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3656:22 [INFO] [stderr] | [INFO] [stderr] 3656 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3678:22 [INFO] [stderr] | [INFO] [stderr] 3678 | let b2 = ((_self.packet[co + 2] as u24be)) as u24be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3692:26 [INFO] [stderr] | [INFO] [stderr] 3692 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3701:26 [INFO] [stderr] | [INFO] [stderr] 3701 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3710:26 [INFO] [stderr] | [INFO] [stderr] 3710 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3719:26 [INFO] [stderr] | [INFO] [stderr] 3719 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3728:26 [INFO] [stderr] | [INFO] [stderr] 3728 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3737:26 [INFO] [stderr] | [INFO] [stderr] 3737 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3746:26 [INFO] [stderr] | [INFO] [stderr] 3746 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3755:26 [INFO] [stderr] | [INFO] [stderr] 3755 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:3869:44 [INFO] [stderr] | [INFO] [stderr] 3869 | _self.packet[co + 0] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4299:22 [INFO] [stderr] | [INFO] [stderr] 4299 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4313:22 [INFO] [stderr] | [INFO] [stderr] 4313 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4327:26 [INFO] [stderr] | [INFO] [stderr] 4327 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4336:26 [INFO] [stderr] | [INFO] [stderr] 4336 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4345:26 [INFO] [stderr] | [INFO] [stderr] 4345 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4354:26 [INFO] [stderr] | [INFO] [stderr] 4354 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4363:26 [INFO] [stderr] | [INFO] [stderr] 4363 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4372:26 [INFO] [stderr] | [INFO] [stderr] 4372 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4381:26 [INFO] [stderr] | [INFO] [stderr] 4381 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4390:26 [INFO] [stderr] | [INFO] [stderr] 4390 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4408:26 [INFO] [stderr] | [INFO] [stderr] 4408 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4417:26 [INFO] [stderr] | [INFO] [stderr] 4417 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4426:26 [INFO] [stderr] | [INFO] [stderr] 4426 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4435:26 [INFO] [stderr] | [INFO] [stderr] 4435 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4444:26 [INFO] [stderr] | [INFO] [stderr] 4444 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4453:26 [INFO] [stderr] | [INFO] [stderr] 4453 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4462:26 [INFO] [stderr] | [INFO] [stderr] 4462 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4471:26 [INFO] [stderr] | [INFO] [stderr] 4471 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4620:22 [INFO] [stderr] | [INFO] [stderr] 4620 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4634:22 [INFO] [stderr] | [INFO] [stderr] 4634 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4648:26 [INFO] [stderr] | [INFO] [stderr] 4648 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4657:26 [INFO] [stderr] | [INFO] [stderr] 4657 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4666:26 [INFO] [stderr] | [INFO] [stderr] 4666 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4675:26 [INFO] [stderr] | [INFO] [stderr] 4675 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4684:26 [INFO] [stderr] | [INFO] [stderr] 4684 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4693:26 [INFO] [stderr] | [INFO] [stderr] 4693 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4702:26 [INFO] [stderr] | [INFO] [stderr] 4702 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4711:26 [INFO] [stderr] | [INFO] [stderr] 4711 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4729:26 [INFO] [stderr] | [INFO] [stderr] 4729 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4738:26 [INFO] [stderr] | [INFO] [stderr] 4738 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4747:26 [INFO] [stderr] | [INFO] [stderr] 4747 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4756:26 [INFO] [stderr] | [INFO] [stderr] 4756 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4765:26 [INFO] [stderr] | [INFO] [stderr] 4765 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4774:26 [INFO] [stderr] | [INFO] [stderr] 4774 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4783:26 [INFO] [stderr] | [INFO] [stderr] 4783 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4792:26 [INFO] [stderr] | [INFO] [stderr] 4792 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4897:44 [INFO] [stderr] | [INFO] [stderr] 4897 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_278_190_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:4898:44 [INFO] [stderr] | [INFO] [stderr] 4898 | _self.packet[co + 1] = ((val & 16711680) >> 16) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider: `16_711_680` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:5405:56 [INFO] [stderr] | [INFO] [stderr] 5405 | assert_eq!(pkg . get_reachable_time ( ) , 0x12345678); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmpv6.rs:5406:54 [INFO] [stderr] | [INFO] [stderr] 5406 | assert_eq!(pkg . get_retrans_time ( ) , 0x87654321); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8765_4321` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/vlan.rs:144:18 [INFO] [stderr] | [INFO] [stderr] 144 | let b1 = ((_self.packet[co + 1] as u12be)) as u12be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/vlan.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/vlan.rs:245:18 [INFO] [stderr] | [INFO] [stderr] 245 | let b1 = ((_self.packet[co + 1] as u12be)) as u12be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/vlan.rs:259:22 [INFO] [stderr] | [INFO] [stderr] 259 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 73 | | if packet.len() >= EthernetPacket::minimum_packet_size() { [INFO] [stderr] 74 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 75 | | Some(EthernetPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 76 | | } else { None } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / pub fn to_immutable<'p>(&'p self) -> EthernetPacket<'p> { [INFO] [stderr] 90 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 91 | | EthernetPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:218:23 [INFO] [stderr] | [INFO] [stderr] 218 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:218:37 [INFO] [stderr] | [INFO] [stderr] 218 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:219:22 [INFO] [stderr] | [INFO] [stderr] 219 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | / pub fn new<'p>(packet: &'p mut [u8]) [INFO] [stderr] 230 | | -> Option> { [INFO] [stderr] 231 | | if packet.len() >= MutableEthernetPacket::minimum_packet_size() { [INFO] [stderr] 232 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] ... | [INFO] [stderr] 235 | | } else { None } [INFO] [stderr] 236 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:248:5 [INFO] [stderr] | [INFO] [stderr] 248 | / pub fn to_immutable<'p>(&'p self) -> EthernetPacket<'p> { [INFO] [stderr] 249 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 250 | | EthernetPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 251 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:387:23 [INFO] [stderr] | [INFO] [stderr] 387 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:387:37 [INFO] [stderr] | [INFO] [stderr] 387 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:388:22 [INFO] [stderr] | [INFO] [stderr] 388 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:405:26 [INFO] [stderr] | [INFO] [stderr] 405 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:412:26 [INFO] [stderr] | [INFO] [stderr] 412 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:419:26 [INFO] [stderr] | [INFO] [stderr] 419 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:426:26 [INFO] [stderr] | [INFO] [stderr] 426 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:433:26 [INFO] [stderr] | [INFO] [stderr] 433 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:440:26 [INFO] [stderr] | [INFO] [stderr] 440 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:462:26 [INFO] [stderr] | [INFO] [stderr] 462 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:469:26 [INFO] [stderr] | [INFO] [stderr] 469 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:476:26 [INFO] [stderr] | [INFO] [stderr] 476 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:483:26 [INFO] [stderr] | [INFO] [stderr] 483 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:490:26 [INFO] [stderr] | [INFO] [stderr] 490 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:497:26 [INFO] [stderr] | [INFO] [stderr] 497 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:519:26 [INFO] [stderr] | [INFO] [stderr] 519 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:552:5 [INFO] [stderr] | [INFO] [stderr] 552 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:555:5 [INFO] [stderr] | [INFO] [stderr] 555 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 556 | | let _self = self; [INFO] [stderr] 557 | | let start = 14; [INFO] [stderr] 558 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 559 | | &mut _self.packet[start..] [INFO] [stderr] 560 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:565:5 [INFO] [stderr] | [INFO] [stderr] 565 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:568:5 [INFO] [stderr] | [INFO] [stderr] 568 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 569 | | let _self = self; [INFO] [stderr] 570 | | let start = 14; [INFO] [stderr] 571 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 572 | | &_self.packet[start..] [INFO] [stderr] 573 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:577:5 [INFO] [stderr] | [INFO] [stderr] 577 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:580:5 [INFO] [stderr] | [INFO] [stderr] 580 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 581 | | let _self = self; [INFO] [stderr] 582 | | let start = 14; [INFO] [stderr] 583 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 584 | | &_self.packet[start..] [INFO] [stderr] 585 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:599:12 [INFO] [stderr] | [INFO] [stderr] 599 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ethernet.rs:774:27 [INFO] [stderr] | [INFO] [stderr] 774 | write!(f , "{}" , match self { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 775 | | & EtherTypes :: Ipv4 => "Ipv4" , & EtherTypes :: Arp => "Arp" , [INFO] [stderr] 776 | | & EtherTypes :: WakeOnLan => "WakeOnLan" , & EtherTypes :: [INFO] [stderr] 777 | | Trill => "Trill" , & EtherTypes :: DECnet => "DECnet" , & [INFO] [stderr] ... | [INFO] [stderr] 788 | | Cfm => "Cfm" , & EtherTypes :: QinQ => "QinQ" , _ => "unknown" [INFO] [stderr] 789 | | , }) [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 774 | write!(f , "{}" , match *self { [INFO] [stderr] 775 | EtherTypes :: Ipv4 => "Ipv4" , EtherTypes :: Arp => "Arp" , [INFO] [stderr] 776 | EtherTypes :: WakeOnLan => "WakeOnLan" , EtherTypes :: [INFO] [stderr] 777 | Trill => "Trill" , EtherTypes :: DECnet => "DECnet" , EtherTypes :: Rarp => "Rarp" , EtherTypes :: AppleTalk => [INFO] [stderr] 778 | "AppleTalk" , EtherTypes :: Aarp => "Aarp" , EtherTypes :: [INFO] [stderr] 779 | Ipx => "Ipx" , EtherTypes :: Qnx => "Qnx" , EtherTypes :: [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 45 | | if packet.len() >= GrePacket::minimum_packet_size() { [INFO] [stderr] 46 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 47 | | Some(GrePacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 48 | | } else { None } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / pub fn to_immutable<'p>(&'p self) -> GrePacket<'p> { [INFO] [stderr] 62 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 63 | | GrePacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:162:19 [INFO] [stderr] | [INFO] [stderr] 162 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:162:33 [INFO] [stderr] | [INFO] [stderr] 162 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:163:18 [INFO] [stderr] | [INFO] [stderr] 163 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `co` is used as a loop counter. Consider using `for (co, item) in 0..vec.capacity().enumerate()` or similar iterators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:385:18 [INFO] [stderr] | [INFO] [stderr] 385 | for _ in 0..vec.capacity() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:396:5 [INFO] [stderr] | [INFO] [stderr] 396 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 397 | | if packet.len() >= MutableGrePacket::minimum_packet_size() { [INFO] [stderr] 398 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 399 | | Some(MutableGrePacket{packet: MutPacketData::Borrowed(packet),}) [INFO] [stderr] 400 | | } else { None } [INFO] [stderr] 401 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:413:5 [INFO] [stderr] | [INFO] [stderr] 413 | / pub fn to_immutable<'p>(&'p self) -> GrePacket<'p> { [INFO] [stderr] 414 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 415 | | GrePacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 416 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:535:19 [INFO] [stderr] | [INFO] [stderr] 535 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:535:33 [INFO] [stderr] | [INFO] [stderr] 535 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:536:18 [INFO] [stderr] | [INFO] [stderr] 536 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `co` is used as a loop counter. Consider using `for (co, item) in 0..vec.capacity().enumerate()` or similar iterators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:758:18 [INFO] [stderr] | [INFO] [stderr] 758 | for _ in 0..vec.capacity() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:772:28 [INFO] [stderr] | [INFO] [stderr] 772 | ((_self.packet[co + 0] & 127) | (((val & 1) << 7) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:771:22 [INFO] [stderr] | [INFO] [stderr] 771 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:782:28 [INFO] [stderr] | [INFO] [stderr] 782 | ((_self.packet[co + 0] & 191) | (((val & 1) << 6) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:781:22 [INFO] [stderr] | [INFO] [stderr] 781 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:792:28 [INFO] [stderr] | [INFO] [stderr] 792 | ((_self.packet[co + 0] & 223) | (((val & 1) << 5) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:791:22 [INFO] [stderr] | [INFO] [stderr] 791 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:802:28 [INFO] [stderr] | [INFO] [stderr] 802 | ((_self.packet[co + 0] & 239) | (((val & 1) << 4) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:801:22 [INFO] [stderr] | [INFO] [stderr] 801 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:812:28 [INFO] [stderr] | [INFO] [stderr] 812 | ((_self.packet[co + 0] & 247) | (((val & 1) << 3) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:811:22 [INFO] [stderr] | [INFO] [stderr] 811 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:822:28 [INFO] [stderr] | [INFO] [stderr] 822 | ((_self.packet[co + 0] & 248) | (((val & 7)) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:821:22 [INFO] [stderr] | [INFO] [stderr] 821 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:832:28 [INFO] [stderr] | [INFO] [stderr] 832 | ((_self.packet[co + 0] & 7) | (((val & 31) << 3) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:831:22 [INFO] [stderr] | [INFO] [stderr] 831 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:842:28 [INFO] [stderr] | [INFO] [stderr] 842 | ((_self.packet[co + 0] & 248) | (((val & 7)) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:841:22 [INFO] [stderr] | [INFO] [stderr] 841 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:852:22 [INFO] [stderr] | [INFO] [stderr] 852 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:877:25 [INFO] [stderr] | [INFO] [stderr] 877 | for val in vals.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:908:25 [INFO] [stderr] | [INFO] [stderr] 908 | for val in vals.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:942:25 [INFO] [stderr] | [INFO] [stderr] 942 | for val in vals.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:978:25 [INFO] [stderr] | [INFO] [stderr] 978 | for val in vals.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1068:5 [INFO] [stderr] | [INFO] [stderr] 1068 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1071:5 [INFO] [stderr] | [INFO] [stderr] 1071 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 1072 | | let _self = self; [INFO] [stderr] 1073 | | let start = [INFO] [stderr] 1074 | | 4 + gre_checksum_length(&_self.to_immutable()) + [INFO] [stderr] ... | [INFO] [stderr] 1080 | | &mut _self.packet[start..] [INFO] [stderr] 1081 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1085:5 [INFO] [stderr] | [INFO] [stderr] 1085 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1088:5 [INFO] [stderr] | [INFO] [stderr] 1088 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1089 | | let _self = self; [INFO] [stderr] 1090 | | let start = [INFO] [stderr] 1091 | | 4 + gre_checksum_length(&_self.to_immutable()) + [INFO] [stderr] ... | [INFO] [stderr] 1097 | | &_self.packet[start..] [INFO] [stderr] 1098 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1102:5 [INFO] [stderr] | [INFO] [stderr] 1102 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1105:5 [INFO] [stderr] | [INFO] [stderr] 1105 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1106 | | let _self = self; [INFO] [stderr] 1107 | | let start = [INFO] [stderr] 1108 | | 4 + gre_checksum_length(&_self.to_immutable()) + [INFO] [stderr] ... | [INFO] [stderr] 1114 | | &_self.packet[start..] [INFO] [stderr] 1115 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1129:12 [INFO] [stderr] | [INFO] [stderr] 1129 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1309:5 [INFO] [stderr] | [INFO] [stderr] 1309 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 1310 | | if packet.len() >= U16BEPacket::minimum_packet_size() { [INFO] [stderr] 1311 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1312 | | Some(U16BEPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 1313 | | } else { None } [INFO] [stderr] 1314 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1326:5 [INFO] [stderr] | [INFO] [stderr] 1326 | / pub fn to_immutable<'p>(&'p self) -> U16BEPacket<'p> { [INFO] [stderr] 1327 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1328 | | U16BEPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 1329 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1351:19 [INFO] [stderr] | [INFO] [stderr] 1351 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1351:33 [INFO] [stderr] | [INFO] [stderr] 1351 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1352:18 [INFO] [stderr] | [INFO] [stderr] 1352 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1360:5 [INFO] [stderr] | [INFO] [stderr] 1360 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 1361 | | if packet.len() >= MutableU16BEPacket::minimum_packet_size() { [INFO] [stderr] 1362 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 1363 | | Some(MutableU16BEPacket{packet: MutPacketData::Borrowed(packet),}) [INFO] [stderr] 1364 | | } else { None } [INFO] [stderr] 1365 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1377:5 [INFO] [stderr] | [INFO] [stderr] 1377 | / pub fn to_immutable<'p>(&'p self) -> U16BEPacket<'p> { [INFO] [stderr] 1378 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1379 | | U16BEPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 1380 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1410:19 [INFO] [stderr] | [INFO] [stderr] 1410 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1410:33 [INFO] [stderr] | [INFO] [stderr] 1410 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1411:18 [INFO] [stderr] | [INFO] [stderr] 1411 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1422:22 [INFO] [stderr] | [INFO] [stderr] 1422 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1444:56 [INFO] [stderr] | [INFO] [stderr] 1444 | fn packet_size(&self) -> usize { let _self = self; 2 + 0 } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1449:56 [INFO] [stderr] | [INFO] [stderr] 1449 | fn packet_size(&self) -> usize { let _self = self; 2 + 0 } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1454:5 [INFO] [stderr] | [INFO] [stderr] 1454 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1457:5 [INFO] [stderr] | [INFO] [stderr] 1457 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 1458 | | let _self = self; [INFO] [stderr] 1459 | | let start = 2; [INFO] [stderr] 1460 | | let end = ::std::cmp::min(2 + 0, _self.packet.len()); [INFO] [stderr] 1461 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 1462 | | &mut _self.packet[start..end] [INFO] [stderr] 1463 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1460:35 [INFO] [stderr] | [INFO] [stderr] 1460 | let end = ::std::cmp::min(2 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1467:5 [INFO] [stderr] | [INFO] [stderr] 1467 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1470:5 [INFO] [stderr] | [INFO] [stderr] 1470 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1471 | | let _self = self; [INFO] [stderr] 1472 | | let start = 2; [INFO] [stderr] 1473 | | let end = ::std::cmp::min(2 + 0, _self.packet.len()); [INFO] [stderr] 1474 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 1475 | | &_self.packet[start..end] [INFO] [stderr] 1476 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1473:35 [INFO] [stderr] | [INFO] [stderr] 1473 | let end = ::std::cmp::min(2 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1480:5 [INFO] [stderr] | [INFO] [stderr] 1480 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1483:5 [INFO] [stderr] | [INFO] [stderr] 1483 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1484 | | let _self = self; [INFO] [stderr] 1485 | | let start = 2; [INFO] [stderr] 1486 | | let end = ::std::cmp::min(2 + 0, _self.packet.len()); [INFO] [stderr] 1487 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 1488 | | &_self.packet[start..end] [INFO] [stderr] 1489 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1486:35 [INFO] [stderr] | [INFO] [stderr] 1486 | let end = ::std::cmp::min(2 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1503:12 [INFO] [stderr] | [INFO] [stderr] 1503 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1590:5 [INFO] [stderr] | [INFO] [stderr] 1590 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 1591 | | if packet.len() >= U32BEPacket::minimum_packet_size() { [INFO] [stderr] 1592 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1593 | | Some(U32BEPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 1594 | | } else { None } [INFO] [stderr] 1595 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1607:5 [INFO] [stderr] | [INFO] [stderr] 1607 | / pub fn to_immutable<'p>(&'p self) -> U32BEPacket<'p> { [INFO] [stderr] 1608 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1609 | | U32BEPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 1610 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1632:19 [INFO] [stderr] | [INFO] [stderr] 1632 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1632:33 [INFO] [stderr] | [INFO] [stderr] 1632 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1633:19 [INFO] [stderr] | [INFO] [stderr] 1633 | let b1 = ((_self.packet[co + 1] as u32be) << 16) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1634:19 [INFO] [stderr] | [INFO] [stderr] 1634 | let b2 = ((_self.packet[co + 2] as u32be) << 8) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1635:18 [INFO] [stderr] | [INFO] [stderr] 1635 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1643:5 [INFO] [stderr] | [INFO] [stderr] 1643 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 1644 | | if packet.len() >= MutableU32BEPacket::minimum_packet_size() { [INFO] [stderr] 1645 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 1646 | | Some(MutableU32BEPacket{packet: MutPacketData::Borrowed(packet),}) [INFO] [stderr] 1647 | | } else { None } [INFO] [stderr] 1648 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1660:5 [INFO] [stderr] | [INFO] [stderr] 1660 | / pub fn to_immutable<'p>(&'p self) -> U32BEPacket<'p> { [INFO] [stderr] 1661 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1662 | | U32BEPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 1663 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1693:19 [INFO] [stderr] | [INFO] [stderr] 1693 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1693:33 [INFO] [stderr] | [INFO] [stderr] 1693 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1694:19 [INFO] [stderr] | [INFO] [stderr] 1694 | let b1 = ((_self.packet[co + 1] as u32be) << 16) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1695:19 [INFO] [stderr] | [INFO] [stderr] 1695 | let b2 = ((_self.packet[co + 2] as u32be) << 8) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1696:18 [INFO] [stderr] | [INFO] [stderr] 1696 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1707:22 [INFO] [stderr] | [INFO] [stderr] 1707 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1731:56 [INFO] [stderr] | [INFO] [stderr] 1731 | fn packet_size(&self) -> usize { let _self = self; 4 + 0 } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1736:56 [INFO] [stderr] | [INFO] [stderr] 1736 | fn packet_size(&self) -> usize { let _self = self; 4 + 0 } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1741:5 [INFO] [stderr] | [INFO] [stderr] 1741 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1744:5 [INFO] [stderr] | [INFO] [stderr] 1744 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 1745 | | let _self = self; [INFO] [stderr] 1746 | | let start = 4; [INFO] [stderr] 1747 | | let end = ::std::cmp::min(4 + 0, _self.packet.len()); [INFO] [stderr] 1748 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 1749 | | &mut _self.packet[start..end] [INFO] [stderr] 1750 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1747:35 [INFO] [stderr] | [INFO] [stderr] 1747 | let end = ::std::cmp::min(4 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1754:5 [INFO] [stderr] | [INFO] [stderr] 1754 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1757:5 [INFO] [stderr] | [INFO] [stderr] 1757 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1758 | | let _self = self; [INFO] [stderr] 1759 | | let start = 4; [INFO] [stderr] 1760 | | let end = ::std::cmp::min(4 + 0, _self.packet.len()); [INFO] [stderr] 1761 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 1762 | | &_self.packet[start..end] [INFO] [stderr] 1763 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1760:35 [INFO] [stderr] | [INFO] [stderr] 1760 | let end = ::std::cmp::min(4 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1767:5 [INFO] [stderr] | [INFO] [stderr] 1767 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1770:5 [INFO] [stderr] | [INFO] [stderr] 1770 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1771 | | let _self = self; [INFO] [stderr] 1772 | | let start = 4; [INFO] [stderr] 1773 | | let end = ::std::cmp::min(4 + 0, _self.packet.len()); [INFO] [stderr] 1774 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 1775 | | &_self.packet[start..end] [INFO] [stderr] 1776 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1773:35 [INFO] [stderr] | [INFO] [stderr] 1773 | let end = ::std::cmp::min(4 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/gre.rs:1790:12 [INFO] [stderr] | [INFO] [stderr] 1790 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ip.rs:493:16 [INFO] [stderr] | [INFO] [stderr] 493 | / match self { [INFO] [stderr] 494 | | &IpNextHeaderProtocols::Hopopt => "Hopopt", // 0 [INFO] [stderr] 495 | | &IpNextHeaderProtocols::Icmp => "Icmp", // 1 [INFO] [stderr] 496 | | &IpNextHeaderProtocols::Igmp => "Igmp", // 2 [INFO] [stderr] ... | [INFO] [stderr] 640 | | _ => "unknown", [INFO] [stderr] 641 | | }) [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 493 | match *self { [INFO] [stderr] 494 | IpNextHeaderProtocols::Hopopt => "Hopopt", // 0 [INFO] [stderr] 495 | IpNextHeaderProtocols::Icmp => "Icmp", // 1 [INFO] [stderr] 496 | IpNextHeaderProtocols::Igmp => "Igmp", // 2 [INFO] [stderr] 497 | IpNextHeaderProtocols::Ggp => "Ggp", // 3 [INFO] [stderr] 498 | IpNextHeaderProtocols::Ipv4 => "Ipv4", // 4 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 200 | | if packet.len() >= Ipv4Packet::minimum_packet_size() { [INFO] [stderr] 201 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 202 | | Some(Ipv4Packet{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 203 | | } else { None } [INFO] [stderr] 204 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:216:5 [INFO] [stderr] | [INFO] [stderr] 216 | / pub fn to_immutable<'p>(&'p self) -> Ipv4Packet<'p> { [INFO] [stderr] 217 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 218 | | Ipv4Packet{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 219 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:279:19 [INFO] [stderr] | [INFO] [stderr] 279 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:279:33 [INFO] [stderr] | [INFO] [stderr] 279 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:280:18 [INFO] [stderr] | [INFO] [stderr] 280 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:291:19 [INFO] [stderr] | [INFO] [stderr] 291 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:291:33 [INFO] [stderr] | [INFO] [stderr] 291 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:292:18 [INFO] [stderr] | [INFO] [stderr] 292 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:312:20 [INFO] [stderr] | [INFO] [stderr] 312 | let b0 = (((_self.packet[co + 0] as u13be) & 31) << 8) as u13be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:312:34 [INFO] [stderr] | [INFO] [stderr] 312 | let b0 = (((_self.packet[co + 0] as u13be) & 31) << 8) as u13be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:313:18 [INFO] [stderr] | [INFO] [stderr] 313 | let b1 = ((_self.packet[co + 1] as u13be)) as u13be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:347:19 [INFO] [stderr] | [INFO] [stderr] 347 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:347:33 [INFO] [stderr] | [INFO] [stderr] 347 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:348:18 [INFO] [stderr] | [INFO] [stderr] 348 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:470:5 [INFO] [stderr] | [INFO] [stderr] 470 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 471 | | if packet.len() >= MutableIpv4Packet::minimum_packet_size() { [INFO] [stderr] 472 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 473 | | Some(MutableIpv4Packet{packet: MutPacketData::Borrowed(packet),}) [INFO] [stderr] 474 | | } else { None } [INFO] [stderr] 475 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:487:5 [INFO] [stderr] | [INFO] [stderr] 487 | / pub fn to_immutable<'p>(&'p self) -> Ipv4Packet<'p> { [INFO] [stderr] 488 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 489 | | Ipv4Packet{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 490 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:571:19 [INFO] [stderr] | [INFO] [stderr] 571 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:571:33 [INFO] [stderr] | [INFO] [stderr] 571 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:572:18 [INFO] [stderr] | [INFO] [stderr] 572 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:583:19 [INFO] [stderr] | [INFO] [stderr] 583 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:583:33 [INFO] [stderr] | [INFO] [stderr] 583 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:584:18 [INFO] [stderr] | [INFO] [stderr] 584 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:604:20 [INFO] [stderr] | [INFO] [stderr] 604 | let b0 = (((_self.packet[co + 0] as u13be) & 31) << 8) as u13be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:604:34 [INFO] [stderr] | [INFO] [stderr] 604 | let b0 = (((_self.packet[co + 0] as u13be) & 31) << 8) as u13be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:605:18 [INFO] [stderr] | [INFO] [stderr] 605 | let b1 = ((_self.packet[co + 1] as u13be)) as u13be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:639:19 [INFO] [stderr] | [INFO] [stderr] 639 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:639:33 [INFO] [stderr] | [INFO] [stderr] 639 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:640:18 [INFO] [stderr] | [INFO] [stderr] 640 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:765:28 [INFO] [stderr] | [INFO] [stderr] 765 | ((_self.packet[co + 0] & 15) | (((val & 15) << 4) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:764:22 [INFO] [stderr] | [INFO] [stderr] 764 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:775:28 [INFO] [stderr] | [INFO] [stderr] 775 | ((_self.packet[co + 0] & 240) | (((val & 15)) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:774:22 [INFO] [stderr] | [INFO] [stderr] 774 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:785:28 [INFO] [stderr] | [INFO] [stderr] 785 | ((_self.packet[co + 0] & 3) | (((val & 63) << 2) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:784:22 [INFO] [stderr] | [INFO] [stderr] 784 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:795:28 [INFO] [stderr] | [INFO] [stderr] 795 | ((_self.packet[co + 0] & 252) | (((val & 3)) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:794:22 [INFO] [stderr] | [INFO] [stderr] 794 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:805:22 [INFO] [stderr] | [INFO] [stderr] 805 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:816:22 [INFO] [stderr] | [INFO] [stderr] 816 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:827:28 [INFO] [stderr] | [INFO] [stderr] 827 | ((_self.packet[co + 0] & 31) | (((val & 7) << 5) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:826:22 [INFO] [stderr] | [INFO] [stderr] 826 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:838:28 [INFO] [stderr] | [INFO] [stderr] 838 | ((_self.packet[co + 0] & 224) | (((val & 7936) >> 8) as u8)) as [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:837:22 [INFO] [stderr] | [INFO] [stderr] 837 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:849:22 [INFO] [stderr] | [INFO] [stderr] 849 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:863:26 [INFO] [stderr] | [INFO] [stderr] 863 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:876:22 [INFO] [stderr] | [INFO] [stderr] 876 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:891:26 [INFO] [stderr] | [INFO] [stderr] 891 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:898:26 [INFO] [stderr] | [INFO] [stderr] 898 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:905:26 [INFO] [stderr] | [INFO] [stderr] 905 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:912:26 [INFO] [stderr] | [INFO] [stderr] 912 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:932:26 [INFO] [stderr] | [INFO] [stderr] 932 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:939:26 [INFO] [stderr] | [INFO] [stderr] 939 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:946:26 [INFO] [stderr] | [INFO] [stderr] 946 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:953:26 [INFO] [stderr] | [INFO] [stderr] 953 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:983:25 [INFO] [stderr] | [INFO] [stderr] 983 | for val in vals.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1028:5 [INFO] [stderr] | [INFO] [stderr] 1028 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1031:5 [INFO] [stderr] | [INFO] [stderr] 1031 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 1032 | | let _self = self; [INFO] [stderr] 1033 | | let start = 20 + ipv4_options_length(&_self.to_immutable()); [INFO] [stderr] 1034 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 1039 | | &mut _self.packet[start..end] [INFO] [stderr] 1040 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1044:5 [INFO] [stderr] | [INFO] [stderr] 1044 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1047:5 [INFO] [stderr] | [INFO] [stderr] 1047 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1048 | | let _self = self; [INFO] [stderr] 1049 | | let start = 20 + ipv4_options_length(&_self.to_immutable()); [INFO] [stderr] 1050 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 1055 | | &_self.packet[start..end] [INFO] [stderr] 1056 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1060:5 [INFO] [stderr] | [INFO] [stderr] 1060 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1063:5 [INFO] [stderr] | [INFO] [stderr] 1063 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1064 | | let _self = self; [INFO] [stderr] 1065 | | let start = 20 + ipv4_options_length(&_self.to_immutable()); [INFO] [stderr] 1066 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 1071 | | &_self.packet[start..end] [INFO] [stderr] 1072 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1086:12 [INFO] [stderr] | [INFO] [stderr] 1086 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1296:5 [INFO] [stderr] | [INFO] [stderr] 1296 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 1297 | | if packet.len() >= Ipv4OptionPacket::minimum_packet_size() { [INFO] [stderr] 1298 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1299 | | Some(Ipv4OptionPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 1300 | | } else { None } [INFO] [stderr] 1301 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1313:5 [INFO] [stderr] | [INFO] [stderr] 1313 | / pub fn to_immutable<'p>(&'p self) -> Ipv4OptionPacket<'p> { [INFO] [stderr] 1314 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1315 | | Ipv4OptionPacket{packet: [INFO] [stderr] 1316 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 1317 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the variable `co` is used as a loop counter. Consider using `for (co, item) in 0..vec.capacity().enumerate()` or similar iterators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1393:18 [INFO] [stderr] | [INFO] [stderr] 1393 | for _ in 0..vec.capacity() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1404:5 [INFO] [stderr] | [INFO] [stderr] 1404 | / pub fn new<'p>(packet: &'p mut [u8]) [INFO] [stderr] 1405 | | -> Option> { [INFO] [stderr] 1406 | | if packet.len() >= MutableIpv4OptionPacket::minimum_packet_size() { [INFO] [stderr] 1407 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] ... | [INFO] [stderr] 1410 | | } else { None } [INFO] [stderr] 1411 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1425:5 [INFO] [stderr] | [INFO] [stderr] 1425 | / pub fn to_immutable<'p>(&'p self) -> Ipv4OptionPacket<'p> { [INFO] [stderr] 1426 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1427 | | Ipv4OptionPacket{packet: [INFO] [stderr] 1428 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 1429 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the variable `co` is used as a loop counter. Consider using `for (co, item) in 0..vec.capacity().enumerate()` or similar iterators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1516:18 [INFO] [stderr] | [INFO] [stderr] 1516 | for _ in 0..vec.capacity() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1530:28 [INFO] [stderr] | [INFO] [stderr] 1530 | ((_self.packet[co + 0] & 127) | (((val & 1) << 7) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1529:22 [INFO] [stderr] | [INFO] [stderr] 1529 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1540:28 [INFO] [stderr] | [INFO] [stderr] 1540 | ((_self.packet[co + 0] & 159) | (((val & 3) << 5) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1539:22 [INFO] [stderr] | [INFO] [stderr] 1539 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1555:32 [INFO] [stderr] | [INFO] [stderr] 1555 | ((_self.packet[co + 0] & 224) | (((val & 31)) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1554:26 [INFO] [stderr] | [INFO] [stderr] 1554 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1626:5 [INFO] [stderr] | [INFO] [stderr] 1626 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1629:5 [INFO] [stderr] | [INFO] [stderr] 1629 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 1630 | | let _self = self; [INFO] [stderr] 1631 | | let start = 1 + ipv4_option_length(&_self.to_immutable()); [INFO] [stderr] 1632 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 1637 | | &mut _self.packet[start..end] [INFO] [stderr] 1638 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1643:5 [INFO] [stderr] | [INFO] [stderr] 1643 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1646:5 [INFO] [stderr] | [INFO] [stderr] 1646 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1647 | | let _self = self; [INFO] [stderr] 1648 | | let start = 1 + ipv4_option_length(&_self.to_immutable()); [INFO] [stderr] 1649 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 1654 | | &_self.packet[start..end] [INFO] [stderr] 1655 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1659:5 [INFO] [stderr] | [INFO] [stderr] 1659 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1662:5 [INFO] [stderr] | [INFO] [stderr] 1662 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1663 | | let _self = self; [INFO] [stderr] 1664 | | let start = 1 + ipv4_option_length(&_self.to_immutable()); [INFO] [stderr] 1665 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 1670 | | &_self.packet[start..end] [INFO] [stderr] 1671 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv4.rs:1685:12 [INFO] [stderr] | [INFO] [stderr] 1685 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 48 | | if packet.len() >= Ipv6Packet::minimum_packet_size() { [INFO] [stderr] 49 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 50 | | Some(Ipv6Packet{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 51 | | } else { None } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / pub fn to_immutable<'p>(&'p self) -> Ipv6Packet<'p> { [INFO] [stderr] 65 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 66 | | Ipv6Packet{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:97:34 [INFO] [stderr] | [INFO] [stderr] 97 | let b0 = (((_self.packet[co + 0] as u8) & 15) << 4) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:109:20 [INFO] [stderr] | [INFO] [stderr] 109 | let b0 = (((_self.packet[co + 0] as u20be) & 15) << 16) as u20be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:109:34 [INFO] [stderr] | [INFO] [stderr] 109 | let b0 = (((_self.packet[co + 0] as u20be) & 15) << 16) as u20be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:110:19 [INFO] [stderr] | [INFO] [stderr] 110 | let b1 = ((_self.packet[co + 1] as u20be) << 8) as u20be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | let b2 = ((_self.packet[co + 2] as u20be)) as u20be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:122:19 [INFO] [stderr] | [INFO] [stderr] 122 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:122:33 [INFO] [stderr] | [INFO] [stderr] 122 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:159:23 [INFO] [stderr] | [INFO] [stderr] 159 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:159:37 [INFO] [stderr] | [INFO] [stderr] 159 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:160:22 [INFO] [stderr] | [INFO] [stderr] 160 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:168:23 [INFO] [stderr] | [INFO] [stderr] 168 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:168:37 [INFO] [stderr] | [INFO] [stderr] 168 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:169:22 [INFO] [stderr] | [INFO] [stderr] 169 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:177:23 [INFO] [stderr] | [INFO] [stderr] 177 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:177:37 [INFO] [stderr] | [INFO] [stderr] 177 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:178:22 [INFO] [stderr] | [INFO] [stderr] 178 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:186:23 [INFO] [stderr] | [INFO] [stderr] 186 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:186:37 [INFO] [stderr] | [INFO] [stderr] 186 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:187:22 [INFO] [stderr] | [INFO] [stderr] 187 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:195:23 [INFO] [stderr] | [INFO] [stderr] 195 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:195:37 [INFO] [stderr] | [INFO] [stderr] 195 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:196:22 [INFO] [stderr] | [INFO] [stderr] 196 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:204:23 [INFO] [stderr] | [INFO] [stderr] 204 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:204:37 [INFO] [stderr] | [INFO] [stderr] 204 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:205:22 [INFO] [stderr] | [INFO] [stderr] 205 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:213:23 [INFO] [stderr] | [INFO] [stderr] 213 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:213:37 [INFO] [stderr] | [INFO] [stderr] 213 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:214:22 [INFO] [stderr] | [INFO] [stderr] 214 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:222:23 [INFO] [stderr] | [INFO] [stderr] 222 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:222:37 [INFO] [stderr] | [INFO] [stderr] 222 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:223:22 [INFO] [stderr] | [INFO] [stderr] 223 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:240:23 [INFO] [stderr] | [INFO] [stderr] 240 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:240:37 [INFO] [stderr] | [INFO] [stderr] 240 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:241:22 [INFO] [stderr] | [INFO] [stderr] 241 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:249:23 [INFO] [stderr] | [INFO] [stderr] 249 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:249:37 [INFO] [stderr] | [INFO] [stderr] 249 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:250:22 [INFO] [stderr] | [INFO] [stderr] 250 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:258:23 [INFO] [stderr] | [INFO] [stderr] 258 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:258:37 [INFO] [stderr] | [INFO] [stderr] 258 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:259:22 [INFO] [stderr] | [INFO] [stderr] 259 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:267:23 [INFO] [stderr] | [INFO] [stderr] 267 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:267:37 [INFO] [stderr] | [INFO] [stderr] 267 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:268:22 [INFO] [stderr] | [INFO] [stderr] 268 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:276:23 [INFO] [stderr] | [INFO] [stderr] 276 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:276:37 [INFO] [stderr] | [INFO] [stderr] 276 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:277:22 [INFO] [stderr] | [INFO] [stderr] 277 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:285:23 [INFO] [stderr] | [INFO] [stderr] 285 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:285:37 [INFO] [stderr] | [INFO] [stderr] 285 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:286:22 [INFO] [stderr] | [INFO] [stderr] 286 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:294:23 [INFO] [stderr] | [INFO] [stderr] 294 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:294:37 [INFO] [stderr] | [INFO] [stderr] 294 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:295:22 [INFO] [stderr] | [INFO] [stderr] 295 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:303:23 [INFO] [stderr] | [INFO] [stderr] 303 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:303:37 [INFO] [stderr] | [INFO] [stderr] 303 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:304:22 [INFO] [stderr] | [INFO] [stderr] 304 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:316:5 [INFO] [stderr] | [INFO] [stderr] 316 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 317 | | if packet.len() >= MutableIpv6Packet::minimum_packet_size() { [INFO] [stderr] 318 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 319 | | Some(MutableIpv6Packet{packet: MutPacketData::Borrowed(packet),}) [INFO] [stderr] 320 | | } else { None } [INFO] [stderr] 321 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:333:5 [INFO] [stderr] | [INFO] [stderr] 333 | / pub fn to_immutable<'p>(&'p self) -> Ipv6Packet<'p> { [INFO] [stderr] 334 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 335 | | Ipv6Packet{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 336 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:381:34 [INFO] [stderr] | [INFO] [stderr] 381 | let b0 = (((_self.packet[co + 0] as u8) & 15) << 4) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:393:20 [INFO] [stderr] | [INFO] [stderr] 393 | let b0 = (((_self.packet[co + 0] as u20be) & 15) << 16) as u20be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:393:34 [INFO] [stderr] | [INFO] [stderr] 393 | let b0 = (((_self.packet[co + 0] as u20be) & 15) << 16) as u20be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:394:19 [INFO] [stderr] | [INFO] [stderr] 394 | let b1 = ((_self.packet[co + 1] as u20be) << 8) as u20be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:395:18 [INFO] [stderr] | [INFO] [stderr] 395 | let b2 = ((_self.packet[co + 2] as u20be)) as u20be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:406:19 [INFO] [stderr] | [INFO] [stderr] 406 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:406:33 [INFO] [stderr] | [INFO] [stderr] 406 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:407:18 [INFO] [stderr] | [INFO] [stderr] 407 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:443:23 [INFO] [stderr] | [INFO] [stderr] 443 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:443:37 [INFO] [stderr] | [INFO] [stderr] 443 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:444:22 [INFO] [stderr] | [INFO] [stderr] 444 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:452:23 [INFO] [stderr] | [INFO] [stderr] 452 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:452:37 [INFO] [stderr] | [INFO] [stderr] 452 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:453:22 [INFO] [stderr] | [INFO] [stderr] 453 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:461:23 [INFO] [stderr] | [INFO] [stderr] 461 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:461:37 [INFO] [stderr] | [INFO] [stderr] 461 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:462:22 [INFO] [stderr] | [INFO] [stderr] 462 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:470:23 [INFO] [stderr] | [INFO] [stderr] 470 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:470:37 [INFO] [stderr] | [INFO] [stderr] 470 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:471:22 [INFO] [stderr] | [INFO] [stderr] 471 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:479:23 [INFO] [stderr] | [INFO] [stderr] 479 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:479:37 [INFO] [stderr] | [INFO] [stderr] 479 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:480:22 [INFO] [stderr] | [INFO] [stderr] 480 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:488:23 [INFO] [stderr] | [INFO] [stderr] 488 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:488:37 [INFO] [stderr] | [INFO] [stderr] 488 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:489:22 [INFO] [stderr] | [INFO] [stderr] 489 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:497:23 [INFO] [stderr] | [INFO] [stderr] 497 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:497:37 [INFO] [stderr] | [INFO] [stderr] 497 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:498:22 [INFO] [stderr] | [INFO] [stderr] 498 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:506:23 [INFO] [stderr] | [INFO] [stderr] 506 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:506:37 [INFO] [stderr] | [INFO] [stderr] 506 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:507:22 [INFO] [stderr] | [INFO] [stderr] 507 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:524:23 [INFO] [stderr] | [INFO] [stderr] 524 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:524:37 [INFO] [stderr] | [INFO] [stderr] 524 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:525:22 [INFO] [stderr] | [INFO] [stderr] 525 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:533:23 [INFO] [stderr] | [INFO] [stderr] 533 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:533:37 [INFO] [stderr] | [INFO] [stderr] 533 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:534:22 [INFO] [stderr] | [INFO] [stderr] 534 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:542:23 [INFO] [stderr] | [INFO] [stderr] 542 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:542:37 [INFO] [stderr] | [INFO] [stderr] 542 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:543:22 [INFO] [stderr] | [INFO] [stderr] 543 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:551:23 [INFO] [stderr] | [INFO] [stderr] 551 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:551:37 [INFO] [stderr] | [INFO] [stderr] 551 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:552:22 [INFO] [stderr] | [INFO] [stderr] 552 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:560:23 [INFO] [stderr] | [INFO] [stderr] 560 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:560:37 [INFO] [stderr] | [INFO] [stderr] 560 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:561:22 [INFO] [stderr] | [INFO] [stderr] 561 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:569:23 [INFO] [stderr] | [INFO] [stderr] 569 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:569:37 [INFO] [stderr] | [INFO] [stderr] 569 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:570:22 [INFO] [stderr] | [INFO] [stderr] 570 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:578:23 [INFO] [stderr] | [INFO] [stderr] 578 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:578:37 [INFO] [stderr] | [INFO] [stderr] 578 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:579:22 [INFO] [stderr] | [INFO] [stderr] 579 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:587:23 [INFO] [stderr] | [INFO] [stderr] 587 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:587:37 [INFO] [stderr] | [INFO] [stderr] 587 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:588:22 [INFO] [stderr] | [INFO] [stderr] 588 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:603:28 [INFO] [stderr] | [INFO] [stderr] 603 | ((_self.packet[co + 0] & 15) | (((val & 15) << 4) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:602:22 [INFO] [stderr] | [INFO] [stderr] 602 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:613:28 [INFO] [stderr] | [INFO] [stderr] 613 | ((_self.packet[co + 0] & 240) | (((val & 240) >> 4) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:612:22 [INFO] [stderr] | [INFO] [stderr] 612 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:626:28 [INFO] [stderr] | [INFO] [stderr] 626 | ((_self.packet[co + 0] & 240) | (((val & 983040) >> 16) as u8)) as [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:625:22 [INFO] [stderr] | [INFO] [stderr] 625 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:639:22 [INFO] [stderr] | [INFO] [stderr] 639 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:654:26 [INFO] [stderr] | [INFO] [stderr] 654 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:666:22 [INFO] [stderr] | [INFO] [stderr] 666 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:680:26 [INFO] [stderr] | [INFO] [stderr] 680 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:688:26 [INFO] [stderr] | [INFO] [stderr] 688 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:696:26 [INFO] [stderr] | [INFO] [stderr] 696 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:704:26 [INFO] [stderr] | [INFO] [stderr] 704 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:712:26 [INFO] [stderr] | [INFO] [stderr] 712 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:720:26 [INFO] [stderr] | [INFO] [stderr] 720 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:728:26 [INFO] [stderr] | [INFO] [stderr] 728 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:736:26 [INFO] [stderr] | [INFO] [stderr] 736 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:761:26 [INFO] [stderr] | [INFO] [stderr] 761 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:769:26 [INFO] [stderr] | [INFO] [stderr] 769 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:777:26 [INFO] [stderr] | [INFO] [stderr] 777 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:785:26 [INFO] [stderr] | [INFO] [stderr] 785 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:793:26 [INFO] [stderr] | [INFO] [stderr] 793 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:801:26 [INFO] [stderr] | [INFO] [stderr] 801 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:809:26 [INFO] [stderr] | [INFO] [stderr] 809 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:817:26 [INFO] [stderr] | [INFO] [stderr] 817 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:865:5 [INFO] [stderr] | [INFO] [stderr] 865 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:868:5 [INFO] [stderr] | [INFO] [stderr] 868 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 869 | | let _self = self; [INFO] [stderr] 870 | | let start = 40; [INFO] [stderr] 871 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 875 | | &mut _self.packet[start..end] [INFO] [stderr] 876 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:880:5 [INFO] [stderr] | [INFO] [stderr] 880 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:883:5 [INFO] [stderr] | [INFO] [stderr] 883 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 884 | | let _self = self; [INFO] [stderr] 885 | | let start = 40; [INFO] [stderr] 886 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 890 | | &_self.packet[start..end] [INFO] [stderr] 891 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:895:5 [INFO] [stderr] | [INFO] [stderr] 895 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:898:5 [INFO] [stderr] | [INFO] [stderr] 898 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 899 | | let _self = self; [INFO] [stderr] 900 | | let start = 40; [INFO] [stderr] 901 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 905 | | &_self.packet[start..end] [INFO] [stderr] 906 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/ipv6.rs:920:12 [INFO] [stderr] | [INFO] [stderr] 920 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 62 | | if packet.len() >= UdpPacket::minimum_packet_size() { [INFO] [stderr] 63 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 64 | | Some(UdpPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 65 | | } else { None } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn to_immutable<'p>(&'p self) -> UdpPacket<'p> { [INFO] [stderr] 79 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 80 | | UdpPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:103:19 [INFO] [stderr] | [INFO] [stderr] 103 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:103:33 [INFO] [stderr] | [INFO] [stderr] 103 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:115:19 [INFO] [stderr] | [INFO] [stderr] 115 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:115:33 [INFO] [stderr] | [INFO] [stderr] 115 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:116:18 [INFO] [stderr] | [INFO] [stderr] 116 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:127:19 [INFO] [stderr] | [INFO] [stderr] 127 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:127:33 [INFO] [stderr] | [INFO] [stderr] 127 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:128:18 [INFO] [stderr] | [INFO] [stderr] 128 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:139:19 [INFO] [stderr] | [INFO] [stderr] 139 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:139:33 [INFO] [stderr] | [INFO] [stderr] 139 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:140:18 [INFO] [stderr] | [INFO] [stderr] 140 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 149 | | if packet.len() >= MutableUdpPacket::minimum_packet_size() { [INFO] [stderr] 150 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 151 | | Some(MutableUdpPacket{packet: MutPacketData::Borrowed(packet),}) [INFO] [stderr] 152 | | } else { None } [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:165:5 [INFO] [stderr] | [INFO] [stderr] 165 | / pub fn to_immutable<'p>(&'p self) -> UdpPacket<'p> { [INFO] [stderr] 166 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 167 | | UdpPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 168 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:201:19 [INFO] [stderr] | [INFO] [stderr] 201 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:201:33 [INFO] [stderr] | [INFO] [stderr] 201 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:202:18 [INFO] [stderr] | [INFO] [stderr] 202 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:213:19 [INFO] [stderr] | [INFO] [stderr] 213 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:213:33 [INFO] [stderr] | [INFO] [stderr] 213 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:214:18 [INFO] [stderr] | [INFO] [stderr] 214 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:225:19 [INFO] [stderr] | [INFO] [stderr] 225 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:225:33 [INFO] [stderr] | [INFO] [stderr] 225 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:226:18 [INFO] [stderr] | [INFO] [stderr] 226 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:237:19 [INFO] [stderr] | [INFO] [stderr] 237 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:237:33 [INFO] [stderr] | [INFO] [stderr] 237 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:238:18 [INFO] [stderr] | [INFO] [stderr] 238 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:249:22 [INFO] [stderr] | [INFO] [stderr] 249 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:260:22 [INFO] [stderr] | [INFO] [stderr] 260 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:271:22 [INFO] [stderr] | [INFO] [stderr] 271 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:282:22 [INFO] [stderr] | [INFO] [stderr] 282 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:311:5 [INFO] [stderr] | [INFO] [stderr] 311 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:314:5 [INFO] [stderr] | [INFO] [stderr] 314 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 315 | | let _self = self; [INFO] [stderr] 316 | | let start = 8; [INFO] [stderr] 317 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 318 | | &mut _self.packet[start..] [INFO] [stderr] 319 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:323:5 [INFO] [stderr] | [INFO] [stderr] 323 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:326:5 [INFO] [stderr] | [INFO] [stderr] 326 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 327 | | let _self = self; [INFO] [stderr] 328 | | let start = 8; [INFO] [stderr] 329 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 330 | | &_self.packet[start..] [INFO] [stderr] 331 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:335:5 [INFO] [stderr] | [INFO] [stderr] 335 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:338:5 [INFO] [stderr] | [INFO] [stderr] 338 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 339 | | let _self = self; [INFO] [stderr] 340 | | let start = 8; [INFO] [stderr] 341 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 342 | | &_self.packet[start..] [INFO] [stderr] 343 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:357:12 [INFO] [stderr] | [INFO] [stderr] 357 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:443:50 [INFO] [stderr] | [INFO] [stderr] 443 | pub fn ipv4_checksum(packet: &UdpPacket, source: &Ipv4Addr, [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:444:35 [INFO] [stderr] | [INFO] [stderr] 444 | destination: &Ipv4Addr) -> u16be { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:455:34 [INFO] [stderr] | [INFO] [stderr] 455 | source: &Ipv4Addr, destination: &Ipv4Addr) -> u16be { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/udp.rs:455:58 [INFO] [stderr] | [INFO] [stderr] 455 | source: &Ipv4Addr, destination: &Ipv4Addr) -> u16be { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 144 | | if packet.len() >= TcpPacket::minimum_packet_size() { [INFO] [stderr] 145 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 146 | | Some(TcpPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 147 | | } else { None } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | / pub fn to_immutable<'p>(&'p self) -> TcpPacket<'p> { [INFO] [stderr] 161 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 162 | | TcpPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 163 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:187:19 [INFO] [stderr] | [INFO] [stderr] 187 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:187:33 [INFO] [stderr] | [INFO] [stderr] 187 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:188:18 [INFO] [stderr] | [INFO] [stderr] 188 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:199:19 [INFO] [stderr] | [INFO] [stderr] 199 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:199:33 [INFO] [stderr] | [INFO] [stderr] 199 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:200:18 [INFO] [stderr] | [INFO] [stderr] 200 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:211:19 [INFO] [stderr] | [INFO] [stderr] 211 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:211:33 [INFO] [stderr] | [INFO] [stderr] 211 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:212:19 [INFO] [stderr] | [INFO] [stderr] 212 | let b1 = ((_self.packet[co + 1] as u32be) << 16) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:213:19 [INFO] [stderr] | [INFO] [stderr] 213 | let b2 = ((_self.packet[co + 2] as u32be) << 8) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:214:18 [INFO] [stderr] | [INFO] [stderr] 214 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:225:19 [INFO] [stderr] | [INFO] [stderr] 225 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:225:33 [INFO] [stderr] | [INFO] [stderr] 225 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:226:19 [INFO] [stderr] | [INFO] [stderr] 226 | let b1 = ((_self.packet[co + 1] as u32be) << 16) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:227:19 [INFO] [stderr] | [INFO] [stderr] 227 | let b2 = ((_self.packet[co + 2] as u32be) << 8) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:228:18 [INFO] [stderr] | [INFO] [stderr] 228 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:257:20 [INFO] [stderr] | [INFO] [stderr] 257 | let b0 = (((_self.packet[co + 0] as u9be) & 1) << 8) as u9be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:257:34 [INFO] [stderr] | [INFO] [stderr] 257 | let b0 = (((_self.packet[co + 0] as u9be) & 1) << 8) as u9be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:258:18 [INFO] [stderr] | [INFO] [stderr] 258 | let b1 = ((_self.packet[co + 1] as u9be)) as u9be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:269:19 [INFO] [stderr] | [INFO] [stderr] 269 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:269:33 [INFO] [stderr] | [INFO] [stderr] 269 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:270:18 [INFO] [stderr] | [INFO] [stderr] 270 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:281:19 [INFO] [stderr] | [INFO] [stderr] 281 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:281:33 [INFO] [stderr] | [INFO] [stderr] 281 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:282:18 [INFO] [stderr] | [INFO] [stderr] 282 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:293:19 [INFO] [stderr] | [INFO] [stderr] 293 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:293:33 [INFO] [stderr] | [INFO] [stderr] 293 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:294:18 [INFO] [stderr] | [INFO] [stderr] 294 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:344:5 [INFO] [stderr] | [INFO] [stderr] 344 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 345 | | if packet.len() >= MutableTcpPacket::minimum_packet_size() { [INFO] [stderr] 346 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 347 | | Some(MutableTcpPacket{packet: MutPacketData::Borrowed(packet),}) [INFO] [stderr] 348 | | } else { None } [INFO] [stderr] 349 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:361:5 [INFO] [stderr] | [INFO] [stderr] 361 | / pub fn to_immutable<'p>(&'p self) -> TcpPacket<'p> { [INFO] [stderr] 362 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 363 | | TcpPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 364 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:406:19 [INFO] [stderr] | [INFO] [stderr] 406 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:406:33 [INFO] [stderr] | [INFO] [stderr] 406 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:407:18 [INFO] [stderr] | [INFO] [stderr] 407 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:418:19 [INFO] [stderr] | [INFO] [stderr] 418 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:418:33 [INFO] [stderr] | [INFO] [stderr] 418 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:419:18 [INFO] [stderr] | [INFO] [stderr] 419 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:430:19 [INFO] [stderr] | [INFO] [stderr] 430 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:430:33 [INFO] [stderr] | [INFO] [stderr] 430 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:431:19 [INFO] [stderr] | [INFO] [stderr] 431 | let b1 = ((_self.packet[co + 1] as u32be) << 16) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:432:19 [INFO] [stderr] | [INFO] [stderr] 432 | let b2 = ((_self.packet[co + 2] as u32be) << 8) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:433:18 [INFO] [stderr] | [INFO] [stderr] 433 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:444:19 [INFO] [stderr] | [INFO] [stderr] 444 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:444:33 [INFO] [stderr] | [INFO] [stderr] 444 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:445:19 [INFO] [stderr] | [INFO] [stderr] 445 | let b1 = ((_self.packet[co + 1] as u32be) << 16) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:446:19 [INFO] [stderr] | [INFO] [stderr] 446 | let b2 = ((_self.packet[co + 2] as u32be) << 8) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:447:18 [INFO] [stderr] | [INFO] [stderr] 447 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:476:20 [INFO] [stderr] | [INFO] [stderr] 476 | let b0 = (((_self.packet[co + 0] as u9be) & 1) << 8) as u9be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:476:34 [INFO] [stderr] | [INFO] [stderr] 476 | let b0 = (((_self.packet[co + 0] as u9be) & 1) << 8) as u9be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:477:18 [INFO] [stderr] | [INFO] [stderr] 477 | let b1 = ((_self.packet[co + 1] as u9be)) as u9be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:488:19 [INFO] [stderr] | [INFO] [stderr] 488 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:488:33 [INFO] [stderr] | [INFO] [stderr] 488 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:489:18 [INFO] [stderr] | [INFO] [stderr] 489 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:500:19 [INFO] [stderr] | [INFO] [stderr] 500 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:500:33 [INFO] [stderr] | [INFO] [stderr] 500 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:501:18 [INFO] [stderr] | [INFO] [stderr] 501 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:512:19 [INFO] [stderr] | [INFO] [stderr] 512 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:512:33 [INFO] [stderr] | [INFO] [stderr] 512 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:513:18 [INFO] [stderr] | [INFO] [stderr] 513 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:566:22 [INFO] [stderr] | [INFO] [stderr] 566 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:577:22 [INFO] [stderr] | [INFO] [stderr] 577 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:588:22 [INFO] [stderr] | [INFO] [stderr] 588 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:601:22 [INFO] [stderr] | [INFO] [stderr] 601 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:614:28 [INFO] [stderr] | [INFO] [stderr] 614 | ((_self.packet[co + 0] & 15) | (((val & 15) << 4) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:613:22 [INFO] [stderr] | [INFO] [stderr] 613 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:624:28 [INFO] [stderr] | [INFO] [stderr] 624 | ((_self.packet[co + 0] & 241) | (((val & 7) << 1) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:623:22 [INFO] [stderr] | [INFO] [stderr] 623 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:635:28 [INFO] [stderr] | [INFO] [stderr] 635 | ((_self.packet[co + 0] & 254) | (((val & 256) >> 8) as u8)) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:634:22 [INFO] [stderr] | [INFO] [stderr] 634 | _self.packet[co + 0] = [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:646:22 [INFO] [stderr] | [INFO] [stderr] 646 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:657:22 [INFO] [stderr] | [INFO] [stderr] 657 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:668:22 [INFO] [stderr] | [INFO] [stderr] 668 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:693:25 [INFO] [stderr] | [INFO] [stderr] 693 | for val in vals.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:733:5 [INFO] [stderr] | [INFO] [stderr] 733 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:736:5 [INFO] [stderr] | [INFO] [stderr] 736 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 737 | | let _self = self; [INFO] [stderr] 738 | | let start = 20 + tcp_options_length(&_self.to_immutable()); [INFO] [stderr] 739 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 740 | | &mut _self.packet[start..] [INFO] [stderr] 741 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:745:5 [INFO] [stderr] | [INFO] [stderr] 745 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:748:5 [INFO] [stderr] | [INFO] [stderr] 748 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 749 | | let _self = self; [INFO] [stderr] 750 | | let start = 20 + tcp_options_length(&_self.to_immutable()); [INFO] [stderr] 751 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 752 | | &_self.packet[start..] [INFO] [stderr] 753 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:757:5 [INFO] [stderr] | [INFO] [stderr] 757 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:760:5 [INFO] [stderr] | [INFO] [stderr] 760 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 761 | | let _self = self; [INFO] [stderr] 762 | | let start = 20 + tcp_options_length(&_self.to_immutable()); [INFO] [stderr] 763 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 764 | | &_self.packet[start..] [INFO] [stderr] 765 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:779:12 [INFO] [stderr] | [INFO] [stderr] 779 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:930:5 [INFO] [stderr] | [INFO] [stderr] 930 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 931 | | if packet.len() >= TcpOptionPacket::minimum_packet_size() { [INFO] [stderr] 932 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 933 | | Some(TcpOptionPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 934 | | } else { None } [INFO] [stderr] 935 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:947:5 [INFO] [stderr] | [INFO] [stderr] 947 | / pub fn to_immutable<'p>(&'p self) -> TcpOptionPacket<'p> { [INFO] [stderr] 948 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 949 | | TcpOptionPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 950 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the variable `co` is used as a loop counter. Consider using `for (co, item) in 0..vec.capacity().enumerate()` or similar iterators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1008:18 [INFO] [stderr] | [INFO] [stderr] 1008 | for _ in 0..vec.capacity() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1019:5 [INFO] [stderr] | [INFO] [stderr] 1019 | / pub fn new<'p>(packet: &'p mut [u8]) [INFO] [stderr] 1020 | | -> Option> { [INFO] [stderr] 1021 | | if packet.len() >= MutableTcpOptionPacket::minimum_packet_size() { [INFO] [stderr] 1022 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] ... | [INFO] [stderr] 1025 | | } else { None } [INFO] [stderr] 1026 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1039:5 [INFO] [stderr] | [INFO] [stderr] 1039 | / pub fn to_immutable<'p>(&'p self) -> TcpOptionPacket<'p> { [INFO] [stderr] 1040 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1041 | | TcpOptionPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 1042 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the variable `co` is used as a loop counter. Consider using `for (co, item) in 0..vec.capacity().enumerate()` or similar iterators [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1109:18 [INFO] [stderr] | [INFO] [stderr] 1109 | for _ in 0..vec.capacity() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1127:26 [INFO] [stderr] | [INFO] [stderr] 1127 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1198:5 [INFO] [stderr] | [INFO] [stderr] 1198 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1201:5 [INFO] [stderr] | [INFO] [stderr] 1201 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 1202 | | let _self = self; [INFO] [stderr] 1203 | | let start = 1 + tcp_option_length(&_self.to_immutable()); [INFO] [stderr] 1204 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 1209 | | &mut _self.packet[start..end] [INFO] [stderr] 1210 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1215:5 [INFO] [stderr] | [INFO] [stderr] 1215 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1218:5 [INFO] [stderr] | [INFO] [stderr] 1218 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1219 | | let _self = self; [INFO] [stderr] 1220 | | let start = 1 + tcp_option_length(&_self.to_immutable()); [INFO] [stderr] 1221 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 1226 | | &_self.packet[start..end] [INFO] [stderr] 1227 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1231:5 [INFO] [stderr] | [INFO] [stderr] 1231 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1234:5 [INFO] [stderr] | [INFO] [stderr] 1234 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1235 | | let _self = self; [INFO] [stderr] 1236 | | let start = 1 + tcp_option_length(&_self.to_immutable()); [INFO] [stderr] 1237 | | let end = [INFO] [stderr] ... | [INFO] [stderr] 1242 | | &_self.packet[start..end] [INFO] [stderr] 1243 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1257:12 [INFO] [stderr] | [INFO] [stderr] 1257 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1420:50 [INFO] [stderr] | [INFO] [stderr] 1420 | pub fn ipv4_checksum(packet: &TcpPacket, source: &Ipv4Addr, [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1421:35 [INFO] [stderr] | [INFO] [stderr] 1421 | destination: &Ipv4Addr) -> u16 { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1432:34 [INFO] [stderr] | [INFO] [stderr] 1432 | source: &Ipv4Addr, destination: &Ipv4Addr) -> u16 { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/tcp.rs:1432:58 [INFO] [stderr] | [INFO] [stderr] 1432 | source: &Ipv4Addr, destination: &Ipv4Addr) -> u16 { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 91 | | if packet.len() >= ArpPacket::minimum_packet_size() { [INFO] [stderr] 92 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 93 | | Some(ArpPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 94 | | } else { None } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / pub fn to_immutable<'p>(&'p self) -> ArpPacket<'p> { [INFO] [stderr] 108 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 109 | | ArpPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:134:23 [INFO] [stderr] | [INFO] [stderr] 134 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:134:37 [INFO] [stderr] | [INFO] [stderr] 134 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:150:23 [INFO] [stderr] | [INFO] [stderr] 150 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:150:37 [INFO] [stderr] | [INFO] [stderr] 150 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:151:22 [INFO] [stderr] | [INFO] [stderr] 151 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:184:23 [INFO] [stderr] | [INFO] [stderr] 184 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:184:37 [INFO] [stderr] | [INFO] [stderr] 184 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:185:22 [INFO] [stderr] | [INFO] [stderr] 185 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:367:5 [INFO] [stderr] | [INFO] [stderr] 367 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 368 | | if packet.len() >= MutableArpPacket::minimum_packet_size() { [INFO] [stderr] 369 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 370 | | Some(MutableArpPacket{packet: MutPacketData::Borrowed(packet),}) [INFO] [stderr] 371 | | } else { None } [INFO] [stderr] 372 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:384:5 [INFO] [stderr] | [INFO] [stderr] 384 | / pub fn to_immutable<'p>(&'p self) -> ArpPacket<'p> { [INFO] [stderr] 385 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 386 | | ArpPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 387 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:427:23 [INFO] [stderr] | [INFO] [stderr] 427 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:427:37 [INFO] [stderr] | [INFO] [stderr] 427 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:428:22 [INFO] [stderr] | [INFO] [stderr] 428 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:443:23 [INFO] [stderr] | [INFO] [stderr] 443 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:443:37 [INFO] [stderr] | [INFO] [stderr] 443 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:444:22 [INFO] [stderr] | [INFO] [stderr] 444 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:477:23 [INFO] [stderr] | [INFO] [stderr] 477 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:477:37 [INFO] [stderr] | [INFO] [stderr] 477 | let b0 = ((_self.packet[co + 0] as u16) << 8) as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:478:22 [INFO] [stderr] | [INFO] [stderr] 478 | let b1 = ((_self.packet[co + 1] as u16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:667:26 [INFO] [stderr] | [INFO] [stderr] 667 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:685:26 [INFO] [stderr] | [INFO] [stderr] 685 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:698:22 [INFO] [stderr] | [INFO] [stderr] 698 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:707:22 [INFO] [stderr] | [INFO] [stderr] 707 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:721:26 [INFO] [stderr] | [INFO] [stderr] 721 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:739:26 [INFO] [stderr] | [INFO] [stderr] 739 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:746:26 [INFO] [stderr] | [INFO] [stderr] 746 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:753:26 [INFO] [stderr] | [INFO] [stderr] 753 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:760:26 [INFO] [stderr] | [INFO] [stderr] 760 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:767:26 [INFO] [stderr] | [INFO] [stderr] 767 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:774:26 [INFO] [stderr] | [INFO] [stderr] 774 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:796:26 [INFO] [stderr] | [INFO] [stderr] 796 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:803:26 [INFO] [stderr] | [INFO] [stderr] 803 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:810:26 [INFO] [stderr] | [INFO] [stderr] 810 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:817:26 [INFO] [stderr] | [INFO] [stderr] 817 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:837:26 [INFO] [stderr] | [INFO] [stderr] 837 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:844:26 [INFO] [stderr] | [INFO] [stderr] 844 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:851:26 [INFO] [stderr] | [INFO] [stderr] 851 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:858:26 [INFO] [stderr] | [INFO] [stderr] 858 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:865:26 [INFO] [stderr] | [INFO] [stderr] 865 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:872:26 [INFO] [stderr] | [INFO] [stderr] 872 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:894:26 [INFO] [stderr] | [INFO] [stderr] 894 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:901:26 [INFO] [stderr] | [INFO] [stderr] 901 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:908:26 [INFO] [stderr] | [INFO] [stderr] 908 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:915:26 [INFO] [stderr] | [INFO] [stderr] 915 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `28` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:942:56 [INFO] [stderr] | [INFO] [stderr] 942 | fn packet_size(&self) -> usize { let _self = self; 28 + 0 } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `28` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:946:56 [INFO] [stderr] | [INFO] [stderr] 946 | fn packet_size(&self) -> usize { let _self = self; 28 + 0 } [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:951:5 [INFO] [stderr] | [INFO] [stderr] 951 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:954:5 [INFO] [stderr] | [INFO] [stderr] 954 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 955 | | let _self = self; [INFO] [stderr] 956 | | let start = 28; [INFO] [stderr] 957 | | let end = ::std::cmp::min(28 + 0, _self.packet.len()); [INFO] [stderr] 958 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 959 | | &mut _self.packet[start..end] [INFO] [stderr] 960 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `28` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:957:35 [INFO] [stderr] | [INFO] [stderr] 957 | let end = ::std::cmp::min(28 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:964:5 [INFO] [stderr] | [INFO] [stderr] 964 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:967:5 [INFO] [stderr] | [INFO] [stderr] 967 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 968 | | let _self = self; [INFO] [stderr] 969 | | let start = 28; [INFO] [stderr] 970 | | let end = ::std::cmp::min(28 + 0, _self.packet.len()); [INFO] [stderr] 971 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 972 | | &_self.packet[start..end] [INFO] [stderr] 973 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `28` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:970:35 [INFO] [stderr] | [INFO] [stderr] 970 | let end = ::std::cmp::min(28 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:977:5 [INFO] [stderr] | [INFO] [stderr] 977 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:980:5 [INFO] [stderr] | [INFO] [stderr] 980 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 981 | | let _self = self; [INFO] [stderr] 982 | | let start = 28; [INFO] [stderr] 983 | | let end = ::std::cmp::min(28 + 0, _self.packet.len()); [INFO] [stderr] 984 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 985 | | &_self.packet[start..end] [INFO] [stderr] 986 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `28` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:983:35 [INFO] [stderr] | [INFO] [stderr] 983 | let end = ::std::cmp::min(28 + 0, _self.packet.len()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/arp.rs:1000:12 [INFO] [stderr] | [INFO] [stderr] 1000 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 103 | | if packet.len() >= IcmpPacket::minimum_packet_size() { [INFO] [stderr] 104 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 105 | | Some(IcmpPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 106 | | } else { None } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | / pub fn to_immutable<'p>(&'p self) -> IcmpPacket<'p> { [INFO] [stderr] 120 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 121 | | IcmpPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:172:19 [INFO] [stderr] | [INFO] [stderr] 172 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:172:33 [INFO] [stderr] | [INFO] [stderr] 172 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:173:18 [INFO] [stderr] | [INFO] [stderr] 173 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | / pub fn new<'p>(packet: &'p mut [u8]) -> Option> { [INFO] [stderr] 182 | | if packet.len() >= MutableIcmpPacket::minimum_packet_size() { [INFO] [stderr] 183 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] 184 | | Some(MutableIcmpPacket{packet: MutPacketData::Borrowed(packet),}) [INFO] [stderr] 185 | | } else { None } [INFO] [stderr] 186 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | / pub fn to_immutable<'p>(&'p self) -> IcmpPacket<'p> { [INFO] [stderr] 199 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 200 | | IcmpPacket{packet: PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:261:19 [INFO] [stderr] | [INFO] [stderr] 261 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:261:33 [INFO] [stderr] | [INFO] [stderr] 261 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:262:18 [INFO] [stderr] | [INFO] [stderr] 262 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:277:26 [INFO] [stderr] | [INFO] [stderr] 277 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:294:26 [INFO] [stderr] | [INFO] [stderr] 294 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:307:22 [INFO] [stderr] | [INFO] [stderr] 307 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:337:5 [INFO] [stderr] | [INFO] [stderr] 337 | fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { &mut self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:340:5 [INFO] [stderr] | [INFO] [stderr] 340 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 341 | | let _self = self; [INFO] [stderr] 342 | | let start = 4; [INFO] [stderr] 343 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 344 | | &mut _self.packet[start..] [INFO] [stderr] 345 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:349:5 [INFO] [stderr] | [INFO] [stderr] 349 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:352:5 [INFO] [stderr] | [INFO] [stderr] 352 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 353 | | let _self = self; [INFO] [stderr] 354 | | let start = 4; [INFO] [stderr] 355 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 356 | | &_self.packet[start..] [INFO] [stderr] 357 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:361:5 [INFO] [stderr] | [INFO] [stderr] 361 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:364:5 [INFO] [stderr] | [INFO] [stderr] 364 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 365 | | let _self = self; [INFO] [stderr] 366 | | let start = 4; [INFO] [stderr] 367 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 368 | | &_self.packet[start..] [INFO] [stderr] 369 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:383:12 [INFO] [stderr] | [INFO] [stderr] 383 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:605:9 [INFO] [stderr] | [INFO] [stderr] 605 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 606 | | if packet.len() >= EchoReplyPacket::minimum_packet_size() { [INFO] [stderr] 607 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 608 | | Some(EchoReplyPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 609 | | } else { None } [INFO] [stderr] 610 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:622:9 [INFO] [stderr] | [INFO] [stderr] 622 | / pub fn to_immutable<'p>(&'p self) -> EchoReplyPacket<'p> { [INFO] [stderr] 623 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 624 | | EchoReplyPacket{packet: [INFO] [stderr] 625 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 626 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:678:23 [INFO] [stderr] | [INFO] [stderr] 678 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:678:37 [INFO] [stderr] | [INFO] [stderr] 678 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:679:22 [INFO] [stderr] | [INFO] [stderr] 679 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:690:23 [INFO] [stderr] | [INFO] [stderr] 690 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:690:37 [INFO] [stderr] | [INFO] [stderr] 690 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:691:22 [INFO] [stderr] | [INFO] [stderr] 691 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:702:23 [INFO] [stderr] | [INFO] [stderr] 702 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:702:37 [INFO] [stderr] | [INFO] [stderr] 702 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:703:22 [INFO] [stderr] | [INFO] [stderr] 703 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:711:9 [INFO] [stderr] | [INFO] [stderr] 711 | / pub fn new<'p>(packet: &'p mut [u8]) [INFO] [stderr] 712 | | -> Option> { [INFO] [stderr] 713 | | if packet.len() >= MutableEchoReplyPacket::minimum_packet_size() { [INFO] [stderr] 714 | | use ::pnet_macros_support::packet::MutPacketData; [INFO] [stderr] ... | [INFO] [stderr] 717 | | } else { None } [INFO] [stderr] 718 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:732:9 [INFO] [stderr] | [INFO] [stderr] 732 | / pub fn to_immutable<'p>(&'p self) -> EchoReplyPacket<'p> { [INFO] [stderr] 733 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 734 | | EchoReplyPacket{packet: [INFO] [stderr] 735 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 736 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:800:23 [INFO] [stderr] | [INFO] [stderr] 800 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:800:37 [INFO] [stderr] | [INFO] [stderr] 800 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:801:22 [INFO] [stderr] | [INFO] [stderr] 801 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:812:23 [INFO] [stderr] | [INFO] [stderr] 812 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:812:37 [INFO] [stderr] | [INFO] [stderr] 812 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:813:22 [INFO] [stderr] | [INFO] [stderr] 813 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:824:23 [INFO] [stderr] | [INFO] [stderr] 824 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:824:37 [INFO] [stderr] | [INFO] [stderr] 824 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:825:22 [INFO] [stderr] | [INFO] [stderr] 825 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:840:30 [INFO] [stderr] | [INFO] [stderr] 840 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:857:30 [INFO] [stderr] | [INFO] [stderr] 857 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:870:26 [INFO] [stderr] | [INFO] [stderr] 870 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:881:26 [INFO] [stderr] | [INFO] [stderr] 881 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:892:26 [INFO] [stderr] | [INFO] [stderr] 892 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:923:9 [INFO] [stderr] | [INFO] [stderr] 923 | / fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 924 | | &mut self.packet[..] [INFO] [stderr] 925 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:928:9 [INFO] [stderr] | [INFO] [stderr] 928 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 929 | | let _self = self; [INFO] [stderr] 930 | | let start = 8; [INFO] [stderr] 931 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 932 | | &mut _self.packet[start..] [INFO] [stderr] 933 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:938:9 [INFO] [stderr] | [INFO] [stderr] 938 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:941:9 [INFO] [stderr] | [INFO] [stderr] 941 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 942 | | let _self = self; [INFO] [stderr] 943 | | let start = 8; [INFO] [stderr] 944 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 945 | | &_self.packet[start..] [INFO] [stderr] 946 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:950:9 [INFO] [stderr] | [INFO] [stderr] 950 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:953:9 [INFO] [stderr] | [INFO] [stderr] 953 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 954 | | let _self = self; [INFO] [stderr] 955 | | let start = 8; [INFO] [stderr] 956 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 957 | | &_self.packet[start..] [INFO] [stderr] 958 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:972:16 [INFO] [stderr] | [INFO] [stderr] 972 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1131:9 [INFO] [stderr] | [INFO] [stderr] 1131 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 1132 | | if packet.len() >= EchoRequestPacket::minimum_packet_size() { [INFO] [stderr] 1133 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1134 | | Some(EchoRequestPacket{packet: PacketData::Borrowed(packet),}) [INFO] [stderr] 1135 | | } else { None } [INFO] [stderr] 1136 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1148:9 [INFO] [stderr] | [INFO] [stderr] 1148 | / pub fn to_immutable<'p>(&'p self) -> EchoRequestPacket<'p> { [INFO] [stderr] 1149 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1150 | | EchoRequestPacket{packet: [INFO] [stderr] 1151 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 1152 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1204:23 [INFO] [stderr] | [INFO] [stderr] 1204 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1204:37 [INFO] [stderr] | [INFO] [stderr] 1204 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1205:22 [INFO] [stderr] | [INFO] [stderr] 1205 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1216:23 [INFO] [stderr] | [INFO] [stderr] 1216 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1216:37 [INFO] [stderr] | [INFO] [stderr] 1216 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1217:22 [INFO] [stderr] | [INFO] [stderr] 1217 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1228:23 [INFO] [stderr] | [INFO] [stderr] 1228 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1228:37 [INFO] [stderr] | [INFO] [stderr] 1228 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1229:22 [INFO] [stderr] | [INFO] [stderr] 1229 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1237:9 [INFO] [stderr] | [INFO] [stderr] 1237 | / pub fn new<'p>(packet: &'p mut [u8]) [INFO] [stderr] 1238 | | -> Option> { [INFO] [stderr] 1239 | | if packet.len() >= MutableEchoRequestPacket::minimum_packet_size() [INFO] [stderr] 1240 | | { [INFO] [stderr] ... | [INFO] [stderr] 1244 | | } else { None } [INFO] [stderr] 1245 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1260:9 [INFO] [stderr] | [INFO] [stderr] 1260 | / pub fn to_immutable<'p>(&'p self) -> EchoRequestPacket<'p> { [INFO] [stderr] 1261 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1262 | | EchoRequestPacket{packet: [INFO] [stderr] 1263 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 1264 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1328:23 [INFO] [stderr] | [INFO] [stderr] 1328 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1328:37 [INFO] [stderr] | [INFO] [stderr] 1328 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1329:22 [INFO] [stderr] | [INFO] [stderr] 1329 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1340:23 [INFO] [stderr] | [INFO] [stderr] 1340 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1340:37 [INFO] [stderr] | [INFO] [stderr] 1340 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1341:22 [INFO] [stderr] | [INFO] [stderr] 1341 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1352:23 [INFO] [stderr] | [INFO] [stderr] 1352 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1352:37 [INFO] [stderr] | [INFO] [stderr] 1352 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1353:22 [INFO] [stderr] | [INFO] [stderr] 1353 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1368:30 [INFO] [stderr] | [INFO] [stderr] 1368 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1385:30 [INFO] [stderr] | [INFO] [stderr] 1385 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1398:26 [INFO] [stderr] | [INFO] [stderr] 1398 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1409:26 [INFO] [stderr] | [INFO] [stderr] 1409 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1420:26 [INFO] [stderr] | [INFO] [stderr] 1420 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1451:9 [INFO] [stderr] | [INFO] [stderr] 1451 | / fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 1452 | | &mut self.packet[..] [INFO] [stderr] 1453 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1456:9 [INFO] [stderr] | [INFO] [stderr] 1456 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 1457 | | let _self = self; [INFO] [stderr] 1458 | | let start = 8; [INFO] [stderr] 1459 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 1460 | | &mut _self.packet[start..] [INFO] [stderr] 1461 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1466:9 [INFO] [stderr] | [INFO] [stderr] 1466 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1469:9 [INFO] [stderr] | [INFO] [stderr] 1469 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1470 | | let _self = self; [INFO] [stderr] 1471 | | let start = 8; [INFO] [stderr] 1472 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 1473 | | &_self.packet[start..] [INFO] [stderr] 1474 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1479:9 [INFO] [stderr] | [INFO] [stderr] 1479 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1482:9 [INFO] [stderr] | [INFO] [stderr] 1482 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1483 | | let _self = self; [INFO] [stderr] 1484 | | let start = 8; [INFO] [stderr] 1485 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 1486 | | &_self.packet[start..] [INFO] [stderr] 1487 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1501:16 [INFO] [stderr] | [INFO] [stderr] 1501 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1663:9 [INFO] [stderr] | [INFO] [stderr] 1663 | / pub fn new<'p>(packet: &'p [u8]) [INFO] [stderr] 1664 | | -> Option> { [INFO] [stderr] 1665 | | if packet.len() >= [INFO] [stderr] 1666 | | DestinationUnreachablePacket::minimum_packet_size() { [INFO] [stderr] ... | [INFO] [stderr] 1670 | | } else { None } [INFO] [stderr] 1671 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1686:9 [INFO] [stderr] | [INFO] [stderr] 1686 | / pub fn to_immutable<'p>(&'p self) [INFO] [stderr] 1687 | | -> DestinationUnreachablePacket<'p> { [INFO] [stderr] 1688 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1689 | | DestinationUnreachablePacket{packet: [INFO] [stderr] 1690 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 1691 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1744:23 [INFO] [stderr] | [INFO] [stderr] 1744 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1744:37 [INFO] [stderr] | [INFO] [stderr] 1744 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1745:22 [INFO] [stderr] | [INFO] [stderr] 1745 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1756:23 [INFO] [stderr] | [INFO] [stderr] 1756 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1756:37 [INFO] [stderr] | [INFO] [stderr] 1756 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1757:23 [INFO] [stderr] | [INFO] [stderr] 1757 | let b1 = ((_self.packet[co + 1] as u32be) << 16) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1758:23 [INFO] [stderr] | [INFO] [stderr] 1758 | let b2 = ((_self.packet[co + 2] as u32be) << 8) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1759:22 [INFO] [stderr] | [INFO] [stderr] 1759 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1767:9 [INFO] [stderr] | [INFO] [stderr] 1767 | / pub fn new<'p>(packet: &'p mut [u8]) [INFO] [stderr] 1768 | | -> Option> { [INFO] [stderr] 1769 | | if packet.len() >= [INFO] [stderr] 1770 | | MutableDestinationUnreachablePacket::minimum_packet_size() [INFO] [stderr] ... | [INFO] [stderr] 1775 | | } else { None } [INFO] [stderr] 1776 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1792:9 [INFO] [stderr] | [INFO] [stderr] 1792 | / pub fn to_immutable<'p>(&'p self) [INFO] [stderr] 1793 | | -> DestinationUnreachablePacket<'p> { [INFO] [stderr] 1794 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 1795 | | DestinationUnreachablePacket{packet: [INFO] [stderr] 1796 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 1797 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1861:23 [INFO] [stderr] | [INFO] [stderr] 1861 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1861:37 [INFO] [stderr] | [INFO] [stderr] 1861 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1862:22 [INFO] [stderr] | [INFO] [stderr] 1862 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1873:23 [INFO] [stderr] | [INFO] [stderr] 1873 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1873:37 [INFO] [stderr] | [INFO] [stderr] 1873 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1874:23 [INFO] [stderr] | [INFO] [stderr] 1874 | let b1 = ((_self.packet[co + 1] as u32be) << 16) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1875:23 [INFO] [stderr] | [INFO] [stderr] 1875 | let b2 = ((_self.packet[co + 2] as u32be) << 8) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1876:22 [INFO] [stderr] | [INFO] [stderr] 1876 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1892:30 [INFO] [stderr] | [INFO] [stderr] 1892 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1910:30 [INFO] [stderr] | [INFO] [stderr] 1910 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1923:26 [INFO] [stderr] | [INFO] [stderr] 1923 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1934:26 [INFO] [stderr] | [INFO] [stderr] 1934 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1967:9 [INFO] [stderr] | [INFO] [stderr] 1967 | / fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 1968 | | &mut self.packet[..] [INFO] [stderr] 1969 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1972:9 [INFO] [stderr] | [INFO] [stderr] 1972 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 1973 | | let _self = self; [INFO] [stderr] 1974 | | let start = 8; [INFO] [stderr] 1975 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 1976 | | &mut _self.packet[start..] [INFO] [stderr] 1977 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1982:9 [INFO] [stderr] | [INFO] [stderr] 1982 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1985:9 [INFO] [stderr] | [INFO] [stderr] 1985 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1986 | | let _self = self; [INFO] [stderr] 1987 | | let start = 8; [INFO] [stderr] 1988 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 1989 | | &_self.packet[start..] [INFO] [stderr] 1990 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1995:9 [INFO] [stderr] | [INFO] [stderr] 1995 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:1998:9 [INFO] [stderr] | [INFO] [stderr] 1998 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 1999 | | let _self = self; [INFO] [stderr] 2000 | | let start = 8; [INFO] [stderr] 2001 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 2002 | | &_self.packet[start..] [INFO] [stderr] 2003 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2017:16 [INFO] [stderr] | [INFO] [stderr] 2017 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2146:9 [INFO] [stderr] | [INFO] [stderr] 2146 | / pub fn new<'p>(packet: &'p [u8]) -> Option> { [INFO] [stderr] 2147 | | if packet.len() >= TimeExceededPacket::minimum_packet_size() { [INFO] [stderr] 2148 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 2149 | | Some(TimeExceededPacket{packet: [INFO] [stderr] 2150 | | PacketData::Borrowed(packet),}) [INFO] [stderr] 2151 | | } else { None } [INFO] [stderr] 2152 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2164:9 [INFO] [stderr] | [INFO] [stderr] 2164 | / pub fn to_immutable<'p>(&'p self) -> TimeExceededPacket<'p> { [INFO] [stderr] 2165 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 2166 | | TimeExceededPacket{packet: [INFO] [stderr] 2167 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 2168 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2220:23 [INFO] [stderr] | [INFO] [stderr] 2220 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2220:37 [INFO] [stderr] | [INFO] [stderr] 2220 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2221:22 [INFO] [stderr] | [INFO] [stderr] 2221 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2232:23 [INFO] [stderr] | [INFO] [stderr] 2232 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2232:37 [INFO] [stderr] | [INFO] [stderr] 2232 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2233:23 [INFO] [stderr] | [INFO] [stderr] 2233 | let b1 = ((_self.packet[co + 1] as u32be) << 16) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2234:23 [INFO] [stderr] | [INFO] [stderr] 2234 | let b2 = ((_self.packet[co + 2] as u32be) << 8) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2235:22 [INFO] [stderr] | [INFO] [stderr] 2235 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2243:9 [INFO] [stderr] | [INFO] [stderr] 2243 | / pub fn new<'p>(packet: &'p mut [u8]) [INFO] [stderr] 2244 | | -> Option> { [INFO] [stderr] 2245 | | if packet.len() >= [INFO] [stderr] 2246 | | MutableTimeExceededPacket::minimum_packet_size() { [INFO] [stderr] ... | [INFO] [stderr] 2250 | | } else { None } [INFO] [stderr] 2251 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2266:9 [INFO] [stderr] | [INFO] [stderr] 2266 | / pub fn to_immutable<'p>(&'p self) -> TimeExceededPacket<'p> { [INFO] [stderr] 2267 | | use ::pnet_macros_support::packet::PacketData; [INFO] [stderr] 2268 | | TimeExceededPacket{packet: [INFO] [stderr] 2269 | | PacketData::Borrowed(self.packet.as_slice()),} [INFO] [stderr] 2270 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2333:23 [INFO] [stderr] | [INFO] [stderr] 2333 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2333:37 [INFO] [stderr] | [INFO] [stderr] 2333 | let b0 = ((_self.packet[co + 0] as u16be) << 8) as u16be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2334:22 [INFO] [stderr] | [INFO] [stderr] 2334 | let b1 = ((_self.packet[co + 1] as u16be)) as u16be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2345:23 [INFO] [stderr] | [INFO] [stderr] 2345 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2345:37 [INFO] [stderr] | [INFO] [stderr] 2345 | let b0 = ((_self.packet[co + 0] as u32be) << 24) as u32be; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2346:23 [INFO] [stderr] | [INFO] [stderr] 2346 | let b1 = ((_self.packet[co + 1] as u32be) << 16) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2347:23 [INFO] [stderr] | [INFO] [stderr] 2347 | let b2 = ((_self.packet[co + 2] as u32be) << 8) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2348:22 [INFO] [stderr] | [INFO] [stderr] 2348 | let b3 = ((_self.packet[co + 3] as u32be)) as u32be; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(_self.packet[co + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2363:30 [INFO] [stderr] | [INFO] [stderr] 2363 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2380:30 [INFO] [stderr] | [INFO] [stderr] 2380 | _self.packet[co + 0] = (val) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2393:26 [INFO] [stderr] | [INFO] [stderr] 2393 | _self.packet[co + 0] = ((val & 65280) >> 8) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `co` [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2404:26 [INFO] [stderr] | [INFO] [stderr] 2404 | _self.packet[co + 0] = ((val & 4278190080) >> 24) as u8; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2437:9 [INFO] [stderr] | [INFO] [stderr] 2437 | / fn packet_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 2438 | | &mut self.packet[..] [INFO] [stderr] 2439 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2442:9 [INFO] [stderr] | [INFO] [stderr] 2442 | / fn payload_mut<'p>(&'p mut self) -> &'p mut [u8] { [INFO] [stderr] 2443 | | let _self = self; [INFO] [stderr] 2444 | | let start = 8; [INFO] [stderr] 2445 | | if _self.packet.len() <= start { return &mut []; } [INFO] [stderr] 2446 | | &mut _self.packet[start..] [INFO] [stderr] 2447 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2452:9 [INFO] [stderr] | [INFO] [stderr] 2452 | fn packet<'p>(&'p self) -> &'p [u8] { &self.packet[..] } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/pnet_packet-7a24a0561279e2e1/out/icmp.rs:2455:9 [INFO] [stderr] | [INFO] [stderr] 2455 | / fn payload<'p>(&'p self) -> &'p [u8] { [INFO] [stderr] 2456 | | let _self = self; [INFO] [stderr] 2457 | | let start = 8; [INFO] [stderr] 2458 | | if _self.packet.len() <= start { return &[]; } [INFO] [stderr] 2459 | | &_self.packet[start..] [WARN] too many lines in the log, truncating it