[INFO] crate pnet_macros 0.21.0 is already in cache [INFO] extracting crate pnet_macros 0.21.0 into work/ex/clippy-test-run/sources/stable/reg/pnet_macros/0.21.0 [INFO] extracting crate pnet_macros 0.21.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnet_macros/0.21.0 [INFO] validating manifest of pnet_macros-0.21.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pnet_macros-0.21.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pnet_macros-0.21.0 [INFO] finished frobbing pnet_macros-0.21.0 [INFO] frobbed toml for pnet_macros-0.21.0 written to work/ex/clippy-test-run/sources/stable/reg/pnet_macros/0.21.0/Cargo.toml [INFO] started frobbing pnet_macros-0.21.0 [INFO] finished frobbing pnet_macros-0.21.0 [INFO] frobbed toml for pnet_macros-0.21.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnet_macros/0.21.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pnet_macros-0.21.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pnet_macros/0.21.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f7e5d821cc298703918cef0729e5af1a7db6812a002ddccb3784be9926b28698 [INFO] running `"docker" "start" "-a" "f7e5d821cc298703918cef0729e5af1a7db6812a002ddccb3784be9926b28698"` [INFO] [stderr] Checking syntex_pos v0.42.0 [INFO] [stderr] Checking syntex_errors v0.42.0 [INFO] [stderr] Checking syntex_syntax v0.42.0 [INFO] [stderr] Checking syntex v0.42.2 [INFO] [stderr] Checking pnet_macros v0.21.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decorator.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decorator.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | packet_length: packet_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decorator.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | struct_length: struct_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `struct_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decorator.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | is_payload: is_payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decorator.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decorator.rs:387:21 [INFO] [stderr] | [INFO] [stderr] 387 | tts: tts, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decorator.rs:428:13 [INFO] [stderr] | [INFO] [stderr] 428 | ecx: ecx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ecx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | mask: mask, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decorator.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decorator.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | packet_length: packet_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decorator.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | struct_length: struct_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `struct_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decorator.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | is_payload: is_payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decorator.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decorator.rs:387:21 [INFO] [stderr] | [INFO] [stderr] 387 | tts: tts, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decorator.rs:428:13 [INFO] [stderr] | [INFO] [stderr] 428 | ecx: ecx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ecx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | mask: mask, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decorator.rs:809:20 [INFO] [stderr] | [INFO] [stderr] 809 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 810 | | if idx != packet.fields.len() - 1 { [INFO] [stderr] 811 | | cx.ecx.span_err(field.span, [INFO] [stderr] 812 | | "#[payload] must specify a #[length_fn], unless it is the \ [INFO] [stderr] ... | [INFO] [stderr] 815 | | } [INFO] [stderr] 816 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 809 | } else if idx != packet.fields.len() - 1 { [INFO] [stderr] 810 | cx.ecx.span_err(field.span, [INFO] [stderr] 811 | "#[payload] must specify a #[length_fn], unless it is the \ [INFO] [stderr] 812 | last field of a packet"); [INFO] [stderr] 813 | error = true; [INFO] [stderr] 814 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/decorator.rs:1272:5 [INFO] [stderr] | [INFO] [stderr] 1272 | mutator [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/decorator.rs:1251:19 [INFO] [stderr] | [INFO] [stderr] 1251 | let mutator = if let Some(struct_name) = inner { [INFO] [stderr] | ___________________^ [INFO] [stderr] 1252 | | format!("#[inline] [INFO] [stderr] 1253 | | #[allow(trivial_numeric_casts)] [INFO] [stderr] 1254 | | #[cfg_attr(feature = \"clippy\", allow(used_underscore_binding))] [INFO] [stderr] ... | [INFO] [stderr] 1269 | | }}", comment = comment, name = name, ty = ty, co = offset, operations = op_strings) [INFO] [stderr] 1270 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/decorator.rs:1307:5 [INFO] [stderr] | [INFO] [stderr] 1307 | op_strings [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/decorator.rs:1292:22 [INFO] [stderr] | [INFO] [stderr] 1292 | let op_strings = if operations.len() == 1 { [INFO] [stderr] | ______________________^ [INFO] [stderr] 1293 | | let replacement_str = format!("({}[co] as {})", name, ty); [INFO] [stderr] 1294 | | operations.first().unwrap().to_string().replace("{}", &replacement_str[..]) [INFO] [stderr] 1295 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 1304 | | op_strings [INFO] [stderr] 1305 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/decorator.rs:1373:5 [INFO] [stderr] | [INFO] [stderr] 1373 | accessor [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/decorator.rs:1352:20 [INFO] [stderr] | [INFO] [stderr] 1352 | let accessor = if let Some(struct_name) = inner { [INFO] [stderr] | ____________________^ [INFO] [stderr] 1353 | | format!("#[inline(always)] [INFO] [stderr] 1354 | | #[allow(trivial_numeric_casts)] [INFO] [stderr] 1355 | | #[cfg_attr(feature = \"clippy\", allow(used_underscore_binding))] [INFO] [stderr] ... | [INFO] [stderr] 1370 | | }}", comment = comment, name = name, ty = ty, co = offset, operations = op_strings) [INFO] [stderr] 1371 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decorator.rs:809:20 [INFO] [stderr] | [INFO] [stderr] 809 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 810 | | if idx != packet.fields.len() - 1 { [INFO] [stderr] 811 | | cx.ecx.span_err(field.span, [INFO] [stderr] 812 | | "#[payload] must specify a #[length_fn], unless it is the \ [INFO] [stderr] ... | [INFO] [stderr] 815 | | } [INFO] [stderr] 816 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 809 | } else if idx != packet.fields.len() - 1 { [INFO] [stderr] 810 | cx.ecx.span_err(field.span, [INFO] [stderr] 811 | "#[payload] must specify a #[length_fn], unless it is the \ [INFO] [stderr] 812 | last field of a packet"); [INFO] [stderr] 813 | error = true; [INFO] [stderr] 814 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/decorator.rs:1272:5 [INFO] [stderr] | [INFO] [stderr] 1272 | mutator [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/decorator.rs:1251:19 [INFO] [stderr] | [INFO] [stderr] 1251 | let mutator = if let Some(struct_name) = inner { [INFO] [stderr] | ___________________^ [INFO] [stderr] 1252 | | format!("#[inline] [INFO] [stderr] 1253 | | #[allow(trivial_numeric_casts)] [INFO] [stderr] 1254 | | #[cfg_attr(feature = \"clippy\", allow(used_underscore_binding))] [INFO] [stderr] ... | [INFO] [stderr] 1269 | | }}", comment = comment, name = name, ty = ty, co = offset, operations = op_strings) [INFO] [stderr] 1270 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/decorator.rs:1307:5 [INFO] [stderr] | [INFO] [stderr] 1307 | op_strings [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/decorator.rs:1292:22 [INFO] [stderr] | [INFO] [stderr] 1292 | let op_strings = if operations.len() == 1 { [INFO] [stderr] | ______________________^ [INFO] [stderr] 1293 | | let replacement_str = format!("({}[co] as {})", name, ty); [INFO] [stderr] 1294 | | operations.first().unwrap().to_string().replace("{}", &replacement_str[..]) [INFO] [stderr] 1295 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 1304 | | op_strings [INFO] [stderr] 1305 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/decorator.rs:1373:5 [INFO] [stderr] | [INFO] [stderr] 1373 | accessor [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/decorator.rs:1352:20 [INFO] [stderr] | [INFO] [stderr] 1352 | let accessor = if let Some(struct_name) = inner { [INFO] [stderr] | ____________________^ [INFO] [stderr] 1353 | | format!("#[inline(always)] [INFO] [stderr] 1354 | | #[allow(trivial_numeric_casts)] [INFO] [stderr] 1355 | | #[cfg_attr(feature = \"clippy\", allow(used_underscore_binding))] [INFO] [stderr] ... | [INFO] [stderr] 1370 | | }}", comment = comment, name = name, ty = ty, co = offset, operations = op_strings) [INFO] [stderr] 1371 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:53:30 [INFO] [stderr] | [INFO] [stderr] 53 | mask: 0b00001111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:60:30 [INFO] [stderr] | [INFO] [stderr] 60 | mask: 0b00001111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | mask: 0b00001111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:74:30 [INFO] [stderr] | [INFO] [stderr] 74 | mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:81:30 [INFO] [stderr] | [INFO] [stderr] 81 | mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:171:35 [INFO] [stderr] | [INFO] [stderr] 171 | save_mask: 0b00000011, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:172:36 [INFO] [stderr] | [INFO] [stderr] 172 | value_mask: 0b00001111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:179:35 [INFO] [stderr] | [INFO] [stderr] 179 | save_mask: 0b11000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:180:36 [INFO] [stderr] | [INFO] [stderr] 180 | value_mask: 0b00001111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:187:35 [INFO] [stderr] | [INFO] [stderr] 187 | save_mask: 0b00011100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:188:36 [INFO] [stderr] | [INFO] [stderr] 188 | value_mask: 0b00001111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:195:35 [INFO] [stderr] | [INFO] [stderr] 195 | save_mask: 0b00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:196:36 [INFO] [stderr] | [INFO] [stderr] 196 | value_mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:203:35 [INFO] [stderr] | [INFO] [stderr] 203 | save_mask: 0b00000011, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:204:36 [INFO] [stderr] | [INFO] [stderr] 204 | value_mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:239:36 [INFO] [stderr] | [INFO] [stderr] 239 | assert_eq!(get_mask(0, 1), (1, 0b10000000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:240:36 [INFO] [stderr] | [INFO] [stderr] 240 | assert_eq!(get_mask(0, 2), (2, 0b11000000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:241:36 [INFO] [stderr] | [INFO] [stderr] 241 | assert_eq!(get_mask(0, 3), (3, 0b11100000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:242:36 [INFO] [stderr] | [INFO] [stderr] 242 | assert_eq!(get_mask(0, 4), (4, 0b11110000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:243:36 [INFO] [stderr] | [INFO] [stderr] 243 | assert_eq!(get_mask(0, 5), (5, 0b11111000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:244:36 [INFO] [stderr] | [INFO] [stderr] 244 | assert_eq!(get_mask(0, 6), (6, 0b11111100)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:245:36 [INFO] [stderr] | [INFO] [stderr] 245 | assert_eq!(get_mask(0, 7), (7, 0b11111110)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:246:36 [INFO] [stderr] | [INFO] [stderr] 246 | assert_eq!(get_mask(0, 8), (8, 0b11111111)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:247:36 [INFO] [stderr] | [INFO] [stderr] 247 | assert_eq!(get_mask(0, 9), (8, 0b11111111)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:248:38 [INFO] [stderr] | [INFO] [stderr] 248 | assert_eq!(get_mask(0, 100), (8, 0b11111111)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:250:36 [INFO] [stderr] | [INFO] [stderr] 250 | assert_eq!(get_mask(1, 1), (1, 0b01000000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:251:36 [INFO] [stderr] | [INFO] [stderr] 251 | assert_eq!(get_mask(1, 2), (2, 0b01100000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:252:36 [INFO] [stderr] | [INFO] [stderr] 252 | assert_eq!(get_mask(1, 3), (3, 0b01110000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:253:36 [INFO] [stderr] | [INFO] [stderr] 253 | assert_eq!(get_mask(1, 4), (4, 0b01111000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:254:36 [INFO] [stderr] | [INFO] [stderr] 254 | assert_eq!(get_mask(1, 5), (5, 0b01111100)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:255:36 [INFO] [stderr] | [INFO] [stderr] 255 | assert_eq!(get_mask(1, 6), (6, 0b01111110)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:256:36 [INFO] [stderr] | [INFO] [stderr] 256 | assert_eq!(get_mask(1, 7), (7, 0b01111111)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:257:36 [INFO] [stderr] | [INFO] [stderr] 257 | assert_eq!(get_mask(1, 8), (7, 0b01111111)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:258:36 [INFO] [stderr] | [INFO] [stderr] 258 | assert_eq!(get_mask(1, 9), (7, 0b01111111)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:259:38 [INFO] [stderr] | [INFO] [stderr] 259 | assert_eq!(get_mask(1, 100), (7, 0b01111111)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:261:36 [INFO] [stderr] | [INFO] [stderr] 261 | assert_eq!(get_mask(5, 1), (1, 0b00000100)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:262:36 [INFO] [stderr] | [INFO] [stderr] 262 | assert_eq!(get_mask(5, 2), (2, 0b00000110)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:263:36 [INFO] [stderr] | [INFO] [stderr] 263 | assert_eq!(get_mask(5, 3), (3, 0b00000111)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:264:36 [INFO] [stderr] | [INFO] [stderr] 264 | assert_eq!(get_mask(5, 4), (3, 0b00000111)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:265:36 [INFO] [stderr] | [INFO] [stderr] 265 | assert_eq!(get_mask(5, 5), (3, 0b00000111)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:266:36 [INFO] [stderr] | [INFO] [stderr] 266 | assert_eq!(get_mask(5, 6), (3, 0b00000111)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:267:36 [INFO] [stderr] | [INFO] [stderr] 267 | assert_eq!(get_mask(5, 7), (3, 0b00000111)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:268:36 [INFO] [stderr] | [INFO] [stderr] 268 | assert_eq!(get_mask(5, 8), (3, 0b00000111)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:269:38 [INFO] [stderr] | [INFO] [stderr] 269 | assert_eq!(get_mask(5, 100), (3, 0b00000111)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:392:31 [INFO] [stderr] | [INFO] [stderr] 392 | mask: 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:398:31 [INFO] [stderr] | [INFO] [stderr] 398 | mask: 0b11000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:404:31 [INFO] [stderr] | [INFO] [stderr] 404 | mask: 0b11100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:410:31 [INFO] [stderr] | [INFO] [stderr] 410 | mask: 0b11110000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:416:31 [INFO] [stderr] | [INFO] [stderr] 416 | mask: 0b11111000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:422:31 [INFO] [stderr] | [INFO] [stderr] 422 | mask: 0b11111100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:428:31 [INFO] [stderr] | [INFO] [stderr] 428 | mask: 0b11111110, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:434:31 [INFO] [stderr] | [INFO] [stderr] 434 | mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:440:31 [INFO] [stderr] | [INFO] [stderr] 440 | mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:445:31 [INFO] [stderr] | [INFO] [stderr] 445 | mask: 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:451:31 [INFO] [stderr] | [INFO] [stderr] 451 | mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:456:31 [INFO] [stderr] | [INFO] [stderr] 456 | mask: 0b11000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:463:31 [INFO] [stderr] | [INFO] [stderr] 463 | mask: 0b01000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:469:31 [INFO] [stderr] | [INFO] [stderr] 469 | mask: 0b01100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:475:31 [INFO] [stderr] | [INFO] [stderr] 475 | mask: 0b01110000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:481:31 [INFO] [stderr] | [INFO] [stderr] 481 | mask: 0b01111000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:487:31 [INFO] [stderr] | [INFO] [stderr] 487 | mask: 0b01111100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:493:31 [INFO] [stderr] | [INFO] [stderr] 493 | mask: 0b01111110, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:499:31 [INFO] [stderr] | [INFO] [stderr] 499 | mask: 0b01111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:505:31 [INFO] [stderr] | [INFO] [stderr] 505 | mask: 0b01111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:510:31 [INFO] [stderr] | [INFO] [stderr] 510 | mask: 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:516:31 [INFO] [stderr] | [INFO] [stderr] 516 | mask: 0b01111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:521:31 [INFO] [stderr] | [INFO] [stderr] 521 | mask: 0b11000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:532:31 [INFO] [stderr] | [INFO] [stderr] 532 | mask: 0b00011111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:537:31 [INFO] [stderr] | [INFO] [stderr] 537 | mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:542:31 [INFO] [stderr] | [INFO] [stderr] 542 | mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:547:31 [INFO] [stderr] | [INFO] [stderr] 547 | mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:552:31 [INFO] [stderr] | [INFO] [stderr] 552 | mask: 0b11110000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:604:39 [INFO] [stderr] | [INFO] [stderr] 604 | mask: 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:609:36 [INFO] [stderr] | [INFO] [stderr] 609 | save_mask: 0b01111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:610:37 [INFO] [stderr] | [INFO] [stderr] 610 | value_mask: 0b00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:615:39 [INFO] [stderr] | [INFO] [stderr] 615 | mask: 0b11000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:620:36 [INFO] [stderr] | [INFO] [stderr] 620 | save_mask: 0b00111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:621:37 [INFO] [stderr] | [INFO] [stderr] 621 | value_mask: 0b00000011, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:626:39 [INFO] [stderr] | [INFO] [stderr] 626 | mask: 0b11100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:631:36 [INFO] [stderr] | [INFO] [stderr] 631 | save_mask: 0b00011111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:632:37 [INFO] [stderr] | [INFO] [stderr] 632 | value_mask: 0b00000111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:637:39 [INFO] [stderr] | [INFO] [stderr] 637 | mask: 0b11110000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:642:36 [INFO] [stderr] | [INFO] [stderr] 642 | save_mask: 0b00001111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:643:37 [INFO] [stderr] | [INFO] [stderr] 643 | value_mask: 0b00001111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:648:39 [INFO] [stderr] | [INFO] [stderr] 648 | mask: 0b11111000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:653:36 [INFO] [stderr] | [INFO] [stderr] 653 | save_mask: 0b00000111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:654:37 [INFO] [stderr] | [INFO] [stderr] 654 | value_mask: 0b00011111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:659:39 [INFO] [stderr] | [INFO] [stderr] 659 | mask: 0b11111100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:664:36 [INFO] [stderr] | [INFO] [stderr] 664 | save_mask: 0b00000011, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:665:37 [INFO] [stderr] | [INFO] [stderr] 665 | value_mask: 0b00111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:670:39 [INFO] [stderr] | [INFO] [stderr] 670 | mask: 0b11111110, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:675:36 [INFO] [stderr] | [INFO] [stderr] 675 | save_mask: 0b00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:676:37 [INFO] [stderr] | [INFO] [stderr] 676 | value_mask: 0b01111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:681:39 [INFO] [stderr] | [INFO] [stderr] 681 | mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:686:36 [INFO] [stderr] | [INFO] [stderr] 686 | save_mask: 0b00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:687:37 [INFO] [stderr] | [INFO] [stderr] 687 | value_mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:692:39 [INFO] [stderr] | [INFO] [stderr] 692 | mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:697:39 [INFO] [stderr] | [INFO] [stderr] 697 | mask: 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:702:36 [INFO] [stderr] | [INFO] [stderr] 702 | save_mask: 0b00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:703:37 [INFO] [stderr] | [INFO] [stderr] 703 | value_mask: 0b111111110, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:708:36 [INFO] [stderr] | [INFO] [stderr] 708 | save_mask: 0b01111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:709:37 [INFO] [stderr] | [INFO] [stderr] 709 | value_mask: 0b00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:715:39 [INFO] [stderr] | [INFO] [stderr] 715 | mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:720:39 [INFO] [stderr] | [INFO] [stderr] 720 | mask: 0b11000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:725:36 [INFO] [stderr] | [INFO] [stderr] 725 | save_mask: 0b00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:726:37 [INFO] [stderr] | [INFO] [stderr] 726 | value_mask: 0b1111111100, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b11_1111_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:731:36 [INFO] [stderr] | [INFO] [stderr] 731 | save_mask: 0b00111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:732:37 [INFO] [stderr] | [INFO] [stderr] 732 | value_mask: 0b00000011, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:738:39 [INFO] [stderr] | [INFO] [stderr] 738 | mask: 0b01000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:743:36 [INFO] [stderr] | [INFO] [stderr] 743 | save_mask: 0b10111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:744:37 [INFO] [stderr] | [INFO] [stderr] 744 | value_mask: 0b00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:749:39 [INFO] [stderr] | [INFO] [stderr] 749 | mask: 0b01100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:754:36 [INFO] [stderr] | [INFO] [stderr] 754 | save_mask: 0b10011111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:755:37 [INFO] [stderr] | [INFO] [stderr] 755 | value_mask: 0b00000011, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:760:39 [INFO] [stderr] | [INFO] [stderr] 760 | mask: 0b01110000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:765:36 [INFO] [stderr] | [INFO] [stderr] 765 | save_mask: 0b10001111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:766:37 [INFO] [stderr] | [INFO] [stderr] 766 | value_mask: 0b00000111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:771:39 [INFO] [stderr] | [INFO] [stderr] 771 | mask: 0b01111000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:776:36 [INFO] [stderr] | [INFO] [stderr] 776 | save_mask: 0b10000111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:777:37 [INFO] [stderr] | [INFO] [stderr] 777 | value_mask: 0b00001111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:782:39 [INFO] [stderr] | [INFO] [stderr] 782 | mask: 0b01111100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:787:36 [INFO] [stderr] | [INFO] [stderr] 787 | save_mask: 0b10000011, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:788:37 [INFO] [stderr] | [INFO] [stderr] 788 | value_mask: 0b00011111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:793:39 [INFO] [stderr] | [INFO] [stderr] 793 | mask: 0b01111110, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:798:36 [INFO] [stderr] | [INFO] [stderr] 798 | save_mask: 0b10000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:799:37 [INFO] [stderr] | [INFO] [stderr] 799 | value_mask: 0b00111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:804:39 [INFO] [stderr] | [INFO] [stderr] 804 | mask: 0b01111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:809:36 [INFO] [stderr] | [INFO] [stderr] 809 | save_mask: 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:810:37 [INFO] [stderr] | [INFO] [stderr] 810 | value_mask: 0b01111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:815:39 [INFO] [stderr] | [INFO] [stderr] 815 | mask: 0b01111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:820:39 [INFO] [stderr] | [INFO] [stderr] 820 | mask: 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:825:36 [INFO] [stderr] | [INFO] [stderr] 825 | save_mask: 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:826:37 [INFO] [stderr] | [INFO] [stderr] 826 | value_mask: 0b11111110, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:831:36 [INFO] [stderr] | [INFO] [stderr] 831 | save_mask: 0b01111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:832:37 [INFO] [stderr] | [INFO] [stderr] 832 | value_mask: 0b00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:837:39 [INFO] [stderr] | [INFO] [stderr] 837 | mask: 0b01111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:842:39 [INFO] [stderr] | [INFO] [stderr] 842 | mask: 0b11000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:847:36 [INFO] [stderr] | [INFO] [stderr] 847 | save_mask: 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:848:37 [INFO] [stderr] | [INFO] [stderr] 848 | value_mask: 0b0111111100, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b01_1111_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:853:36 [INFO] [stderr] | [INFO] [stderr] 853 | save_mask: 0b00111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:854:37 [INFO] [stderr] | [INFO] [stderr] 854 | value_mask: 0b00000011, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:860:39 [INFO] [stderr] | [INFO] [stderr] 860 | mask: 0b00011111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:865:39 [INFO] [stderr] | [INFO] [stderr] 865 | mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:870:39 [INFO] [stderr] | [INFO] [stderr] 870 | mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:875:39 [INFO] [stderr] | [INFO] [stderr] 875 | mask: 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:880:39 [INFO] [stderr] | [INFO] [stderr] 880 | mask: 0b11110000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:885:36 [INFO] [stderr] | [INFO] [stderr] 885 | save_mask: 0b11100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:886:37 [INFO] [stderr] | [INFO] [stderr] 886 | value_mask: 0x1F0000000, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_F000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:891:36 [INFO] [stderr] | [INFO] [stderr] 891 | save_mask: 0b00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:892:37 [INFO] [stderr] | [INFO] [stderr] 892 | value_mask: 0x00FF00000, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0000_0FF0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:897:36 [INFO] [stderr] | [INFO] [stderr] 897 | save_mask: 0b00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:898:37 [INFO] [stderr] | [INFO] [stderr] 898 | value_mask: 0x0000FF000, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0000_000F_F000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:903:36 [INFO] [stderr] | [INFO] [stderr] 903 | save_mask: 0b00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:904:37 [INFO] [stderr] | [INFO] [stderr] 904 | value_mask: 0x000000FF0, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0000_0000_0FF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:909:36 [INFO] [stderr] | [INFO] [stderr] 909 | save_mask: 0b00001111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:910:37 [INFO] [stderr] | [INFO] [stderr] 910 | value_mask: 0x00000000F, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0000_0000_000F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decorator.rs:83:34 [INFO] [stderr] | [INFO] [stderr] 83 | } else if ty_str.starts_with("&") { [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decorator.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | for ref field in fields { [INFO] [stderr] | ^^^^^^^^^ ------ help: try: `let field = &fields;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/decorator.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | if let None = field.ident { [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 110 | | ecx.span_err(field.span, "all fields in a packet must be named"); [INFO] [stderr] 111 | | return None; [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________________- help: try this: `if field.ident.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decorator.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | for ref field in sfields { [INFO] [stderr] | ^^^^^^^^^ ------- help: try: `let field = &sfields;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decorator.rs:290:21 [INFO] [stderr] | [INFO] [stderr] 290 | for ref variant in &ed.variants { [INFO] [stderr] | ^^^^^^^^^^^ ------------ help: try: `let variant = &&ed.variants;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/decorator.rs:349:32 [INFO] [stderr] | [INFO] [stderr] 349 | if let None = needs_constant { [INFO] [stderr] | _________________________- ^^^^ [INFO] [stderr] 350 | | needs_constant = Some(span); [INFO] [stderr] 351 | | } [INFO] [stderr] | |_________________________- help: try this: `if needs_constant.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/decorator.rs:458:1 [INFO] [stderr] | [INFO] [stderr] 458 | / fn handle_misc_field(cx: &mut GenContext, [INFO] [stderr] 459 | | error: &mut bool, [INFO] [stderr] 460 | | field: &Field, [INFO] [stderr] 461 | | bit_offset: &mut usize, [INFO] [stderr] ... | [INFO] [stderr] 551 | | [INFO] [stderr] 552 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:482:13 [INFO] [stderr] | [INFO] [stderr] 482 | / inner_accessors = [INFO] [stderr] 483 | | inner_accessors + [INFO] [stderr] 484 | | &generate_accessor_str(&arg_name[..], [INFO] [stderr] 485 | | &ty_str[..], [INFO] [stderr] 486 | | &co[..], [INFO] [stderr] 487 | | &ops[..], [INFO] [stderr] 488 | | Some(&name[..]))[..]; [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 482 | inner_accessors += &generate_accessor_str(&arg_name[..], [INFO] [stderr] 483 | &ty_str[..], [INFO] [stderr] 484 | &co[..], [INFO] [stderr] 485 | &ops[..], [INFO] [stderr] 486 | Some(&name[..]))[..]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:489:13 [INFO] [stderr] | [INFO] [stderr] 489 | / inner_mutators = [INFO] [stderr] 490 | | inner_mutators + [INFO] [stderr] 491 | | &generate_mutator_str(&arg_name[..], [INFO] [stderr] 492 | | &ty_str[..], [INFO] [stderr] 493 | | &co[..], [INFO] [stderr] 494 | | &to_mutator(&ops[..])[..], [INFO] [stderr] 495 | | Some(&name[..]))[..]; [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 489 | inner_mutators += &generate_mutator_str(&arg_name[..], [INFO] [stderr] 490 | &ty_str[..], [INFO] [stderr] 491 | &co[..], [INFO] [stderr] 492 | &to_mutator(&ops[..])[..], [INFO] [stderr] 493 | Some(&name[..]))[..]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/decorator.rs:554:1 [INFO] [stderr] | [INFO] [stderr] 554 | / fn handle_vec_primitive(cx: &mut GenContext, [INFO] [stderr] 555 | | error: &mut bool, [INFO] [stderr] 556 | | inner_ty_str: &str, [INFO] [stderr] 557 | | size: usize, [INFO] [stderr] ... | [INFO] [stderr] 655 | | } [INFO] [stderr] 656 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/decorator.rs:608:13 [INFO] [stderr] | [INFO] [stderr] 608 | / format!(" [INFO] [stderr] 609 | | // &mut and & can never overlap [INFO] [stderr] 610 | | unsafe {{ [INFO] [stderr] 611 | | copy_nonoverlapping(vals[..].as_ptr(), [INFO] [stderr] ... | [INFO] [stderr] 614 | | }} [INFO] [stderr] 615 | | ") [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 608 | " [INFO] [stderr] 609 | // &mut and & can never overlap [INFO] [stderr] 610 | unsafe {{ [INFO] [stderr] 611 | copy_nonoverlapping(vals[..].as_ptr(), [INFO] [stderr] 612 | _self.packet[current_offset..].as_mut_ptr(), [INFO] [stderr] 613 | vals.len()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/decorator.rs:663:34 [INFO] [stderr] | [INFO] [stderr] 663 | inner_ty: &Box, [INFO] [stderr] | ^^^^^^^^^^ help: try: `&Type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/decorator.rs:665:8 [INFO] [stderr] | [INFO] [stderr] 665 | if !field.is_payload && !field.packet_length.is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!field.is_payload && field.packet_length.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/decorator.rs:805:13 [INFO] [stderr] | [INFO] [stderr] 805 | / let mut upper_bound_str = "".to_owned(); [INFO] [stderr] 806 | | if field.packet_length.is_some() { [INFO] [stderr] 807 | | upper_bound_str = [INFO] [stderr] 808 | | format!("{} + {}", co.clone(), field.packet_length.as_ref().unwrap()); [INFO] [stderr] ... | [INFO] [stderr] 815 | | } [INFO] [stderr] 816 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let upper_bound_str = if field.packet_length.is_some() { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { ..; "".to_owned() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:831:17 [INFO] [stderr] | [INFO] [stderr] 831 | / mutators = mutators + [INFO] [stderr] 832 | | &generate_mutator_str(&field.name[..], [INFO] [stderr] 833 | | &ty_str[..], [INFO] [stderr] 834 | | &co[..], [INFO] [stderr] 835 | | &to_mutator(&ops[..])[..], [INFO] [stderr] 836 | | None)[..]; [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 831 | mutators += &generate_mutator_str(&field.name[..], [INFO] [stderr] 832 | &ty_str[..], [INFO] [stderr] 833 | &co[..], [INFO] [stderr] 834 | &to_mutator(&ops[..])[..], [INFO] [stderr] 835 | None)[..]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:837:17 [INFO] [stderr] | [INFO] [stderr] 837 | / accessors = accessors + [INFO] [stderr] 838 | | &generate_accessor_str(&field.name[..], [INFO] [stderr] 839 | | &ty_str[..], [INFO] [stderr] 840 | | &co[..], [INFO] [stderr] 841 | | &ops[..], [INFO] [stderr] 842 | | None)[..]; [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 837 | accessors += &generate_accessor_str(&field.name[..], [INFO] [stderr] 838 | &ty_str[..], [INFO] [stderr] 839 | &co[..], [INFO] [stderr] 840 | &ops[..], [INFO] [stderr] 841 | None)[..]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:884:21 [INFO] [stderr] | [INFO] [stderr] 884 | / set_fields = set_fields + [INFO] [stderr] 885 | | &format!("_self.set_{field}(&packet.{field});\n", [INFO] [stderr] 886 | | field = field.name)[..]; [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 884 | set_fields += &format!("_self.set_{field}(&packet.{field});\n", [INFO] [stderr] 885 | field = field.name)[..]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:889:21 [INFO] [stderr] | [INFO] [stderr] 889 | / set_fields = set_fields + [INFO] [stderr] 890 | | &format!("_self.set_{field}(packet.{field});\n", [INFO] [stderr] 891 | | field = field.name)[..]; [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 889 | set_fields += &format!("_self.set_{field}(packet.{field});\n", [INFO] [stderr] 890 | field = field.name)[..]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:1037:13 [INFO] [stderr] | [INFO] [stderr] 1037 | pre = pre + &format!("let start = {};", payload_bounds.lower)[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pre += &format!("let start = {};", payload_bounds.lower)[..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:1041:13 [INFO] [stderr] | [INFO] [stderr] 1041 | / pre = pre + &format!("let end = ::std::cmp::min({}, _self.packet.len());", [INFO] [stderr] 1042 | | payload_bounds.upper)[..]; [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 1041 | pre += &format!("let end = ::std::cmp::min({}, _self.packet.len());", [INFO] [stderr] 1042 | payload_bounds.upper)[..]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:1284:13 [INFO] [stderr] | [INFO] [stderr] 1284 | ret = ret + &format!("b{} | ", i)[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ret += &format!("b{} | ", i)[..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:1300:13 [INFO] [stderr] | [INFO] [stderr] 1300 | op_strings = op_strings + &format!("let b{} = ({}) as {};\n", idx, operation, ty)[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_strings += &format!("let b{} = ({}) as {};\n", idx, operation, ty)[..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:1302:9 [INFO] [stderr] | [INFO] [stderr] 1302 | op_strings = op_strings + &format!("\n{}\n", build_return(operations.len()))[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_strings += &format!("\n{}\n", build_return(operations.len()))[..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:1387:13 [INFO] [stderr] | [INFO] [stderr] 1387 | / gets = gets + [INFO] [stderr] 1388 | | &format!("{field} : {{ [INFO] [stderr] 1389 | | let payload = self.payload(); [INFO] [stderr] 1390 | | let mut vec = Vec::with_capacity(payload.len()); [INFO] [stderr] ... | [INFO] [stderr] 1393 | | vec [INFO] [stderr] 1394 | | }},\n", field = field.name)[..] [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 1387 | gets += &format!("{field} : {{ [INFO] [stderr] 1388 | let payload = self.payload(); [INFO] [stderr] 1389 | let mut vec = Vec::with_capacity(payload.len()); [INFO] [stderr] 1390 | vec.extend_from_slice(payload); [INFO] [stderr] 1391 | [INFO] [stderr] 1392 | vec [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:1396:13 [INFO] [stderr] | [INFO] [stderr] 1396 | gets = gets + &format!("{field} : _self.get_{field}(),\n", field = field.name)[..] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gets += &format!("{field} : _self.get_{field}(),\n", field = field.name)[..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | let shift = (self.shiftr as i16) - (self.shiftl as i16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.shiftr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:30:44 [INFO] [stderr] | [INFO] [stderr] 30 | let shift = (self.shiftr as i16) - (self.shiftl as i16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.shiftl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | let shift = (self.shiftr as i16) - (self.shiftl as i16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.shiftr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:133:44 [INFO] [stderr] | [INFO] [stderr] 133 | let shift = (self.shiftr as i16) - (self.shiftl as i16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.shiftl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/util.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | format!("{}", mask_str) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `mask_str.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/util.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | mask = mask | (0x80 >> (offset + num_bits_to_mask - 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mask |= (0x80 >> (offset + num_bits_to_mask - 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/util.rs:562:9 [INFO] [stderr] | [INFO] [stderr] 562 | mask = mask | (1 << (bits - 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mask |= (1 << (bits - 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decorator.rs:83:34 [INFO] [stderr] | [INFO] [stderr] 83 | } else if ty_str.starts_with("&") { [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decorator.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | for ref field in fields { [INFO] [stderr] | ^^^^^^^^^ ------ help: try: `let field = &fields;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/decorator.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | if let None = field.ident { [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 110 | | ecx.span_err(field.span, "all fields in a packet must be named"); [INFO] [stderr] 111 | | return None; [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________________- help: try this: `if field.ident.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decorator.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | for ref field in sfields { [INFO] [stderr] | ^^^^^^^^^ ------- help: try: `let field = &sfields;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decorator.rs:290:21 [INFO] [stderr] | [INFO] [stderr] 290 | for ref variant in &ed.variants { [INFO] [stderr] | ^^^^^^^^^^^ ------------ help: try: `let variant = &&ed.variants;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/decorator.rs:349:32 [INFO] [stderr] | [INFO] [stderr] 349 | if let None = needs_constant { [INFO] [stderr] | _________________________- ^^^^ [INFO] [stderr] 350 | | needs_constant = Some(span); [INFO] [stderr] 351 | | } [INFO] [stderr] | |_________________________- help: try this: `if needs_constant.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/decorator.rs:458:1 [INFO] [stderr] | [INFO] [stderr] 458 | / fn handle_misc_field(cx: &mut GenContext, [INFO] [stderr] 459 | | error: &mut bool, [INFO] [stderr] 460 | | field: &Field, [INFO] [stderr] 461 | | bit_offset: &mut usize, [INFO] [stderr] ... | [INFO] [stderr] 551 | | [INFO] [stderr] 552 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:482:13 [INFO] [stderr] | [INFO] [stderr] 482 | / inner_accessors = [INFO] [stderr] 483 | | inner_accessors + [INFO] [stderr] 484 | | &generate_accessor_str(&arg_name[..], [INFO] [stderr] 485 | | &ty_str[..], [INFO] [stderr] 486 | | &co[..], [INFO] [stderr] 487 | | &ops[..], [INFO] [stderr] 488 | | Some(&name[..]))[..]; [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 482 | inner_accessors += &generate_accessor_str(&arg_name[..], [INFO] [stderr] 483 | &ty_str[..], [INFO] [stderr] 484 | &co[..], [INFO] [stderr] 485 | &ops[..], [INFO] [stderr] 486 | Some(&name[..]))[..]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:489:13 [INFO] [stderr] | [INFO] [stderr] 489 | / inner_mutators = [INFO] [stderr] 490 | | inner_mutators + [INFO] [stderr] 491 | | &generate_mutator_str(&arg_name[..], [INFO] [stderr] 492 | | &ty_str[..], [INFO] [stderr] 493 | | &co[..], [INFO] [stderr] 494 | | &to_mutator(&ops[..])[..], [INFO] [stderr] 495 | | Some(&name[..]))[..]; [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 489 | inner_mutators += &generate_mutator_str(&arg_name[..], [INFO] [stderr] 490 | &ty_str[..], [INFO] [stderr] 491 | &co[..], [INFO] [stderr] 492 | &to_mutator(&ops[..])[..], [INFO] [stderr] 493 | Some(&name[..]))[..]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/decorator.rs:554:1 [INFO] [stderr] | [INFO] [stderr] 554 | / fn handle_vec_primitive(cx: &mut GenContext, [INFO] [stderr] 555 | | error: &mut bool, [INFO] [stderr] 556 | | inner_ty_str: &str, [INFO] [stderr] 557 | | size: usize, [INFO] [stderr] ... | [INFO] [stderr] 655 | | } [INFO] [stderr] 656 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/decorator.rs:608:13 [INFO] [stderr] | [INFO] [stderr] 608 | / format!(" [INFO] [stderr] 609 | | // &mut and & can never overlap [INFO] [stderr] 610 | | unsafe {{ [INFO] [stderr] 611 | | copy_nonoverlapping(vals[..].as_ptr(), [INFO] [stderr] ... | [INFO] [stderr] 614 | | }} [INFO] [stderr] 615 | | ") [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 608 | " [INFO] [stderr] 609 | // &mut and & can never overlap [INFO] [stderr] 610 | unsafe {{ [INFO] [stderr] 611 | copy_nonoverlapping(vals[..].as_ptr(), [INFO] [stderr] 612 | _self.packet[current_offset..].as_mut_ptr(), [INFO] [stderr] 613 | vals.len()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/decorator.rs:663:34 [INFO] [stderr] | [INFO] [stderr] 663 | inner_ty: &Box, [INFO] [stderr] | ^^^^^^^^^^ help: try: `&Type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/decorator.rs:665:8 [INFO] [stderr] | [INFO] [stderr] 665 | if !field.is_payload && !field.packet_length.is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!field.is_payload && field.packet_length.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/decorator.rs:805:13 [INFO] [stderr] | [INFO] [stderr] 805 | / let mut upper_bound_str = "".to_owned(); [INFO] [stderr] 806 | | if field.packet_length.is_some() { [INFO] [stderr] 807 | | upper_bound_str = [INFO] [stderr] 808 | | format!("{} + {}", co.clone(), field.packet_length.as_ref().unwrap()); [INFO] [stderr] ... | [INFO] [stderr] 815 | | } [INFO] [stderr] 816 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let upper_bound_str = if field.packet_length.is_some() { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { ..; "".to_owned() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:831:17 [INFO] [stderr] | [INFO] [stderr] 831 | / mutators = mutators + [INFO] [stderr] 832 | | &generate_mutator_str(&field.name[..], [INFO] [stderr] 833 | | &ty_str[..], [INFO] [stderr] 834 | | &co[..], [INFO] [stderr] 835 | | &to_mutator(&ops[..])[..], [INFO] [stderr] 836 | | None)[..]; [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 831 | mutators += &generate_mutator_str(&field.name[..], [INFO] [stderr] 832 | &ty_str[..], [INFO] [stderr] 833 | &co[..], [INFO] [stderr] 834 | &to_mutator(&ops[..])[..], [INFO] [stderr] 835 | None)[..]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:837:17 [INFO] [stderr] | [INFO] [stderr] 837 | / accessors = accessors + [INFO] [stderr] 838 | | &generate_accessor_str(&field.name[..], [INFO] [stderr] 839 | | &ty_str[..], [INFO] [stderr] 840 | | &co[..], [INFO] [stderr] 841 | | &ops[..], [INFO] [stderr] 842 | | None)[..]; [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 837 | accessors += &generate_accessor_str(&field.name[..], [INFO] [stderr] 838 | &ty_str[..], [INFO] [stderr] 839 | &co[..], [INFO] [stderr] 840 | &ops[..], [INFO] [stderr] 841 | None)[..]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:884:21 [INFO] [stderr] | [INFO] [stderr] 884 | / set_fields = set_fields + [INFO] [stderr] 885 | | &format!("_self.set_{field}(&packet.{field});\n", [INFO] [stderr] 886 | | field = field.name)[..]; [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 884 | set_fields += &format!("_self.set_{field}(&packet.{field});\n", [INFO] [stderr] 885 | field = field.name)[..]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:889:21 [INFO] [stderr] | [INFO] [stderr] 889 | / set_fields = set_fields + [INFO] [stderr] 890 | | &format!("_self.set_{field}(packet.{field});\n", [INFO] [stderr] 891 | | field = field.name)[..]; [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 889 | set_fields += &format!("_self.set_{field}(packet.{field});\n", [INFO] [stderr] 890 | field = field.name)[..]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:1037:13 [INFO] [stderr] | [INFO] [stderr] 1037 | pre = pre + &format!("let start = {};", payload_bounds.lower)[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pre += &format!("let start = {};", payload_bounds.lower)[..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:1041:13 [INFO] [stderr] | [INFO] [stderr] 1041 | / pre = pre + &format!("let end = ::std::cmp::min({}, _self.packet.len());", [INFO] [stderr] 1042 | | payload_bounds.upper)[..]; [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 1041 | pre += &format!("let end = ::std::cmp::min({}, _self.packet.len());", [INFO] [stderr] 1042 | payload_bounds.upper)[..]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:1284:13 [INFO] [stderr] | [INFO] [stderr] 1284 | ret = ret + &format!("b{} | ", i)[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ret += &format!("b{} | ", i)[..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:1300:13 [INFO] [stderr] | [INFO] [stderr] 1300 | op_strings = op_strings + &format!("let b{} = ({}) as {};\n", idx, operation, ty)[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_strings += &format!("let b{} = ({}) as {};\n", idx, operation, ty)[..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:1302:9 [INFO] [stderr] | [INFO] [stderr] 1302 | op_strings = op_strings + &format!("\n{}\n", build_return(operations.len()))[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_strings += &format!("\n{}\n", build_return(operations.len()))[..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:1387:13 [INFO] [stderr] | [INFO] [stderr] 1387 | / gets = gets + [INFO] [stderr] 1388 | | &format!("{field} : {{ [INFO] [stderr] 1389 | | let payload = self.payload(); [INFO] [stderr] 1390 | | let mut vec = Vec::with_capacity(payload.len()); [INFO] [stderr] ... | [INFO] [stderr] 1393 | | vec [INFO] [stderr] 1394 | | }},\n", field = field.name)[..] [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 1387 | gets += &format!("{field} : {{ [INFO] [stderr] 1388 | let payload = self.payload(); [INFO] [stderr] 1389 | let mut vec = Vec::with_capacity(payload.len()); [INFO] [stderr] 1390 | vec.extend_from_slice(payload); [INFO] [stderr] 1391 | [INFO] [stderr] 1392 | vec [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/decorator.rs:1396:13 [INFO] [stderr] | [INFO] [stderr] 1396 | gets = gets + &format!("{field} : _self.get_{field}(),\n", field = field.name)[..] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gets += &format!("{field} : _self.get_{field}(),\n", field = field.name)[..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | let shift = (self.shiftr as i16) - (self.shiftl as i16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.shiftr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:30:44 [INFO] [stderr] | [INFO] [stderr] 30 | let shift = (self.shiftr as i16) - (self.shiftl as i16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.shiftl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | let shift = (self.shiftr as i16) - (self.shiftl as i16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.shiftr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:133:44 [INFO] [stderr] | [INFO] [stderr] 133 | let shift = (self.shiftr as i16) - (self.shiftl as i16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.shiftl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/util.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | format!("{}", mask_str) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `mask_str.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/util.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | mask = mask | (0x80 >> (offset + num_bits_to_mask - 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mask |= (0x80 >> (offset + num_bits_to_mask - 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/util.rs:238:1 [INFO] [stderr] | [INFO] [stderr] 238 | / fn test_get_mask() { [INFO] [stderr] 239 | | assert_eq!(get_mask(0, 1), (1, 0b10000000)); [INFO] [stderr] 240 | | assert_eq!(get_mask(0, 2), (2, 0b11000000)); [INFO] [stderr] 241 | | assert_eq!(get_mask(0, 3), (3, 0b11100000)); [INFO] [stderr] ... | [INFO] [stderr] 269 | | assert_eq!(get_mask(5, 100), (3, 0b00000111)); [INFO] [stderr] 270 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/util.rs:562:9 [INFO] [stderr] | [INFO] [stderr] 562 | mask = mask | (1 << (bits - 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mask |= (1 << (bits - 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.07s [INFO] running `"docker" "inspect" "f7e5d821cc298703918cef0729e5af1a7db6812a002ddccb3784be9926b28698"` [INFO] running `"docker" "rm" "-f" "f7e5d821cc298703918cef0729e5af1a7db6812a002ddccb3784be9926b28698"` [INFO] [stdout] f7e5d821cc298703918cef0729e5af1a7db6812a002ddccb3784be9926b28698