[INFO] crate pnet_base 0.21.0 is already in cache [INFO] extracting crate pnet_base 0.21.0 into work/ex/clippy-test-run/sources/stable/reg/pnet_base/0.21.0 [INFO] extracting crate pnet_base 0.21.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnet_base/0.21.0 [INFO] validating manifest of pnet_base-0.21.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pnet_base-0.21.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pnet_base-0.21.0 [INFO] finished frobbing pnet_base-0.21.0 [INFO] frobbed toml for pnet_base-0.21.0 written to work/ex/clippy-test-run/sources/stable/reg/pnet_base/0.21.0/Cargo.toml [INFO] started frobbing pnet_base-0.21.0 [INFO] finished frobbing pnet_base-0.21.0 [INFO] frobbed toml for pnet_base-0.21.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnet_base/0.21.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pnet_base-0.21.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pnet_base/0.21.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6f581f75026f83d618d0387c185236f7baa40d24917c95c7675d02ef90c9d038 [INFO] running `"docker" "start" "-a" "6f581f75026f83d618d0387c185236f7baa40d24917c95c7675d02ef90c9d038"` [INFO] [stderr] Checking pnet_base v0.21.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/macaddr.rs:18:44 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(a: u8, b: u8, c: u8, d: u8, e: u8, f: u8) -> MacAddr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/macaddr.rs:18:51 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(a: u8, b: u8, c: u8, d: u8, e: u8, f: u8) -> MacAddr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/macaddr.rs:18:44 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(a: u8, b: u8, c: u8, d: u8, e: u8, f: u8) -> MacAddr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/macaddr.rs:18:51 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(a: u8, b: u8, c: u8, d: u8, e: u8, f: u8) -> MacAddr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/macaddr.rs:67:26 [INFO] [stderr] | [INFO] [stderr] 67 | Ok(b) if split.len() != 0 => parts[i] = b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!split.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/macaddr.rs:67:26 [INFO] [stderr] | [INFO] [stderr] 67 | Ok(b) if split.len() != 0 => parts[i] = b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!split.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.09s [INFO] running `"docker" "inspect" "6f581f75026f83d618d0387c185236f7baa40d24917c95c7675d02ef90c9d038"` [INFO] running `"docker" "rm" "-f" "6f581f75026f83d618d0387c185236f7baa40d24917c95c7675d02ef90c9d038"` [INFO] [stdout] 6f581f75026f83d618d0387c185236f7baa40d24917c95c7675d02ef90c9d038