[INFO] crate pnacl-build-helper 1.4.11 is already in cache [INFO] extracting crate pnacl-build-helper 1.4.11 into work/ex/clippy-test-run/sources/stable/reg/pnacl-build-helper/1.4.11 [INFO] extracting crate pnacl-build-helper 1.4.11 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnacl-build-helper/1.4.11 [INFO] validating manifest of pnacl-build-helper-1.4.11 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pnacl-build-helper-1.4.11 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pnacl-build-helper-1.4.11 [INFO] finished frobbing pnacl-build-helper-1.4.11 [INFO] frobbed toml for pnacl-build-helper-1.4.11 written to work/ex/clippy-test-run/sources/stable/reg/pnacl-build-helper/1.4.11/Cargo.toml [INFO] started frobbing pnacl-build-helper-1.4.11 [INFO] finished frobbing pnacl-build-helper-1.4.11 [INFO] frobbed toml for pnacl-build-helper-1.4.11 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnacl-build-helper/1.4.11/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pnacl-build-helper-1.4.11 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pnacl-build-helper/1.4.11:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2da056b1581ec7ee43cd11b0a9e03de914c64e1ad73baca49dd69eb0ba35e3a6 [INFO] running `"docker" "start" "-a" "2da056b1581ec7ee43cd11b0a9e03de914c64e1ad73baca49dd69eb0ba35e3a6"` [INFO] [stderr] Checking pnacl-build-helper v1.4.11 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:228:17 [INFO] [stderr] | [INFO] [stderr] 228 | cc: cc, [INFO] [stderr] | ^^^^^^ help: replace it with: `cc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:229:17 [INFO] [stderr] | [INFO] [stderr] 229 | cxx: cxx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cxx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:230:17 [INFO] [stderr] | [INFO] [stderr] 230 | ar: ar, [INFO] [stderr] | ^^^^^^ help: replace it with: `ar` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:231:17 [INFO] [stderr] | [INFO] [stderr] 231 | ranlib: ranlib, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ranlib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:346:13 [INFO] [stderr] | [INFO] [stderr] 346 | tools: tools, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tools` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | args: args, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:376:13 [INFO] [stderr] | [INFO] [stderr] 376 | src_dir: src_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `src_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:455:13 [INFO] [stderr] | [INFO] [stderr] 455 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:456:13 [INFO] [stderr] | [INFO] [stderr] 456 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:489:9 [INFO] [stderr] | [INFO] [stderr] 489 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:490:9 [INFO] [stderr] | [INFO] [stderr] 490 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:524:13 [INFO] [stderr] | [INFO] [stderr] 524 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:525:13 [INFO] [stderr] | [INFO] [stderr] 525 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:228:17 [INFO] [stderr] | [INFO] [stderr] 228 | cc: cc, [INFO] [stderr] | ^^^^^^ help: replace it with: `cc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:229:17 [INFO] [stderr] | [INFO] [stderr] 229 | cxx: cxx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cxx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:230:17 [INFO] [stderr] | [INFO] [stderr] 230 | ar: ar, [INFO] [stderr] | ^^^^^^ help: replace it with: `ar` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:231:17 [INFO] [stderr] | [INFO] [stderr] 231 | ranlib: ranlib, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ranlib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:346:13 [INFO] [stderr] | [INFO] [stderr] 346 | tools: tools, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tools` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | args: args, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:376:13 [INFO] [stderr] | [INFO] [stderr] 376 | src_dir: src_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `src_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:455:13 [INFO] [stderr] | [INFO] [stderr] 455 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:456:13 [INFO] [stderr] | [INFO] [stderr] 456 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:489:9 [INFO] [stderr] | [INFO] [stderr] 489 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:490:9 [INFO] [stderr] | [INFO] [stderr] 490 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:524:13 [INFO] [stderr] | [INFO] [stderr] 524 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:525:13 [INFO] [stderr] | [INFO] [stderr] 525 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | return self.fresh.get().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.fresh.get().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:457:13 [INFO] [stderr] | [INFO] [stderr] 457 | return self.fresh.get().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.fresh.get().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | return self.fresh.get().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.fresh.get().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:457:13 [INFO] [stderr] | [INFO] [stderr] 457 | return self.fresh.get().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.fresh.get().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join [INFO] [stderr] --> src/lib.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | .connect("_"); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join [INFO] [stderr] --> src/lib.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | .connect("_"); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 26 | | &NaClMode::Portable => "le32", [INFO] [stderr] 27 | | &NaClMode::Native(s) => s, [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | let s = match *self { [INFO] [stderr] 26 | NaClMode::Portable => "le32", [INFO] [stderr] 27 | NaClMode::Native(s) => s, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:384:29 [INFO] [stderr] | [INFO] [stderr] 384 | .unwrap_or_else(|| VecDeque::new() ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `VecDeque::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:433:20 [INFO] [stderr] | [INFO] [stderr] 433 | if !files.is_ok() { continue; } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `files.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:439:24 [INFO] [stderr] | [INFO] [stderr] 439 | if !stat.is_ok() { continue; } [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `stat.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:611:9 [INFO] [stderr] | [INFO] [stderr] 611 | / match target { [INFO] [stderr] 612 | | Some(NaClMode::Portable) => { [INFO] [stderr] 613 | | a.push(format!("-I{}/include/pnacl", sdk.display())) [INFO] [stderr] 614 | | } [INFO] [stderr] 615 | | _ => (), [INFO] [stderr] 616 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 611 | if let Some(NaClMode::Portable) = target { [INFO] [stderr] 612 | a.push(format!("-I{}/include/pnacl", sdk.display())) [INFO] [stderr] 613 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 26 | | &NaClMode::Portable => "le32", [INFO] [stderr] 27 | | &NaClMode::Native(s) => s, [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | let s = match *self { [INFO] [stderr] 26 | NaClMode::Portable => "le32", [INFO] [stderr] 27 | NaClMode::Native(s) => s, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:384:29 [INFO] [stderr] | [INFO] [stderr] 384 | .unwrap_or_else(|| VecDeque::new() ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `VecDeque::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:433:20 [INFO] [stderr] | [INFO] [stderr] 433 | if !files.is_ok() { continue; } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `files.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:439:24 [INFO] [stderr] | [INFO] [stderr] 439 | if !stat.is_ok() { continue; } [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `stat.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:611:9 [INFO] [stderr] | [INFO] [stderr] 611 | / match target { [INFO] [stderr] 612 | | Some(NaClMode::Portable) => { [INFO] [stderr] 613 | | a.push(format!("-I{}/include/pnacl", sdk.display())) [INFO] [stderr] 614 | | } [INFO] [stderr] 615 | | _ => (), [INFO] [stderr] 616 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 611 | if let Some(NaClMode::Portable) = target { [INFO] [stderr] 612 | a.push(format!("-I{}/include/pnacl", sdk.display())) [INFO] [stderr] 613 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.34s [INFO] running `"docker" "inspect" "2da056b1581ec7ee43cd11b0a9e03de914c64e1ad73baca49dd69eb0ba35e3a6"` [INFO] running `"docker" "rm" "-f" "2da056b1581ec7ee43cd11b0a9e03de914c64e1ad73baca49dd69eb0ba35e3a6"` [INFO] [stdout] 2da056b1581ec7ee43cd11b0a9e03de914c64e1ad73baca49dd69eb0ba35e3a6