[INFO] crate plumber 0.0.7 is already in cache [INFO] extracting crate plumber 0.0.7 into work/ex/clippy-test-run/sources/stable/reg/plumber/0.0.7 [INFO] extracting crate plumber 0.0.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/plumber/0.0.7 [INFO] validating manifest of plumber-0.0.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of plumber-0.0.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing plumber-0.0.7 [INFO] finished frobbing plumber-0.0.7 [INFO] frobbed toml for plumber-0.0.7 written to work/ex/clippy-test-run/sources/stable/reg/plumber/0.0.7/Cargo.toml [INFO] started frobbing plumber-0.0.7 [INFO] finished frobbing plumber-0.0.7 [INFO] frobbed toml for plumber-0.0.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/plumber/0.0.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting plumber-0.0.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/plumber/0.0.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9aaea243da889e6dfde182577b2f375b520206ba254e3b0682925699fd6cc286 [INFO] running `"docker" "start" "-a" "9aaea243da889e6dfde182577b2f375b520206ba254e3b0682925699fd6cc286"` [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking plumber v0.0.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dns.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dns.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Checking rand_pcg v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_os v0.1.1 [INFO] [stderr] Checking rand_chacha v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate lazy_static; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `BTreeMap` [INFO] [stderr] --> src/hooks.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | use std::collections::{BTreeMap}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `CStr` [INFO] [stderr] --> src/hooks.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | use std::ffi::{CStr}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::mem` [INFO] [stderr] --> src/hooks.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::mem; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::from_utf8` [INFO] [stderr] --> src/hooks.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::str::from_utf8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `RwLock` [INFO] [stderr] --> src/hooks.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | use std::sync::{RwLock}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `dynamic::dlsym_next` [INFO] [stderr] --> src/hooks.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use dynamic::dlsym_next; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `port_ip_to_sa_data`, `sockaddr_to_port_ip` [INFO] [stderr] --> src/hooks.rs:11:12 [INFO] [stderr] | [INFO] [stderr] 11 | use util::{sockaddr_to_port_ip,port_ip_to_sa_data}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `dns::srv_mapper` [INFO] [stderr] --> src/hooks.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use dns::srv_mapper; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/util.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | let data = unsafe { (*address).sa_data }; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:17:6 [INFO] [stderr] | [INFO] [stderr] 17 | ((data[0] as u16) << 8 | (data[1] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(data[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:17:30 [INFO] [stderr] | [INFO] [stderr] 17 | ((data[0] as u16) << 8 | (data[1] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variant `ns_s_qd` should have a camel case name such as `NsSQd` [INFO] [stderr] --> src/ctypes.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | ns_s_qd = 0, /* Query: Question. */ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `ns_s_an` should have a camel case name such as `NsSAn` [INFO] [stderr] --> src/ctypes.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | ns_s_an = 1, /* Query: Answer. */ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `ns_s_ns` should have a camel case name such as `NsSNs` [INFO] [stderr] --> src/ctypes.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | ns_s_ns = 2, /* Query: Name servers. */ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `ns_s_ar` should have a camel case name such as `NsSAr` [INFO] [stderr] --> src/ctypes.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | ns_s_ar = 3, /* Query|Update: Additional records. */ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `ns_s_max` should have a camel case name such as `NsSMax` [INFO] [stderr] --> src/ctypes.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | ns_s_max = 4 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/ctypes.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | rdata: 0 as *const u8, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/ctypes.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | msg: 0 as *const u8, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/ctypes.rs:105:18 [INFO] [stderr] | [INFO] [stderr] 105 | eom: 0 as *const u8, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/ctypes.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | sections: [0 as *const u8, 0 as *const u8, 0 as *const u8, 0 as *const u8], [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/ctypes.rs:109:40 [INFO] [stderr] | [INFO] [stderr] 109 | sections: [0 as *const u8, 0 as *const u8, 0 as *const u8, 0 as *const u8], [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/ctypes.rs:109:56 [INFO] [stderr] | [INFO] [stderr] 109 | sections: [0 as *const u8, 0 as *const u8, 0 as *const u8, 0 as *const u8], [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/ctypes.rs:109:72 [INFO] [stderr] | [INFO] [stderr] 109 | sections: [0 as *const u8, 0 as *const u8, 0 as *const u8, 0 as *const u8], [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/ctypes.rs:112:22 [INFO] [stderr] | [INFO] [stderr] 112 | msg_ptr: 0 as *const u8, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/dns.rs:46:31 [INFO] [stderr] | [INFO] [stderr] 46 | let nmsg_additional = msg.counts[3] as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(msg.counts[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/dns.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | 0 as *const c_char, 0 as *const c_char, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/dns.rs:52:45 [INFO] [stderr] | [INFO] [stderr] 52 | 0 as *const c_char, 0 as *const c_char, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dns.rs:58:44 [INFO] [stderr] | [INFO] [stderr] 58 | let octets: Vec = ip.split(".").map( |o| { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/dns.rs:73:27 [INFO] [stderr] | [INFO] [stderr] 73 | let nmsg_answer = msg.counts[1] as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(msg.counts[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/dns.rs:79:25 [INFO] [stderr] | [INFO] [stderr] 79 | 0 as *const c_char, 0 as *const c_char, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/dns.rs:79:45 [INFO] [stderr] | [INFO] [stderr] 79 | 0 as *const c_char, 0 as *const c_char, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dns.rs:87:30 [INFO] [stderr] | [INFO] [stderr] 87 | let prio: u16 = ((rdata[0] as u16) << 8) + rdata[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(rdata[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dns.rs:87:56 [INFO] [stderr] | [INFO] [stderr] 87 | let prio: u16 = ((rdata[0] as u16) << 8) + rdata[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(rdata[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dns.rs:88:32 [INFO] [stderr] | [INFO] [stderr] 88 | let weight: u16 = ((rdata[2] as u16) << 8) + rdata[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(rdata[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dns.rs:88:58 [INFO] [stderr] | [INFO] [stderr] 88 | let weight: u16 = ((rdata[2] as u16) << 8) + rdata[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(rdata[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dns.rs:89:30 [INFO] [stderr] | [INFO] [stderr] 89 | let port: u16 = ((rdata[4] as u16) << 8) + rdata[5] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(rdata[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dns.rs:89:56 [INFO] [stderr] | [INFO] [stderr] 89 | let port: u16 = ((rdata[4] as u16) << 8) + rdata[5] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(rdata[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dns.rs:91:22 [INFO] [stderr] | [INFO] [stderr] 91 | ip: *host_to_ip.get(&s.split(" ").last().unwrap().to_string()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&host_to_ip[&s.split(" ").last().unwrap().to_string()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dns.rs:91:46 [INFO] [stderr] | [INFO] [stderr] 91 | ip: *host_to_ip.get(&s.split(" ").last().unwrap().to_string()).unwrap(), [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dns.rs:99:8 [INFO] [stderr] | [INFO] [stderr] 99 | if res.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `res.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/dns.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | pub fn srv_mapper(host: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dns.rs:119:8 [INFO] [stderr] | [INFO] [stderr] 119 | if results.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `results.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `plumber`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "9aaea243da889e6dfde182577b2f375b520206ba254e3b0682925699fd6cc286"` [INFO] running `"docker" "rm" "-f" "9aaea243da889e6dfde182577b2f375b520206ba254e3b0682925699fd6cc286"` [INFO] [stdout] 9aaea243da889e6dfde182577b2f375b520206ba254e3b0682925699fd6cc286