[INFO] crate plist 0.3.0 is already in cache [INFO] extracting crate plist 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/plist/0.3.0 [INFO] extracting crate plist 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/plist/0.3.0 [INFO] validating manifest of plist-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of plist-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing plist-0.3.0 [INFO] finished frobbing plist-0.3.0 [INFO] frobbed toml for plist-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/plist/0.3.0/Cargo.toml [INFO] started frobbing plist-0.3.0 [INFO] finished frobbing plist-0.3.0 [INFO] frobbed toml for plist-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/plist/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting plist-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/plist/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0511f823664d251851b898d6a534c087f61e945faa52660a89ee2a2b9ef67c73 [INFO] running `"docker" "start" "-a" "0511f823664d251851b898d6a534c087f61e945faa52660a89ee2a2b9ef67c73"` [INFO] [stderr] Compiling plist v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binary/reader.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binary/reader.rs:268:21 [INFO] [stderr] | [INFO] [stderr] 268 | object_refs: object_refs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `object_refs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binary/reader.rs:289:21 [INFO] [stderr] | [INFO] [stderr] 289 | object_refs: object_refs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `object_refs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serde/de.rs:323:13 [INFO] [stderr] | [INFO] [stderr] 323 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serde/de.rs:324:13 [INFO] [stderr] | [INFO] [stderr] 324 | is_struct: is_struct, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_struct` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serde/ser.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | Serializer { writer: writer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binary/reader.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binary/reader.rs:268:21 [INFO] [stderr] | [INFO] [stderr] 268 | object_refs: object_refs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `object_refs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/binary/reader.rs:289:21 [INFO] [stderr] | [INFO] [stderr] 289 | object_refs: object_refs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `object_refs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serde/de.rs:323:13 [INFO] [stderr] | [INFO] [stderr] 323 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serde/de.rs:324:13 [INFO] [stderr] | [INFO] [stderr] 324 | is_struct: is_struct, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_struct` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serde/ser.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | Serializer { writer: writer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/date.rs:28:49 [INFO] [stderr] | [INFO] [stderr] 28 | const PLIST_EPOCH_UNIX_TIMESTAMP: u64 = 978307200; [INFO] [stderr] | ^^^^^^^^^ help: consider: `978_307_200` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/date.rs:79:42 [INFO] [stderr] | [INFO] [stderr] 79 | pub const DATE_NEWTYPE_STRUCT_NAME: &'static str = "PLIST-DATE"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/date.rs:28:49 [INFO] [stderr] | [INFO] [stderr] 28 | const PLIST_EPOCH_UNIX_TIMESTAMP: u64 = 978307200; [INFO] [stderr] | ^^^^^^^^^ help: consider: `978_307_200` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/date.rs:79:42 [INFO] [stderr] | [INFO] [stderr] 79 | pub const DATE_NEWTYPE_STRUCT_NAME: &'static str = "PLIST-DATE"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:129:32 [INFO] [stderr] | [INFO] [stderr] 129 | 1 => ints.push(self.reader.read_u8()? as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:130:32 [INFO] [stderr] | [INFO] [stderr] 130 | 2 => ints.push(self.reader.read_u16::()? as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reader.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:131:32 [INFO] [stderr] | [INFO] [stderr] 131 | 4 => ints.push(self.reader.read_u32::()? as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reader.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:148:22 [INFO] [stderr] | [INFO] [stderr] 148 | 0 => self.reader.read_u8()? as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:149:22 [INFO] [stderr] | [INFO] [stderr] 149 | 1 => self.reader.read_u16::()? as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reader.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:150:22 [INFO] [stderr] | [INFO] [stderr] 150 | 2 => self.reader.read_u32::()? as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reader.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:155:16 [INFO] [stderr] | [INFO] [stderr] 155 | Ok(len as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/binary/reader.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | / fn read_next(&mut self) -> Result> { [INFO] [stderr] 175 | | if self.ref_size == 0 { [INFO] [stderr] 176 | | // Initialise here rather than in new [INFO] [stderr] 177 | | self.read_trailer()?; [INFO] [stderr] ... | [INFO] [stderr] 302 | | Ok(result) [INFO] [stderr] 303 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:215:55 [INFO] [stderr] | [INFO] [stderr] 215 | (0x1, 0) => Some(PlistEvent::IntegerValue(self.reader.read_u8()? as i64)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | self.reader.read_u16::()? as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.reader.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:220:17 [INFO] [stderr] | [INFO] [stderr] 220 | self.reader.read_u32::()? as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.reader.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:225:52 [INFO] [stderr] | [INFO] [stderr] 225 | (0x2, 2) => Some(PlistEvent::RealValue(self.reader.read_f32::()? as f64)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.reader.read_f32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/binary/reader.rs:281:26 [INFO] [stderr] | [INFO] [stderr] 281 | for i in 1..len + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/date.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | Date { inner: date.into() } [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `date` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/date.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | self.inner.into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | Plist::Real(from as f64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:236:24 [INFO] [stderr] | [INFO] [stderr] 236 | Plist::Integer(from as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:242:24 [INFO] [stderr] | [INFO] [stderr] 242 | Plist::Integer(from as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:248:24 [INFO] [stderr] | [INFO] [stderr] 248 | Plist::Integer(from as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:254:24 [INFO] [stderr] | [INFO] [stderr] 254 | Plist::Integer(from as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:260:24 [INFO] [stderr] | [INFO] [stderr] 260 | Plist::Integer(from as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:266:24 [INFO] [stderr] | [INFO] [stderr] 266 | Plist::Integer(from as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:278:21 [INFO] [stderr] | [INFO] [stderr] 278 | Plist::Real(*from as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:290:24 [INFO] [stderr] | [INFO] [stderr] 290 | Plist::Integer(*from as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:296:24 [INFO] [stderr] | [INFO] [stderr] 296 | Plist::Integer(*from as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:302:24 [INFO] [stderr] | [INFO] [stderr] 302 | Plist::Integer(*from as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:308:24 [INFO] [stderr] | [INFO] [stderr] 308 | Plist::Integer(*from as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:314:24 [INFO] [stderr] | [INFO] [stderr] 314 | Plist::Integer(*from as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:320:24 [INFO] [stderr] | [INFO] [stderr] 320 | Plist::Integer(*from as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/serde/ser.rs:61:28 [INFO] [stderr] | [INFO] [stderr] 61 | self.serialize_i64(v as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/serde/ser.rs:65:28 [INFO] [stderr] | [INFO] [stderr] 65 | self.serialize_i64(v as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/serde/ser.rs:69:28 [INFO] [stderr] | [INFO] [stderr] 69 | self.serialize_i64(v as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serde/ser.rs:77:28 [INFO] [stderr] | [INFO] [stderr] 77 | self.serialize_u64(v as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serde/ser.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | self.serialize_u64(v as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serde/ser.rs:85:28 [INFO] [stderr] | [INFO] [stderr] 85 | self.serialize_u64(v as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/serde/ser.rs:93:28 [INFO] [stderr] | [INFO] [stderr] 93 | self.serialize_f64(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:129:32 [INFO] [stderr] | [INFO] [stderr] 129 | 1 => ints.push(self.reader.read_u8()? as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:130:32 [INFO] [stderr] | [INFO] [stderr] 130 | 2 => ints.push(self.reader.read_u16::()? as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reader.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:131:32 [INFO] [stderr] | [INFO] [stderr] 131 | 4 => ints.push(self.reader.read_u32::()? as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reader.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:148:22 [INFO] [stderr] | [INFO] [stderr] 148 | 0 => self.reader.read_u8()? as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:149:22 [INFO] [stderr] | [INFO] [stderr] 149 | 1 => self.reader.read_u16::()? as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reader.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:150:22 [INFO] [stderr] | [INFO] [stderr] 150 | 2 => self.reader.read_u32::()? as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reader.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:155:16 [INFO] [stderr] | [INFO] [stderr] 155 | Ok(len as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/binary/reader.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | / fn read_next(&mut self) -> Result> { [INFO] [stderr] 175 | | if self.ref_size == 0 { [INFO] [stderr] 176 | | // Initialise here rather than in new [INFO] [stderr] 177 | | self.read_trailer()?; [INFO] [stderr] ... | [INFO] [stderr] 302 | | Ok(result) [INFO] [stderr] 303 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:215:55 [INFO] [stderr] | [INFO] [stderr] 215 | (0x1, 0) => Some(PlistEvent::IntegerValue(self.reader.read_u8()? as i64)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | self.reader.read_u16::()? as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.reader.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:220:17 [INFO] [stderr] | [INFO] [stderr] 220 | self.reader.read_u32::()? as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.reader.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/binary/reader.rs:225:52 [INFO] [stderr] | [INFO] [stderr] 225 | (0x2, 2) => Some(PlistEvent::RealValue(self.reader.read_f32::()? as f64)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.reader.read_f32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/binary/reader.rs:281:26 [INFO] [stderr] | [INFO] [stderr] 281 | for i in 1..len + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/builder.rs:126:59 [INFO] [stderr] | [INFO] [stderr] 126 | let builder = Builder::new(events.into_iter().map(|e| Ok(e))); [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/date.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | Date { inner: date.into() } [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `date` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/date.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | self.inner.into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | Plist::Real(from as f64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:236:24 [INFO] [stderr] | [INFO] [stderr] 236 | Plist::Integer(from as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:242:24 [INFO] [stderr] | [INFO] [stderr] 242 | Plist::Integer(from as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:248:24 [INFO] [stderr] | [INFO] [stderr] 248 | Plist::Integer(from as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:254:24 [INFO] [stderr] | [INFO] [stderr] 254 | Plist::Integer(from as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:260:24 [INFO] [stderr] | [INFO] [stderr] 260 | Plist::Integer(from as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:266:24 [INFO] [stderr] | [INFO] [stderr] 266 | Plist::Integer(from as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:278:21 [INFO] [stderr] | [INFO] [stderr] 278 | Plist::Real(*from as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:290:24 [INFO] [stderr] | [INFO] [stderr] 290 | Plist::Integer(*from as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:296:24 [INFO] [stderr] | [INFO] [stderr] 296 | Plist::Integer(*from as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:302:24 [INFO] [stderr] | [INFO] [stderr] 302 | Plist::Integer(*from as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:308:24 [INFO] [stderr] | [INFO] [stderr] 308 | Plist::Integer(*from as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:314:24 [INFO] [stderr] | [INFO] [stderr] 314 | Plist::Integer(*from as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/plist.rs:320:24 [INFO] [stderr] | [INFO] [stderr] 320 | Plist::Integer(*from as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/serde/ser.rs:61:28 [INFO] [stderr] | [INFO] [stderr] 61 | self.serialize_i64(v as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/serde/ser.rs:65:28 [INFO] [stderr] | [INFO] [stderr] 65 | self.serialize_i64(v as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/serde/ser.rs:69:28 [INFO] [stderr] | [INFO] [stderr] 69 | self.serialize_i64(v as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serde/ser.rs:77:28 [INFO] [stderr] | [INFO] [stderr] 77 | self.serialize_u64(v as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serde/ser.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | self.serialize_u64(v as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serde/ser.rs:85:28 [INFO] [stderr] | [INFO] [stderr] 85 | self.serialize_u64(v as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/serde/ser.rs:93:28 [INFO] [stderr] | [INFO] [stderr] 93 | self.serialize_f64(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/serde_tests/mod.rs:139:33 [INFO] [stderr] | [INFO] [stderr] 139 | vec![1.0, 2.0, 3.14159, 0.000000001, 1.27e31], [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.000_000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/serde_tests/mod.rs:154:19 [INFO] [stderr] | [INFO] [stderr] 154 | RealValue(0.000000001), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.000_000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/serde_tests/mod.rs:139:24 [INFO] [stderr] | [INFO] [stderr] 139 | vec![1.0, 2.0, 3.14159, 0.000000001, 1.27e31], [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/serde_tests/mod.rs:153:19 [INFO] [stderr] | [INFO] [stderr] 153 | RealValue(3.14159), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `plist`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0511f823664d251851b898d6a534c087f61e945faa52660a89ee2a2b9ef67c73"` [INFO] running `"docker" "rm" "-f" "0511f823664d251851b898d6a534c087f61e945faa52660a89ee2a2b9ef67c73"` [INFO] [stdout] 0511f823664d251851b898d6a534c087f61e945faa52660a89ee2a2b9ef67c73