[INFO] crate plexus 0.0.10 is already in cache [INFO] extracting crate plexus 0.0.10 into work/ex/clippy-test-run/sources/stable/reg/plexus/0.0.10 [INFO] extracting crate plexus 0.0.10 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/plexus/0.0.10 [INFO] validating manifest of plexus-0.0.10 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of plexus-0.0.10 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing plexus-0.0.10 [INFO] removed 0 missing examples [INFO] finished frobbing plexus-0.0.10 [INFO] frobbed toml for plexus-0.0.10 written to work/ex/clippy-test-run/sources/stable/reg/plexus/0.0.10/Cargo.toml [INFO] started frobbing plexus-0.0.10 [INFO] removed 0 missing examples [INFO] finished frobbing plexus-0.0.10 [INFO] frobbed toml for plexus-0.0.10 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/plexus/0.0.10/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting plexus-0.0.10 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/plexus/0.0.10:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 53d9469e64ca9b2fb1fcf9f3ae9f56a7d9db4ec6937c84a61caa2b4bba99d8a0 [INFO] running `"docker" "start" "-a" "53d9469e64ca9b2fb1fcf9f3ae9f56a7d9db4ec6937c84a61caa2b4bba99d8a0"` [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Compiling glutin v0.10.1 [INFO] [stderr] Checking decorum v0.0.11 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Compiling gfx_gl v0.4.0 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking gfx_device_gl v0.14.6 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking gfx_window_glutin v0.18.0 [INFO] [stderr] Checking plexus v0.0.10 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/primitive/cube.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/primitive/decompose.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | #[allow(type_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/primitive/decompose.rs:415:13 [INFO] [stderr] | [INFO] [stderr] 415 | #[allow(type_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/primitive/cube.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/primitive/decompose.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | #[allow(type_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/primitive/decompose.rs:415:13 [INFO] [stderr] | [INFO] [stderr] 415 | #[allow(type_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/primitive/decompose.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | #[allow(type_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/primitive/decompose.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | #[allow(type_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::root_cause': please use the 'find_root_cause()' method instead [INFO] [stderr] --> src/graph/mesh.rs:705:14 [INFO] [stderr] | [INFO] [stderr] 705 | .root_cause() [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::root_cause': please use the 'find_root_cause()' method instead [INFO] [stderr] --> src/graph/mesh.rs:735:14 [INFO] [stderr] | [INFO] [stderr] 735 | .root_cause() [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::root_cause': please use the 'find_root_cause()' method instead [INFO] [stderr] --> src/graph/mesh.rs:776:14 [INFO] [stderr] | [INFO] [stderr] 776 | .root_cause() [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `vertices` [INFO] [stderr] --> src/graph/mutation/region.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn vertices(&self) -> &[VertexKey] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bind` [INFO] [stderr] --> src/graph/view/edge.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub(in graph) fn bind(self, storage: N) -> EdgeView<>::Output, G> [INFO] [stderr] 45 | | where [INFO] [stderr] 46 | | T: Topological, [INFO] [stderr] 47 | | M: Bind, [INFO] [stderr] ... | [INFO] [stderr] 53 | | EdgeView::from_keyed_storage_unchecked(key, origin.bind(storage)) [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `interior_reborrow_mut` [INFO] [stderr] --> src/graph/view/edge.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | fn interior_reborrow_mut(&mut self) -> EdgeView<&mut M::Target, G> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bind` [INFO] [stderr] --> src/graph/view/face.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub(in graph) fn bind(self, storage: N) -> FaceView<>::Output, G> [INFO] [stderr] 45 | | where [INFO] [stderr] 46 | | T: Topological, [INFO] [stderr] 47 | | M: Bind, [INFO] [stderr] ... | [INFO] [stderr] 53 | | FaceView::from_keyed_storage_unchecked(key, origin.bind(storage)) [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bind` [INFO] [stderr] --> src/graph/view/vertex.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub(in graph) fn bind(self, storage: N) -> VertexView<>::Output, G> [INFO] [stderr] 37 | | where [INFO] [stderr] 38 | | T: Topological, [INFO] [stderr] 39 | | M: Bind, [INFO] [stderr] ... | [INFO] [stderr] 45 | | VertexView::from_keyed_storage_unchecked(key, origin.bind(storage)) [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/graph/mesh.rs:482:44 [INFO] [stderr] | [INFO] [stderr] 482 | .bind(vertices.map_values_into(|vertex| Vertex::::from_interior_geometry(vertex))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Vertex::::from_interior_geometry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/graph/mesh.rs:483:41 [INFO] [stderr] | [INFO] [stderr] 483 | .bind(edges.map_values_into(|edge| Edge::::from_interior_geometry(edge))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Edge::::from_interior_geometry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/graph/mesh.rs:484:41 [INFO] [stderr] | [INFO] [stderr] 484 | .bind(faces.map_values_into(|face| Face::::from_interior_geometry(face))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Face::::from_interior_geometry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/graph/mutation/edge.rs:308:14 [INFO] [stderr] | [INFO] [stderr] 308 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/graph/mutation/region.rs:64:41 [INFO] [stderr] | [INFO] [stderr] 64 | if vertices.iter().any(|vertex| { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 65 | | !AsStorage::>::as_storage(storage.reborrow()).contains_key(vertex) [INFO] [stderr] 66 | | }) { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: method is never used: `vertices` [INFO] [stderr] --> src/graph/mutation/region.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn vertices(&self) -> &[VertexKey] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bind` [INFO] [stderr] --> src/graph/view/edge.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub(in graph) fn bind(self, storage: N) -> EdgeView<>::Output, G> [INFO] [stderr] 45 | | where [INFO] [stderr] 46 | | T: Topological, [INFO] [stderr] 47 | | M: Bind, [INFO] [stderr] ... | [INFO] [stderr] 53 | | EdgeView::from_keyed_storage_unchecked(key, origin.bind(storage)) [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `interior_reborrow_mut` [INFO] [stderr] --> src/graph/view/edge.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | fn interior_reborrow_mut(&mut self) -> EdgeView<&mut M::Target, G> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bind` [INFO] [stderr] --> src/graph/view/face.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub(in graph) fn bind(self, storage: N) -> FaceView<>::Output, G> [INFO] [stderr] 45 | | where [INFO] [stderr] 46 | | T: Topological, [INFO] [stderr] 47 | | M: Bind, [INFO] [stderr] ... | [INFO] [stderr] 53 | | FaceView::from_keyed_storage_unchecked(key, origin.bind(storage)) [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bind` [INFO] [stderr] --> src/graph/view/vertex.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub(in graph) fn bind(self, storage: N) -> VertexView<>::Output, G> [INFO] [stderr] 37 | | where [INFO] [stderr] 38 | | T: Topological, [INFO] [stderr] 39 | | M: Bind, [INFO] [stderr] ... | [INFO] [stderr] 45 | | VertexView::from_keyed_storage_unchecked(key, origin.bind(storage)) [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive/cube.rs:68:32 [INFO] [stderr] | [INFO] [stderr] 68 | fn polygon_with_plane_from(&self, _: &(), index: usize) -> Quad { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive/cube.rs:68:42 [INFO] [stderr] | [INFO] [stderr] 68 | fn polygon_with_plane_from(&self, _: &(), index: usize) -> Quad { [INFO] [stderr] | ^^^ help: consider passing by value instead: `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/graph/mesh.rs:482:44 [INFO] [stderr] | [INFO] [stderr] 482 | .bind(vertices.map_values_into(|vertex| Vertex::::from_interior_geometry(vertex))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Vertex::::from_interior_geometry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/graph/mesh.rs:483:41 [INFO] [stderr] | [INFO] [stderr] 483 | .bind(edges.map_values_into(|edge| Edge::::from_interior_geometry(edge))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Edge::::from_interior_geometry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/graph/mesh.rs:484:41 [INFO] [stderr] | [INFO] [stderr] 484 | .bind(faces.map_values_into(|face| Face::::from_interior_geometry(face))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Face::::from_interior_geometry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/mesh.rs:764:35 [INFO] [stderr] | [INFO] [stderr] 764 | .map(|vertex| vertex.geometry.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `vertex.geometry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/graph/mesh.rs:804:21 [INFO] [stderr] | [INFO] [stderr] 804 | let value = 3.14; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/graph/mesh.rs:812:13 [INFO] [stderr] | [INFO] [stderr] 812 | assert_eq!(value, face.geometry); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/graph/mesh.rs:812:13 [INFO] [stderr] | [INFO] [stderr] 812 | assert_eq!(value, face.geometry); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/graph/mutation/edge.rs:308:14 [INFO] [stderr] | [INFO] [stderr] 308 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: Could not compile `plexus`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/graph/mutation/region.rs:64:41 [INFO] [stderr] | [INFO] [stderr] 64 | if vertices.iter().any(|vertex| { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 65 | | !AsStorage::>::as_storage(storage.reborrow()).contains_key(vertex) [INFO] [stderr] 66 | | }) { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive/cube.rs:68:32 [INFO] [stderr] | [INFO] [stderr] 68 | fn polygon_with_plane_from(&self, _: &(), index: usize) -> Quad { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/primitive/cube.rs:68:42 [INFO] [stderr] | [INFO] [stderr] 68 | fn polygon_with_plane_from(&self, _: &(), index: usize) -> Quad { [INFO] [stderr] | ^^^ help: consider passing by value instead: `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `plexus`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "53d9469e64ca9b2fb1fcf9f3ae9f56a7d9db4ec6937c84a61caa2b4bba99d8a0"` [INFO] running `"docker" "rm" "-f" "53d9469e64ca9b2fb1fcf9f3ae9f56a7d9db4ec6937c84a61caa2b4bba99d8a0"` [INFO] [stdout] 53d9469e64ca9b2fb1fcf9f3ae9f56a7d9db4ec6937c84a61caa2b4bba99d8a0