[INFO] crate please 0.2.1 is already in cache [INFO] extracting crate please 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/please/0.2.1 [INFO] extracting crate please 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/please/0.2.1 [INFO] validating manifest of please-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of please-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing please-0.2.1 [INFO] finished frobbing please-0.2.1 [INFO] frobbed toml for please-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/please/0.2.1/Cargo.toml [INFO] started frobbing please-0.2.1 [INFO] finished frobbing please-0.2.1 [INFO] frobbed toml for please-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/please/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting please-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/please/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2e00f53cdef11e59e786328e916b28917714737efbf2f9f715e74e662d0e220e [INFO] running `"docker" "start" "-a" "2e00f53cdef11e59e786328e916b28917714737efbf2f9f715e74e662d0e220e"` [INFO] [stderr] Compiling diesel_derives v1.4.0 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Checking diesel v1.4.1 [INFO] [stderr] Checking please v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | / match self { [INFO] [stderr] 178 | | &PleaseError::Provider(ref e) => Display::fmt(e, f), [INFO] [stderr] 179 | | &PleaseError::Query(ref e) => Display::fmt(e, f), [INFO] [stderr] 180 | | &PleaseError::Expired => Display::fmt(self.description(), f), [INFO] [stderr] 181 | | &PleaseError::__Nonexhaustive => unreachable!(), [INFO] [stderr] 182 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 177 | match *self { [INFO] [stderr] 178 | PleaseError::Provider(ref e) => Display::fmt(e, f), [INFO] [stderr] 179 | PleaseError::Query(ref e) => Display::fmt(e, f), [INFO] [stderr] 180 | PleaseError::Expired => Display::fmt(self.description(), f), [INFO] [stderr] 181 | PleaseError::__Nonexhaustive => unreachable!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | / match self { [INFO] [stderr] 189 | | &PleaseError::Provider(ref e) => e.description(), [INFO] [stderr] 190 | | &PleaseError::Query(ref e) => e.description(), [INFO] [stderr] 191 | | &PleaseError::Expired => "The `please` handle has expired and can no longer be used", [INFO] [stderr] 192 | | &PleaseError::__Nonexhaustive => unreachable!(), [INFO] [stderr] 193 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 188 | match *self { [INFO] [stderr] 189 | PleaseError::Provider(ref e) => e.description(), [INFO] [stderr] 190 | PleaseError::Query(ref e) => e.description(), [INFO] [stderr] 191 | PleaseError::Expired => "The `please` handle has expired and can no longer be used", [INFO] [stderr] 192 | PleaseError::__Nonexhaustive => unreachable!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | / match self { [INFO] [stderr] 197 | | &PleaseError::Provider(ref e) => Some(e), [INFO] [stderr] 198 | | &PleaseError::Query(ref e) => Some(e), [INFO] [stderr] 199 | | &PleaseError::Expired => None, [INFO] [stderr] 200 | | &PleaseError::__Nonexhaustive => unreachable!(), [INFO] [stderr] 201 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 196 | match *self { [INFO] [stderr] 197 | PleaseError::Provider(ref e) => Some(e), [INFO] [stderr] 198 | PleaseError::Query(ref e) => Some(e), [INFO] [stderr] 199 | PleaseError::Expired => None, [INFO] [stderr] 200 | PleaseError::__Nonexhaustive => unreachable!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | / match self { [INFO] [stderr] 178 | | &PleaseError::Provider(ref e) => Display::fmt(e, f), [INFO] [stderr] 179 | | &PleaseError::Query(ref e) => Display::fmt(e, f), [INFO] [stderr] 180 | | &PleaseError::Expired => Display::fmt(self.description(), f), [INFO] [stderr] 181 | | &PleaseError::__Nonexhaustive => unreachable!(), [INFO] [stderr] 182 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 177 | match *self { [INFO] [stderr] 178 | PleaseError::Provider(ref e) => Display::fmt(e, f), [INFO] [stderr] 179 | PleaseError::Query(ref e) => Display::fmt(e, f), [INFO] [stderr] 180 | PleaseError::Expired => Display::fmt(self.description(), f), [INFO] [stderr] 181 | PleaseError::__Nonexhaustive => unreachable!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | / match self { [INFO] [stderr] 189 | | &PleaseError::Provider(ref e) => e.description(), [INFO] [stderr] 190 | | &PleaseError::Query(ref e) => e.description(), [INFO] [stderr] 191 | | &PleaseError::Expired => "The `please` handle has expired and can no longer be used", [INFO] [stderr] 192 | | &PleaseError::__Nonexhaustive => unreachable!(), [INFO] [stderr] 193 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 188 | match *self { [INFO] [stderr] 189 | PleaseError::Provider(ref e) => e.description(), [INFO] [stderr] 190 | PleaseError::Query(ref e) => e.description(), [INFO] [stderr] 191 | PleaseError::Expired => "The `please` handle has expired and can no longer be used", [INFO] [stderr] 192 | PleaseError::__Nonexhaustive => unreachable!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | / match self { [INFO] [stderr] 197 | | &PleaseError::Provider(ref e) => Some(e), [INFO] [stderr] 198 | | &PleaseError::Query(ref e) => Some(e), [INFO] [stderr] 199 | | &PleaseError::Expired => None, [INFO] [stderr] 200 | | &PleaseError::__Nonexhaustive => unreachable!(), [INFO] [stderr] 201 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 196 | match *self { [INFO] [stderr] 197 | PleaseError::Provider(ref e) => Some(e), [INFO] [stderr] 198 | PleaseError::Query(ref e) => Some(e), [INFO] [stderr] 199 | PleaseError::Expired => None, [INFO] [stderr] 200 | PleaseError::__Nonexhaustive => unreachable!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 06s [INFO] running `"docker" "inspect" "2e00f53cdef11e59e786328e916b28917714737efbf2f9f715e74e662d0e220e"` [INFO] running `"docker" "rm" "-f" "2e00f53cdef11e59e786328e916b28917714737efbf2f9f715e74e662d0e220e"` [INFO] [stdout] 2e00f53cdef11e59e786328e916b28917714737efbf2f9f715e74e662d0e220e