[INFO] crate playlist-duration 0.1.3 is already in cache [INFO] extracting crate playlist-duration 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/playlist-duration/0.1.3 [INFO] extracting crate playlist-duration 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/playlist-duration/0.1.3 [INFO] validating manifest of playlist-duration-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of playlist-duration-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing playlist-duration-0.1.3 [INFO] finished frobbing playlist-duration-0.1.3 [INFO] frobbed toml for playlist-duration-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/playlist-duration/0.1.3/Cargo.toml [INFO] started frobbing playlist-duration-0.1.3 [INFO] finished frobbing playlist-duration-0.1.3 [INFO] frobbed toml for playlist-duration-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/playlist-duration/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting playlist-duration-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/playlist-duration/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 462043e1dbd995236afb4037da0e75a3ab9a9e43a5b9f7ce232365cd2edee7f0 [INFO] running `"docker" "start" "-a" "462043e1dbd995236afb4037da0e75a3ab9a9e43a5b9f7ce232365cd2edee7f0"` [INFO] [stderr] Checking ogg v0.5.1 [INFO] [stderr] Checking metaflac v0.1.8 [INFO] [stderr] Checking mp3-duration v0.1.4 [INFO] [stderr] Checking ogg_metadata v0.4.1 [INFO] [stderr] Checking playlist-duration v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | return Some(Duration::from_secs(nb_sec)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Duration::from_secs(nb_sec))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | return Some(Duration::from_secs(nb_sec)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Duration::from_secs(nb_sec))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:46:8 [INFO] [stderr] | [INFO] [stderr] 46 | if stream_info.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stream_info.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:51:44 [INFO] [stderr] | [INFO] [stderr] 51 | let nb_sec = s.total_samples / s.sample_rate as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(s.sample_rate)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:132:18 [INFO] [stderr] | [INFO] [stderr] 132 | .map(|e| String::from(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:46:8 [INFO] [stderr] | [INFO] [stderr] 46 | if stream_info.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stream_info.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:51:44 [INFO] [stderr] | [INFO] [stderr] 51 | let nb_sec = s.total_samples / s.sample_rate as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(s.sample_rate)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:132:18 [INFO] [stderr] | [INFO] [stderr] 132 | .map(|e| String::from(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.31s [INFO] running `"docker" "inspect" "462043e1dbd995236afb4037da0e75a3ab9a9e43a5b9f7ce232365cd2edee7f0"` [INFO] running `"docker" "rm" "-f" "462043e1dbd995236afb4037da0e75a3ab9a9e43a5b9f7ce232365cd2edee7f0"` [INFO] [stdout] 462043e1dbd995236afb4037da0e75a3ab9a9e43a5b9f7ce232365cd2edee7f0