[INFO] crate playlist-decoder 0.7.0 is already in cache [INFO] extracting crate playlist-decoder 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/playlist-decoder/0.7.0 [INFO] extracting crate playlist-decoder 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/playlist-decoder/0.7.0 [INFO] validating manifest of playlist-decoder-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of playlist-decoder-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing playlist-decoder-0.7.0 [INFO] finished frobbing playlist-decoder-0.7.0 [INFO] frobbed toml for playlist-decoder-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/playlist-decoder/0.7.0/Cargo.toml [INFO] started frobbing playlist-decoder-0.7.0 [INFO] finished frobbing playlist-decoder-0.7.0 [INFO] frobbed toml for playlist-decoder-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/playlist-decoder/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting playlist-decoder-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/playlist-decoder/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 01698e1e6096c25c59b366a1869665cdedbfa9e07be0b8e9055d06e9955f4219 [INFO] running `"docker" "start" "-a" "01698e1e6096c25c59b366a1869665cdedbfa9e07be0b8e9055d06e9955f4219"` [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking quick-xml v0.12.4 [INFO] [stderr] Checking playlist-decoder v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/pls.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 23 | | if found_pls { [INFO] [stderr] 24 | | if line.starts_with("File") { [INFO] [stderr] 25 | | let idend = line.find('='); [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 22 | } else if found_pls { [INFO] [stderr] 23 | if line.starts_with("File") { [INFO] [stderr] 24 | let idend = line.find('='); [INFO] [stderr] 25 | if let Some(idend) = idend { [INFO] [stderr] 26 | let (key, value) = line.split_at(idend); [INFO] [stderr] 27 | let id: Result = key[4..idend].parse(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/asx.rs:32:29 [INFO] [stderr] | [INFO] [stderr] 32 | / if path == "asx/entry/ref" { [INFO] [stderr] 33 | | if key == "href" { [INFO] [stderr] 34 | | item.url = value; [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 32 | if path == "asx/entry/ref" && key == "href" { [INFO] [stderr] 33 | item.url = value; [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/asx.rs:53:29 [INFO] [stderr] | [INFO] [stderr] 53 | / if path == "asx/entry/ref" { [INFO] [stderr] 54 | | if key == "href" { [INFO] [stderr] 55 | | item.url = value; [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 53 | if path == "asx/entry/ref" && key == "href" { [INFO] [stderr] 54 | item.url = value; [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/xspf.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | / if path == "asx/entry/ref" { [INFO] [stderr] 35 | | if key == "href" { [INFO] [stderr] 36 | | item.url = value; [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 34 | if path == "asx/entry/ref" && key == "href" { [INFO] [stderr] 35 | item.url = value; [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/xspf.rs:55:29 [INFO] [stderr] | [INFO] [stderr] 55 | / if path == "asx/entry/ref" { [INFO] [stderr] 56 | | if key == "href" { [INFO] [stderr] 57 | | item.url = value; [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 55 | if path == "asx/entry/ref" && key == "href" { [INFO] [stderr] 56 | item.url = value; [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/pls.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/m3u.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/asx.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | / match a { [INFO] [stderr] 29 | | Ok(a) => { [INFO] [stderr] 30 | | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 31 | | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] ... | [INFO] [stderr] 38 | | Err(_) => {} [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | if let Ok(a) = a { [INFO] [stderr] 29 | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 30 | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] 31 | if path == "asx/entry/ref" { [INFO] [stderr] 32 | if key == "href" { [INFO] [stderr] 33 | item.url = value; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/asx.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | / match a { [INFO] [stderr] 50 | | Ok(a) => { [INFO] [stderr] 51 | | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 52 | | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] ... | [INFO] [stderr] 59 | | Err(_) => {} [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | if let Ok(a) = a { [INFO] [stderr] 50 | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 51 | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] 52 | if path == "asx/entry/ref" { [INFO] [stderr] 53 | if key == "href" { [INFO] [stderr] 54 | item.url = value; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/asx.rs:75:65 [INFO] [stderr] | [INFO] [stderr] 75 | item.title = e.unescape_and_decode(&reader).unwrap_or(String::from("")).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/xspf.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | / match a { [INFO] [stderr] 31 | | Ok(a) => { [INFO] [stderr] 32 | | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 33 | | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] ... | [INFO] [stderr] 40 | | Err(_) => {} [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | if let Ok(a) = a { [INFO] [stderr] 31 | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 32 | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] 33 | if path == "asx/entry/ref" { [INFO] [stderr] 34 | if key == "href" { [INFO] [stderr] 35 | item.url = value; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/xspf.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | / match a { [INFO] [stderr] 52 | | Ok(a) => { [INFO] [stderr] 53 | | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 54 | | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] ... | [INFO] [stderr] 61 | | Err(_) => {} [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | if let Ok(a) = a { [INFO] [stderr] 52 | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 53 | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] 54 | if path == "asx/entry/ref" { [INFO] [stderr] 55 | if key == "href" { [INFO] [stderr] 56 | item.url = value; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/xspf.rs:78:65 [INFO] [stderr] | [INFO] [stderr] 78 | item.title = e.unescape_and_decode(&reader).unwrap_or(String::from("")).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/pls.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 23 | | if found_pls { [INFO] [stderr] 24 | | if line.starts_with("File") { [INFO] [stderr] 25 | | let idend = line.find('='); [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 22 | } else if found_pls { [INFO] [stderr] 23 | if line.starts_with("File") { [INFO] [stderr] 24 | let idend = line.find('='); [INFO] [stderr] 25 | if let Some(idend) = idend { [INFO] [stderr] 26 | let (key, value) = line.split_at(idend); [INFO] [stderr] 27 | let id: Result = key[4..idend].parse(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/asx.rs:32:29 [INFO] [stderr] | [INFO] [stderr] 32 | / if path == "asx/entry/ref" { [INFO] [stderr] 33 | | if key == "href" { [INFO] [stderr] 34 | | item.url = value; [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 32 | if path == "asx/entry/ref" && key == "href" { [INFO] [stderr] 33 | item.url = value; [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/asx.rs:53:29 [INFO] [stderr] | [INFO] [stderr] 53 | / if path == "asx/entry/ref" { [INFO] [stderr] 54 | | if key == "href" { [INFO] [stderr] 55 | | item.url = value; [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 53 | if path == "asx/entry/ref" && key == "href" { [INFO] [stderr] 54 | item.url = value; [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/xspf.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | / if path == "asx/entry/ref" { [INFO] [stderr] 35 | | if key == "href" { [INFO] [stderr] 36 | | item.url = value; [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 34 | if path == "asx/entry/ref" && key == "href" { [INFO] [stderr] 35 | item.url = value; [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/xspf.rs:55:29 [INFO] [stderr] | [INFO] [stderr] 55 | / if path == "asx/entry/ref" { [INFO] [stderr] 56 | | if key == "href" { [INFO] [stderr] 57 | | item.url = value; [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 55 | if path == "asx/entry/ref" && key == "href" { [INFO] [stderr] 56 | item.url = value; [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/pls.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/m3u.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/asx.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | / match a { [INFO] [stderr] 29 | | Ok(a) => { [INFO] [stderr] 30 | | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 31 | | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] ... | [INFO] [stderr] 38 | | Err(_) => {} [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | if let Ok(a) = a { [INFO] [stderr] 29 | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 30 | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] 31 | if path == "asx/entry/ref" { [INFO] [stderr] 32 | if key == "href" { [INFO] [stderr] 33 | item.url = value; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/asx.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | / match a { [INFO] [stderr] 50 | | Ok(a) => { [INFO] [stderr] 51 | | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 52 | | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] ... | [INFO] [stderr] 59 | | Err(_) => {} [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | if let Ok(a) = a { [INFO] [stderr] 50 | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 51 | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] 52 | if path == "asx/entry/ref" { [INFO] [stderr] 53 | if key == "href" { [INFO] [stderr] 54 | item.url = value; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/asx.rs:75:65 [INFO] [stderr] | [INFO] [stderr] 75 | item.title = e.unescape_and_decode(&reader).unwrap_or(String::from("")).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/xspf.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | / match a { [INFO] [stderr] 31 | | Ok(a) => { [INFO] [stderr] 32 | | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 33 | | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] ... | [INFO] [stderr] 40 | | Err(_) => {} [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | if let Ok(a) = a { [INFO] [stderr] 31 | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 32 | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] 33 | if path == "asx/entry/ref" { [INFO] [stderr] 34 | if key == "href" { [INFO] [stderr] 35 | item.url = value; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/xspf.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | / match a { [INFO] [stderr] 52 | | Ok(a) => { [INFO] [stderr] 53 | | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 54 | | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] ... | [INFO] [stderr] 61 | | Err(_) => {} [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | if let Ok(a) = a { [INFO] [stderr] 52 | let key = reader.decode(a.key).to_string().to_lowercase(); [INFO] [stderr] 53 | let value = reader.decode(&a.value).to_string(); [INFO] [stderr] 54 | if path == "asx/entry/ref" { [INFO] [stderr] 55 | if key == "href" { [INFO] [stderr] 56 | item.url = value; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/xspf.rs:78:65 [INFO] [stderr] | [INFO] [stderr] 78 | item.title = e.unescape_and_decode(&reader).unwrap_or(String::from("")).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.48s [INFO] running `"docker" "inspect" "01698e1e6096c25c59b366a1869665cdedbfa9e07be0b8e9055d06e9955f4219"` [INFO] running `"docker" "rm" "-f" "01698e1e6096c25c59b366a1869665cdedbfa9e07be0b8e9055d06e9955f4219"` [INFO] [stdout] 01698e1e6096c25c59b366a1869665cdedbfa9e07be0b8e9055d06e9955f4219