[INFO] crate play 0.5.3 is already in cache [INFO] extracting crate play 0.5.3 into work/ex/clippy-test-run/sources/stable/reg/play/0.5.3 [INFO] extracting crate play 0.5.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/play/0.5.3 [INFO] validating manifest of play-0.5.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of play-0.5.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing play-0.5.3 [INFO] finished frobbing play-0.5.3 [INFO] frobbed toml for play-0.5.3 written to work/ex/clippy-test-run/sources/stable/reg/play/0.5.3/Cargo.toml [INFO] started frobbing play-0.5.3 [INFO] finished frobbing play-0.5.3 [INFO] frobbed toml for play-0.5.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/play/0.5.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting play-0.5.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/play/0.5.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd8a0eb4c147967838bbf9b50c13c6f49edd0140acca66b6822d80b135937a1d [INFO] running `"docker" "start" "-a" "fd8a0eb4c147967838bbf9b50c13c6f49edd0140acca66b6822d80b135937a1d"` [INFO] [stderr] Checking mpg123-sys v0.6.0 [INFO] [stderr] Checking out123-sys v0.5.0 [INFO] [stderr] Checking play v0.5.3 (/opt/crater/workdir) [INFO] [stderr] warning: type annotations needed [INFO] [stderr] --> src/lib.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | if !buffer.is_null() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 66 | cleanup_and_raise!("failed to instantiate mpg123"); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(tyvar_behind_raw_pointer)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #46906 [INFO] [stderr] [INFO] [stderr] warning: type annotations needed [INFO] [stderr] --> src/lib.rs:48:35 [INFO] [stderr] | [INFO] [stderr] 48 | if !out123_handle.is_null() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 66 | cleanup_and_raise!("failed to instantiate mpg123"); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #46906 [INFO] [stderr] [INFO] [stderr] warning: type annotations needed [INFO] [stderr] --> src/lib.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | if !buffer.is_null() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 70 | cleanup_and_raise!("failed to open the input"); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #46906 [INFO] [stderr] [INFO] [stderr] warning: type annotations needed [INFO] [stderr] --> src/lib.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | if !buffer.is_null() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 77 | cleanup_and_raise!("failed to get the format"); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #46906 [INFO] [stderr] [INFO] [stderr] warning: type annotations needed [INFO] [stderr] --> src/lib.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | if !buffer.is_null() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 81 | cleanup_and_raise!("failed to instantiate out123"); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #46906 [INFO] [stderr] [INFO] [stderr] warning: type annotations needed [INFO] [stderr] --> src/lib.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | if !buffer.is_null() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 85 | cleanup_and_raise!("failed to open the output"); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #46906 [INFO] [stderr] [INFO] [stderr] warning: type annotations needed [INFO] [stderr] --> src/lib.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | if !buffer.is_null() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 89 | cleanup_and_raise!("failed to start the output"); [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #46906 [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/lib.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn play>(path: T) -> Result<()> { [INFO] [stderr] 24 | | let path = path.as_ref(); [INFO] [stderr] 25 | | if !path.exists() { [INFO] [stderr] 26 | | raise!("the file does not exist"); [INFO] [stderr] ... | [INFO] [stderr] 108 | | Ok(()) [INFO] [stderr] 109 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: type annotations needed [INFO] [stderr] --> src/lib.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | if !buffer.is_null() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 66 | cleanup_and_raise!("failed to instantiate mpg123"); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(tyvar_behind_raw_pointer)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #46906 [INFO] [stderr] [INFO] [stderr] warning: type annotations needed [INFO] [stderr] --> src/lib.rs:48:35 [INFO] [stderr] | [INFO] [stderr] 48 | if !out123_handle.is_null() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 66 | cleanup_and_raise!("failed to instantiate mpg123"); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #46906 [INFO] [stderr] [INFO] [stderr] warning: type annotations needed [INFO] [stderr] --> src/lib.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | if !buffer.is_null() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 70 | cleanup_and_raise!("failed to open the input"); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #46906 [INFO] [stderr] [INFO] [stderr] warning: type annotations needed [INFO] [stderr] --> src/lib.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | if !buffer.is_null() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 77 | cleanup_and_raise!("failed to get the format"); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #46906 [INFO] [stderr] [INFO] [stderr] warning: type annotations needed [INFO] [stderr] --> src/lib.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | if !buffer.is_null() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 81 | cleanup_and_raise!("failed to instantiate out123"); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #46906 [INFO] [stderr] [INFO] [stderr] warning: type annotations needed [INFO] [stderr] --> src/lib.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | if !buffer.is_null() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 85 | cleanup_and_raise!("failed to open the output"); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #46906 [INFO] [stderr] [INFO] [stderr] warning: type annotations needed [INFO] [stderr] --> src/lib.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | if !buffer.is_null() { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 89 | cleanup_and_raise!("failed to start the output"); [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in the 2018 edition! [INFO] [stderr] = note: for more information, see issue #46906 [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/lib.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn play>(path: T) -> Result<()> { [INFO] [stderr] 24 | | let path = path.as_ref(); [INFO] [stderr] 25 | | if !path.exists() { [INFO] [stderr] 26 | | raise!("the file does not exist"); [INFO] [stderr] ... | [INFO] [stderr] 108 | | Ok(()) [INFO] [stderr] 109 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.08s [INFO] running `"docker" "inspect" "fd8a0eb4c147967838bbf9b50c13c6f49edd0140acca66b6822d80b135937a1d"` [INFO] running `"docker" "rm" "-f" "fd8a0eb4c147967838bbf9b50c13c6f49edd0140acca66b6822d80b135937a1d"` [INFO] [stdout] fd8a0eb4c147967838bbf9b50c13c6f49edd0140acca66b6822d80b135937a1d