[INFO] crate planetkit 0.0.1 is already in cache [INFO] extracting crate planetkit 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/planetkit/0.0.1 [INFO] extracting crate planetkit 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/planetkit/0.0.1 [INFO] validating manifest of planetkit-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of planetkit-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing planetkit-0.0.1 [INFO] finished frobbing planetkit-0.0.1 [INFO] frobbed toml for planetkit-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/planetkit/0.0.1/Cargo.toml [INFO] started frobbing planetkit-0.0.1 [INFO] finished frobbing planetkit-0.0.1 [INFO] frobbed toml for planetkit-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/planetkit/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting planetkit-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/planetkit/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bbaf7dc3b1b85d70b50cfd0bdb63ab25ab98df1072eb67802f190399aaa7c3b5 [INFO] running `"docker" "start" "-a" "bbaf7dc3b1b85d70b50cfd0bdb63ab25ab98df1072eb67802f190399aaa7c3b5"` [INFO] [stderr] Checking froggy v0.4.4 [INFO] [stderr] Checking arrayvec v0.4.10 [INFO] [stderr] Checking quaternion v0.3.1 [INFO] [stderr] Compiling planetkit v0.0.1 (/opt/crater/workdir) [INFO] [stderr] Compiling shred-derive v0.3.0 [INFO] [stderr] Checking noise v0.4.1 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking nalgebra v0.13.1 [INFO] [stderr] Checking piston3d-cam v0.3.0 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking camera_controllers v0.23.0 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking piston2d-graphics v0.24.0 [INFO] [stderr] Checking piston2d-graphics v0.23.0 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.43.0 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking hibitset v0.3.2 [INFO] [stderr] Checking shred v0.5.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking specs v0.10.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking piston2d-opengl_graphics v0.49.0 [INFO] [stderr] Checking piston-gfx_texture v0.30.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.47.0 [INFO] [stderr] Checking piston_window v0.74.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid/root.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | Root { index: index } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid/grid_point2.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid/grid_point2.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid/grid_point2.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid/grid_point3.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | z: z, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid/root.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | Root { index: index } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid/grid_point2.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid/grid_point2.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid/grid_point2.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid/neighbors.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | resolution: resolution, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resolution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid/dir.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | Dir { index: index } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/globe.rs:53:13 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid/grid_point3.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | z: z, [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid/neighbors.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | resolution: resolution, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resolution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid/dir.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | Dir { index: index } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] 53 | spec: spec, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `spec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/globe/icosahedron.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/globe/icosahedron.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/spec.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | floor_radius: floor_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `floor_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/spec.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | ocean_radius: ocean_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ocean_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | cells: cells, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | chunk_resolution: chunk_resolution, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_resolution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/gen.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | spec: spec, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `spec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/gen.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | terrain_noise: terrain_noise, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `terrain_noise` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/gen.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | material: material, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk_view.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk_view.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | globe_entity: globe_entity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `globe_entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk_view_system.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | seconds_between_geometry_creation: seconds_between_geometry_creation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `seconds_between_geometry_creation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/cursor.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | globe: globe, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `globe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/cursor.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/cursor.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | globe: globe, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `globe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/cursor.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk_origin.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | ChunkOrigin { pos: pos } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/iters.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/iters.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | root_resolution: root_resolution, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_resolution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/iters.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | chunk_resolution: chunk_resolution, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_resolution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/globe/iters.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk_shared_points.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/globe/mod.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | let e: Pt3 = Pt3::new( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/globe/mod.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | let f: Pt3 = Pt3::new( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | log: log, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `log` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | world: world, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | projection: projection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `projection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/system.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | pso: pso, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pso` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/system.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | encoder_channel: encoder_channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `encoder_channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/system.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | output_color: output_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/system.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | output_stencil: output_stencil, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_stencil` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/system.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | projection: projection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `projection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/system.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | mesh_repo: mesh_repo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mesh_repo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mesh.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mesh.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mesh_repository.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | default_output_color_buffer: default_output_color_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `default_output_color_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mesh_repository.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | default_output_stencil_buffer: default_output_stencil_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `default_output_stencil_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/proto_mesh.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | vertexes: vertexes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertexes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/proto_mesh.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | indexes: indexes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indexes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/cell_dweller.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/cell_dweller.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/cell_dweller.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | globe_spec: globe_spec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `globe_spec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/cell_dweller.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | globe_entity: globe_entity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `globe_entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/globe.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | spec: spec, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `spec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/globe/icosahedron.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/globe/icosahedron.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/spec.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | floor_radius: floor_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `floor_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/spec.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | ocean_radius: ocean_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ocean_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | cells: cells, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | chunk_resolution: chunk_resolution, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_resolution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/gen.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | spec: spec, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `spec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/gen.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | terrain_noise: terrain_noise, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `terrain_noise` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/gen.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | material: material, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk_view.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk_view.rs:14:13 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/movement_system.rs:34:32 [INFO] [stderr] | [INFO] [stderr] 34 | MovementInputAdapter { sender: sender } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] 14 | globe_entity: globe_entity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `globe_entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk_view_system.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | seconds_between_geometry_creation: seconds_between_geometry_creation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `seconds_between_geometry_creation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/cursor.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | globe: globe, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `globe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/cursor.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/cursor.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | globe: globe, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `globe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/cursor.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk_origin.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | ChunkOrigin { pos: pos } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/iters.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/iters.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | root_resolution: root_resolution, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_resolution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/iters.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | chunk_resolution: chunk_resolution, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_resolution` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/globe/iters.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/globe/chunk_shared_points.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/globe/mod.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | let e: Pt3 = Pt3::new( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/globe/mod.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | let f: Pt3 = Pt3::new( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | log: log, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `log` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | world: world, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | projection: projection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `projection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/system.rs:68:13 [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/movement_system.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | input_receiver: input_receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/movement_system.rs:318:29 [INFO] [stderr] | [INFO] [stderr] 318 | entity_id: entity_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entity_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/mining_system.rs:30:30 [INFO] [stderr] | [INFO] [stderr] 30 | MiningInputAdapter { sender: sender } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] 68 | pso: pso, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pso` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/system.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | encoder_channel: encoder_channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `encoder_channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/system.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | output_color: output_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/system.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | output_stencil: output_stencil, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_stencil` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/system.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | projection: projection, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `projection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/system.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | mesh_repo: mesh_repo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mesh_repo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mesh.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mesh.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mesh_repository.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | default_output_color_buffer: default_output_color_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `default_output_color_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mesh_repository.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | default_output_stencil_buffer: default_output_stencil_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `default_output_stencil_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/proto_mesh.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | vertexes: vertexes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertexes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/proto_mesh.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | indexes: indexes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indexes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/cell_dweller.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/cell_dweller.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/cell_dweller.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | globe_spec: globe_spec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `globe_spec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/cell_dweller.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | globe_entity: globe_entity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `globe_entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/movement_system.rs:34:32 [INFO] [stderr] | [INFO] [stderr] 34 | MovementInputAdapter { sender: sender } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/movement_system.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | input_receiver: input_receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/movement_system.rs:318:29 [INFO] [stderr] | [INFO] [stderr] 318 | entity_id: entity_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entity_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/mining_system.rs:30:30 [INFO] [stderr] | [INFO] [stderr] 30 | MiningInputAdapter { sender: sender } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/mining_system.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | input_receiver: input_receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/mining_system.rs:162:29 [INFO] [stderr] | [INFO] [stderr] 162 | cd_entity_id: cd_entity_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cd_entity_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/physics_system.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | seconds_between_falls: seconds_between_falls, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `seconds_between_falls` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/recv_system.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | recv_rx: recv_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `recv_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/recv_system.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | game_message: game_message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/send_system.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | send_udp_tx: send_udp_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `send_udp_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/new_peer_system.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | new_peer_rx: new_peer_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_peer_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/server.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | remote: remote, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/server.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | recv_system_sender: recv_system_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_system_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/server.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | send_system_new_peer_sender: send_system_new_peer_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `send_system_new_peer_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/server_resource.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | send_udp_tx: send_udp_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `send_udp_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/tcp.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | peer_addr: peer_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/tests.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | world: world, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/tests.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | dispatcher: dispatcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dispatcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spatial.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | local_transform: local_transform, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_transform` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spatial.rs:254:17 [INFO] [stderr] | [INFO] [stderr] 254 | world: world, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spatial.rs:255:17 [INFO] [stderr] | [INFO] [stderr] 255 | sun: sun, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sun` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spatial.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | earth: earth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `earth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spatial.rs:257:17 [INFO] [stderr] | [INFO] [stderr] 257 | moon: moon, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `moon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spatial.rs:258:17 [INFO] [stderr] | [INFO] [stderr] 258 | polar_satellite: polar_satellite, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `polar_satellite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app_builder.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | root_log: root_log, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `root_log` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app_builder.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | world: world, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/integration_tests/random_walk.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | movement_input_sender: movement_input_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `movement_input_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/integration_tests/random_walk.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | world: world, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/integration_tests/random_walk.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | dispatcher: dispatcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dispatcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/integration_tests/random_walk.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | guy_entities: guy_entities, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `guy_entities` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/mining_system.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | input_receiver: input_receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/mining_system.rs:162:29 [INFO] [stderr] | [INFO] [stderr] 162 | cd_entity_id: cd_entity_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cd_entity_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell_dweller/physics_system.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | seconds_between_falls: seconds_between_falls, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `seconds_between_falls` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/recv_system.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | recv_rx: recv_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `recv_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/recv_system.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | game_message: game_message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/send_system.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | send_udp_tx: send_udp_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `send_udp_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/new_peer_system.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | new_peer_rx: new_peer_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_peer_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/server.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | remote: remote, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/server.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | recv_system_sender: recv_system_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_system_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/server.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | send_system_new_peer_sender: send_system_new_peer_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `send_system_new_peer_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/server_resource.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | send_udp_tx: send_udp_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `send_udp_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/tcp.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | peer_addr: peer_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spatial.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | local_transform: local_transform, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_transform` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spatial.rs:254:17 [INFO] [stderr] | [INFO] [stderr] 254 | world: world, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spatial.rs:255:17 [INFO] [stderr] | [INFO] [stderr] 255 | sun: sun, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sun` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spatial.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | earth: earth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `earth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spatial.rs:257:17 [INFO] [stderr] | [INFO] [stderr] 257 | moon: moon, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `moon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spatial.rs:258:17 [INFO] [stderr] | [INFO] [stderr] 258 | polar_satellite: polar_satellite, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `polar_satellite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app_builder.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | root_log: root_log, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `root_log` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app_builder.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | world: world, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/globe/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod globe; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/globe/icosahedron.rs:2:18 [INFO] [stderr] | [INFO] [stderr] 2 | const PHI: f64 = 1.61803398874989484820458683436563811772030917980576286213544862270526046281890244970720720418939113748475; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `1.618_033_988_749_894_848_204_586_834_365_638_117_720_309_179_805_762_862_135_448_622_705_260_462_818_902_449_707_207_204_189_391_137_484_75` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/globe/icosahedron.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | const SF: f64 = 0.525731112119133606025669084847876607285497932243341781528935523241211146403214018371632628831552570956698521400021; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0.525_731_112_119_133_606_025_669_084_847_876_607_285_497_932_243_341_781_528_935_523_241_211_146_403_214_018_371_632_628_831_552_570_956_698_521_400_021` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/globe/spec.rs:48:31 [INFO] [stderr] | [INFO] [stderr] 48 | root_resolution: [8388608, 16777216], [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_608` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/globe/spec.rs:48:40 [INFO] [stderr] | [INFO] [stderr] 48 | root_resolution: [8388608, 16777216], [INFO] [stderr] | ^^^^^^^^ help: consider: `16_777_216` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/globe/mod.rs:43:44 [INFO] [stderr] | [INFO] [stderr] 43 | #[cfg_attr(feature = "cargo-clippy", allow(many_single_char_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cell_dweller/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod cell_dweller; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/net/send_system.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | system [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/net/send_system.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | let system = SendSystem { [INFO] [stderr] | ______________________^ [INFO] [stderr] 45 | | log: parent_log.new(o!()), [INFO] [stderr] 46 | | send_udp_tx: send_udp_tx, [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/net/send_system.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/net/send_system.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/net/new_peer_system.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | system [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/net/new_peer_system.rs:40:22 [INFO] [stderr] | [INFO] [stderr] 40 | let system = NewPeerSystem { [INFO] [stderr] | ______________________^ [INFO] [stderr] 41 | | _log: parent_log.new(o!()), [INFO] [stderr] 42 | | new_peer_rx: new_peer_rx, [INFO] [stderr] 43 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/net/udp.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | rx_f [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/net/udp.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | let rx_f = stream [INFO] [stderr] | ____________________^ [INFO] [stderr] 120 | | .filter(|recv_wire_message| { [INFO] [stderr] 121 | | // TODO: log [INFO] [stderr] 122 | | match recv_wire_message.message { [INFO] [stderr] ... | [INFO] [stderr] 139 | | futures::future::ok(()) [INFO] [stderr] 140 | | }); [INFO] [stderr] | |______________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/net/udp.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/net/tcp.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | f [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/net/tcp.rs:170:17 [INFO] [stderr] | [INFO] [stderr] 170 | let f = socket.incoming().for_each(move |(socket, peer_addr)| { [INFO] [stderr] | _________________^ [INFO] [stderr] 171 | | info!(server_log, "New client connected"; "addr" => format!("{}", peer_addr)); [INFO] [stderr] 172 | | handle_tcp_stream( [INFO] [stderr] 173 | | &cloned_handle, [INFO] [stderr] ... | [INFO] [stderr] 182 | | futures::future::ok(()) [INFO] [stderr] 183 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/net/tcp.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | f [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/net/tcp.rs:223:17 [INFO] [stderr] | [INFO] [stderr] 223 | let f = socket_future.and_then(move |socket| { [INFO] [stderr] | _________________^ [INFO] [stderr] 224 | | info!(client_log, "Connected!"); [INFO] [stderr] 225 | | [INFO] [stderr] 226 | | local_port_tx.send( [INFO] [stderr] ... | [INFO] [stderr] 243 | | futures::future::ok(()) [INFO] [stderr] 244 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/net/tcp.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/globe/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod globe; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/globe/icosahedron.rs:2:18 [INFO] [stderr] | [INFO] [stderr] 2 | const PHI: f64 = 1.61803398874989484820458683436563811772030917980576286213544862270526046281890244970720720418939113748475; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `1.618_033_988_749_894_848_204_586_834_365_638_117_720_309_179_805_762_862_135_448_622_705_260_462_818_902_449_707_207_204_189_391_137_484_75` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/globe/icosahedron.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | const SF: f64 = 0.525731112119133606025669084847876607285497932243341781528935523241211146403214018371632628831552570956698521400021; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0.525_731_112_119_133_606_025_669_084_847_876_607_285_497_932_243_341_781_528_935_523_241_211_146_403_214_018_371_632_628_831_552_570_956_698_521_400_021` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/globe/spec.rs:48:31 [INFO] [stderr] | [INFO] [stderr] 48 | root_resolution: [8388608, 16777216], [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_608` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/globe/spec.rs:48:40 [INFO] [stderr] | [INFO] [stderr] 48 | root_resolution: [8388608, 16777216], [INFO] [stderr] | ^^^^^^^^ help: consider: `16_777_216` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/globe/iters.rs:267:21 [INFO] [stderr] | [INFO] [stderr] 267 | 123456, [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/globe/mod.rs:43:44 [INFO] [stderr] | [INFO] [stderr] 43 | #[cfg_attr(feature = "cargo-clippy", allow(many_single_char_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cell_dweller/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod cell_dweller; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/net/send_system.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | system [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/net/send_system.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | let system = SendSystem { [INFO] [stderr] | ______________________^ [INFO] [stderr] 45 | | log: parent_log.new(o!()), [INFO] [stderr] 46 | | send_udp_tx: send_udp_tx, [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/net/send_system.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/net/send_system.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/net/new_peer_system.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | system [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/net/new_peer_system.rs:40:22 [INFO] [stderr] | [INFO] [stderr] 40 | let system = NewPeerSystem { [INFO] [stderr] | ______________________^ [INFO] [stderr] 41 | | _log: parent_log.new(o!()), [INFO] [stderr] 42 | | new_peer_rx: new_peer_rx, [INFO] [stderr] 43 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/net/udp.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | rx_f [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/net/udp.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | let rx_f = stream [INFO] [stderr] | ____________________^ [INFO] [stderr] 120 | | .filter(|recv_wire_message| { [INFO] [stderr] 121 | | // TODO: log [INFO] [stderr] 122 | | match recv_wire_message.message { [INFO] [stderr] ... | [INFO] [stderr] 139 | | futures::future::ok(()) [INFO] [stderr] 140 | | }); [INFO] [stderr] | |______________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/net/udp.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/net/tcp.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | f [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/net/tcp.rs:170:17 [INFO] [stderr] | [INFO] [stderr] 170 | let f = socket.incoming().for_each(move |(socket, peer_addr)| { [INFO] [stderr] | _________________^ [INFO] [stderr] 171 | | info!(server_log, "New client connected"; "addr" => format!("{}", peer_addr)); [INFO] [stderr] 172 | | handle_tcp_stream( [INFO] [stderr] 173 | | &cloned_handle, [INFO] [stderr] ... | [INFO] [stderr] 182 | | futures::future::ok(()) [INFO] [stderr] 183 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/net/tcp.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | f [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/net/tcp.rs:223:17 [INFO] [stderr] | [INFO] [stderr] 223 | let f = socket_future.and_then(move |socket| { [INFO] [stderr] | _________________^ [INFO] [stderr] 224 | | info!(client_log, "Connected!"); [INFO] [stderr] 225 | | [INFO] [stderr] 226 | | local_port_tx.send( [INFO] [stderr] ... | [INFO] [stderr] 243 | | futures::future::ok(()) [INFO] [stderr] 244 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/net/tcp.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/net/tcp.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | buf.put_u16::(0); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/net/tcp.rs:276:33 [INFO] [stderr] | [INFO] [stderr] 276 | let (sink, stream) = socket.framed(codec).split(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/grid/root.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn next_east(&self) -> Root { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/grid/root.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn next_west(&self) -> Root { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/grid/dir.rs:24:31 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn points_at_hex_edge(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/grid/dir.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn next_hex_edge_left(&self) -> Dir { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/grid/dir.rs:34:32 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn next_hex_edge_right(&self) -> Dir { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/grid/dir.rs:38:21 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn opposite(&self) -> Dir { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/grid/equivalent_points.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match &mut self.iter { [INFO] [stderr] 98 | | &mut EquivalentPointsImpl::NorthPole(ref mut iter) => iter.next(), [INFO] [stderr] 99 | | &mut EquivalentPointsImpl::SouthPole(ref mut iter) => iter.next(), [INFO] [stderr] 100 | | &mut EquivalentPointsImpl::EastArctic(ref mut iter) => iter.next(), [INFO] [stderr] ... | [INFO] [stderr] 106 | | &mut EquivalentPointsImpl::Interior(ref mut iter) => iter.next(), [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | match *(&mut self.iter) { [INFO] [stderr] 98 | EquivalentPointsImpl::NorthPole(ref mut iter) => iter.next(), [INFO] [stderr] 99 | EquivalentPointsImpl::SouthPole(ref mut iter) => iter.next(), [INFO] [stderr] 100 | EquivalentPointsImpl::EastArctic(ref mut iter) => iter.next(), [INFO] [stderr] 101 | EquivalentPointsImpl::WestArctic(ref mut iter) => iter.next(), [INFO] [stderr] 102 | EquivalentPointsImpl::EastTropics(ref mut iter) => iter.next(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/globe/globe.rs:280:56 [INFO] [stderr] | [INFO] [stderr] 280 | let chunk_origin = self.origin_of_chunk_owning(pos.into()); [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/globe.rs:340:23 [INFO] [stderr] | [INFO] [stderr] 340 | for cell_z in origin.pos().z..(end_z + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `origin.pos().z..=end_z` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/globe.rs:341:27 [INFO] [stderr] | [INFO] [stderr] 341 | for cell_y in origin.pos().y..(end_y + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `origin.pos().y..=end_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/globe.rs:342:31 [INFO] [stderr] | [INFO] [stderr] 342 | for cell_x in origin.pos().x..(end_x + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `origin.pos().x..=end_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/net/tcp.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | buf.put_u16::(0); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/globe/globe_ext.rs:76:21 [INFO] [stderr] | [INFO] [stderr] 76 | hopefully_air_pos.z = hopefully_air_pos.z + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hopefully_air_pos.z += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/globe/globe_ext.rs:168:28 [INFO] [stderr] | [INFO] [stderr] 168 | return pos.into(); [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/globe/icosahedron.rs:2:18 [INFO] [stderr] | [INFO] [stderr] 2 | const PHI: f64 = 1.61803398874989484820458683436563811772030917980576286213544862270526046281890244970720720418939113748475; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.618_033_988_749_895` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/globe/icosahedron.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | const SF: f64 = 0.525731112119133606025669084847876607285497932243341781528935523241211146403214018371632628831552570956698521400021; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.525_731_112_119_133_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/net/tcp.rs:276:33 [INFO] [stderr] | [INFO] [stderr] 276 | let (sink, stream) = socket.framed(codec).split(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/globe/chunk.rs:106:12 [INFO] [stderr] | [INFO] [stderr] 106 | if self.upstream_neighbors.len() > 0 || self.downstream_neighbors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.upstream_neighbors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/globe/chunk.rs:106:49 [INFO] [stderr] | [INFO] [stderr] 106 | if self.upstream_neighbors.len() > 0 || self.downstream_neighbors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.downstream_neighbors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/view.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | for cell_z in origin.pos().z..(end_z + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `origin.pos().z..=end_z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/view.rs:79:27 [INFO] [stderr] | [INFO] [stderr] 79 | for cell_y in origin.pos().y..(end_y + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `origin.pos().y..=end_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/view.rs:80:31 [INFO] [stderr] | [INFO] [stderr] 80 | for cell_x in origin.pos().x..(end_x + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `origin.pos().x..=end_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/net/tcp.rs:392:17 [INFO] [stderr] | [INFO] [stderr] 392 | buf.put_u16::(message.len() as u16); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/net/tcp.rs:398:18 [INFO] [stderr] | [INFO] [stderr] 398 | buf2.put_u16::(message.len() as u16); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/net/tcp.rs:459:17 [INFO] [stderr] | [INFO] [stderr] 459 | buf.put_u16::(message.len() as u16); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/net/tcp.rs:461:17 [INFO] [stderr] | [INFO] [stderr] 461 | buf.put_u16::(message.len() as u16); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/globe/chunk_view_system.rs:226:23 [INFO] [stderr] | [INFO] [stderr] 226 | type SystemData = (Entities<'a>, [INFO] [stderr] | _______________________^ [INFO] [stderr] 227 | | Fetch<'a, TimeDeltaResource>, [INFO] [stderr] 228 | | WriteStorage<'a, Globe>, [INFO] [stderr] 229 | | WriteStorage<'a, Visual>, [INFO] [stderr] 230 | | WriteStorage<'a, Spatial>, [INFO] [stderr] 231 | | WriteStorage<'a, ChunkView>); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/globe/chunk_system.rs:86:12 [INFO] [stderr] | [INFO] [stderr] 86 | if cd_positions.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cd_positions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/globe/chunk_shared_points.rs:20:11 [INFO] [stderr] | [INFO] [stderr] 20 | iter: itertools::ConsTuples< [INFO] [stderr] | ___________^ [INFO] [stderr] 21 | | itertools::Product< [INFO] [stderr] 22 | | itertools::Product< [INFO] [stderr] 23 | | ops::Range, [INFO] [stderr] ... | [INFO] [stderr] 28 | | ((GridCoord, GridCoord), GridCoord), [INFO] [stderr] 29 | | >, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/chunk_shared_points.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | pos.x..(pos.x + chunk_resolution[0] + 1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pos.x..=pos.x + chunk_resolution[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/chunk_shared_points.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | pos.y..(pos.y + chunk_resolution[1] + 1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pos.y..=pos.y + chunk_resolution[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app.rs:201:32 [INFO] [stderr] | [INFO] [stderr] 201 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> src/app.rs:205:34 [INFO] [stderr] | [INFO] [stderr] 205 | self.dispatcher.dispatch(&mut self.world.res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/render/system.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new>( [INFO] [stderr] 36 | | world: &mut specs::World, [INFO] [stderr] 37 | | factory: &mut F, [INFO] [stderr] 38 | | encoder_channel: EncoderChannel, [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render/mesh.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | assert!(vertices.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vertices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render/mesh.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | assert!(vertex_indices.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vertex_indices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render/proto_mesh.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | assert!(vertexes.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vertexes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render/proto_mesh.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | assert!(indexes.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!indexes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cell_dweller/movement_system.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / if let &Input::Button(button_args) = input_event { [INFO] [stderr] 44 | | if let Button::Keyboard(key) = button_args.button { [INFO] [stderr] 45 | | let is_down = match button_args.state { [INFO] [stderr] 46 | | ButtonState::Press => true, [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | if let Input::Button(button_args) = *input_event { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cell_dweller/movement_system.rs:176:18 [INFO] [stderr] | [INFO] [stderr] 176 | for _ in 0..(self.max_step_height + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.max_step_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/cell_dweller/movement_system.rs:197:23 [INFO] [stderr] | [INFO] [stderr] 197 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 198 | | Fetch<'a, TimeDeltaResource>, [INFO] [stderr] 199 | | WriteStorage<'a, CellDweller>, [INFO] [stderr] 200 | | WriteStorage<'a, Spatial>, [INFO] [stderr] ... | [INFO] [stderr] 204 | | ReadStorage<'a, NetMarker>, [INFO] [stderr] 205 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cell_dweller/mining.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | let cs = cell.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*cell` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cell_dweller/mining_system.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / if let &Input::Button(button_args) = input_event { [INFO] [stderr] 40 | | if let Button::Keyboard(key) = button_args.button { [INFO] [stderr] 41 | | let is_down = match button_args.state { [INFO] [stderr] 42 | | ButtonState::Press => true, [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 39 | if let Input::Button(button_args) = *input_event { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cell_dweller/mining_system.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | / match key { [INFO] [stderr] 46 | | Key::U => self.sender.send(MiningEvent::PickUp(is_down)).unwrap(), [INFO] [stderr] 47 | | _ => (), [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Key::U = key { self.sender.send(MiningEvent::PickUp(is_down)).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/cell_dweller/mining_system.rs:95:23 [INFO] [stderr] | [INFO] [stderr] 95 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 96 | | WriteStorage<'a, CellDweller>, [INFO] [stderr] 97 | | WriteStorage<'a, Globe>, [INFO] [stderr] 98 | | Fetch<'a, ActiveCellDweller>, [INFO] [stderr] 99 | | FetchMut<'a, SendMessageQueue>, [INFO] [stderr] 100 | | ReadStorage<'a, NetMarker>, [INFO] [stderr] 101 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/cell_dweller/recv_system.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 43 | | WriteStorage<'a, Globe>, [INFO] [stderr] 44 | | WriteStorage<'a, CellDweller>, [INFO] [stderr] 45 | | WriteStorage<'a, Spatial>, [INFO] [stderr] ... | [INFO] [stderr] 49 | | Fetch<'a, NodeResource>, [INFO] [stderr] 50 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/movement/turn.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn opposite(&self) -> TurnDir { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/movement/turn.rs:28:27 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn apply_one_unit(&self, dir: &mut Dir) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/movement/turn.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn apply_two_units(&self, dir: &mut Dir) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/movement/util.rs:100:10 [INFO] [stderr] | [INFO] [stderr] 100 | dir: &Dir, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/movement/util.rs:125:41 [INFO] [stderr] | [INFO] [stderr] 125 | let middle_axis_dir: i16 = (triangle.x_dir as i16 + 1) % 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(triangle.x_dir)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/movement/util.rs:126:43 [INFO] [stderr] | [INFO] [stderr] 126 | let mut a = middle_axis_dir - dir.index as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i16::from(dir.index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/net/send_system.rs:88:23 [INFO] [stderr] | [INFO] [stderr] 88 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 89 | | FetchMut<'a, SendMessageQueue>, [INFO] [stderr] 90 | | FetchMut<'a, RecvMessageQueue>, [INFO] [stderr] 91 | | FetchMut<'a, NetworkPeers>, [INFO] [stderr] 92 | | Fetch<'a, NodeResource>, [INFO] [stderr] 93 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `app_builder::AppBuilder` [INFO] [stderr] --> src/app_builder.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> AppBuilder { [INFO] [stderr] 34 | | use ::LogResource; [INFO] [stderr] 35 | | [INFO] [stderr] 36 | | // Set up logger. [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | impl Default for app_builder::AppBuilder { [INFO] [stderr] 33 | fn default() -> Self { [INFO] [stderr] 34 | Self::new() [INFO] [stderr] 35 | } [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/grid/root.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn next_east(&self) -> Root { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/grid/root.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn next_west(&self) -> Root { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/grid/dir.rs:24:31 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn points_at_hex_edge(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/grid/dir.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn next_hex_edge_left(&self) -> Dir { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/grid/dir.rs:34:32 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn next_hex_edge_right(&self) -> Dir { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/grid/dir.rs:38:21 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn opposite(&self) -> Dir { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/grid/equivalent_points.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match &mut self.iter { [INFO] [stderr] 98 | | &mut EquivalentPointsImpl::NorthPole(ref mut iter) => iter.next(), [INFO] [stderr] 99 | | &mut EquivalentPointsImpl::SouthPole(ref mut iter) => iter.next(), [INFO] [stderr] 100 | | &mut EquivalentPointsImpl::EastArctic(ref mut iter) => iter.next(), [INFO] [stderr] ... | [INFO] [stderr] 106 | | &mut EquivalentPointsImpl::Interior(ref mut iter) => iter.next(), [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 97 | match *(&mut self.iter) { [INFO] [stderr] 98 | EquivalentPointsImpl::NorthPole(ref mut iter) => iter.next(), [INFO] [stderr] 99 | EquivalentPointsImpl::SouthPole(ref mut iter) => iter.next(), [INFO] [stderr] 100 | EquivalentPointsImpl::EastArctic(ref mut iter) => iter.next(), [INFO] [stderr] 101 | EquivalentPointsImpl::WestArctic(ref mut iter) => iter.next(), [INFO] [stderr] 102 | EquivalentPointsImpl::EastTropics(ref mut iter) => iter.next(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/grid/equivalent_points.rs:820:29 [INFO] [stderr] | [INFO] [stderr] 820 | for xy in iproduct!(0..(ROOT_RESOLUTION[0] + 1), 0..(ROOT_RESOLUTION[1] + 1)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=ROOT_RESOLUTION[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/grid/equivalent_points.rs:820:58 [INFO] [stderr] | [INFO] [stderr] 820 | for xy in iproduct!(0..(ROOT_RESOLUTION[0] + 1), 0..(ROOT_RESOLUTION[1] + 1)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=ROOT_RESOLUTION[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/globe/globe.rs:280:56 [INFO] [stderr] | [INFO] [stderr] 280 | let chunk_origin = self.origin_of_chunk_owning(pos.into()); [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/globe.rs:340:23 [INFO] [stderr] | [INFO] [stderr] 340 | for cell_z in origin.pos().z..(end_z + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `origin.pos().z..=end_z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/globe.rs:341:27 [INFO] [stderr] | [INFO] [stderr] 341 | for cell_y in origin.pos().y..(end_y + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `origin.pos().y..=end_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/globe.rs:342:31 [INFO] [stderr] | [INFO] [stderr] 342 | for cell_x in origin.pos().x..(end_x + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `origin.pos().x..=end_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/globe/globe_ext.rs:76:21 [INFO] [stderr] | [INFO] [stderr] 76 | hopefully_air_pos.z = hopefully_air_pos.z + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hopefully_air_pos.z += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/globe/globe_ext.rs:168:28 [INFO] [stderr] | [INFO] [stderr] 168 | return pos.into(); [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/globe/icosahedron.rs:2:18 [INFO] [stderr] | [INFO] [stderr] 2 | const PHI: f64 = 1.61803398874989484820458683436563811772030917980576286213544862270526046281890244970720720418939113748475; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `1.618_033_988_749_895` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/globe/icosahedron.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | const SF: f64 = 0.525731112119133606025669084847876607285497932243341781528935523241211146403214018371632628831552570956698521400021; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.525_731_112_119_133_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/globe/chunk.rs:106:12 [INFO] [stderr] | [INFO] [stderr] 106 | if self.upstream_neighbors.len() > 0 || self.downstream_neighbors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.upstream_neighbors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/globe/chunk.rs:106:49 [INFO] [stderr] | [INFO] [stderr] 106 | if self.upstream_neighbors.len() > 0 || self.downstream_neighbors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.downstream_neighbors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/view.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | for cell_z in origin.pos().z..(end_z + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `origin.pos().z..=end_z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/view.rs:79:27 [INFO] [stderr] | [INFO] [stderr] 79 | for cell_y in origin.pos().y..(end_y + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `origin.pos().y..=end_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/view.rs:80:31 [INFO] [stderr] | [INFO] [stderr] 80 | for cell_x in origin.pos().x..(end_x + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `origin.pos().x..=end_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/globe/chunk_view_system.rs:226:23 [INFO] [stderr] | [INFO] [stderr] 226 | type SystemData = (Entities<'a>, [INFO] [stderr] | _______________________^ [INFO] [stderr] 227 | | Fetch<'a, TimeDeltaResource>, [INFO] [stderr] 228 | | WriteStorage<'a, Globe>, [INFO] [stderr] 229 | | WriteStorage<'a, Visual>, [INFO] [stderr] 230 | | WriteStorage<'a, Spatial>, [INFO] [stderr] 231 | | WriteStorage<'a, ChunkView>); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/globe/chunk_system.rs:86:12 [INFO] [stderr] | [INFO] [stderr] 86 | if cd_positions.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cd_positions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/globe/chunk_shared_points.rs:20:11 [INFO] [stderr] | [INFO] [stderr] 20 | iter: itertools::ConsTuples< [INFO] [stderr] | ___________^ [INFO] [stderr] 21 | | itertools::Product< [INFO] [stderr] 22 | | itertools::Product< [INFO] [stderr] 23 | | ops::Range, [INFO] [stderr] ... | [INFO] [stderr] 28 | | ((GridCoord, GridCoord), GridCoord), [INFO] [stderr] 29 | | >, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/chunk_shared_points.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | pos.x..(pos.x + chunk_resolution[0] + 1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pos.x..=pos.x + chunk_resolution[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/globe/chunk_shared_points.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | pos.y..(pos.y + chunk_resolution[1] + 1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `pos.y..=pos.y + chunk_resolution[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app.rs:201:32 [INFO] [stderr] | [INFO] [stderr] 201 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> src/app.rs:205:34 [INFO] [stderr] | [INFO] [stderr] 205 | self.dispatcher.dispatch(&mut self.world.res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/render/system.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new>( [INFO] [stderr] 36 | | world: &mut specs::World, [INFO] [stderr] 37 | | factory: &mut F, [INFO] [stderr] 38 | | encoder_channel: EncoderChannel, [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render/mesh.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | assert!(vertices.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vertices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render/mesh.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | assert!(vertex_indices.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vertex_indices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render/proto_mesh.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | assert!(vertexes.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vertexes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render/proto_mesh.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | assert!(indexes.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!indexes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cell_dweller/movement_system.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / if let &Input::Button(button_args) = input_event { [INFO] [stderr] 44 | | if let Button::Keyboard(key) = button_args.button { [INFO] [stderr] 45 | | let is_down = match button_args.state { [INFO] [stderr] 46 | | ButtonState::Press => true, [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | if let Input::Button(button_args) = *input_event { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cell_dweller/movement_system.rs:176:18 [INFO] [stderr] | [INFO] [stderr] 176 | for _ in 0..(self.max_step_height + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.max_step_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/cell_dweller/movement_system.rs:197:23 [INFO] [stderr] | [INFO] [stderr] 197 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 198 | | Fetch<'a, TimeDeltaResource>, [INFO] [stderr] 199 | | WriteStorage<'a, CellDweller>, [INFO] [stderr] 200 | | WriteStorage<'a, Spatial>, [INFO] [stderr] ... | [INFO] [stderr] 204 | | ReadStorage<'a, NetMarker>, [INFO] [stderr] 205 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cell_dweller/mining.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | let cs = cell.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*cell` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cell_dweller/mining_system.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / if let &Input::Button(button_args) = input_event { [INFO] [stderr] 40 | | if let Button::Keyboard(key) = button_args.button { [INFO] [stderr] 41 | | let is_down = match button_args.state { [INFO] [stderr] 42 | | ButtonState::Press => true, [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 39 | if let Input::Button(button_args) = *input_event { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cell_dweller/mining_system.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | / match key { [INFO] [stderr] 46 | | Key::U => self.sender.send(MiningEvent::PickUp(is_down)).unwrap(), [INFO] [stderr] 47 | | _ => (), [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Key::U = key { self.sender.send(MiningEvent::PickUp(is_down)).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/cell_dweller/mining_system.rs:95:23 [INFO] [stderr] | [INFO] [stderr] 95 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 96 | | WriteStorage<'a, CellDweller>, [INFO] [stderr] 97 | | WriteStorage<'a, Globe>, [INFO] [stderr] 98 | | Fetch<'a, ActiveCellDweller>, [INFO] [stderr] 99 | | FetchMut<'a, SendMessageQueue>, [INFO] [stderr] 100 | | ReadStorage<'a, NetMarker>, [INFO] [stderr] 101 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/cell_dweller/recv_system.rs:42:23 [INFO] [stderr] | [INFO] [stderr] 42 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 43 | | WriteStorage<'a, Globe>, [INFO] [stderr] 44 | | WriteStorage<'a, CellDweller>, [INFO] [stderr] 45 | | WriteStorage<'a, Spatial>, [INFO] [stderr] ... | [INFO] [stderr] 49 | | Fetch<'a, NodeResource>, [INFO] [stderr] 50 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/movement/turn.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn opposite(&self) -> TurnDir { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/movement/turn.rs:28:27 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn apply_one_unit(&self, dir: &mut Dir) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/movement/turn.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn apply_two_units(&self, dir: &mut Dir) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/movement/util.rs:100:10 [INFO] [stderr] | [INFO] [stderr] 100 | dir: &Dir, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/movement/util.rs:125:41 [INFO] [stderr] | [INFO] [stderr] 125 | let middle_axis_dir: i16 = (triangle.x_dir as i16 + 1) % 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(triangle.x_dir)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/movement/util.rs:126:43 [INFO] [stderr] | [INFO] [stderr] 126 | let mut a = middle_axis_dir - dir.index as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i16::from(dir.index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/movement/tests.rs:246:29 [INFO] [stderr] | [INFO] [stderr] 246 | let final_pos = pos.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/movement/tests.rs:247:29 [INFO] [stderr] | [INFO] [stderr] 247 | let final_dir = dir.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/movement/tests.rs:298:29 [INFO] [stderr] | [INFO] [stderr] 298 | let final_pos = pos.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/movement/tests.rs:299:29 [INFO] [stderr] | [INFO] [stderr] 299 | let final_dir = dir.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/net/send_system.rs:88:23 [INFO] [stderr] | [INFO] [stderr] 88 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 89 | | FetchMut<'a, SendMessageQueue>, [INFO] [stderr] 90 | | FetchMut<'a, RecvMessageQueue>, [INFO] [stderr] 91 | | FetchMut<'a, NetworkPeers>, [INFO] [stderr] 92 | | Fetch<'a, NodeResource>, [INFO] [stderr] 93 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> src/net/tests.rs:88:34 [INFO] [stderr] | [INFO] [stderr] 88 | self.dispatcher.dispatch(&mut self.world.res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/net/tests.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | assert!(recv_queue.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!recv_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `app_builder::AppBuilder` [INFO] [stderr] --> src/app_builder.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> AppBuilder { [INFO] [stderr] 34 | | use ::LogResource; [INFO] [stderr] 35 | | [INFO] [stderr] 36 | | // Set up logger. [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | impl Default for app_builder::AppBuilder { [INFO] [stderr] 33 | fn default() -> Self { [INFO] [stderr] 34 | Self::new() [INFO] [stderr] 35 | } [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/integration_tests/random_walk.rs:116:42 [INFO] [stderr] | [INFO] [stderr] 116 | .maybe_entity = Some(guy_entity.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*guy_entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> src/integration_tests/random_walk.rs:147:42 [INFO] [stderr] | [INFO] [stderr] 147 | self.dispatcher.dispatch(&mut self.world.res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 19s [INFO] running `"docker" "inspect" "bbaf7dc3b1b85d70b50cfd0bdb63ab25ab98df1072eb67802f190399aaa7c3b5"` [INFO] running `"docker" "rm" "-f" "bbaf7dc3b1b85d70b50cfd0bdb63ab25ab98df1072eb67802f190399aaa7c3b5"` [INFO] [stdout] bbaf7dc3b1b85d70b50cfd0bdb63ab25ab98df1072eb67802f190399aaa7c3b5