[INFO] crate plaid 0.2.0 is already in cache [INFO] extracting crate plaid 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/plaid/0.2.0 [INFO] extracting crate plaid 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/plaid/0.2.0 [INFO] validating manifest of plaid-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of plaid-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing plaid-0.2.0 [INFO] finished frobbing plaid-0.2.0 [INFO] frobbed toml for plaid-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/plaid/0.2.0/Cargo.toml [INFO] started frobbing plaid-0.2.0 [INFO] finished frobbing plaid-0.2.0 [INFO] frobbed toml for plaid-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/plaid/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting plaid-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/plaid/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1090de8eff93b02b73f0bdb9098752b701cac40ceb75b93e19ddd3deeac36005 [INFO] running `"docker" "start" "-a" "1090de8eff93b02b73f0bdb9098752b701cac40ceb75b93e19ddd3deeac36005"` [INFO] [stderr] Checking plaid v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/product/info.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | primary: primary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `primary` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/data/account.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | current_balance: current_balance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_balance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/data/account.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | available_balance: available_balance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `available_balance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/data/account.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | account_number: account_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `account_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/data/account.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | routing_number: routing_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `routing_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/data/account.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | wire_routing_number: wire_routing_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wire_routing_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/product/info.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | primary: primary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `primary` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/data/account.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | current_balance: current_balance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_balance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/data/account.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | available_balance: available_balance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `available_balance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/data/account.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | account_number: account_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `account_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/data/account.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | routing_number: routing_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `routing_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/data/account.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | wire_routing_number: wire_routing_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wire_routing_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api/client/mod.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | (ref s, _) => return Err(Error::UnsuccessfulResponse(*s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::UnsuccessfulResponse(*s))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/api/data/transaction.rs:142:45 [INFO] [stderr] | [INFO] [stderr] 142 | assert_eq!(transaction.category_id, 13005000 as CategoryID); [INFO] [stderr] | ^^^^^^^^ help: consider: `13_005_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api/client/mod.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | (ref s, _) => return Err(Error::UnsuccessfulResponse(*s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::UnsuccessfulResponse(*s))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: The function/method `h::client::Body::BufBody` doesn't need a mutable reference [INFO] [stderr] --> src/api/client/mod.rs:62:48 [INFO] [stderr] | [INFO] [stderr] 62 | .body(h::client::Body::BufBody(&mut body, body_capacity)) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `json::decode` doesn't need a mutable reference [INFO] [stderr] --> src/api/client/mod.rs:72:52 [INFO] [stderr] | [INFO] [stderr] 72 | let user: User = try!(json::decode(&mut buffer)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `json::decode` doesn't need a mutable reference [INFO] [stderr] --> src/api/client/mod.rs:73:71 [INFO] [stderr] | [INFO] [stderr] 73 | let mfa_challenge: mfa::Challenge = try!(json::decode(&mut buffer)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `json::decode` doesn't need a mutable reference [INFO] [stderr] --> src/api/client/mod.rs:82:52 [INFO] [stderr] | [INFO] [stderr] 82 | let user: User = try!(json::decode(&mut buffer)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `json::decode` doesn't need a mutable reference [INFO] [stderr] --> src/api/client/mod.rs:83:55 [INFO] [stderr] | [INFO] [stderr] 83 | let data: P::Data = try!(json::decode(&mut buffer_copy)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `json::decode` doesn't need a mutable reference [INFO] [stderr] --> src/api/client/mod.rs:90:55 [INFO] [stderr] | [INFO] [stderr] 90 | let data: P::Data = try!(json::decode(&mut buffer_copy)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `h::client::Body::BufBody` doesn't need a mutable reference [INFO] [stderr] --> src/api/client/mod.rs:62:48 [INFO] [stderr] | [INFO] [stderr] 62 | .body(h::client::Body::BufBody(&mut body, body_capacity)) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `json::decode` doesn't need a mutable reference [INFO] [stderr] --> src/api/client/mod.rs:72:52 [INFO] [stderr] | [INFO] [stderr] 72 | let user: User = try!(json::decode(&mut buffer)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `json::decode` doesn't need a mutable reference [INFO] [stderr] --> src/api/client/mod.rs:73:71 [INFO] [stderr] | [INFO] [stderr] 73 | let mfa_challenge: mfa::Challenge = try!(json::decode(&mut buffer)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `json::decode` doesn't need a mutable reference [INFO] [stderr] --> src/api/client/mod.rs:82:52 [INFO] [stderr] | [INFO] [stderr] 82 | let user: User = try!(json::decode(&mut buffer)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `json::decode` doesn't need a mutable reference [INFO] [stderr] --> src/api/client/mod.rs:83:55 [INFO] [stderr] | [INFO] [stderr] 83 | let data: P::Data = try!(json::decode(&mut buffer_copy)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `json::decode` doesn't need a mutable reference [INFO] [stderr] --> src/api/client/mod.rs:90:55 [INFO] [stderr] | [INFO] [stderr] 90 | let data: P::Data = try!(json::decode(&mut buffer_copy)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/api/data/account.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | assert_eq!(acc.current_balance, 7255.23 as Amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/api/data/account.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | assert_eq!(acc.current_balance, 7255.23 as Amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/api/data/account.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | assert_eq!(acc.current_balance, 7255.23 as Amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/api/data/account.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | assert_eq!(acc.current_balance, 7255.23 as Amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/api/data/transaction.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | assert_eq!(transaction.amount, 12.70 as Amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/api/data/transaction.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | assert_eq!(transaction.amount, 12.70 as Amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `plaid`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "1090de8eff93b02b73f0bdb9098752b701cac40ceb75b93e19ddd3deeac36005"` [INFO] running `"docker" "rm" "-f" "1090de8eff93b02b73f0bdb9098752b701cac40ceb75b93e19ddd3deeac36005"` [INFO] [stdout] 1090de8eff93b02b73f0bdb9098752b701cac40ceb75b93e19ddd3deeac36005