[INFO] crate pkg-config 0.3.14 is already in cache [INFO] extracting crate pkg-config 0.3.14 into work/ex/clippy-test-run/sources/stable/reg/pkg-config/0.3.14 [INFO] extracting crate pkg-config 0.3.14 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pkg-config/0.3.14 [INFO] validating manifest of pkg-config-0.3.14 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pkg-config-0.3.14 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pkg-config-0.3.14 [INFO] finished frobbing pkg-config-0.3.14 [INFO] frobbed toml for pkg-config-0.3.14 written to work/ex/clippy-test-run/sources/stable/reg/pkg-config/0.3.14/Cargo.toml [INFO] started frobbing pkg-config-0.3.14 [INFO] finished frobbing pkg-config-0.3.14 [INFO] frobbed toml for pkg-config-0.3.14 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pkg-config/0.3.14/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pkg-config-0.3.14 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pkg-config/0.3.14:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6b13748b744b7be7af612a3d3dc9acebfb5f969dadec730f64ed2f1cf9f579d1 [INFO] running `"docker" "start" "-a" "6b13748b744b7be7af612a3d3dc9acebfb5f969dadec730f64ed2f1cf9f579d1"` [INFO] [stderr] Checking pkg-config v0.3.14 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:563:21 [INFO] [stderr] | [INFO] [stderr] 563 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:569:13 [INFO] [stderr] | [INFO] [stderr] 569 | cause: cause, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:563:21 [INFO] [stderr] | [INFO] [stderr] 563 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:569:13 [INFO] [stderr] | [INFO] [stderr] 569 | cause: cause, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/lib.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/lib.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:435:16 [INFO] [stderr] | [INFO] [stderr] 435 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 436 | | false [INFO] [stderr] 437 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:433:71 [INFO] [stderr] | [INFO] [stderr] 433 | } else if self.env_var_os("PKG_CONFIG_ALL_DYNAMIC").is_some() { [INFO] [stderr] | _______________________________________________________________________^ [INFO] [stderr] 434 | | false [INFO] [stderr] 435 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression will always return false [INFO] [stderr] --> src/lib.rs:433:16 [INFO] [stderr] | [INFO] [stderr] 433 | } else if self.env_var_os("PKG_CONFIG_ALL_DYNAMIC").is_some() { [INFO] [stderr] | ________________^ [INFO] [stderr] 434 | | false [INFO] [stderr] 435 | | } else { [INFO] [stderr] 436 | | false [INFO] [stderr] 437 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:504:46 [INFO] [stderr] | [INFO] [stderr] 504 | let mut iter = val.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pkg-config`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:435:16 [INFO] [stderr] | [INFO] [stderr] 435 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 436 | | false [INFO] [stderr] 437 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:433:71 [INFO] [stderr] | [INFO] [stderr] 433 | } else if self.env_var_os("PKG_CONFIG_ALL_DYNAMIC").is_some() { [INFO] [stderr] | _______________________________________________________________________^ [INFO] [stderr] 434 | | false [INFO] [stderr] 435 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression will always return false [INFO] [stderr] --> src/lib.rs:433:16 [INFO] [stderr] | [INFO] [stderr] 433 | } else if self.env_var_os("PKG_CONFIG_ALL_DYNAMIC").is_some() { [INFO] [stderr] | ________________^ [INFO] [stderr] 434 | | false [INFO] [stderr] 435 | | } else { [INFO] [stderr] 436 | | false [INFO] [stderr] 437 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:504:46 [INFO] [stderr] | [INFO] [stderr] 504 | let mut iter = val.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pkg-config`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6b13748b744b7be7af612a3d3dc9acebfb5f969dadec730f64ed2f1cf9f579d1"` [INFO] running `"docker" "rm" "-f" "6b13748b744b7be7af612a3d3dc9acebfb5f969dadec730f64ed2f1cf9f579d1"` [INFO] [stdout] 6b13748b744b7be7af612a3d3dc9acebfb5f969dadec730f64ed2f1cf9f579d1