[INFO] crate pixelast 0.1.0 is already in cache [INFO] extracting crate pixelast 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/pixelast/0.1.0 [INFO] extracting crate pixelast 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pixelast/0.1.0 [INFO] validating manifest of pixelast-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pixelast-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pixelast-0.1.0 [INFO] finished frobbing pixelast-0.1.0 [INFO] frobbed toml for pixelast-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/pixelast/0.1.0/Cargo.toml [INFO] started frobbing pixelast-0.1.0 [INFO] finished frobbing pixelast-0.1.0 [INFO] frobbed toml for pixelast-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pixelast/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pixelast-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pixelast/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 13ae702ecfae8565f5d45c922505bd70aa9ac16010f87df562cd7b50d89884fd [INFO] running `"docker" "start" "-a" "13ae702ecfae8565f5d45c922505bd70aa9ac16010f87df562cd7b50d89884fd"` [INFO] [stderr] Checking pixelast v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/response.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | if let Ok(_) = res { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 43 | | panic!("not failed."); [INFO] [stderr] 44 | | }; [INFO] [stderr] | |_________- help: try this: `if res.is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/response.rs:52:16 [INFO] [stderr] | [INFO] [stderr] 52 | if let Ok(_) = res { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 53 | | panic!("not failed."); [INFO] [stderr] 54 | | }; [INFO] [stderr] | |_________- help: try this: `if res.is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | String::from(format!("{}users", BASE_URL)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}users", BASE_URL)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | String::from(format!("{}users/{}", BASE_URL, username)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}users/{}", BASE_URL, username)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | String::from(format!("{}/graphs", user_url)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}/graphs", user_url)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | String::from(format!("{}/{}", graphs_url, graph_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}/{}", graphs_url, graph_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | String::from(format!("{}users", BASE_URL)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}users", BASE_URL)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | String::from(format!("{}users/{}", BASE_URL, username)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}users/{}", BASE_URL, username)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | return String::from(format!("{}/{}?date={}", graphs_url, graph_id, v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}/{}?date={}", graphs_url, graph_id, v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | String::from(format!("{}/{}", graphs_url, graph_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}/{}", graphs_url, graph_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | String::from(format!("{}/{}", graph_url, date)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}/{}", graph_url, date)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | String::from(format!("{}/{}", graph_url, "increment")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}/{}", graph_url, "increment")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | String::from(format!("{}/{}", graph_url, "decrement")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}/{}", graph_url, "decrement")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | String::from(format!("{}/graphs", user_url)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}/graphs", user_url)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | String::from(format!("{}/{}", graphs_url, graph_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}/{}", graphs_url, graph_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | return String::from(format!("{}/{}?date={}", graphs_url, graph_id, v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}/{}?date={}", graphs_url, graph_id, v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:61:30 [INFO] [stderr] | [INFO] [stderr] 61 | let expect_url = String::from(format!("https://pixe.la/v1/users/{}", username)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("https://pixe.la/v1/users/{}", username)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:72:30 [INFO] [stderr] | [INFO] [stderr] 72 | let expect_url = String::from(format!("https://pixe.la/v1/users/{}/graphs", username)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("https://pixe.la/v1/users/{}/graphs", username)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:80:30 [INFO] [stderr] | [INFO] [stderr] 80 | let expect_url = String::from(format!("https://pixe.la/v1/users/{}/graphs/{}", username, graph_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("https://pixe.la/v1/users/{}/graphs/{}", username, graph_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | String::from(format!("{}/{}", graphs_url, graph_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}/{}", graphs_url, graph_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | String::from(format!("{}/{}", graph_url, date)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}/{}", graph_url, date)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | String::from(format!("{}/{}", graph_url, "increment")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}/{}", graph_url, "increment")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:90:34 [INFO] [stderr] | [INFO] [stderr] 90 | let expect_url = String::from(format!("https://pixe.la/v1/users/{}/graphs/{}", username, graph_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("https://pixe.la/v1/users/{}/graphs/{}", username, graph_id)` [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | String::from(format!("{}/{}", graph_url, "decrement")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}/{}", graph_url, "decrement")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:94:34 [INFO] [stderr] | [INFO] [stderr] 94 | let expect_url = String::from(format!("https://pixe.la/v1/users/{}/graphs/{}?date={}", username, graph_id, "20181018")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("https://pixe.la/v1/users/{}/graphs/{}?date={}", username, graph_id, "20181018")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:108:30 [INFO] [stderr] | [INFO] [stderr] 108 | let expect_url = String::from(format!("https://pixe.la/v1/users/{}/graphs/{}/{}", username, graph_id, date)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("https://pixe.la/v1/users/{}/graphs/{}/{}", username, graph_id, date)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:116:30 [INFO] [stderr] | [INFO] [stderr] 116 | let expect_url = String::from(format!("https://pixe.la/v1/users/{}/graphs/{}/increment", username, graph_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("https://pixe.la/v1/users/{}/graphs/{}/increment", username, graph_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/endpoint.rs:124:30 [INFO] [stderr] | [INFO] [stderr] 124 | let expect_url = String::from(format!("https://pixe.la/v1/users/{}/graphs/{}/decrement", username, graph_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("https://pixe.la/v1/users/{}/graphs/{}/decrement", username, graph_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.35s [INFO] running `"docker" "inspect" "13ae702ecfae8565f5d45c922505bd70aa9ac16010f87df562cd7b50d89884fd"` [INFO] running `"docker" "rm" "-f" "13ae702ecfae8565f5d45c922505bd70aa9ac16010f87df562cd7b50d89884fd"` [INFO] [stdout] 13ae702ecfae8565f5d45c922505bd70aa9ac16010f87df562cd7b50d89884fd