[INFO] crate pit 0.1.0 is already in cache
[INFO] extracting crate pit 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/pit/0.1.0
[INFO] extracting crate pit 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pit/0.1.0
[INFO] validating manifest of pit-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pit-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pit-0.1.0
[INFO] removed 0 missing examples
[INFO] finished frobbing pit-0.1.0
[INFO] frobbed toml for pit-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/pit/0.1.0/Cargo.toml
[INFO] started frobbing pit-0.1.0
[INFO] removed 0 missing examples
[INFO] finished frobbing pit-0.1.0
[INFO] frobbed toml for pit-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pit/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pit-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pit/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3b95dd04fd8025d91ce6c3e6323cf17dcb26e5dd2f110955475c6e9a41d9be86
[INFO] running `"docker" "start" "-a" "3b95dd04fd8025d91ce6c3e6323cf17dcb26e5dd2f110955475c6e9a41d9be86"`
[INFO] [stderr]     Checking pit v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             config_path: config_path,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_path`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             profile_path: profile_path,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `profile_path`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             config_path: config_path,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_path`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             profile_path: profile_path,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `profile_path`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/lib.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | use std::env::home_dir;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/lib.rs:65:23
[INFO] [stderr]    |
[INFO] [stderr] 65 |         let homedir = home_dir().expect("fail home_dir");
[INFO] [stderr]    |                       ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this block may be rewritten with the `?` operator
[INFO] [stderr]    --> src/lib.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 | /         if config.is_none() {
[INFO] [stderr] 102 | |             return None;
[INFO] [stderr] 103 | |         }
[INFO] [stderr]     | |_________^ help: replace_it_with: `config?;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::question_mark)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stderr] 
[INFO] [stderr] warning: this block may be rewritten with the `?` operator
[INFO] [stderr]    --> src/lib.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 | /         if profile.is_none() {
[INFO] [stderr] 110 | |             return None;
[INFO] [stderr] 111 | |         };
[INFO] [stderr]     | |_________^ help: replace_it_with: `profile?;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stderr] 
[INFO] [stderr] warning: this block may be rewritten with the `?` operator
[INFO] [stderr]    --> src/lib.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 | /         if profile.unwrap().as_hash().is_none() {
[INFO] [stderr] 113 | |             return None;
[INFO] [stderr] 114 | |         }
[INFO] [stderr]     | |_________^ help: replace_it_with: `profile.unwrap().as_hash()?;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:150:21
[INFO] [stderr]     |
[INFO] [stderr] 150 |             let c = format!("--- {{}}");
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"--- {{}}".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/lib.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | use std::env::home_dir;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/lib.rs:65:23
[INFO] [stderr]    |
[INFO] [stderr] 65 |         let homedir = home_dir().expect("fail home_dir");
[INFO] [stderr]    |                       ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this block may be rewritten with the `?` operator
[INFO] [stderr]    --> src/lib.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 | /         if config.is_none() {
[INFO] [stderr] 102 | |             return None;
[INFO] [stderr] 103 | |         }
[INFO] [stderr]     | |_________^ help: replace_it_with: `config?;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::question_mark)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stderr] 
[INFO] [stderr] warning: this block may be rewritten with the `?` operator
[INFO] [stderr]    --> src/lib.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 | /         if profile.is_none() {
[INFO] [stderr] 110 | |             return None;
[INFO] [stderr] 111 | |         };
[INFO] [stderr]     | |_________^ help: replace_it_with: `profile?;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stderr] 
[INFO] [stderr] warning: this block may be rewritten with the `?` operator
[INFO] [stderr]    --> src/lib.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 | /         if profile.unwrap().as_hash().is_none() {
[INFO] [stderr] 113 | |             return None;
[INFO] [stderr] 114 | |         }
[INFO] [stderr]     | |_________^ help: replace_it_with: `profile.unwrap().as_hash()?;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:150:21
[INFO] [stderr]     |
[INFO] [stderr] 150 |             let c = format!("--- {{}}");
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"--- {{}}".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> examples/hello_pit.rs:17:20
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let username = config.get("username").unwrap();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config["username"]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> examples/hello_pit.rs:18:20
[INFO] [stderr]    |
[INFO] [stderr] 18 |     let password = config.get("password").unwrap();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config["password"]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.26s
[INFO] running `"docker" "inspect" "3b95dd04fd8025d91ce6c3e6323cf17dcb26e5dd2f110955475c6e9a41d9be86"`
[INFO] running `"docker" "rm" "-f" "3b95dd04fd8025d91ce6c3e6323cf17dcb26e5dd2f110955475c6e9a41d9be86"`
[INFO] [stdout] 3b95dd04fd8025d91ce6c3e6323cf17dcb26e5dd2f110955475c6e9a41d9be86