[INFO] crate pistoncore-glutin_window 0.51.1 is already in cache [INFO] extracting crate pistoncore-glutin_window 0.51.1 into work/ex/clippy-test-run/sources/stable/reg/pistoncore-glutin_window/0.51.1 [INFO] extracting crate pistoncore-glutin_window 0.51.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pistoncore-glutin_window/0.51.1 [INFO] validating manifest of pistoncore-glutin_window-0.51.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pistoncore-glutin_window-0.51.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pistoncore-glutin_window-0.51.1 [INFO] finished frobbing pistoncore-glutin_window-0.51.1 [INFO] frobbed toml for pistoncore-glutin_window-0.51.1 written to work/ex/clippy-test-run/sources/stable/reg/pistoncore-glutin_window/0.51.1/Cargo.toml [INFO] started frobbing pistoncore-glutin_window-0.51.1 [INFO] finished frobbing pistoncore-glutin_window-0.51.1 [INFO] frobbed toml for pistoncore-glutin_window-0.51.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pistoncore-glutin_window/0.51.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pistoncore-glutin_window-0.51.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pistoncore-glutin_window/0.51.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 144eabb523074ffa695c695fb725c7db2b0c1be7b210e9b999ca2417cb4c5428 [INFO] running `"docker" "start" "-a" "144eabb523074ffa695c695fb725c7db2b0c1be7b210e9b999ca2417cb4c5428"` [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Checking wayland-sys v0.21.11 [INFO] [stderr] Compiling wayland-client v0.21.11 [INFO] [stderr] Checking pistoncore-input v0.23.0 [INFO] [stderr] Checking wayland-commons v0.21.11 [INFO] [stderr] Checking andrew v0.1.6 [INFO] [stderr] Checking pistoncore-window v0.34.0 [INFO] [stderr] Checking wayland-protocols v0.21.11 [INFO] [stderr] Checking smithay-client-toolkit v0.4.4 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | exit_on_esc: exit_on_esc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exit_on_esc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | events_loop: events_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `events_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | exit_on_esc: exit_on_esc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exit_on_esc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | events_loop: events_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `events_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:93:46 [INFO] [stderr] | [INFO] [stderr] 93 | builder = builder.with_multisampling(samples as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(samples)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | let ref mut events = self.events; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------- help: try: `let events = &mut self.events;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:189:17 [INFO] [stderr] | [INFO] [stderr] 189 | let ref mut events = self.events; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------- help: try: `let events = &mut self.events;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:208:16 [INFO] [stderr] | [INFO] [stderr] 208 | if self.events.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.events.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:209:21 [INFO] [stderr] | [INFO] [stderr] 209 | let ref mut events = self.events; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------- help: try: `let events = &mut self.events;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:223:24 [INFO] [stderr] | [INFO] [stderr] 223 | if self.events.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.events.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:224:29 [INFO] [stderr] | [INFO] [stderr] 224 | let ref mut events = self.events; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------- help: try: `let events = &mut self.events;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:378:56 [INFO] [stderr] | [INFO] [stderr] 378 | }) => Some(Input::Move(Motion::MouseScroll(x as f64, y as f64))), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:378:66 [INFO] [stderr] | [INFO] [stderr] 378 | }) => Some(Input::Move(Motion::MouseScroll(x as f64, y as f64))), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:413:24 [INFO] [stderr] | [INFO] [stderr] 413 | if let Ok(_) = self.window.set_cursor_position((cx, cy).into()) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 414 | | self.last_cursor_pos = Some([cx, cy]); [INFO] [stderr] 415 | | } [INFO] [stderr] | |_________________- help: try this: `if self.window.set_cursor_position((cx, cy).into()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:423:49 [INFO] [stderr] | [INFO] [stderr] 423 | let size = self.window.get_inner_size().unwrap_or((0.0, 0.0).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| (0.0, 0.0).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:429:14 [INFO] [stderr] | [INFO] [stderr] 429 | .unwrap_or((0.0, 0.0).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| (0.0, 0.0).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:93:46 [INFO] [stderr] | [INFO] [stderr] 93 | builder = builder.with_multisampling(samples as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(samples)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | let ref mut events = self.events; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------- help: try: `let events = &mut self.events;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:189:17 [INFO] [stderr] | [INFO] [stderr] 189 | let ref mut events = self.events; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------- help: try: `let events = &mut self.events;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:208:16 [INFO] [stderr] | [INFO] [stderr] 208 | if self.events.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.events.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:209:21 [INFO] [stderr] | [INFO] [stderr] 209 | let ref mut events = self.events; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------- help: try: `let events = &mut self.events;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:223:24 [INFO] [stderr] | [INFO] [stderr] 223 | if self.events.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.events.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:224:29 [INFO] [stderr] | [INFO] [stderr] 224 | let ref mut events = self.events; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------- help: try: `let events = &mut self.events;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:378:56 [INFO] [stderr] | [INFO] [stderr] 378 | }) => Some(Input::Move(Motion::MouseScroll(x as f64, y as f64))), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:378:66 [INFO] [stderr] | [INFO] [stderr] 378 | }) => Some(Input::Move(Motion::MouseScroll(x as f64, y as f64))), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:413:24 [INFO] [stderr] | [INFO] [stderr] 413 | if let Ok(_) = self.window.set_cursor_position((cx, cy).into()) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 414 | | self.last_cursor_pos = Some([cx, cy]); [INFO] [stderr] 415 | | } [INFO] [stderr] | |_________________- help: try this: `if self.window.set_cursor_position((cx, cy).into()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:423:49 [INFO] [stderr] | [INFO] [stderr] 423 | let size = self.window.get_inner_size().unwrap_or((0.0, 0.0).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| (0.0, 0.0).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:429:14 [INFO] [stderr] | [INFO] [stderr] 429 | .unwrap_or((0.0, 0.0).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| (0.0, 0.0).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 47.72s [INFO] running `"docker" "inspect" "144eabb523074ffa695c695fb725c7db2b0c1be7b210e9b999ca2417cb4c5428"` [INFO] running `"docker" "rm" "-f" "144eabb523074ffa695c695fb725c7db2b0c1be7b210e9b999ca2417cb4c5428"` [INFO] [stdout] 144eabb523074ffa695c695fb725c7db2b0c1be7b210e9b999ca2417cb4c5428