[INFO] crate pistoncore-event_loop 0.39.0 is already in cache [INFO] extracting crate pistoncore-event_loop 0.39.0 into work/ex/clippy-test-run/sources/stable/reg/pistoncore-event_loop/0.39.0 [INFO] extracting crate pistoncore-event_loop 0.39.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pistoncore-event_loop/0.39.0 [INFO] validating manifest of pistoncore-event_loop-0.39.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pistoncore-event_loop-0.39.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pistoncore-event_loop-0.39.0 [INFO] finished frobbing pistoncore-event_loop-0.39.0 [INFO] frobbed toml for pistoncore-event_loop-0.39.0 written to work/ex/clippy-test-run/sources/stable/reg/pistoncore-event_loop/0.39.0/Cargo.toml [INFO] started frobbing pistoncore-event_loop-0.39.0 [INFO] finished frobbing pistoncore-event_loop-0.39.0 [INFO] frobbed toml for pistoncore-event_loop-0.39.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pistoncore-event_loop/0.39.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pistoncore-event_loop-0.39.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pistoncore-event_loop/0.39.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 84921e32ad556f6d4fdadd38bea70468996249d99f6a852b33da30659e0c8acb [INFO] running `"docker" "start" "-a" "84921e32ad556f6d4fdadd38bea70468996249d99f6a852b33da30659e0c8acb"` [INFO] [stderr] Checking pistoncore-window v0.34.0 [INFO] [stderr] Checking pistoncore-event_loop v0.39.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:107:28 [INFO] [stderr] | [INFO] [stderr] 107 | dur.as_secs() as f64 + dur.subsec_nanos() as f64 / 1_000_000_000.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/lib.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | / pub fn next(&mut self, window: &mut W) -> Option [INFO] [stderr] 143 | | where W: Window [INFO] [stderr] 144 | | { [INFO] [stderr] 145 | | if self.settings.lazy || self.settings.ups == 0 { [INFO] [stderr] ... | [INFO] [stderr] 372 | | } [INFO] [stderr] 373 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:107:28 [INFO] [stderr] | [INFO] [stderr] 107 | dur.as_secs() as f64 + dur.subsec_nanos() as f64 / 1_000_000_000.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/lib.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | / pub fn next(&mut self, window: &mut W) -> Option [INFO] [stderr] 143 | | where W: Window [INFO] [stderr] 144 | | { [INFO] [stderr] 145 | | if self.settings.lazy || self.settings.ups == 0 { [INFO] [stderr] ... | [INFO] [stderr] 372 | | } [INFO] [stderr] 373 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.82s [INFO] running `"docker" "inspect" "84921e32ad556f6d4fdadd38bea70468996249d99f6a852b33da30659e0c8acb"` [INFO] running `"docker" "rm" "-f" "84921e32ad556f6d4fdadd38bea70468996249d99f6a852b33da30659e0c8acb"` [INFO] [stdout] 84921e32ad556f6d4fdadd38bea70468996249d99f6a852b33da30659e0c8acb