[INFO] crate piston_meta_search 0.17.0 is already in cache [INFO] extracting crate piston_meta_search 0.17.0 into work/ex/clippy-test-run/sources/stable/reg/piston_meta_search/0.17.0 [INFO] extracting crate piston_meta_search 0.17.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston_meta_search/0.17.0 [INFO] validating manifest of piston_meta_search-0.17.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of piston_meta_search-0.17.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing piston_meta_search-0.17.0 [INFO] finished frobbing piston_meta_search-0.17.0 [INFO] frobbed toml for piston_meta_search-0.17.0 written to work/ex/clippy-test-run/sources/stable/reg/piston_meta_search/0.17.0/Cargo.toml [INFO] started frobbing piston_meta_search-0.17.0 [INFO] finished frobbing piston_meta_search-0.17.0 [INFO] frobbed toml for piston_meta_search-0.17.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston_meta_search/0.17.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting piston_meta_search-0.17.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/piston_meta_search/0.17.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1815cd19d4cbbe64e10ec8f62fde5d7abc38c054b0a1594dd699029455fdd52c [INFO] running `"docker" "start" "-a" "1815cd19d4cbbe64e10ec8f62fde5d7abc38c054b0a1594dd699029455fdd52c"` [INFO] [stderr] Checking range v0.3.1 [INFO] [stderr] Checking read_token v0.9.0 [INFO] [stderr] Checking piston_meta v0.30.0 [INFO] [stderr] Checking piston_meta_search v0.17.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:41:35 [INFO] [stderr] | [INFO] [stderr] 41 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / match &d.data { [INFO] [stderr] 49 | | &MetaData::String(ref n, ref v) => { [INFO] [stderr] 50 | | if &**n == name && &**v == val { [INFO] [stderr] 51 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 57 | | _ => {} [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | if let &MetaData::String(ref n, ref v) = &d.data { [INFO] [stderr] 49 | if &**n == name && &**v == val { [INFO] [stderr] 50 | return f(Search { [INFO] [stderr] 51 | data: &self.data[i + 1..], [INFO] [stderr] 52 | range: Some(d.range()) [INFO] [stderr] 53 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / match &d.data { [INFO] [stderr] 49 | | &MetaData::String(ref n, ref v) => { [INFO] [stderr] 50 | | if &**n == name && &**v == val { [INFO] [stderr] 51 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 57 | | _ => {} [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 48 | match d.data { [INFO] [stderr] 49 | MetaData::String(ref n, ref v) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:50:24 [INFO] [stderr] | [INFO] [stderr] 50 | if &**n == name && &**v == val { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:50:40 [INFO] [stderr] | [INFO] [stderr] 50 | if &**n == name && &**v == val { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:77:12 [INFO] [stderr] | [INFO] [stderr] 77 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:78:35 [INFO] [stderr] | [INFO] [stderr] 78 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / match &d.data { [INFO] [stderr] 86 | | &MetaData::F64(ref n, v) => { [INFO] [stderr] 87 | | if &**n == name && v == val { [INFO] [stderr] 88 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 94 | | _ => {} [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | if let &MetaData::F64(ref n, v) = &d.data { [INFO] [stderr] 86 | if &**n == name && v == val { [INFO] [stderr] 87 | return f(Search { [INFO] [stderr] 88 | data: &self.data[i + 1..], [INFO] [stderr] 89 | range: Some(d.range()) [INFO] [stderr] 90 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / match &d.data { [INFO] [stderr] 86 | | &MetaData::F64(ref n, v) => { [INFO] [stderr] 87 | | if &**n == name && v == val { [INFO] [stderr] 88 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 94 | | _ => {} [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 85 | match d.data { [INFO] [stderr] 86 | MetaData::F64(ref n, v) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:87:24 [INFO] [stderr] | [INFO] [stderr] 87 | if &**n == name && v == val { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:87:40 [INFO] [stderr] | [INFO] [stderr] 87 | if &**n == name && v == val { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(v - val).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:87:40 [INFO] [stderr] | [INFO] [stderr] 87 | if &**n == name && v == val { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:115:35 [INFO] [stderr] | [INFO] [stderr] 115 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | / match &d.data { [INFO] [stderr] 123 | | &MetaData::Bool(ref n, v) => { [INFO] [stderr] 124 | | if &**n == name && v == val { [INFO] [stderr] 125 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => {} [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 122 | if let &MetaData::Bool(ref n, v) = &d.data { [INFO] [stderr] 123 | if &**n == name && v == val { [INFO] [stderr] 124 | return f(Search { [INFO] [stderr] 125 | data: &self.data[i + 1..], [INFO] [stderr] 126 | range: Some(d.range()) [INFO] [stderr] 127 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | / match &d.data { [INFO] [stderr] 123 | | &MetaData::Bool(ref n, v) => { [INFO] [stderr] 124 | | if &**n == name && v == val { [INFO] [stderr] 125 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => {} [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 122 | match d.data { [INFO] [stderr] 123 | MetaData::Bool(ref n, v) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:124:24 [INFO] [stderr] | [INFO] [stderr] 124 | if &**n == name && v == val { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:135:24 [INFO] [stderr] | [INFO] [stderr] 135 | Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:150:12 [INFO] [stderr] | [INFO] [stderr] 150 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | / match &d.data { [INFO] [stderr] 158 | | &MetaData::StartNode(ref n) => { [INFO] [stderr] 159 | | if &**n == name { [INFO] [stderr] 160 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 166 | | _ => {} [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 157 | if let &MetaData::StartNode(ref n) = &d.data { [INFO] [stderr] 158 | if &**n == name { [INFO] [stderr] 159 | return f(Search { [INFO] [stderr] 160 | data: &self.data[i + 1..], [INFO] [stderr] 161 | range: Some(d.range()) [INFO] [stderr] 162 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | / match &d.data { [INFO] [stderr] 158 | | &MetaData::StartNode(ref n) => { [INFO] [stderr] 159 | | if &**n == name { [INFO] [stderr] 160 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 166 | | _ => {} [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 157 | match d.data { [INFO] [stderr] 158 | MetaData::StartNode(ref n) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:159:24 [INFO] [stderr] | [INFO] [stderr] 159 | if &**n == name { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:170:24 [INFO] [stderr] | [INFO] [stderr] 170 | Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:184:12 [INFO] [stderr] | [INFO] [stderr] 184 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:185:35 [INFO] [stderr] | [INFO] [stderr] 185 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | / match &d.data { [INFO] [stderr] 192 | | &MetaData::EndNode(ref n) => { [INFO] [stderr] 193 | | if &**n == name { [INFO] [stderr] 194 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 200 | | _ => {} [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 191 | if let &MetaData::EndNode(ref n) = &d.data { [INFO] [stderr] 192 | if &**n == name { [INFO] [stderr] 193 | return f(Search { [INFO] [stderr] 194 | data: &self.data[i + 1..], [INFO] [stderr] 195 | range: Some(d.range()) [INFO] [stderr] 196 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | / match &d.data { [INFO] [stderr] 192 | | &MetaData::EndNode(ref n) => { [INFO] [stderr] 193 | | if &**n == name { [INFO] [stderr] 194 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 200 | | _ => {} [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 191 | match d.data { [INFO] [stderr] 192 | MetaData::EndNode(ref n) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:193:24 [INFO] [stderr] | [INFO] [stderr] 193 | if &**n == name { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:204:24 [INFO] [stderr] | [INFO] [stderr] 204 | Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:211:12 [INFO] [stderr] | [INFO] [stderr] 211 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:212:35 [INFO] [stderr] | [INFO] [stderr] 212 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:219:20 [INFO] [stderr] | [INFO] [stderr] 219 | if &**n == name { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:237:12 [INFO] [stderr] | [INFO] [stderr] 237 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:238:35 [INFO] [stderr] | [INFO] [stderr] 238 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:245:20 [INFO] [stderr] | [INFO] [stderr] 245 | if &**n == name { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:266:12 [INFO] [stderr] | [INFO] [stderr] 266 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:267:35 [INFO] [stderr] | [INFO] [stderr] 267 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:274:20 [INFO] [stderr] | [INFO] [stderr] 274 | if &**n == name { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:292:12 [INFO] [stderr] | [INFO] [stderr] 292 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:293:35 [INFO] [stderr] | [INFO] [stderr] 293 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:300:20 [INFO] [stderr] | [INFO] [stderr] 300 | if &**n == name { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:318:12 [INFO] [stderr] | [INFO] [stderr] 318 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:319:35 [INFO] [stderr] | [INFO] [stderr] 319 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:326:20 [INFO] [stderr] | [INFO] [stderr] 326 | if &**n == name { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `piston_meta_search`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:41:35 [INFO] [stderr] | [INFO] [stderr] 41 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / match &d.data { [INFO] [stderr] 49 | | &MetaData::String(ref n, ref v) => { [INFO] [stderr] 50 | | if &**n == name && &**v == val { [INFO] [stderr] 51 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 57 | | _ => {} [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | if let &MetaData::String(ref n, ref v) = &d.data { [INFO] [stderr] 49 | if &**n == name && &**v == val { [INFO] [stderr] 50 | return f(Search { [INFO] [stderr] 51 | data: &self.data[i + 1..], [INFO] [stderr] 52 | range: Some(d.range()) [INFO] [stderr] 53 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / match &d.data { [INFO] [stderr] 49 | | &MetaData::String(ref n, ref v) => { [INFO] [stderr] 50 | | if &**n == name && &**v == val { [INFO] [stderr] 51 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 57 | | _ => {} [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 48 | match d.data { [INFO] [stderr] 49 | MetaData::String(ref n, ref v) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:50:24 [INFO] [stderr] | [INFO] [stderr] 50 | if &**n == name && &**v == val { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:50:40 [INFO] [stderr] | [INFO] [stderr] 50 | if &**n == name && &**v == val { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:77:12 [INFO] [stderr] | [INFO] [stderr] 77 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:78:35 [INFO] [stderr] | [INFO] [stderr] 78 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / match &d.data { [INFO] [stderr] 86 | | &MetaData::F64(ref n, v) => { [INFO] [stderr] 87 | | if &**n == name && v == val { [INFO] [stderr] 88 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 94 | | _ => {} [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | if let &MetaData::F64(ref n, v) = &d.data { [INFO] [stderr] 86 | if &**n == name && v == val { [INFO] [stderr] 87 | return f(Search { [INFO] [stderr] 88 | data: &self.data[i + 1..], [INFO] [stderr] 89 | range: Some(d.range()) [INFO] [stderr] 90 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / match &d.data { [INFO] [stderr] 86 | | &MetaData::F64(ref n, v) => { [INFO] [stderr] 87 | | if &**n == name && v == val { [INFO] [stderr] 88 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 94 | | _ => {} [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 85 | match d.data { [INFO] [stderr] 86 | MetaData::F64(ref n, v) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:87:24 [INFO] [stderr] | [INFO] [stderr] 87 | if &**n == name && v == val { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:87:40 [INFO] [stderr] | [INFO] [stderr] 87 | if &**n == name && v == val { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(v - val).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:87:40 [INFO] [stderr] | [INFO] [stderr] 87 | if &**n == name && v == val { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:115:35 [INFO] [stderr] | [INFO] [stderr] 115 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | / match &d.data { [INFO] [stderr] 123 | | &MetaData::Bool(ref n, v) => { [INFO] [stderr] 124 | | if &**n == name && v == val { [INFO] [stderr] 125 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => {} [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 122 | if let &MetaData::Bool(ref n, v) = &d.data { [INFO] [stderr] 123 | if &**n == name && v == val { [INFO] [stderr] 124 | return f(Search { [INFO] [stderr] 125 | data: &self.data[i + 1..], [INFO] [stderr] 126 | range: Some(d.range()) [INFO] [stderr] 127 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | / match &d.data { [INFO] [stderr] 123 | | &MetaData::Bool(ref n, v) => { [INFO] [stderr] 124 | | if &**n == name && v == val { [INFO] [stderr] 125 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => {} [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 122 | match d.data { [INFO] [stderr] 123 | MetaData::Bool(ref n, v) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:124:24 [INFO] [stderr] | [INFO] [stderr] 124 | if &**n == name && v == val { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:135:24 [INFO] [stderr] | [INFO] [stderr] 135 | Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:150:12 [INFO] [stderr] | [INFO] [stderr] 150 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | / match &d.data { [INFO] [stderr] 158 | | &MetaData::StartNode(ref n) => { [INFO] [stderr] 159 | | if &**n == name { [INFO] [stderr] 160 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 166 | | _ => {} [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 157 | if let &MetaData::StartNode(ref n) = &d.data { [INFO] [stderr] 158 | if &**n == name { [INFO] [stderr] 159 | return f(Search { [INFO] [stderr] 160 | data: &self.data[i + 1..], [INFO] [stderr] 161 | range: Some(d.range()) [INFO] [stderr] 162 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | / match &d.data { [INFO] [stderr] 158 | | &MetaData::StartNode(ref n) => { [INFO] [stderr] 159 | | if &**n == name { [INFO] [stderr] 160 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 166 | | _ => {} [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 157 | match d.data { [INFO] [stderr] 158 | MetaData::StartNode(ref n) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:159:24 [INFO] [stderr] | [INFO] [stderr] 159 | if &**n == name { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:170:24 [INFO] [stderr] | [INFO] [stderr] 170 | Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:184:12 [INFO] [stderr] | [INFO] [stderr] 184 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:185:35 [INFO] [stderr] | [INFO] [stderr] 185 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | / match &d.data { [INFO] [stderr] 192 | | &MetaData::EndNode(ref n) => { [INFO] [stderr] 193 | | if &**n == name { [INFO] [stderr] 194 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 200 | | _ => {} [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 191 | if let &MetaData::EndNode(ref n) = &d.data { [INFO] [stderr] 192 | if &**n == name { [INFO] [stderr] 193 | return f(Search { [INFO] [stderr] 194 | data: &self.data[i + 1..], [INFO] [stderr] 195 | range: Some(d.range()) [INFO] [stderr] 196 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | / match &d.data { [INFO] [stderr] 192 | | &MetaData::EndNode(ref n) => { [INFO] [stderr] 193 | | if &**n == name { [INFO] [stderr] 194 | | return f(Search { [INFO] [stderr] ... | [INFO] [stderr] 200 | | _ => {} [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 191 | match d.data { [INFO] [stderr] 192 | MetaData::EndNode(ref n) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:193:24 [INFO] [stderr] | [INFO] [stderr] 193 | if &**n == name { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:204:24 [INFO] [stderr] | [INFO] [stderr] 204 | Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:211:12 [INFO] [stderr] | [INFO] [stderr] 211 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:212:35 [INFO] [stderr] | [INFO] [stderr] 212 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:219:20 [INFO] [stderr] | [INFO] [stderr] 219 | if &**n == name { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:237:12 [INFO] [stderr] | [INFO] [stderr] 237 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:238:35 [INFO] [stderr] | [INFO] [stderr] 238 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:245:20 [INFO] [stderr] | [INFO] [stderr] 245 | if &**n == name { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:266:12 [INFO] [stderr] | [INFO] [stderr] 266 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:267:35 [INFO] [stderr] | [INFO] [stderr] 267 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:274:20 [INFO] [stderr] | [INFO] [stderr] 274 | if &**n == name { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:292:12 [INFO] [stderr] | [INFO] [stderr] 292 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:293:35 [INFO] [stderr] | [INFO] [stderr] 293 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:300:20 [INFO] [stderr] | [INFO] [stderr] 300 | if &**n == name { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:318:12 [INFO] [stderr] | [INFO] [stderr] 318 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:319:35 [INFO] [stderr] | [INFO] [stderr] 319 | return Err(self.range.unwrap_or(Range::empty(0)).wrap( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Range::empty(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:326:20 [INFO] [stderr] | [INFO] [stderr] 326 | if &**n == name { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | assert_eq!(a, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | assert_eq!(a, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:361:9 [INFO] [stderr] | [INFO] [stderr] 361 | assert_eq!(b, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:361:9 [INFO] [stderr] | [INFO] [stderr] 361 | assert_eq!(b, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:406:55 [INFO] [stderr] | [INFO] [stderr] 406 | assert!(s.for_end_node("proposition", |mut s| { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 407 | | stderr_unwrap(text, s.node("proposition")); [INFO] [stderr] 408 | | assert_eq!(s.bool("val"), Ok(false)); [INFO] [stderr] 409 | | stderr_unwrap(text, s.end_node("proposition")); [INFO] [stderr] 410 | | Ok(()) [INFO] [stderr] 411 | | }).is_ok()); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `piston_meta_search`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1815cd19d4cbbe64e10ec8f62fde5d7abc38c054b0a1594dd699029455fdd52c"` [INFO] running `"docker" "rm" "-f" "1815cd19d4cbbe64e10ec8f62fde5d7abc38c054b0a1594dd699029455fdd52c"` [INFO] [stdout] 1815cd19d4cbbe64e10ec8f62fde5d7abc38c054b0a1594dd699029455fdd52c