[INFO] crate piston_meta 0.30.0 is already in cache [INFO] extracting crate piston_meta 0.30.0 into work/ex/clippy-test-run/sources/stable/reg/piston_meta/0.30.0 [INFO] extracting crate piston_meta 0.30.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston_meta/0.30.0 [INFO] validating manifest of piston_meta-0.30.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of piston_meta-0.30.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing piston_meta-0.30.0 [INFO] finished frobbing piston_meta-0.30.0 [INFO] frobbed toml for piston_meta-0.30.0 written to work/ex/clippy-test-run/sources/stable/reg/piston_meta/0.30.0/Cargo.toml [INFO] started frobbing piston_meta-0.30.0 [INFO] finished frobbing piston_meta-0.30.0 [INFO] frobbed toml for piston_meta-0.30.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston_meta/0.30.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting piston_meta-0.30.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/piston_meta/0.30.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a259921bee4bff42084d3105e0394d9ca8be5ca473639a26922c067d6b1a8611 [INFO] running `"docker" "start" "-a" "a259921bee4bff42084d3105e0394d9ca8be5ca473639a26922c067d6b1a8611"` [INFO] [stderr] Checking piston_meta v0.30.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | args: args [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:285:21 [INFO] [stderr] | [INFO] [stderr] 285 | optional: optional, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `optional` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:286:21 [INFO] [stderr] | [INFO] [stderr] 286 | property: property [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `property` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:333:21 [INFO] [stderr] | [INFO] [stderr] 333 | optional: optional, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `optional` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:334:21 [INFO] [stderr] | [INFO] [stderr] 334 | property: property [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `property` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:386:21 [INFO] [stderr] | [INFO] [stderr] 386 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:387:21 [INFO] [stderr] | [INFO] [stderr] 387 | not: not, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `not` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:388:21 [INFO] [stderr] | [INFO] [stderr] 388 | inverted: inverted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `inverted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:389:21 [INFO] [stderr] | [INFO] [stderr] 389 | property: property, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `property` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:409:13 [INFO] [stderr] | [INFO] [stderr] 409 | optional: optional, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `optional` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:446:13 [INFO] [stderr] | [INFO] [stderr] 446 | allow_empty: allow_empty, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allow_empty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:447:13 [INFO] [stderr] | [INFO] [stderr] 447 | property: property, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `property` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:485:13 [INFO] [stderr] | [INFO] [stderr] 485 | property: property, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `property` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:525:21 [INFO] [stderr] | [INFO] [stderr] 525 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:526:21 [INFO] [stderr] | [INFO] [stderr] 526 | property: property, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `property` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:564:13 [INFO] [stderr] | [INFO] [stderr] 564 | args: args [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:588:13 [INFO] [stderr] | [INFO] [stderr] 588 | rule: rule, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:612:13 [INFO] [stderr] | [INFO] [stderr] 612 | rule: rule, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:664:21 [INFO] [stderr] | [INFO] [stderr] 664 | optional: optional, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `optional` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:665:21 [INFO] [stderr] | [INFO] [stderr] 665 | allow_trail: allow_trail, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allow_trail` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:666:21 [INFO] [stderr] | [INFO] [stderr] 666 | by: by, [INFO] [stderr] | ^^^^^^ help: replace it with: `by` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:667:21 [INFO] [stderr] | [INFO] [stderr] 667 | rule: rule, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:693:13 [INFO] [stderr] | [INFO] [stderr] 693 | rule: rule, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:733:21 [INFO] [stderr] | [INFO] [stderr] 733 | rule: rule, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:734:21 [INFO] [stderr] | [INFO] [stderr] 734 | optional: optional, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `optional` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse_error_handler.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | lines: lines, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | args: args [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:285:21 [INFO] [stderr] | [INFO] [stderr] 285 | optional: optional, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `optional` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:286:21 [INFO] [stderr] | [INFO] [stderr] 286 | property: property [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `property` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:333:21 [INFO] [stderr] | [INFO] [stderr] 333 | optional: optional, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `optional` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:334:21 [INFO] [stderr] | [INFO] [stderr] 334 | property: property [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `property` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:386:21 [INFO] [stderr] | [INFO] [stderr] 386 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:387:21 [INFO] [stderr] | [INFO] [stderr] 387 | not: not, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `not` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:388:21 [INFO] [stderr] | [INFO] [stderr] 388 | inverted: inverted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `inverted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:389:21 [INFO] [stderr] | [INFO] [stderr] 389 | property: property, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `property` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:409:13 [INFO] [stderr] | [INFO] [stderr] 409 | optional: optional, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `optional` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:446:13 [INFO] [stderr] | [INFO] [stderr] 446 | allow_empty: allow_empty, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allow_empty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:447:13 [INFO] [stderr] | [INFO] [stderr] 447 | property: property, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `property` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:485:13 [INFO] [stderr] | [INFO] [stderr] 485 | property: property, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `property` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:525:21 [INFO] [stderr] | [INFO] [stderr] 525 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:526:21 [INFO] [stderr] | [INFO] [stderr] 526 | property: property, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `property` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:564:13 [INFO] [stderr] | [INFO] [stderr] 564 | args: args [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:588:13 [INFO] [stderr] | [INFO] [stderr] 588 | rule: rule, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:612:13 [INFO] [stderr] | [INFO] [stderr] 612 | rule: rule, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:664:21 [INFO] [stderr] | [INFO] [stderr] 664 | optional: optional, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `optional` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:665:21 [INFO] [stderr] | [INFO] [stderr] 665 | allow_trail: allow_trail, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allow_trail` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:666:21 [INFO] [stderr] | [INFO] [stderr] 666 | by: by, [INFO] [stderr] | ^^^^^^ help: replace it with: `by` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:667:21 [INFO] [stderr] | [INFO] [stderr] 667 | rule: rule, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:693:13 [INFO] [stderr] | [INFO] [stderr] 693 | rule: rule, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:733:21 [INFO] [stderr] | [INFO] [stderr] 733 | rule: rule, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bootstrap/convert.rs:734:21 [INFO] [stderr] | [INFO] [stderr] 734 | optional: optional, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `optional` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse_error_handler.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | lines: lines, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/meta_rules/tag.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 64 | | if self.not { [INFO] [stderr] 65 | | match &self.property { [INFO] [stderr] 66 | | &Some(ref name) => { [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | } else if self.not { [INFO] [stderr] 64 | match &self.property { [INFO] [stderr] 65 | &Some(ref name) => { [INFO] [stderr] 66 | let range = read_token.start(); [INFO] [stderr] 67 | Ok((range, read_data( [INFO] [stderr] 68 | tokens, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/meta_rules/until_any.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 40 | | if let Some(ref property) = self.property { [INFO] [stderr] 41 | | let text = read_token.raw_string(range.length); [INFO] [stderr] 42 | | Ok((range, read_data( [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 39 | } else if let Some(ref property) = self.property { [INFO] [stderr] 40 | let text = read_token.raw_string(range.length); [INFO] [stderr] 41 | Ok((range, read_data( [INFO] [stderr] 42 | tokens, [INFO] [stderr] 43 | range.wrap( [INFO] [stderr] 44 | MetaData::String(property.clone(), Arc::new(text))), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/meta_rules/until_any_or_whitespace.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 41 | | if let Some(ref property) = self.property { [INFO] [stderr] 42 | | let text = read_token.raw_string(range.length); [INFO] [stderr] 43 | | Ok((range, read_data( [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 40 | } else if let Some(ref property) = self.property { [INFO] [stderr] 41 | let text = read_token.raw_string(range.length); [INFO] [stderr] 42 | Ok((range, read_data( [INFO] [stderr] 43 | tokens, [INFO] [stderr] 44 | range.wrap( [INFO] [stderr] 45 | MetaData::String(property.clone(), Arc::new(text))), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/meta_rules/fast_select.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 85 | | if let Some(ch) = read_token.src.chars().next() { [INFO] [stderr] 86 | | let mut buf = [0; 4]; [INFO] [stderr] 87 | | ch.encode_utf8(&mut buf); [INFO] [stderr] ... | [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 84 | } else if let Some(ch) = read_token.src.chars().next() { [INFO] [stderr] 85 | let mut buf = [0; 4]; [INFO] [stderr] 86 | ch.encode_utf8(&mut buf); [INFO] [stderr] 87 | let ind = self.table[buf[0] as usize]; [INFO] [stderr] 88 | if ind != 255 { [INFO] [stderr] 89 | let sub_rule = &self.args[ind as usize]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/optimize.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 67 | | if let Some(ch) = tag.text.chars().next() { [INFO] [stderr] 68 | | let mut buf = [0; 4]; [INFO] [stderr] 69 | | ch.encode_utf8(&mut buf); [INFO] [stderr] 70 | | Some(buf[0]) [INFO] [stderr] 71 | | } else {None} [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 66 | else if let Some(ch) = tag.text.chars().next() { [INFO] [stderr] 67 | let mut buf = [0; 4]; [INFO] [stderr] 68 | ch.encode_utf8(&mut buf); [INFO] [stderr] 69 | Some(buf[0]) [INFO] [stderr] 70 | } else {None} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/meta_rules/tag.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 64 | | if self.not { [INFO] [stderr] 65 | | match &self.property { [INFO] [stderr] 66 | | &Some(ref name) => { [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | } else if self.not { [INFO] [stderr] 64 | match &self.property { [INFO] [stderr] 65 | &Some(ref name) => { [INFO] [stderr] 66 | let range = read_token.start(); [INFO] [stderr] 67 | Ok((range, read_data( [INFO] [stderr] 68 | tokens, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/meta_rules/until_any.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 40 | | if let Some(ref property) = self.property { [INFO] [stderr] 41 | | let text = read_token.raw_string(range.length); [INFO] [stderr] 42 | | Ok((range, read_data( [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 39 | } else if let Some(ref property) = self.property { [INFO] [stderr] 40 | let text = read_token.raw_string(range.length); [INFO] [stderr] 41 | Ok((range, read_data( [INFO] [stderr] 42 | tokens, [INFO] [stderr] 43 | range.wrap( [INFO] [stderr] 44 | MetaData::String(property.clone(), Arc::new(text))), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/meta_rules/until_any_or_whitespace.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 41 | | if let Some(ref property) = self.property { [INFO] [stderr] 42 | | let text = read_token.raw_string(range.length); [INFO] [stderr] 43 | | Ok((range, read_data( [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 40 | } else if let Some(ref property) = self.property { [INFO] [stderr] 41 | let text = read_token.raw_string(range.length); [INFO] [stderr] 42 | Ok((range, read_data( [INFO] [stderr] 43 | tokens, [INFO] [stderr] 44 | range.wrap( [INFO] [stderr] 45 | MetaData::String(property.clone(), Arc::new(text))), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/meta_rules/fast_select.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 85 | | if let Some(ch) = read_token.src.chars().next() { [INFO] [stderr] 86 | | let mut buf = [0; 4]; [INFO] [stderr] 87 | | ch.encode_utf8(&mut buf); [INFO] [stderr] ... | [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 84 | } else if let Some(ch) = read_token.src.chars().next() { [INFO] [stderr] 85 | let mut buf = [0; 4]; [INFO] [stderr] 86 | ch.encode_utf8(&mut buf); [INFO] [stderr] 87 | let ind = self.table[buf[0] as usize]; [INFO] [stderr] 88 | if ind != 255 { [INFO] [stderr] 89 | let sub_rule = &self.args[ind as usize]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/optimize.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 67 | | if let Some(ch) = tag.text.chars().next() { [INFO] [stderr] 68 | | let mut buf = [0; 4]; [INFO] [stderr] 69 | | ch.encode_utf8(&mut buf); [INFO] [stderr] 70 | | Some(buf[0]) [INFO] [stderr] 71 | | } else {None} [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 66 | else if let Some(ch) = tag.text.chars().next() { [INFO] [stderr] 67 | let mut buf = [0; 4]; [INFO] [stderr] 68 | ch.encode_utf8(&mut buf); [INFO] [stderr] 69 | Some(buf[0]) [INFO] [stderr] 70 | } else {None} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bootstrap/convert.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if rhs.data.len() == 0 || self.offset <= rhs.offset { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rhs.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bootstrap/convert.rs:70:12 [INFO] [stderr] | [INFO] [stderr] 70 | if self.data.len() == 0 { return Err(()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/bootstrap/convert.rs:72:43 [INFO] [stderr] | [INFO] [stderr] 72 | MetaData::StartNode(ref n) if &**n == name => { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bootstrap/convert.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | if self.data.len() == 0 { return Err(()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/bootstrap/convert.rs:83:41 [INFO] [stderr] | [INFO] [stderr] 83 | MetaData::EndNode(ref n) if &**n == name => { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/bootstrap/convert.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | / match &item.data { [INFO] [stderr] 97 | | &MetaData::StartNode(_) => acc += 1, [INFO] [stderr] 98 | | &MetaData::EndNode(_) => acc -= 1, [INFO] [stderr] 99 | | _ => {} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 96 | match item.data { [INFO] [stderr] 97 | MetaData::StartNode(_) => acc += 1, [INFO] [stderr] 98 | MetaData::EndNode(_) => acc -= 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bootstrap/convert.rs:109:12 [INFO] [stderr] | [INFO] [stderr] 109 | if self.data.len() == 0 { return Err(()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/bootstrap/convert.rs:111:49 [INFO] [stderr] | [INFO] [stderr] 111 | MetaData::String(ref n, ref val) if &**n == name => { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bootstrap/convert.rs:120:12 [INFO] [stderr] | [INFO] [stderr] 120 | if self.data.len() == 0 { return Err(()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/bootstrap/convert.rs:122:46 [INFO] [stderr] | [INFO] [stderr] 122 | MetaData::F64(ref n, ref val) if &**n == name => { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bootstrap/convert.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | if self.data.len() == 0 { return Err(()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/bootstrap/convert.rs:133:47 [INFO] [stderr] | [INFO] [stderr] 133 | MetaData::Bool(ref n, ref val) if &**n == name => { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/bootstrap/convert.rs:148:8 [INFO] [stderr] | [INFO] [stderr] 148 | -> Result<(Range, (Arc, Arc)), ()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:185:21 [INFO] [stderr] | [INFO] [stderr] 185 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/bootstrap/convert.rs:213:44 [INFO] [stderr] | [INFO] [stderr] 213 | strings.iter().find(|&&(ref s, _)| &**s == val).map(|&(_, ref s)| s.clone()) [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:299:21 [INFO] [stderr] | [INFO] [stderr] 299 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:347:21 [INFO] [stderr] | [INFO] [stderr] 347 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:398:21 [INFO] [stderr] | [INFO] [stderr] 398 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:419:21 [INFO] [stderr] | [INFO] [stderr] 419 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:457:21 [INFO] [stderr] | [INFO] [stderr] 457 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:496:21 [INFO] [stderr] | [INFO] [stderr] 496 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:540:21 [INFO] [stderr] | [INFO] [stderr] 540 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:574:21 [INFO] [stderr] | [INFO] [stderr] 574 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:598:21 [INFO] [stderr] | [INFO] [stderr] 598 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:622:21 [INFO] [stderr] | [INFO] [stderr] 622 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:680:21 [INFO] [stderr] | [INFO] [stderr] 680 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:703:21 [INFO] [stderr] | [INFO] [stderr] 703 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:748:21 [INFO] [stderr] | [INFO] [stderr] 748 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:837:21 [INFO] [stderr] | [INFO] [stderr] 837 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/bootstrap/convert.rs:876:5 [INFO] [stderr] | [INFO] [stderr] 876 | / loop { [INFO] [stderr] 877 | | if let Ok((range, val)) = read_string(convert) { [INFO] [stderr] 878 | | strings.push(val); [INFO] [stderr] 879 | | convert.update(range); [INFO] [stderr] ... | [INFO] [stderr] 882 | | } [INFO] [stderr] 883 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok((range, val)) = read_string(convert) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/lines.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/lines.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | let mut state = state.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/node.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/node.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | state.clone() [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/node.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | state.clone() [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/not.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/not.rs:45:36 [INFO] [stderr] | [INFO] [stderr] 45 | Ok((start.start(), state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/number.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/number.rs:51:36 [INFO] [stderr] | [INFO] [stderr] 51 | Ok((range, state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/optional.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/optional.rs:37:33 [INFO] [stderr] | [INFO] [stderr] 37 | let mut success_state = state.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/optional.rs:47:40 [INFO] [stderr] | [INFO] [stderr] 47 | return (start.start(), state.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/repeat.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/repeat.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | let mut state = state.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/rule.rs:69:16 [INFO] [stderr] | [INFO] [stderr] 69 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/meta_rules/rule.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | / match self { [INFO] [stderr] 74 | | &Rule::Whitespace(ref w) => { [INFO] [stderr] 75 | | w.parse(read_token).map(|r| (r, state.clone(), None)) [INFO] [stderr] 76 | | } [INFO] [stderr] ... | [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 73 | match *self { [INFO] [stderr] 74 | Rule::Whitespace(ref w) => { [INFO] [stderr] 75 | w.parse(read_token).map(|r| (r, state.clone(), None)) [INFO] [stderr] 76 | } [INFO] [stderr] 77 | Rule::Tag(ref t) => { [INFO] [stderr] 78 | t.parse(tokens, state, read_token) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/rule.rs:75:49 [INFO] [stderr] | [INFO] [stderr] 75 | w.parse(read_token).map(|r| (r, state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/meta_rules/rule.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / match self { [INFO] [stderr] 128 | | &mut Rule::Node(ref mut p) => { [INFO] [stderr] 129 | | match p.index { [INFO] [stderr] 130 | | None => { [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | match *self { [INFO] [stderr] 128 | Rule::Node(ref mut p) => { [INFO] [stderr] 129 | match p.index { [INFO] [stderr] 130 | None => { [INFO] [stderr] 131 | // Look through references and update if correct name [INFO] [stderr] 132 | // is found. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/meta_rules/rule.rs:135:32 [INFO] [stderr] | [INFO] [stderr] 135 | if &**p.name == &**r { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 135 | if **p.name == **r { [INFO] [stderr] | ^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/select.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/separate_by.rs:37:16 [INFO] [stderr] | [INFO] [stderr] 37 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/separate_by.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | let mut state = state.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/sequence.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/sequence.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | let mut state = state.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/text.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/text.rs:53:40 [INFO] [stderr] | [INFO] [stderr] 53 | Ok((range, state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/tag.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/meta_rules/tag.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | / match &self.property { [INFO] [stderr] 50 | | &Some(ref name) => { [INFO] [stderr] 51 | | Ok((range, read_data( [INFO] [stderr] 52 | | tokens, [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 49 | match self.property { [INFO] [stderr] 50 | Some(ref name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/tag.rs:59:36 [INFO] [stderr] | [INFO] [stderr] 59 | Ok((range, state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/meta_rules/tag.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | / match &self.property { [INFO] [stderr] 66 | | &Some(ref name) => { [INFO] [stderr] 67 | | let range = read_token.start(); [INFO] [stderr] 68 | | Ok((range, read_data( [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 65 | match self.property { [INFO] [stderr] 66 | Some(ref name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/tag.rs:76:49 [INFO] [stderr] | [INFO] [stderr] 76 | Ok((read_token.start(), state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/until_any.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/until_any.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | Ok((range, state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/until_any_or_whitespace.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/until_any_or_whitespace.rs:50:28 [INFO] [stderr] | [INFO] [stderr] 50 | Ok((range, state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/fast_select.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/meta_rules/mod.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / if let &mut Some(ref mut opt_error) = opt_error { [INFO] [stderr] 129 | | if let Some(err) = err { [INFO] [stderr] 130 | | if opt_error.next_offset() <= err.next_offset() { [INFO] [stderr] 131 | | *opt_error = err; [INFO] [stderr] ... | [INFO] [stderr] 135 | | *opt_error = err; [INFO] [stderr] 136 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(ref mut opt_error) = *opt_error { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tokenizer.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | state: &TokenizerState [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tokenizer::TokenizerState` [INFO] [stderr] --> src/tokenizer.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn new() -> TokenizerState { TokenizerState(0) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parse_error.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match self { [INFO] [stderr] 44 | | &ParseError::ExpectedWhitespace(debug_id) => [INFO] [stderr] 45 | | try!(write!(fmt, "#{}, Expected whitespace", [INFO] [stderr] 46 | | debug_id)), [INFO] [stderr] ... | [INFO] [stderr] 76 | | try!(write!(fmt, "Conversion, {}", msg)), [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *self { [INFO] [stderr] 44 | ParseError::ExpectedWhitespace(debug_id) => [INFO] [stderr] 45 | try!(write!(fmt, "#{}, Expected whitespace", [INFO] [stderr] 46 | debug_id)), [INFO] [stderr] 47 | ParseError::ExpectedNewLine(debug_id) => [INFO] [stderr] 48 | try!(write!(fmt, "#{}, Expected new line", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/parse_error_handler.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / if let &ParseError::ExpectedTag(_, _) = &error { [INFO] [stderr] 105 | | // Improves the error report when forgetting a token at end of [INFO] [stderr] 106 | | // a line, for example `;` after an expression. [INFO] [stderr] 107 | | if let Some(first_line) = first_line(self, range) { [INFO] [stderr] ... | [INFO] [stderr] 120 | | } [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 104 | if let ParseError::ExpectedTag(_, _) = error { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parse_error_handler.rs:113:34 [INFO] [stderr] | [INFO] [stderr] 113 | .all(|c| { c.is_whitespace() }) { break; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/optimize.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | if seq.args.len() == 0 {None} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `seq.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Syntax` [INFO] [stderr] --> src/lib.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | / pub fn new() -> Syntax { [INFO] [stderr] 186 | | Syntax { [INFO] [stderr] 187 | | rules: vec![], [INFO] [stderr] 188 | | names: vec![] [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 176 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | format!("Bootstrapping rules are incorrect")))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Bootstrapping rules are incorrect".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bootstrap/convert.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if rhs.data.len() == 0 || self.offset <= rhs.offset { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rhs.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bootstrap/convert.rs:70:12 [INFO] [stderr] | [INFO] [stderr] 70 | if self.data.len() == 0 { return Err(()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/bootstrap/convert.rs:72:43 [INFO] [stderr] | [INFO] [stderr] 72 | MetaData::StartNode(ref n) if &**n == name => { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bootstrap/convert.rs:81:12 [INFO] [stderr] | [INFO] [stderr] 81 | if self.data.len() == 0 { return Err(()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/bootstrap/convert.rs:83:41 [INFO] [stderr] | [INFO] [stderr] 83 | MetaData::EndNode(ref n) if &**n == name => { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/bootstrap/convert.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | / match &item.data { [INFO] [stderr] 97 | | &MetaData::StartNode(_) => acc += 1, [INFO] [stderr] 98 | | &MetaData::EndNode(_) => acc -= 1, [INFO] [stderr] 99 | | _ => {} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 96 | match item.data { [INFO] [stderr] 97 | MetaData::StartNode(_) => acc += 1, [INFO] [stderr] 98 | MetaData::EndNode(_) => acc -= 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bootstrap/convert.rs:109:12 [INFO] [stderr] | [INFO] [stderr] 109 | if self.data.len() == 0 { return Err(()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/bootstrap/convert.rs:111:49 [INFO] [stderr] | [INFO] [stderr] 111 | MetaData::String(ref n, ref val) if &**n == name => { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bootstrap/convert.rs:120:12 [INFO] [stderr] | [INFO] [stderr] 120 | if self.data.len() == 0 { return Err(()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/bootstrap/convert.rs:122:46 [INFO] [stderr] | [INFO] [stderr] 122 | MetaData::F64(ref n, ref val) if &**n == name => { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bootstrap/convert.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | if self.data.len() == 0 { return Err(()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/bootstrap/convert.rs:133:47 [INFO] [stderr] | [INFO] [stderr] 133 | MetaData::Bool(ref n, ref val) if &**n == name => { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/bootstrap/convert.rs:148:8 [INFO] [stderr] | [INFO] [stderr] 148 | -> Result<(Range, (Arc, Arc)), ()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:185:21 [INFO] [stderr] | [INFO] [stderr] 185 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/bootstrap/convert.rs:213:44 [INFO] [stderr] | [INFO] [stderr] 213 | strings.iter().find(|&&(ref s, _)| &**s == val).map(|&(_, ref s)| s.clone()) [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:251:21 [INFO] [stderr] | [INFO] [stderr] 251 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:299:21 [INFO] [stderr] | [INFO] [stderr] 299 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:347:21 [INFO] [stderr] | [INFO] [stderr] 347 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:398:21 [INFO] [stderr] | [INFO] [stderr] 398 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:419:21 [INFO] [stderr] | [INFO] [stderr] 419 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:457:21 [INFO] [stderr] | [INFO] [stderr] 457 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:496:21 [INFO] [stderr] | [INFO] [stderr] 496 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:540:21 [INFO] [stderr] | [INFO] [stderr] 540 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:574:21 [INFO] [stderr] | [INFO] [stderr] 574 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:598:21 [INFO] [stderr] | [INFO] [stderr] 598 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:622:21 [INFO] [stderr] | [INFO] [stderr] 622 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:680:21 [INFO] [stderr] | [INFO] [stderr] 680 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:703:21 [INFO] [stderr] | [INFO] [stderr] 703 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:748:21 [INFO] [stderr] | [INFO] [stderr] 748 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bootstrap/convert.rs:837:21 [INFO] [stderr] | [INFO] [stderr] 837 | let start = convert.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `convert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/bootstrap/convert.rs:876:5 [INFO] [stderr] | [INFO] [stderr] 876 | / loop { [INFO] [stderr] 877 | | if let Ok((range, val)) = read_string(convert) { [INFO] [stderr] 878 | | strings.push(val); [INFO] [stderr] 879 | | convert.update(range); [INFO] [stderr] ... | [INFO] [stderr] 882 | | } [INFO] [stderr] 883 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok((range, val)) = read_string(convert) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/lines.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/lines.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | let mut state = state.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/node.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/node.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | state.clone() [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/node.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | state.clone() [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/meta_rules/node.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | let foo: Arc = Arc::new("foo".into()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/not.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/not.rs:45:36 [INFO] [stderr] | [INFO] [stderr] 45 | Ok((start.start(), state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/number.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/number.rs:51:36 [INFO] [stderr] | [INFO] [stderr] 51 | Ok((range, state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/optional.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/optional.rs:37:33 [INFO] [stderr] | [INFO] [stderr] 37 | let mut success_state = state.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/optional.rs:47:40 [INFO] [stderr] | [INFO] [stderr] 47 | return (start.start(), state.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/repeat.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/repeat.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | let mut state = state.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/rule.rs:69:16 [INFO] [stderr] | [INFO] [stderr] 69 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/meta_rules/rule.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | / match self { [INFO] [stderr] 74 | | &Rule::Whitespace(ref w) => { [INFO] [stderr] 75 | | w.parse(read_token).map(|r| (r, state.clone(), None)) [INFO] [stderr] 76 | | } [INFO] [stderr] ... | [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 73 | match *self { [INFO] [stderr] 74 | Rule::Whitespace(ref w) => { [INFO] [stderr] 75 | w.parse(read_token).map(|r| (r, state.clone(), None)) [INFO] [stderr] 76 | } [INFO] [stderr] 77 | Rule::Tag(ref t) => { [INFO] [stderr] 78 | t.parse(tokens, state, read_token) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/rule.rs:75:49 [INFO] [stderr] | [INFO] [stderr] 75 | w.parse(read_token).map(|r| (r, state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/meta_rules/rule.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / match self { [INFO] [stderr] 128 | | &mut Rule::Node(ref mut p) => { [INFO] [stderr] 129 | | match p.index { [INFO] [stderr] 130 | | None => { [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | match *self { [INFO] [stderr] 128 | Rule::Node(ref mut p) => { [INFO] [stderr] 129 | match p.index { [INFO] [stderr] 130 | None => { [INFO] [stderr] 131 | // Look through references and update if correct name [INFO] [stderr] 132 | // is found. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/meta_rules/rule.rs:135:32 [INFO] [stderr] | [INFO] [stderr] 135 | if &**p.name == &**r { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 135 | if **p.name == **r { [INFO] [stderr] | ^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/select.rs:30:16 [INFO] [stderr] | [INFO] [stderr] 30 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/meta_rules/select.rs:74:28 [INFO] [stderr] | [INFO] [stderr] 74 | let invalid_rule = match &res { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 75 | | &Err(ref range_err) => { [INFO] [stderr] 76 | | match range_err.data { [INFO] [stderr] 77 | | ParseError::InvalidRule(_, _) => true, [INFO] [stderr] ... | [INFO] [stderr] 81 | | _ => false [INFO] [stderr] 82 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 74 | let invalid_rule = match res { [INFO] [stderr] 75 | Err(ref range_err) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/separate_by.rs:37:16 [INFO] [stderr] | [INFO] [stderr] 37 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/separate_by.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | let mut state = state.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/sequence.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/sequence.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | let mut state = state.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/text.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/text.rs:53:40 [INFO] [stderr] | [INFO] [stderr] 53 | Ok((range, state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/meta_rules/text.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | let foo: Arc = Arc::new("foo".into()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/tag.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/meta_rules/tag.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | / match &self.property { [INFO] [stderr] 50 | | &Some(ref name) => { [INFO] [stderr] 51 | | Ok((range, read_data( [INFO] [stderr] 52 | | tokens, [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 49 | match self.property { [INFO] [stderr] 50 | Some(ref name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/tag.rs:59:36 [INFO] [stderr] | [INFO] [stderr] 59 | Ok((range, state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/meta_rules/tag.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | / match &self.property { [INFO] [stderr] 66 | | &Some(ref name) => { [INFO] [stderr] 67 | | let range = read_token.start(); [INFO] [stderr] 68 | | Ok((range, read_data( [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 65 | match self.property { [INFO] [stderr] 66 | Some(ref name) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/tag.rs:76:49 [INFO] [stderr] | [INFO] [stderr] 76 | Ok((read_token.start(), state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/until_any.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/until_any.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | Ok((range, state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] error: Could not compile `piston_meta`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/until_any_or_whitespace.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/meta_rules/until_any_or_whitespace.rs:50:28 [INFO] [stderr] | [INFO] [stderr] 50 | Ok((range, state.clone(), None)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/meta_rules/fast_select.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | state: &TokenizerState, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/meta_rules/mod.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / if let &mut Some(ref mut opt_error) = opt_error { [INFO] [stderr] 129 | | if let Some(err) = err { [INFO] [stderr] 130 | | if opt_error.next_offset() <= err.next_offset() { [INFO] [stderr] 131 | | *opt_error = err; [INFO] [stderr] ... | [INFO] [stderr] 135 | | *opt_error = err; [INFO] [stderr] 136 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(ref mut opt_error) = *opt_error { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tokenizer.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | state: &TokenizerState [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `TokenizerState` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tokenizer::TokenizerState` [INFO] [stderr] --> src/tokenizer.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn new() -> TokenizerState { TokenizerState(0) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parse_error.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match self { [INFO] [stderr] 44 | | &ParseError::ExpectedWhitespace(debug_id) => [INFO] [stderr] 45 | | try!(write!(fmt, "#{}, Expected whitespace", [INFO] [stderr] 46 | | debug_id)), [INFO] [stderr] ... | [INFO] [stderr] 76 | | try!(write!(fmt, "Conversion, {}", msg)), [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *self { [INFO] [stderr] 44 | ParseError::ExpectedWhitespace(debug_id) => [INFO] [stderr] 45 | try!(write!(fmt, "#{}, Expected whitespace", [INFO] [stderr] 46 | debug_id)), [INFO] [stderr] 47 | ParseError::ExpectedNewLine(debug_id) => [INFO] [stderr] 48 | try!(write!(fmt, "#{}, Expected new line", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/parse_error_handler.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / if let &ParseError::ExpectedTag(_, _) = &error { [INFO] [stderr] 105 | | // Improves the error report when forgetting a token at end of [INFO] [stderr] 106 | | // a line, for example `;` after an expression. [INFO] [stderr] 107 | | if let Some(first_line) = first_line(self, range) { [INFO] [stderr] ... | [INFO] [stderr] 120 | | } [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 104 | if let ParseError::ExpectedTag(_, _) = error { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parse_error_handler.rs:113:34 [INFO] [stderr] | [INFO] [stderr] 113 | .all(|c| { c.is_whitespace() }) { break; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/optimize.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | if seq.args.len() == 0 {None} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `seq.args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `table` [INFO] [stderr] --> src/optimize.rs:210:18 [INFO] [stderr] | [INFO] [stderr] 210 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 210 | for (i, ) in table.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `table` [INFO] [stderr] --> src/optimize.rs:227:18 [INFO] [stderr] | [INFO] [stderr] 227 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 227 | for (i, ) in table.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `table`. [INFO] [stderr] --> src/optimize.rs:245:18 [INFO] [stderr] | [INFO] [stderr] 245 | for i in 0..256 {assert_eq!(table[i], 255)} [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 245 | for in &table {assert_eq!(table[i], 255)} [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Syntax` [INFO] [stderr] --> src/lib.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | / pub fn new() -> Syntax { [INFO] [stderr] 186 | | Syntax { [INFO] [stderr] 187 | | rules: vec![], [INFO] [stderr] 188 | | names: vec![] [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 176 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | format!("Bootstrapping rules are incorrect")))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Bootstrapping rules are incorrect".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "a259921bee4bff42084d3105e0394d9ca8be5ca473639a26922c067d6b1a8611"` [INFO] running `"docker" "rm" "-f" "a259921bee4bff42084d3105e0394d9ca8be5ca473639a26922c067d6b1a8611"` [INFO] [stdout] a259921bee4bff42084d3105e0394d9ca8be5ca473639a26922c067d6b1a8611