[INFO] crate piston3d-gfx_voxel 0.26.0 is already in cache [INFO] extracting crate piston3d-gfx_voxel 0.26.0 into work/ex/clippy-test-run/sources/stable/reg/piston3d-gfx_voxel/0.26.0 [INFO] extracting crate piston3d-gfx_voxel 0.26.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston3d-gfx_voxel/0.26.0 [INFO] validating manifest of piston3d-gfx_voxel-0.26.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of piston3d-gfx_voxel-0.26.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing piston3d-gfx_voxel-0.26.0 [INFO] finished frobbing piston3d-gfx_voxel-0.26.0 [INFO] frobbed toml for piston3d-gfx_voxel-0.26.0 written to work/ex/clippy-test-run/sources/stable/reg/piston3d-gfx_voxel/0.26.0/Cargo.toml [INFO] started frobbing piston3d-gfx_voxel-0.26.0 [INFO] finished frobbing piston3d-gfx_voxel-0.26.0 [INFO] frobbed toml for piston3d-gfx_voxel-0.26.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston3d-gfx_voxel/0.26.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting piston3d-gfx_voxel-0.26.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/piston3d-gfx_voxel/0.26.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 62c4633f2b188bce0ece210caf2e74de20efd56419b93e01cd560bd1d4f7f405 [INFO] running `"docker" "start" "-a" "62c4633f2b188bce0ece210caf2e74de20efd56419b93e01cd560bd1d4f7f405"` [INFO] [stderr] Checking array v0.0.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking piston3d-gfx_voxel v0.26.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | unit_width: unit_width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | unit_height: unit_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | unit_width: unit_width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/texture.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | unit_height: unit_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cube.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | pub const QUADS: &'static [[usize; 4]; 6] = &[ [INFO] [stderr] | -^^^^^^^---------------- help: consider removing `'static`: `&[[usize; 4]; 6]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cube.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | pub const VERTICES: &'static [Vector3; 8] = &[ [INFO] [stderr] | -^^^^^^^------------------ help: consider removing `'static`: `&[Vector3; 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/texture.rs:174:12 [INFO] [stderr] | [INFO] [stderr] 174 | if self.position >= size * 2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 174 | if self.position > size * 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cube.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | pub const QUADS: &'static [[usize; 4]; 6] = &[ [INFO] [stderr] | -^^^^^^^---------------- help: consider removing `'static`: `&[[usize; 4]; 6]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cube.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | pub const VERTICES: &'static [Vector3; 8] = &[ [INFO] [stderr] | -^^^^^^^------------------ help: consider removing `'static`: `&[Vector3; 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/texture.rs:174:12 [INFO] [stderr] | [INFO] [stderr] 174 | if self.position >= size * 2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 174 | if self.position > size * 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cube::FaceIterator` [INFO] [stderr] --> src/cube.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / pub fn new() -> Self { [INFO] [stderr] 162 | | FaceIterator(0) [INFO] [stderr] 163 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 157 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:86:36 [INFO] [stderr] | [INFO] [stderr] 86 | let col = self.0.get_pixel(x as u32, y as u32).channels(); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:86:46 [INFO] [stderr] | [INFO] [stderr] 86 | let col = self.0.get_pixel(x as u32, y as u32).channels(); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cube::FaceIterator` [INFO] [stderr] --> src/cube.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | / pub fn new() -> Self { [INFO] [stderr] 162 | | FaceIterator(0) [INFO] [stderr] 163 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 157 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:86:36 [INFO] [stderr] | [INFO] [stderr] 86 | let col = self.0.get_pixel(x as u32, y as u32).channels(); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:86:46 [INFO] [stderr] | [INFO] [stderr] 86 | let col = self.0.get_pixel(x as u32, y as u32).channels(); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.82s [INFO] running `"docker" "inspect" "62c4633f2b188bce0ece210caf2e74de20efd56419b93e01cd560bd1d4f7f405"` [INFO] running `"docker" "rm" "-f" "62c4633f2b188bce0ece210caf2e74de20efd56419b93e01cd560bd1d4f7f405"` [INFO] [stdout] 62c4633f2b188bce0ece210caf2e74de20efd56419b93e01cd560bd1d4f7f405