[INFO] crate piston2d-sprite 0.47.0 is already in cache [INFO] extracting crate piston2d-sprite 0.47.0 into work/ex/clippy-test-run/sources/stable/reg/piston2d-sprite/0.47.0 [INFO] extracting crate piston2d-sprite 0.47.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston2d-sprite/0.47.0 [INFO] validating manifest of piston2d-sprite-0.47.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of piston2d-sprite-0.47.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing piston2d-sprite-0.47.0 [INFO] finished frobbing piston2d-sprite-0.47.0 [INFO] frobbed toml for piston2d-sprite-0.47.0 written to work/ex/clippy-test-run/sources/stable/reg/piston2d-sprite/0.47.0/Cargo.toml [INFO] started frobbing piston2d-sprite-0.47.0 [INFO] finished frobbing piston2d-sprite-0.47.0 [INFO] frobbed toml for piston2d-sprite-0.47.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston2d-sprite/0.47.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting piston2d-sprite-0.47.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/piston2d-sprite/0.47.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ad220340c2a58604459284d9c9906c0ab32ef88fab5c1a8a0397a1bbed870f6f [INFO] running `"docker" "start" "-a" "ad220340c2a58604459284d9c9906c0ab32ef88fab5c1a8a0397a1bbed870f6f"` [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Checking piston-ai_behavior v0.26.0 [INFO] [stderr] Checking piston2d-sprite v0.47.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/animation.rs:221:37 [INFO] [stderr] | [INFO] [stderr] 221 | Rotate(t, b, c, d) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/animation.rs:229:35 [INFO] [stderr] | [INFO] [stderr] 229 | Fade(t, b, c, d) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sprite.rs:370:21 [INFO] [stderr] | [INFO] [stderr] 370 | let (w, h) = (tex_w, tex_h); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/animation.rs:221:37 [INFO] [stderr] | [INFO] [stderr] 221 | Rotate(t, b, c, d) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/animation.rs:229:35 [INFO] [stderr] | [INFO] [stderr] 229 | Fade(t, b, c, d) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sprite.rs:370:21 [INFO] [stderr] | [INFO] [stderr] 370 | let (w, h) = (tex_w, tex_h); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/scene.rs:198:16 [INFO] [stderr] | [INFO] [stderr] 198 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 199 | | if self.child(sprite_id).is_some() { [INFO] [stderr] 200 | | Some(0) [INFO] [stderr] 201 | | } else { [INFO] [stderr] 202 | | None [INFO] [stderr] 203 | | } [INFO] [stderr] 204 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 198 | } else if self.child(sprite_id).is_some() { [INFO] [stderr] 199 | Some(0) [INFO] [stderr] 200 | } else { [INFO] [stderr] 201 | None [INFO] [stderr] 202 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/scene.rs:198:16 [INFO] [stderr] | [INFO] [stderr] 198 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 199 | | if self.child(sprite_id).is_some() { [INFO] [stderr] 200 | | Some(0) [INFO] [stderr] 201 | | } else { [INFO] [stderr] 202 | | None [INFO] [stderr] 203 | | } [INFO] [stderr] 204 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 198 | } else if self.child(sprite_id).is_some() { [INFO] [stderr] 199 | Some(0) [INFO] [stderr] 200 | } else { [INFO] [stderr] 201 | None [INFO] [stderr] 202 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/animation.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | let b = sprite.get_opacity() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(sprite.get_opacity())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/animation.rs:127:25 [INFO] [stderr] | [INFO] [stderr] 127 | let b = sprite.get_opacity() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(sprite.get_opacity())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/animation.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | let b = sprite.get_opacity() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(sprite.get_opacity())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/animation.rs:254:1 [INFO] [stderr] | [INFO] [stderr] 254 | / fn update_position( [INFO] [stderr] 255 | | sprite: &mut Sprite, [INFO] [stderr] 256 | | factor: f64, [INFO] [stderr] 257 | | t: f64, [INFO] [stderr] ... | [INFO] [stderr] 271 | | } [INFO] [stderr] 272 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/animation.rs:292:1 [INFO] [stderr] | [INFO] [stderr] 292 | / fn update_scale( [INFO] [stderr] 293 | | sprite: &mut Sprite, [INFO] [stderr] 294 | | factor: f64, [INFO] [stderr] 295 | | t: f64, [INFO] [stderr] ... | [INFO] [stderr] 309 | | } [INFO] [stderr] 310 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/scene.rs:25:14 [INFO] [stderr] | [INFO] [stderr] 25 | running: HashMap, State, bool)>>, [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `scene::Scene` [INFO] [stderr] --> src/scene.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Scene { [INFO] [stderr] 34 | | Scene { [INFO] [stderr] 35 | | children: Vec::new(), [INFO] [stderr] 36 | | children_index: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scene.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | / match status { [INFO] [stderr] 72 | | // the behavior is still running, add it for next update [INFO] [stderr] 73 | | Running => { [INFO] [stderr] 74 | | new_animations.push((b, a, paused)); [INFO] [stderr] 75 | | }, [INFO] [stderr] 76 | | _ => {}, [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | if let Running = status { [INFO] [stderr] 72 | new_animations.push((b, a, paused)); [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/scene.rs:187:32 [INFO] [stderr] | [INFO] [stderr] 187 | for (_, animations) in &self.running { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 187 | for animations in self.running.values() { [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scene.rs:211:36 [INFO] [stderr] | [INFO] [stderr] 211 | self.children_index.insert(id.clone(), self.children.len() - 1); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scene.rs:236:53 [INFO] [stderr] | [INFO] [stderr] 236 | if let Some(c) = child.remove_child(id.clone()) { [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scene.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | / match self.running_for_child(id) { [INFO] [stderr] 257 | | Some(n) => { [INFO] [stderr] 258 | | if n == 0 { [INFO] [stderr] 259 | | self.remove_child(id); [INFO] [stderr] ... | [INFO] [stderr] 264 | | None => {} [INFO] [stderr] 265 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 256 | if let Some(n) = self.running_for_child(id) { [INFO] [stderr] 257 | if n == 0 { [INFO] [stderr] 258 | self.remove_child(id); [INFO] [stderr] 259 | } else { [INFO] [stderr] 260 | self.dead_sprites.insert(id); [INFO] [stderr] 261 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scene.rs:274:46 [INFO] [stderr] | [INFO] [stderr] 274 | if let Some(c) = child.child(id.clone()) { [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scene.rs:288:50 [INFO] [stderr] | [INFO] [stderr] 288 | if let Some(c) = child.child_mut(id.clone()) { [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sprite.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | self.id.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sprite.rs:249:36 [INFO] [stderr] | [INFO] [stderr] 249 | self.children_index.insert(id.clone(), self.children.len() - 1); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sprite.rs:266:53 [INFO] [stderr] | [INFO] [stderr] 266 | if let Some(c) = child.remove_child(id.clone()) { [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sprite.rs:280:46 [INFO] [stderr] | [INFO] [stderr] 280 | if let Some(c) = child.child(id.clone()) { [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sprite.rs:294:50 [INFO] [stderr] | [INFO] [stderr] 294 | if let Some(c) = child.child_mut(id.clone()) { [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sprite.rs:317:21 [INFO] [stderr] | [INFO] [stderr] 317 | let tex_w = tex_w as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(tex_w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sprite.rs:318:21 [INFO] [stderr] | [INFO] [stderr] 318 | let tex_h = tex_h as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(tex_h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/sprite.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | let ref draw_state: graphics::DrawState = Default::default(); [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------------------------- help: try: `let draw_state: &graphics::DrawState = &Default::default();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sprite.rs:367:21 [INFO] [stderr] | [INFO] [stderr] 367 | let tex_w = tex_w as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(tex_w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sprite.rs:368:21 [INFO] [stderr] | [INFO] [stderr] 368 | let tex_h = tex_h as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(tex_h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/sprite.rs:389:13 [INFO] [stderr] | [INFO] [stderr] 389 | let ref draw_state: graphics::DrawState = Default::default(); [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------------------------- help: try: `let draw_state: &graphics::DrawState = &Default::default();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sprite.rs:414:24 [INFO] [stderr] | [INFO] [stderr] 414 | [0.0, 0.0, sprite_w as f64, sprite_h as f64] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(sprite_w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sprite.rs:414:41 [INFO] [stderr] | [INFO] [stderr] 414 | [0.0, 0.0, sprite_w as f64, sprite_h as f64] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(sprite_h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/animation.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | let b = sprite.get_opacity() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(sprite.get_opacity())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/animation.rs:127:25 [INFO] [stderr] | [INFO] [stderr] 127 | let b = sprite.get_opacity() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(sprite.get_opacity())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/animation.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | let b = sprite.get_opacity() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(sprite.get_opacity())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/animation.rs:254:1 [INFO] [stderr] | [INFO] [stderr] 254 | / fn update_position( [INFO] [stderr] 255 | | sprite: &mut Sprite, [INFO] [stderr] 256 | | factor: f64, [INFO] [stderr] 257 | | t: f64, [INFO] [stderr] ... | [INFO] [stderr] 271 | | } [INFO] [stderr] 272 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/animation.rs:292:1 [INFO] [stderr] | [INFO] [stderr] 292 | / fn update_scale( [INFO] [stderr] 293 | | sprite: &mut Sprite, [INFO] [stderr] 294 | | factor: f64, [INFO] [stderr] 295 | | t: f64, [INFO] [stderr] ... | [INFO] [stderr] 309 | | } [INFO] [stderr] 310 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/scene.rs:25:14 [INFO] [stderr] | [INFO] [stderr] 25 | running: HashMap, State, bool)>>, [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `scene::Scene` [INFO] [stderr] --> src/scene.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Scene { [INFO] [stderr] 34 | | Scene { [INFO] [stderr] 35 | | children: Vec::new(), [INFO] [stderr] 36 | | children_index: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scene.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | / match status { [INFO] [stderr] 72 | | // the behavior is still running, add it for next update [INFO] [stderr] 73 | | Running => { [INFO] [stderr] 74 | | new_animations.push((b, a, paused)); [INFO] [stderr] 75 | | }, [INFO] [stderr] 76 | | _ => {}, [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | if let Running = status { [INFO] [stderr] 72 | new_animations.push((b, a, paused)); [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/scene.rs:187:32 [INFO] [stderr] | [INFO] [stderr] 187 | for (_, animations) in &self.running { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 187 | for animations in self.running.values() { [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scene.rs:211:36 [INFO] [stderr] | [INFO] [stderr] 211 | self.children_index.insert(id.clone(), self.children.len() - 1); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scene.rs:236:53 [INFO] [stderr] | [INFO] [stderr] 236 | if let Some(c) = child.remove_child(id.clone()) { [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scene.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | / match self.running_for_child(id) { [INFO] [stderr] 257 | | Some(n) => { [INFO] [stderr] 258 | | if n == 0 { [INFO] [stderr] 259 | | self.remove_child(id); [INFO] [stderr] ... | [INFO] [stderr] 264 | | None => {} [INFO] [stderr] 265 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 256 | if let Some(n) = self.running_for_child(id) { [INFO] [stderr] 257 | if n == 0 { [INFO] [stderr] 258 | self.remove_child(id); [INFO] [stderr] 259 | } else { [INFO] [stderr] 260 | self.dead_sprites.insert(id); [INFO] [stderr] 261 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scene.rs:274:46 [INFO] [stderr] | [INFO] [stderr] 274 | if let Some(c) = child.child(id.clone()) { [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scene.rs:288:50 [INFO] [stderr] | [INFO] [stderr] 288 | if let Some(c) = child.child_mut(id.clone()) { [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sprite.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | self.id.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sprite.rs:249:36 [INFO] [stderr] | [INFO] [stderr] 249 | self.children_index.insert(id.clone(), self.children.len() - 1); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sprite.rs:266:53 [INFO] [stderr] | [INFO] [stderr] 266 | if let Some(c) = child.remove_child(id.clone()) { [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sprite.rs:280:46 [INFO] [stderr] | [INFO] [stderr] 280 | if let Some(c) = child.child(id.clone()) { [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sprite.rs:294:50 [INFO] [stderr] | [INFO] [stderr] 294 | if let Some(c) = child.child_mut(id.clone()) { [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sprite.rs:317:21 [INFO] [stderr] | [INFO] [stderr] 317 | let tex_w = tex_w as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(tex_w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sprite.rs:318:21 [INFO] [stderr] | [INFO] [stderr] 318 | let tex_h = tex_h as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(tex_h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/sprite.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | let ref draw_state: graphics::DrawState = Default::default(); [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------------------------- help: try: `let draw_state: &graphics::DrawState = &Default::default();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sprite.rs:367:21 [INFO] [stderr] | [INFO] [stderr] 367 | let tex_w = tex_w as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(tex_w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sprite.rs:368:21 [INFO] [stderr] | [INFO] [stderr] 368 | let tex_h = tex_h as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(tex_h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/sprite.rs:389:13 [INFO] [stderr] | [INFO] [stderr] 389 | let ref draw_state: graphics::DrawState = Default::default(); [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------------------------- help: try: `let draw_state: &graphics::DrawState = &Default::default();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sprite.rs:414:24 [INFO] [stderr] | [INFO] [stderr] 414 | [0.0, 0.0, sprite_w as f64, sprite_h as f64] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(sprite_w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sprite.rs:414:41 [INFO] [stderr] | [INFO] [stderr] 414 | [0.0, 0.0, sprite_w as f64, sprite_h as f64] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(sprite_h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `FakeTexture` [INFO] [stderr] --> tests/fake_texture.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn new() -> Self { FakeTexture } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.20s [INFO] running `"docker" "inspect" "ad220340c2a58604459284d9c9906c0ab32ef88fab5c1a8a0397a1bbed870f6f"` [INFO] running `"docker" "rm" "-f" "ad220340c2a58604459284d9c9906c0ab32ef88fab5c1a8a0397a1bbed870f6f"` [INFO] [stdout] ad220340c2a58604459284d9c9906c0ab32ef88fab5c1a8a0397a1bbed870f6f