[INFO] crate piston2d-graphics_tree 0.19.0 is already in cache [INFO] extracting crate piston2d-graphics_tree 0.19.0 into work/ex/clippy-test-run/sources/stable/reg/piston2d-graphics_tree/0.19.0 [INFO] extracting crate piston2d-graphics_tree 0.19.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston2d-graphics_tree/0.19.0 [INFO] validating manifest of piston2d-graphics_tree-0.19.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of piston2d-graphics_tree-0.19.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing piston2d-graphics_tree-0.19.0 [INFO] finished frobbing piston2d-graphics_tree-0.19.0 [INFO] frobbed toml for piston2d-graphics_tree-0.19.0 written to work/ex/clippy-test-run/sources/stable/reg/piston2d-graphics_tree/0.19.0/Cargo.toml [INFO] started frobbing piston2d-graphics_tree-0.19.0 [INFO] finished frobbing piston2d-graphics_tree-0.19.0 [INFO] frobbed toml for piston2d-graphics_tree-0.19.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston2d-graphics_tree/0.19.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting piston2d-graphics_tree-0.19.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/piston2d-graphics_tree/0.19.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 79675986114a20fe78344ef0f7809d7fcecdc5a5e50067891b462d10cd33ce6b [INFO] running `"docker" "start" "-a" "79675986114a20fe78344ef0f7809d7fcecdc5a5e50067891b462d10cd33ce6b"` [INFO] [stderr] Checking fps_counter v1.0.0 [INFO] [stderr] Compiling wayland-scanner v0.21.11 [INFO] [stderr] Compiling num-derive v0.2.4 [INFO] [stderr] Checking wayland-sys v0.21.11 [INFO] [stderr] Checking andrew v0.1.6 [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking pistoncore-input v0.23.0 [INFO] [stderr] Checking wayland-commons v0.21.11 [INFO] [stderr] Compiling wayland-client v0.21.11 [INFO] [stderr] Compiling wayland-protocols v0.21.11 [INFO] [stderr] Checking pistoncore-window v0.34.0 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking pistoncore-event_loop v0.39.0 [INFO] [stderr] Checking piston v0.39.0 [INFO] [stderr] Checking piston2d-graphics_tree v0.19.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | image: image [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | factory: factory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `factory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Checking smithay-client-toolkit v0.4.4 [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `GraphicsTree` [INFO] [stderr] --> src/lib.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / pub fn new() -> GraphicsTree { [INFO] [stderr] 62 | | GraphicsTree { [INFO] [stderr] 63 | | commands: vec![], [INFO] [stderr] 64 | | vertices: vec![], [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.54.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.1 [INFO] [stderr] Checking piston_window v0.85.0 [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> examples/rectangle_fps.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let y: f64 = rng.gen::() * 512.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | image: image [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | factory: factory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `factory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `GraphicsTree` [INFO] [stderr] --> src/lib.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / pub fn new() -> GraphicsTree { [INFO] [stderr] 62 | | GraphicsTree { [INFO] [stderr] 63 | | commands: vec![], [INFO] [stderr] 64 | | vertices: vec![], [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/paint.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let ref mut graphics_tree = GraphicsTree::new(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^----------------------- help: try: `let graphics_tree = &mut GraphicsTree::new();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/paint.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let ref mut texture_buffer = TextureBuffer::new(window.factory.clone()); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^---------------------------------------------- help: try: `let texture_buffer = &mut TextureBuffer::new(window.factory.clone());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/image.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let ref mut graphics_tree = GraphicsTree::new(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^----------------------- help: try: `let graphics_tree = &mut GraphicsTree::new();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/image.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let ref mut tx_buffer = TextureBuffer::new(window.factory.clone()); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^---------------------------------------------- help: try: `let tx_buffer = &mut TextureBuffer::new(window.factory.clone());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/rectangle_fps.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let ref mut graphics_tree = GraphicsTree::new(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^----------------------- help: try: `let graphics_tree = &mut GraphicsTree::new();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/rectangle_fps.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | let ref mut texture_buffer = TextureBuffer::new(window.factory.clone()); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^---------------------------------------------- help: try: `let texture_buffer = &mut TextureBuffer::new(window.factory.clone());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 25s [INFO] running `"docker" "inspect" "79675986114a20fe78344ef0f7809d7fcecdc5a5e50067891b462d10cd33ce6b"` [INFO] running `"docker" "rm" "-f" "79675986114a20fe78344ef0f7809d7fcecdc5a5e50067891b462d10cd33ce6b"` [INFO] [stdout] 79675986114a20fe78344ef0f7809d7fcecdc5a5e50067891b462d10cd33ce6b