[INFO] crate piston2d-glium_graphics 0.54.0 is already in cache [INFO] extracting crate piston2d-glium_graphics 0.54.0 into work/ex/clippy-test-run/sources/stable/reg/piston2d-glium_graphics/0.54.0 [INFO] extracting crate piston2d-glium_graphics 0.54.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston2d-glium_graphics/0.54.0 [INFO] validating manifest of piston2d-glium_graphics-0.54.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of piston2d-glium_graphics-0.54.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing piston2d-glium_graphics-0.54.0 [INFO] finished frobbing piston2d-glium_graphics-0.54.0 [INFO] frobbed toml for piston2d-glium_graphics-0.54.0 written to work/ex/clippy-test-run/sources/stable/reg/piston2d-glium_graphics/0.54.0/Cargo.toml [INFO] started frobbing piston2d-glium_graphics-0.54.0 [INFO] finished frobbing piston2d-glium_graphics-0.54.0 [INFO] frobbed toml for piston2d-glium_graphics-0.54.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston2d-glium_graphics/0.54.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting piston2d-glium_graphics-0.54.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/piston2d-glium_graphics/0.54.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a4ab793fa311d11142e4309f1913aa3a03e67a49de4bc0efafceb68c6fd52196 [INFO] running `"docker" "start" "-a" "a4ab793fa311d11142e4309f1913aa3a03e67a49de4bc0efafceb68c6fd52196"` [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Compiling glium v0.22.0 [INFO] [stderr] Compiling num-derive v0.2.4 [INFO] [stderr] Checking pistoncore-event_loop v0.39.0 [INFO] [stderr] Checking andrew v0.1.6 [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Checking piston v0.39.0 [INFO] [stderr] Checking smithay-client-toolkit v0.4.4 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.1 [INFO] [stderr] Checking piston2d-glium_graphics v0.54.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | plain_buffer: plain_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plain_buffer` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | plain_buffer: plain_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plain_buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | system: system, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | system: system, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | surface: surface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `surface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/window.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/back_end.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | / Program::from_source(window, [INFO] [stderr] 63 | | Shaders::new().set(GLSL::V1_20, src(textured::VERTEX_GLSL_120)) [INFO] [stderr] 64 | | .set(GLSL::V1_50, src(textured::VERTEX_GLSL_150_CORE)) [INFO] [stderr] 65 | | .get(glsl).unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 68 | | .get(glsl).unwrap(), [INFO] [stderr] 69 | | None).ok().expect("failed to initialize textured shader"), [INFO] [stderr] | |_____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/back_end.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | / Program::from_source(window, [INFO] [stderr] 72 | | Shaders::new().set(GLSL::V1_20, src(colored::VERTEX_GLSL_120)) [INFO] [stderr] 73 | | .set(GLSL::V1_50, src(colored::VERTEX_GLSL_150_CORE)) [INFO] [stderr] 74 | | .get(glsl).unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 77 | | .get(glsl).unwrap(), [INFO] [stderr] 78 | | None).ok().expect("failed to initialize colored shader"), [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/back_end.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let ref mut g = GliumGraphics::new(self, target); [INFO] [stderr] | ----^^^^^^^^^------------------------------------ help: try: `let g = &mut GliumGraphics::new(self, target);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/back_end.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / self.surface.draw( [INFO] [stderr] 120 | | slice, [INFO] [stderr] 121 | | &NoIndices(PrimitiveType::TrianglesList), [INFO] [stderr] 122 | | &self.system.shader_color, [INFO] [stderr] ... | [INFO] [stderr] 126 | | .ok() [INFO] [stderr] 127 | | .expect("failed to draw triangle list"); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/back_end.rs:146:36 [INFO] [stderr] | [INFO] [stderr] 146 | self.surface.clear_stencil(value as i32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/back_end.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | / self.surface.draw( [INFO] [stderr] 224 | | slice, [INFO] [stderr] 225 | | &NoIndices(PrimitiveType::TrianglesList), [INFO] [stderr] 226 | | &self.system.shader_texture, [INFO] [stderr] ... | [INFO] [stderr] 233 | | .ok() [INFO] [stderr] 234 | | .expect("failed to draw triangle list"); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/window.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | events: self.events.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.events` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/window.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 89 | | self.events.next(&mut *self.window.borrow_mut()) [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/draw_state.rs:67:44 [INFO] [stderr] | [INFO] [stderr] 67 | reference_value_clockwise: reference_value as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(reference_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/draw_state.rs:75:52 [INFO] [stderr] | [INFO] [stderr] 75 | reference_value_counter_clockwise: reference_value as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(reference_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/glium_texture.rs:46:19 [INFO] [stderr] | [INFO] [stderr] 46 | settings: &TextureSettings [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TextureSettings` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/glium_texture.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | settings: &TextureSettings [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TextureSettings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/glium_texture.rs:87:19 [INFO] [stderr] | [INFO] [stderr] 87 | settings: &TextureSettings [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TextureSettings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/glium_texture.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | let ref tex = self.0; [INFO] [stderr] | ----^^^^^^^---------- help: try: `let tex = &self.0;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/back_end.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | / Program::from_source(window, [INFO] [stderr] 63 | | Shaders::new().set(GLSL::V1_20, src(textured::VERTEX_GLSL_120)) [INFO] [stderr] 64 | | .set(GLSL::V1_50, src(textured::VERTEX_GLSL_150_CORE)) [INFO] [stderr] 65 | | .get(glsl).unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 68 | | .get(glsl).unwrap(), [INFO] [stderr] 69 | | None).ok().expect("failed to initialize textured shader"), [INFO] [stderr] | |_____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/back_end.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | / Program::from_source(window, [INFO] [stderr] 72 | | Shaders::new().set(GLSL::V1_20, src(colored::VERTEX_GLSL_120)) [INFO] [stderr] 73 | | .set(GLSL::V1_50, src(colored::VERTEX_GLSL_150_CORE)) [INFO] [stderr] 74 | | .get(glsl).unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 77 | | .get(glsl).unwrap(), [INFO] [stderr] 78 | | None).ok().expect("failed to initialize colored shader"), [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/back_end.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let ref mut g = GliumGraphics::new(self, target); [INFO] [stderr] | ----^^^^^^^^^------------------------------------ help: try: `let g = &mut GliumGraphics::new(self, target);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/back_end.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / self.surface.draw( [INFO] [stderr] 120 | | slice, [INFO] [stderr] 121 | | &NoIndices(PrimitiveType::TrianglesList), [INFO] [stderr] 122 | | &self.system.shader_color, [INFO] [stderr] ... | [INFO] [stderr] 126 | | .ok() [INFO] [stderr] 127 | | .expect("failed to draw triangle list"); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/back_end.rs:146:36 [INFO] [stderr] | [INFO] [stderr] 146 | self.surface.clear_stencil(value as i32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/back_end.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | / self.surface.draw( [INFO] [stderr] 224 | | slice, [INFO] [stderr] 225 | | &NoIndices(PrimitiveType::TrianglesList), [INFO] [stderr] 226 | | &self.system.shader_texture, [INFO] [stderr] ... | [INFO] [stderr] 233 | | .ok() [INFO] [stderr] 234 | | .expect("failed to draw triangle list"); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/window.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | events: self.events.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.events` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/window.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 89 | | self.events.next(&mut *self.window.borrow_mut()) [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/draw_state.rs:67:44 [INFO] [stderr] | [INFO] [stderr] 67 | reference_value_clockwise: reference_value as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(reference_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/draw_state.rs:75:52 [INFO] [stderr] | [INFO] [stderr] 75 | reference_value_counter_clockwise: reference_value as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(reference_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/glium_texture.rs:46:19 [INFO] [stderr] | [INFO] [stderr] 46 | settings: &TextureSettings [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TextureSettings` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/glium_texture.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | settings: &TextureSettings [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TextureSettings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/glium_texture.rs:87:19 [INFO] [stderr] | [INFO] [stderr] 87 | settings: &TextureSettings [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TextureSettings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/glium_texture.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | let ref tex = self.0; [INFO] [stderr] | ----^^^^^^^---------- help: try: `let tex = &self.0;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/draw_state.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | let ref mut window: GliumWindow = [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 19 | let window: &mut GliumWindow = &mut WindowSettings::new("glium_graphics: image_test", [w, h]) [INFO] [stderr] 20 | .exit_on_esc(true).opengl(opengl).build().unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/text_test.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | let ref mut window: GliumWindow = [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 14 | let window: &mut GliumWindow = &mut WindowSettings::new("gfx_graphics: text_test", size) [INFO] [stderr] 15 | .exit_on_esc(true).opengl(opengl).build().unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/image_test.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let ref mut window: GliumWindow = [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 17 | let window: &mut GliumWindow = &mut WindowSettings::new("glium_graphics: image_test", [w, h]) [INFO] [stderr] 18 | .exit_on_esc(true).opengl(opengl).build().unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 00s [INFO] running `"docker" "inspect" "a4ab793fa311d11142e4309f1913aa3a03e67a49de4bc0efafceb68c6fd52196"` [INFO] running `"docker" "rm" "-f" "a4ab793fa311d11142e4309f1913aa3a03e67a49de4bc0efafceb68c6fd52196"` [INFO] [stdout] a4ab793fa311d11142e4309f1913aa3a03e67a49de4bc0efafceb68c6fd52196