[INFO] crate piston2d-gfx_graphics 0.54.0 is already in cache [INFO] extracting crate piston2d-gfx_graphics 0.54.0 into work/ex/clippy-test-run/sources/stable/reg/piston2d-gfx_graphics/0.54.0 [INFO] extracting crate piston2d-gfx_graphics 0.54.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston2d-gfx_graphics/0.54.0 [INFO] validating manifest of piston2d-gfx_graphics-0.54.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of piston2d-gfx_graphics-0.54.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing piston2d-gfx_graphics-0.54.0 [INFO] finished frobbing piston2d-gfx_graphics-0.54.0 [INFO] frobbed toml for piston2d-gfx_graphics-0.54.0 written to work/ex/clippy-test-run/sources/stable/reg/piston2d-gfx_graphics/0.54.0/Cargo.toml [INFO] started frobbing piston2d-gfx_graphics-0.54.0 [INFO] finished frobbing piston2d-gfx_graphics-0.54.0 [INFO] frobbed toml for piston2d-gfx_graphics-0.54.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston2d-gfx_graphics/0.54.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting piston2d-gfx_graphics-0.54.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/piston2d-gfx_graphics/0.54.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 214d20f6ec853bcaeeb0669e29f8833b0b77e0aa20d4dc289846a50c27529c93 [INFO] running `"docker" "start" "-a" "214d20f6ec853bcaeeb0669e29f8833b0b77e0aa20d4dc289846a50c27529c93"` [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Checking pistoncore-input v0.23.0 [INFO] [stderr] Checking andrew v0.1.6 [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Checking smithay-client-toolkit v0.4.4 [INFO] [stderr] Checking pistoncore-window v0.34.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.54.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | buffer_pos: buffer_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | buffer_color: buffer_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | buffer_uv: buffer_uv, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_uv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | colored: colored, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `colored` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | textured: textured, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `textured` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:353:13 [INFO] [stderr] | [INFO] [stderr] 353 | encoder: encoder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `encoder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:354:13 [INFO] [stderr] | [INFO] [stderr] 354 | output_color: output_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:355:13 [INFO] [stderr] | [INFO] [stderr] 355 | output_stencil: output_stencil, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_stencil` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:356:13 [INFO] [stderr] | [INFO] [stderr] 356 | g2d: g2d, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `g2d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | scissor: scissor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `scissor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:500:29 [INFO] [stderr] | [INFO] [stderr] 500 | color: color [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:551:13 [INFO] [stderr] | [INFO] [stderr] 551 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:557:13 [INFO] [stderr] | [INFO] [stderr] 557 | scissor: scissor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `scissor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Checking pistoncore-event_loop v0.39.0 [INFO] [stderr] Checking piston v0.39.0 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/back_end.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | let ref mut g = GfxGraphics::new( [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 310 | let g = &mut GfxGraphics::new( [INFO] [stderr] 311 | encoder, [INFO] [stderr] 312 | output_color, [INFO] [stderr] 313 | output_stencil, [INFO] [stderr] 314 | self [INFO] [stderr] 315 | ); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | buffer_pos: buffer_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | buffer_color: buffer_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | buffer_uv: buffer_uv, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_uv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | colored: colored, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `colored` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | textured: textured, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `textured` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:353:13 [INFO] [stderr] | [INFO] [stderr] 353 | encoder: encoder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `encoder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:354:13 [INFO] [stderr] | [INFO] [stderr] 354 | output_color: output_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:355:13 [INFO] [stderr] | [INFO] [stderr] 355 | output_stencil: output_stencil, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_stencil` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:356:13 [INFO] [stderr] | [INFO] [stderr] 356 | g2d: g2d, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `g2d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | scissor: scissor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `scissor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:500:29 [INFO] [stderr] | [INFO] [stderr] 500 | color: color [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:551:13 [INFO] [stderr] | [INFO] [stderr] 551 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/back_end.rs:557:13 [INFO] [stderr] | [INFO] [stderr] 557 | scissor: scissor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `scissor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> examples/draw_state.rs:95:16 [INFO] [stderr] | [INFO] [stderr] 95 | if let Some(_) = e.after_render_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 96 | | device.cleanup(); [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________- help: try this: `if e.after_render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/back_end.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | let ref mut g = GfxGraphics::new( [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 310 | let g = &mut GfxGraphics::new( [INFO] [stderr] 311 | encoder, [INFO] [stderr] 312 | output_color, [INFO] [stderr] 313 | output_stencil, [INFO] [stderr] 314 | self [INFO] [stderr] 315 | ); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/text_test.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let ref mut window: GlutinWindow = [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 22 | let window: &mut GlutinWindow = &mut WindowSettings::new("gfx_graphics: text_test", size) [INFO] [stderr] 23 | .exit_on_esc(true) [INFO] [stderr] 24 | .opengl(opengl) [INFO] [stderr] 25 | .samples(samples) [INFO] [stderr] 26 | .build().unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> examples/text_test.rs:72:16 [INFO] [stderr] | [INFO] [stderr] 72 | if let Some(_) = e.after_render_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 73 | | device.cleanup(); [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________- help: try this: `if e.after_render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.23s [INFO] running `"docker" "inspect" "214d20f6ec853bcaeeb0669e29f8833b0b77e0aa20d4dc289846a50c27529c93"` [INFO] running `"docker" "rm" "-f" "214d20f6ec853bcaeeb0669e29f8833b0b77e0aa20d4dc289846a50c27529c93"` [INFO] [stdout] 214d20f6ec853bcaeeb0669e29f8833b0b77e0aa20d4dc289846a50c27529c93