[INFO] crate piston2d-drag_controller 0.24.0 is already in cache [INFO] extracting crate piston2d-drag_controller 0.24.0 into work/ex/clippy-test-run/sources/stable/reg/piston2d-drag_controller/0.24.0 [INFO] extracting crate piston2d-drag_controller 0.24.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston2d-drag_controller/0.24.0 [INFO] validating manifest of piston2d-drag_controller-0.24.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of piston2d-drag_controller-0.24.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing piston2d-drag_controller-0.24.0 [INFO] finished frobbing piston2d-drag_controller-0.24.0 [INFO] frobbed toml for piston2d-drag_controller-0.24.0 written to work/ex/clippy-test-run/sources/stable/reg/piston2d-drag_controller/0.24.0/Cargo.toml [INFO] started frobbing piston2d-drag_controller-0.24.0 [INFO] finished frobbing piston2d-drag_controller-0.24.0 [INFO] frobbed toml for piston2d-drag_controller-0.24.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston2d-drag_controller/0.24.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting piston2d-drag_controller-0.24.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/piston2d-drag_controller/0.24.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 50efe7f3f6281dbec55120fc73c447e03ab64d337ac7a8081deeaead5a63d8f5 [INFO] running `"docker" "start" "-a" "50efe7f3f6281dbec55120fc73c447e03ab64d337ac7a8081deeaead5a63d8f5"` [INFO] [stderr] Checking piston2d-drag_controller v0.24.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `DragController` [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> DragController { [INFO] [stderr] 42 | | DragController { [INFO] [stderr] 43 | | drag: false, [INFO] [stderr] 44 | | pos: [0.0, 0.0], [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | / match button { [INFO] [stderr] 64 | | Mouse(MouseButton::Left) => { [INFO] [stderr] 65 | | if !self.drag { [INFO] [stderr] 66 | | self.drag = f(Drag::Start(self.pos[0], self.pos[1])); [INFO] [stderr] ... | [INFO] [stderr] 69 | | _ => {} [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | if let Mouse(MouseButton::Left) = button { [INFO] [stderr] 64 | if !self.drag { [INFO] [stderr] 65 | self.drag = f(Drag::Start(self.pos[0], self.pos[1])); [INFO] [stderr] 66 | } [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | / match button { [INFO] [stderr] 78 | | Mouse(MouseButton::Left) => { [INFO] [stderr] 79 | | if self.drag { [INFO] [stderr] 80 | | f(Drag::End(self.pos[0], self.pos[1])); [INFO] [stderr] ... | [INFO] [stderr] 84 | | _ => {} [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | if let Mouse(MouseButton::Left) = button { [INFO] [stderr] 78 | if self.drag { [INFO] [stderr] 79 | f(Drag::End(self.pos[0], self.pos[1])); [INFO] [stderr] 80 | } [INFO] [stderr] 81 | self.drag = false; [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | if focused == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!focused` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `DragController` [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> DragController { [INFO] [stderr] 42 | | DragController { [INFO] [stderr] 43 | | drag: false, [INFO] [stderr] 44 | | pos: [0.0, 0.0], [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | / match button { [INFO] [stderr] 64 | | Mouse(MouseButton::Left) => { [INFO] [stderr] 65 | | if !self.drag { [INFO] [stderr] 66 | | self.drag = f(Drag::Start(self.pos[0], self.pos[1])); [INFO] [stderr] ... | [INFO] [stderr] 69 | | _ => {} [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | if let Mouse(MouseButton::Left) = button { [INFO] [stderr] 64 | if !self.drag { [INFO] [stderr] 65 | self.drag = f(Drag::Start(self.pos[0], self.pos[1])); [INFO] [stderr] 66 | } [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | / match button { [INFO] [stderr] 78 | | Mouse(MouseButton::Left) => { [INFO] [stderr] 79 | | if self.drag { [INFO] [stderr] 80 | | f(Drag::End(self.pos[0], self.pos[1])); [INFO] [stderr] ... | [INFO] [stderr] 84 | | _ => {} [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | if let Mouse(MouseButton::Left) = button { [INFO] [stderr] 78 | if self.drag { [INFO] [stderr] 79 | f(Drag::End(self.pos[0], self.pos[1])); [INFO] [stderr] 80 | } [INFO] [stderr] 81 | self.drag = false; [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | if focused == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!focused` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.48s [INFO] running `"docker" "inspect" "50efe7f3f6281dbec55120fc73c447e03ab64d337ac7a8081deeaead5a63d8f5"` [INFO] running `"docker" "rm" "-f" "50efe7f3f6281dbec55120fc73c447e03ab64d337ac7a8081deeaead5a63d8f5"` [INFO] [stdout] 50efe7f3f6281dbec55120fc73c447e03ab64d337ac7a8081deeaead5a63d8f5