[INFO] crate piston-history_tree 0.1.0 is already in cache
[INFO] extracting crate piston-history_tree 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/piston-history_tree/0.1.0
[INFO] extracting crate piston-history_tree 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston-history_tree/0.1.0
[INFO] validating manifest of piston-history_tree-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of piston-history_tree-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing piston-history_tree-0.1.0
[INFO] finished frobbing piston-history_tree-0.1.0
[INFO] frobbed toml for piston-history_tree-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/piston-history_tree/0.1.0/Cargo.toml
[INFO] started frobbing piston-history_tree-0.1.0
[INFO] finished frobbing piston-history_tree-0.1.0
[INFO] frobbed toml for piston-history_tree-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston-history_tree/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting piston-history_tree-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/piston-history_tree/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d38b81da68784e8da2c194e21dafbe02507a0dc5bec8ad43718d8986681e6252
[INFO] running `"docker" "start" "-a" "d38b81da68784e8da2c194e21dafbe02507a0dc5bec8ad43718d8986681e6252"`
[INFO] [stderr]     Checking piston-history_tree v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |             parent: parent,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `parent`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |             parent: parent,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `parent`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:117:13
[INFO] [stderr]     |
[INFO] [stderr] 117 |             parent: parent,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `parent`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |             parent: parent,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `parent`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |             parent: parent,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `parent`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:117:13
[INFO] [stderr]     |
[INFO] [stderr] 117 |             parent: parent,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `parent`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:166:16
[INFO] [stderr]     |
[INFO] [stderr] 166 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 167 | |             if self.records.len() == 0 {None}
[INFO] [stderr] 168 | |             else {Some(self.records.len() - 2)}
[INFO] [stderr] 169 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 166 |         } else if self.records.len() == 0 {None}
[INFO] [stderr] 167 | else {Some(self.records.len() - 2)};
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `HistoryTree`
[INFO] [stderr]   --> src/lib.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 | /     pub fn new() -> HistoryTree {
[INFO] [stderr] 59 | |         HistoryTree {
[INFO] [stderr] 60 | |             records: vec![Record {
[INFO] [stderr] 61 | |                 prev: 0, // Points back to itself.
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |         }
[INFO] [stderr] 67 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:166:16
[INFO] [stderr]     |
[INFO] [stderr] 166 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 167 | |             if self.records.len() == 0 {None}
[INFO] [stderr] 168 | |             else {Some(self.records.len() - 2)}
[INFO] [stderr] 169 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 166 |         } else if self.records.len() == 0 {None}
[INFO] [stderr] 167 | else {Some(self.records.len() - 2)};
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 46 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:127:46
[INFO] [stderr]     |
[INFO] [stderr] 127 |         let nodes: Vec<usize> = self.records[1..cursor + 1].iter()
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^ help: use: `1..=cursor`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:164:21
[INFO] [stderr]     |
[INFO] [stderr] 164 |             else if self.records.len() == 0 {None}
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.records.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:167:16
[INFO] [stderr]     |
[INFO] [stderr] 167 |             if self.records.len() == 0 {None}
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.records.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `HistoryTree`
[INFO] [stderr]   --> src/lib.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 | /     pub fn new() -> HistoryTree {
[INFO] [stderr] 59 | |         HistoryTree {
[INFO] [stderr] 60 | |             records: vec![Record {
[INFO] [stderr] 61 | |                 prev: 0, // Points back to itself.
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |         }
[INFO] [stderr] 67 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 46 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:127:46
[INFO] [stderr]     |
[INFO] [stderr] 127 |         let nodes: Vec<usize> = self.records[1..cursor + 1].iter()
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^ help: use: `1..=cursor`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:164:21
[INFO] [stderr]     |
[INFO] [stderr] 164 |             else if self.records.len() == 0 {None}
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.records.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:167:16
[INFO] [stderr]     |
[INFO] [stderr] 167 |             if self.records.len() == 0 {None}
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.records.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]   --> examples/index.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |     let mut bar = ht.add(notes);
[INFO] [stderr]    |             ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `App`
[INFO] [stderr]   --> examples/app.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 | /     pub fn new() -> App {
[INFO] [stderr] 40 | |         App {
[INFO] [stderr] 41 | |             ht: HistoryTree::new(),
[INFO] [stderr] 42 | |             // Add dummy root to align indices.
[INFO] [stderr] 43 | |             text: vec!["root".into()],
[INFO] [stderr] 44 | |         }
[INFO] [stderr] 45 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 37 | impl Default for App {
[INFO] [stderr] 38 |     fn default() -> Self {
[INFO] [stderr] 39 |         Self::new()
[INFO] [stderr] 40 |     }
[INFO] [stderr] 41 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.52s
[INFO] running `"docker" "inspect" "d38b81da68784e8da2c194e21dafbe02507a0dc5bec8ad43718d8986681e6252"`
[INFO] running `"docker" "rm" "-f" "d38b81da68784e8da2c194e21dafbe02507a0dc5bec8ad43718d8986681e6252"`
[INFO] [stdout] d38b81da68784e8da2c194e21dafbe02507a0dc5bec8ad43718d8986681e6252