[INFO] crate piston-gfx_texture 0.34.0 is already in cache
[INFO] extracting crate piston-gfx_texture 0.34.0 into work/ex/clippy-test-run/sources/stable/reg/piston-gfx_texture/0.34.0
[INFO] extracting crate piston-gfx_texture 0.34.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston-gfx_texture/0.34.0
[INFO] validating manifest of piston-gfx_texture-0.34.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of piston-gfx_texture-0.34.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing piston-gfx_texture-0.34.0
[INFO] finished frobbing piston-gfx_texture-0.34.0
[INFO] frobbed toml for piston-gfx_texture-0.34.0 written to work/ex/clippy-test-run/sources/stable/reg/piston-gfx_texture/0.34.0/Cargo.toml
[INFO] started frobbing piston-gfx_texture-0.34.0
[INFO] finished frobbing piston-gfx_texture-0.34.0
[INFO] frobbed toml for piston-gfx_texture-0.34.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston-gfx_texture/0.34.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting piston-gfx_texture-0.34.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/piston-gfx_texture/0.34.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b4f338870583d11feae1142f3a86c1df8dd19d8a1fb47e3b197313baabfdf879
[INFO] running `"docker" "start" "-a" "b4f338870583d11feae1142f3a86c1df8dd19d8a1fb47e3b197313baabfdf879"`
[INFO] [stderr]     Checking tiff v0.2.1
[INFO] [stderr]     Checking image v0.20.1
[INFO] [stderr]     Checking piston-gfx_texture v0.34.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:166:17
[INFO] [stderr]     |
[INFO] [stderr] 166 |                 kind: kind,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:201:22
[INFO] [stderr]     |
[INFO] [stderr] 201 |         Ok(Texture { surface: surface, sampler: sampler, view: view })
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^ help: replace it with: `surface`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:201:40
[INFO] [stderr]     |
[INFO] [stderr] 201 |         Ok(Texture { surface: surface, sampler: sampler, view: view })
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^ help: replace it with: `sampler`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:201:58
[INFO] [stderr]     |
[INFO] [stderr] 201 |         Ok(Texture { surface: surface, sampler: sampler, view: view })
[INFO] [stderr]     |                                                          ^^^^^^^^^^ help: replace it with: `view`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:166:17
[INFO] [stderr]     |
[INFO] [stderr] 166 |                 kind: kind,
[INFO] [stderr]     |                 ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:201:22
[INFO] [stderr]     |
[INFO] [stderr] 201 |         Ok(Texture { surface: surface, sampler: sampler, view: view })
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^ help: replace it with: `surface`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:201:40
[INFO] [stderr]     |
[INFO] [stderr] 201 |         Ok(Texture { surface: surface, sampler: sampler, view: view })
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^ help: replace it with: `sampler`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:201:58
[INFO] [stderr]     |
[INFO] [stderr] 201 |         Ok(Texture { surface: surface, sampler: sampler, view: view })
[INFO] [stderr]     |                                                          ^^^^^^^^^^ help: replace it with: `view`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:58:19
[INFO] [stderr]    |
[INFO] [stderr] 58 |         settings: &TextureSettings,
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TextureSettings`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:88:19
[INFO] [stderr]    |
[INFO] [stderr] 88 |         settings: &TextureSettings
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TextureSettings`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:103:19
[INFO] [stderr]     |
[INFO] [stderr] 103 |         settings: &TextureSettings
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TextureSettings`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/lib.rs:149:14
[INFO] [stderr]     |
[INFO] [stderr] 149 |           ) -> Result<(
[INFO] [stderr]     |  ______________^
[INFO] [stderr] 150 | |             gfx::handle::Texture<R, T::Surface>,
[INFO] [stderr] 151 | |             gfx::handle::ShaderResourceView<R, T::View>
[INFO] [stderr] 152 | |         ), CombinedError>
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:251:10
[INFO] [stderr]     |
[INFO] [stderr] 251 |         (w as u32, h as u32)
[INFO] [stderr]     |          ^^^^^^^^ help: try: `u32::from(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:251:20
[INFO] [stderr]     |
[INFO] [stderr] 251 |         (w as u32, h as u32)
[INFO] [stderr]     |                    ^^^^^^^^ help: try: `u32::from(h)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:58:19
[INFO] [stderr]    |
[INFO] [stderr] 58 |         settings: &TextureSettings,
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TextureSettings`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:88:19
[INFO] [stderr]    |
[INFO] [stderr] 88 |         settings: &TextureSettings
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TextureSettings`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:103:19
[INFO] [stderr]     |
[INFO] [stderr] 103 |         settings: &TextureSettings
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TextureSettings`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/lib.rs:149:14
[INFO] [stderr]     |
[INFO] [stderr] 149 |           ) -> Result<(
[INFO] [stderr]     |  ______________^
[INFO] [stderr] 150 | |             gfx::handle::Texture<R, T::Surface>,
[INFO] [stderr] 151 | |             gfx::handle::ShaderResourceView<R, T::View>
[INFO] [stderr] 152 | |         ), CombinedError>
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:251:10
[INFO] [stderr]     |
[INFO] [stderr] 251 |         (w as u32, h as u32)
[INFO] [stderr]     |          ^^^^^^^^ help: try: `u32::from(w)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:251:20
[INFO] [stderr]     |
[INFO] [stderr] 251 |         (w as u32, h as u32)
[INFO] [stderr]     |                    ^^^^^^^^ help: try: `u32::from(h)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 14.21s
[INFO] running `"docker" "inspect" "b4f338870583d11feae1142f3a86c1df8dd19d8a1fb47e3b197313baabfdf879"`
[INFO] running `"docker" "rm" "-f" "b4f338870583d11feae1142f3a86c1df8dd19d8a1fb47e3b197313baabfdf879"`
[INFO] [stdout] b4f338870583d11feae1142f3a86c1df8dd19d8a1fb47e3b197313baabfdf879